7c5f06771d3ab142f4b0c9a235897dfa46d47148: Bug 1287007 - Harden browser.storage.local serialization draft
Rob Wu <rob@robwu.nl> - Sun, 04 Sep 2016 19:19:17 -0700 - rev 410799
Push 28760 by bmo:rob@robwu.nl at Tue, 06 Sep 2016 22:34:56 +0000
Bug 1287007 - Harden browser.storage.local serialization - Lazily initialize file IO-specific stuff in ExtensionStorage.jsm, and limit this work to the main process. - Add local versions of the `storage.local.get` and `storage.local.set` implementations that perform sanitization (without the change, values are improperly serialized over IPC). - Switch from JSON.stringify to a custom serializer, because: - The serialization of the value is affected by the context's override of methods such as `toJSON` and `toString`. - Nested objects with function values trigger the following error: > XrayWrapper denied access to property "foo" (reason: value is callable). > See https://developer.mozilla.org/en-US/docs/Xray_vision for more > information. Note that only the first denied property access from a > given global object will be reported. - Copied the `backgroundScript` test from xpcshell/test_ext_storage.js to mochitest/test_ext_storage_content.html because they should behave identical. Before this patch the test failed due to IPC serialization issues, now the test passes. Note that the old test also passes with the changes. MozReview-Commit-ID: 8J8CCdwMACN
6a0ed3fff7f16d253a501244c2a3050a11261a97: Bug 1287007 - Allow local implementations to call remote implementations draft
Rob Wu <rob@robwu.nl> - Sun, 04 Sep 2016 02:29:48 -0700 - rev 410798
Push 28760 by bmo:rob@robwu.nl at Tue, 06 Sep 2016 22:34:56 +0000
Bug 1287007 - Allow local implementations to call remote implementations - Add callParentFunctionNoReturn / callParentAsyncFunction to ChildAPIManager to implement remote calls. - Add in-process browser.test implementation that uses this. - Add tests to verify that the browser.test.assert* methods with the `allowAmbiguousOptionalArguments` schema attribute are working with objects that cannot be passed as-is over IPC. (except test.sendMessage, because stringifying the arguments has an observable impact on test behavior) MozReview-Commit-ID: 6cFVgmFfU93
09565282f6ceb27e70caad610ea28e1b6f166ad5: Bug 1287007 - Mark all browserAction methods as async draft
Rob Wu <rob@robwu.nl> - Fri, 02 Sep 2016 14:22:09 -0700 - rev 410797
Push 28760 by bmo:rob@robwu.nl at Tue, 06 Sep 2016 22:34:56 +0000
Bug 1287007 - Mark all browserAction methods as async E.g. browser.browserAction.enable(...).then(...) now works as expected. MozReview-Commit-ID: 4Shxtn0rjYH
c5eb5a828cd80264415735697604ebb49fbff1f1: Bug 1287007 - Fix timing issue in browser/page action tests draft
Rob Wu <rob@robwu.nl> - Fri, 02 Sep 2016 16:33:32 -0700 - rev 410796
Push 28760 by bmo:rob@robwu.nl at Tue, 06 Sep 2016 22:34:56 +0000
Bug 1287007 - Fix timing issue in browser/page action tests MozReview-Commit-ID: 9L0ttaq42Ga
fa68a0b6b0e56673c4d62cd204c7f22a097f4124: Bug 1287007 - Refactor test_ext_schemas_api_injection.js draft
Rob Wu <rob@robwu.nl> - Fri, 02 Sep 2016 05:36:33 -0700 - rev 410795
Push 28760 by bmo:rob@robwu.nl at Tue, 06 Sep 2016 22:34:56 +0000
Bug 1287007 - Refactor test_ext_schemas_api_injection.js When the background API move to a separate implementation, then the schema APIs will be generated (and ChildAPIManager will just delegate the implementation to the parent process). The purpose of the test is to verify that nested namespaces and null-feturn values work, so just use the base classes instead of a concrete implementation for BaseContext / SchemaAPIManager instead of setting up a full extension. MozReview-Commit-ID: CB5s7Ae24zS
efa2285886572eb6847ecb568212f2071ee7fbc6: Bug 1287007 - Allow callbacks in browser.* when async=true draft
Rob Wu <rob@robwu.nl> - Fri, 02 Sep 2016 03:37:55 -0700 - rev 410794
Push 28760 by bmo:rob@robwu.nl at Tue, 06 Sep 2016 22:34:56 +0000
Bug 1287007 - Allow callbacks in browser.* when async=true === Before === In the pageAction and browserAction schemas, several methods are declared with `"async": true` but without a specified callback in the `"parameters"` object, so callbacks are not allowed. However, when a callback is proxied, the `ParentAPIManager` will mirror the call by passing in an extra callback to the proxied API - and break. === After === If `"async": true` is specified in the schema, then there is no named callback parameter in the "chrome." API. The "browser." API, on the other hand will either return a promise or accept an extra callback. Examples of accepted formats: - chrome.pageAction.show(1) - browser.pageAction.show(1) - browser.pageAction.show(1, callback) - browser.pageAction.show(1).then(callback) Example of rejected formats: - chrome.pageAction.show(1, callback) New tests: - `testParameterValidation` tests the above scenarios. - `testAsyncResults` tests whether error propagation works. This did not fail before this commit, and still passes with the changes. MozReview-Commit-ID: JQqzmTUAotB
38ffb6c74674ff42014bb9ef995deab12da08403: Bug 1287007 - Improve errors for non-existing remote APIs draft
Rob Wu <rob@robwu.nl> - Thu, 01 Sep 2016 21:14:31 -0700 - rev 410793
Push 28760 by bmo:rob@robwu.nl at Tue, 06 Sep 2016 22:34:56 +0000
Bug 1287007 - Improve errors for non-existing remote APIs Currently, if the remote implementation is missing, the next unhelpful error message is logged to the console: "TypeError: findPathInObject(...) is not a function" or "TypeError: findPathInObject(...) is undefined", etc. This commit makes the message more useful: "findPathInObject: No obj found for path: tabs.create" MozReview-Commit-ID: FhPEYKSjnLm
8ace8b442d8cd504752872f85ed4266435a23c34: Bug 1287007 - Fix some flaws in ProxyAPIImplementation draft
Rob Wu <rob@robwu.nl> - Thu, 01 Sep 2016 21:10:18 -0700 - rev 410792
Push 28760 by bmo:rob@robwu.nl at Tue, 06 Sep 2016 22:34:56 +0000
Bug 1287007 - Fix some flaws in ProxyAPIImplementation - removeListener: There is no set.remove, use set.delete. - Async callbacks: Do not unconditionally turn the result in a SpreadArgs because it causes the result to unconditionally be wrapped in an array. MozReview-Commit-ID: LqwtBsHWJJr
77ab7b224e524b57751d0ced6b7e0b2ea2d6b2ad: Bug 1285085: It is OK to fail to create a bitmap, it could be too large. r?bas draft
Milan Sreckovic <milan@mozilla.com> - Tue, 06 Sep 2016 18:15:31 -0400 - rev 410791
Push 28759 by msreckovic@mozilla.com at Tue, 06 Sep 2016 22:15:58 +0000
Bug 1285085: It is OK to fail to create a bitmap, it could be too large. r?bas MozReview-Commit-ID: 9q6r081vU9L
b45c4aab1e7b78acdacb44b05d17638f1d956ade: Bug 1296403 - Update tooltool rustc to 1.11.0. r?mshal draft
Ralph Giles <giles@mozilla.com> - Tue, 06 Sep 2016 13:09:56 -0700 - rev 410790
Push 28758 by bmo:giles@thaumas.net at Tue, 06 Sep 2016 21:39:57 +0000
Bug 1296403 - Update tooltool rustc to 1.11.0. r?mshal Repacks of upstream builds of rust 1.11.0 stable with std libraries for the appropriate targets. Remove the separate rust-std package references since the new repacks include the necessary targets. Also update clang and hazard builds to the latest toolchain. MozReview-Commit-ID: K7oBxQZnLPu
4e149f812d45cf54125d7ebc701755b01b3a7b3e: Bug 1274496 - Filter excluded bookmarks at sync time based on their root. r?markh r?rnewman draft
Kit Cambridge <kcambridge@mozilla.com> - Tue, 06 Sep 2016 11:39:13 -0700 - rev 410789
Push 28757 by bmo:kcambridge@mozilla.com at Tue, 06 Sep 2016 21:34:26 +0000
Bug 1274496 - Filter excluded bookmarks at sync time based on their root. r?markh r?rnewman MozReview-Commit-ID: 6xWohLeIMha
56270f5290ed1dc0b33bcfd10b4314d6fa39e745: Bug 1274496 - Filter excluded bookmarks at sync time based on their root. r?markh r?rnewman draft
Kit Cambridge <kcambridge@mozilla.com> - Tue, 06 Sep 2016 11:39:13 -0700 - rev 410788
Push 28756 by bmo:kcambridge@mozilla.com at Tue, 06 Sep 2016 21:30:54 +0000
Bug 1274496 - Filter excluded bookmarks at sync time based on their root. r?markh r?rnewman MozReview-Commit-ID: 6xWohLeIMha
90c41d8fd40e3714f456e95810c9ab325c964532: Bug 1296900 - Hide commands API if manifest key is missing r?kmag draft
Rob Wu <rob@robwu.nl> - Sat, 20 Aug 2016 23:01:43 -0700 - rev 410787
Push 28755 by bmo:rob@robwu.nl at Tue, 06 Sep 2016 21:26:58 +0000
Bug 1296900 - Hide commands API if manifest key is missing r?kmag MozReview-Commit-ID: 7vld6MgSlqG
a2b3c1de5177f6709e3a0f00deab244a09d9c716: Bug 1296900 - Add test for availability of default WebExtension APIs r?kmag draft
Rob Wu <rob@robwu.nl> - Sat, 20 Aug 2016 22:21:45 -0700 - rev 410786
Push 28755 by bmo:rob@robwu.nl at Tue, 06 Sep 2016 21:26:58 +0000
Bug 1296900 - Add test for availability of default WebExtension APIs r?kmag MozReview-Commit-ID: LIr5Nsv51I3
c0dcfa8f805fa6bc07ab298a951acaec26142b31: Bug 1296403 - Update tooltool rustc to 1.11.0. r=mshal draft
Ralph Giles <giles@mozilla.com> - Tue, 06 Sep 2016 13:09:56 -0700 - rev 410785
Push 28754 by bmo:giles@thaumas.net at Tue, 06 Sep 2016 21:22:39 +0000
Bug 1296403 - Update tooltool rustc to 1.11.0. r=mshal Repacks of upstream builds of rust 1.11.0 stable with std libraries for the appropriate targets. Remove the separate rust-std package since the new repacks include the necessary target arch. MozReview-Commit-ID: K7oBxQZnLPu
4ee5ddeeee281b9b6f564fc56efb1713da8d7eac: Merge m-c to autoland
Phil Ringnalda <philringnalda@gmail.com> - Tue, 06 Sep 2016 07:37:13 -0700 - rev 410784
Push 28754 by bmo:giles@thaumas.net at Tue, 06 Sep 2016 21:22:39 +0000
Merge m-c to autoland
431b256767ded293d7988f4da51773f54abc8e3e: Bug 1274943 - Ensure to wait for the update dialog after a forced fallback. r=maja_zf
Henrik Skupin <mail@hskupin.info> - Tue, 06 Sep 2016 11:55:54 +0200 - rev 410783
Push 28754 by bmo:giles@thaumas.net at Tue, 06 Sep 2016 21:22:39 +0000
Bug 1274943 - Ensure to wait for the update dialog after a forced fallback. r=maja_zf MozReview-Commit-ID: 7i9SwSbm0p0
80f14ad15f86a55c8247b278903e955edabe7e61: Merge mozilla-central to autoland
Carsten "Tomcat" Book <cbook@mozilla.com> - Tue, 06 Sep 2016 15:46:44 +0200 - rev 410782
Push 28754 by bmo:giles@thaumas.net at Tue, 06 Sep 2016 21:22:39 +0000
Merge mozilla-central to autoland
0788fe67e9ae4254553d3f308cc2c3ee061023f1: Bug 1300745 - remoed unused variable from CustomElementDefinition. r=baku
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Tue, 06 Sep 2016 14:38:10 +0300 - rev 410781
Push 28754 by bmo:giles@thaumas.net at Tue, 06 Sep 2016 21:22:39 +0000
Bug 1300745 - remoed unused variable from CustomElementDefinition. r=baku MozReview-Commit-ID: Ea9O9YwrIH6
eff773a2ba3e6475f3cf5d940c650e5824a19f63: Bug 1300757 - log error message if SkiaGL DrawTarget fails. r=baku
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Tue, 06 Sep 2016 15:31:08 +0300 - rev 410780
Push 28754 by bmo:giles@thaumas.net at Tue, 06 Sep 2016 21:22:39 +0000
Bug 1300757 - log error message if SkiaGL DrawTarget fails. r=baku MozReview-Commit-ID: EQqXFp3W79X
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip