7a9d6a3cdf1a68952f8fb88a0999db1f9486b921: Bug 1307357 part 2 - Fix issues appear after adding file to unified source. r=heycam
Xidorn Quan <me@upsuper.org> - Wed, 23 Nov 2016 10:26:20 +1100 - rev 442960
Push
36877 by bmo:ato@mozilla.com at Wed, 23 Nov 2016 16:26:21 +0000
Bug 1307357 part 2 - Fix issues appear after adding file to unified source. r=heycam
MozReview-Commit-ID: 5FkisMn3LKq
067fb417bb7bc51956941a495f4d6be271c832b4: Bug 1307357 part 1 - Make css::Rule hold StyleSheet rather than CSSStyleSheet. r=heycam
Xidorn Quan <me@upsuper.org> - Wed, 23 Nov 2016 10:26:20 +1100 - rev 442959
Push
36877 by bmo:ato@mozilla.com at Wed, 23 Nov 2016 16:26:21 +0000
Bug 1307357 part 1 - Make css::Rule hold StyleSheet rather than CSSStyleSheet. r=heycam
MozReview-Commit-ID: JsJa4YqpCZy
2fc2fea2aba4478b5359fd3b4a00cae0098f231d: Bug 1301468 - Add activity stream session for new tab panel. r?ahunt
draft
Sebastian Kaspari <s.kaspari@gmail.com> - Wed, 23 Nov 2016 17:24:31 +0100 - rev 442958
Push
36876 by s.kaspari@gmail.com at Wed, 23 Nov 2016 16:25:14 +0000
Bug 1301468 - Add activity stream session for new tab panel. r?ahunt
MozReview-Commit-ID: 45yMkb3bJfS
07a61d0a6de451d38ff9b44e9f6a881d7adbf093: Bug 1301468 - Add telemetry to AS context menu (following the pattern of existing probes). r?ahunt
draft
Sebastian Kaspari <s.kaspari@gmail.com> - Wed, 23 Nov 2016 17:10:04 +0100 - rev 442957
Push
36876 by s.kaspari@gmail.com at Wed, 23 Nov 2016 16:25:14 +0000
Bug 1301468 - Add telemetry to AS context menu (following the pattern of existing probes). r?ahunt
MozReview-Commit-ID: 91E0c9rPSbB
1b4a0387064476050072bf68c0a91d17e5e0d6d0: Bug 1301468 - AS Top Sites: Add telemetry for showing context menu. r?ahunt
draft
Sebastian Kaspari <s.kaspari@gmail.com> - Wed, 23 Nov 2016 16:59:13 +0100 - rev 442956
Push
36876 by s.kaspari@gmail.com at Wed, 23 Nov 2016 16:25:14 +0000
Bug 1301468 - AS Top Sites: Add telemetry for showing context menu. r?ahunt
MozReview-Commit-ID: 9OzR2NjUnZJ
b87eb97d2f2732a94434a5b55db8d5762dd8e085: Bug 1301468 - AS Highlights: Add LOAD_URL telemetry. r?ahunt
draft
Sebastian Kaspari <s.kaspari@gmail.com> - Wed, 23 Nov 2016 16:55:06 +0100 - rev 442955
Push
36876 by s.kaspari@gmail.com at Wed, 23 Nov 2016 16:25:14 +0000
Bug 1301468 - AS Highlights: Add LOAD_URL telemetry. r?ahunt
MozReview-Commit-ID: 4iVJXkz8L61
9244ce043fb33937cc7164874e558676c8777e47: Bug 1301468 - AS Top Sites: Add LOAD_URL telemetry. r?ahunt
draft
Sebastian Kaspari <s.kaspari@gmail.com> - Wed, 23 Nov 2016 16:52:20 +0100 - rev 442954
Push
36876 by s.kaspari@gmail.com at Wed, 23 Nov 2016 16:25:14 +0000
Bug 1301468 - AS Top Sites: Add LOAD_URL telemetry. r?ahunt
MozReview-Commit-ID: 2vgWB2KxPMK
6c7e491436d4587eb8e04f93f7ae5003657fb083: Bug 1319816 - fix default browser determination on Windows 7 and below in the automigration case, r?jaws
draft
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 23 Nov 2016 16:06:00 +0000 - rev 442953
Push
36875 by bmo:gijskruitbosch+bugs@gmail.com at Wed, 23 Nov 2016 16:11:31 +0000
Bug 1319816 - fix default browser determination on Windows 7 and below in the automigration case, r?jaws
As noted on the bug, because we call getMigratorKeyForDefaultBrowser() multiple times,
its value no longer reflects the (deleted) registry key for subsequent calls.
While we can fix this for the automigrate case by just passing the default we determined a few
lines earlier (and that seems worth doing to avoid busywork), there are 2 small problems
with this:
1) if the default browser has no data, `migratorKey` won't be set, and so we'll call the same
method again anyway, and the message reported in the error console will be that we can't
migrate from Firefox, when the real problem is that we can't migrate from the original
default browser.
2) there are other callers besides AutoMigrate. Specifically, migration.js also calls this
method.
To deal with these, I've fixed getMigratorKeyForDefaultBrowser() to return the same
registry-based value for its lifetime if we hit the 'the default is firefox, go look for an
earlier default' case.
I've verified that either the s/aMigratorKey/migratorKey/ or the change to
getMigratorKeyForDefaultBrowser() are sufficient to make this work properly in the
automigration case.
While I was here, I also updated one of the error messages to be more explicit.
MozReview-Commit-ID: GeUNTfScMMB
e3ea7b576c5457d1a6722597ba2a15a5204662fb: Bug 1319237 - Make GeckoDriver#setWindowSize synchronous; r?automatedtester
draft
Andreas Tolfsen <ato@mozilla.com> - Mon, 21 Nov 2016 23:44:22 +0100 - rev 442952
Push
36874 by bmo:ato@mozilla.com at Wed, 23 Nov 2016 16:09:45 +0000
Bug 1319237 - Make GeckoDriver#setWindowSize synchronous; r?automatedtester
Return from the Set Window Size command only after the window resize
DOM event has occurred.
MozReview-Commit-ID: 7ygZuNJZzq2
6cf3791d9ddd0096e9a3fabe0d3057a00917caf3: Bug 1319237 - Make GeckoDriver#setWindowPosition synchronous; r?automatedtester
draft
Andreas Tolfsen <ato@mozilla.com> - Mon, 21 Nov 2016 23:43:35 +0100 - rev 442951
Push
36874 by bmo:ato@mozilla.com at Wed, 23 Nov 2016 16:09:45 +0000
Bug 1319237 - Make GeckoDriver#setWindowPosition synchronous; r?automatedtester
This change makes the Set Window Position command synchronous by waiting
for the original window position to change before returning.
MozReview-Commit-ID: 3gOv6bNPASV
12b271c622550dfae4e6964df02b510729dbf8b0: Bug 1319237 - Generalise implicit wait utility; r?automatedtester
draft
Andreas Tolfsen <ato@mozilla.com> - Mon, 21 Nov 2016 23:41:20 +0100 - rev 442950
Push
36874 by bmo:ato@mozilla.com at Wed, 23 Nov 2016 16:09:45 +0000
Bug 1319237 - Generalise implicit wait utility; r?automatedtester
This makes the `implicitWaitFor` utility from
testing/marionette/element.js generally available in Marionette.
MozReview-Commit-ID: G8F99tdbiNb
a6a1af5d6cdb38b1a91c875b0abc95ae57826513: Bug 1319237 - Make session fixture module scoped; r?jgraham
draft
Andreas Tolfsen <ato@mozilla.com> - Mon, 21 Nov 2016 23:39:42 +0100 - rev 442949
Push
36874 by bmo:ato@mozilla.com at Wed, 23 Nov 2016 16:09:45 +0000
Bug 1319237 - Make session fixture module scoped; r?jgraham
I recently changed it to function scoped, which was a mistake.
pytest complains if it is not module scoped.
MozReview-Commit-ID: GYP9Ky1avks
22497189c81e8bc0b4f4ec7dd3fa6c9372f4c08b: Bug 1319237 - Allow pytests to be skipped imperatively at runtime; r?jgraham
draft
Andreas Tolfsen <ato@mozilla.com> - Mon, 21 Nov 2016 23:38:42 +0100 - rev 442948
Push
36874 by bmo:ato@mozilla.com at Wed, 23 Nov 2016 16:09:45 +0000
Bug 1319237 - Allow pytests to be skipped imperatively at runtime; r?jgraham
It is required to skip certain WebDriver tests imperatively at runtime,
such as for the Get Window Size and Get Window Position commands, which
are only available at certain configurations.
MozReview-Commit-ID: 9ERYkYm34iI
58e229555bce80def91a538521e8b1db7ef0c365: Bug 1319237 - Assign GeckoDriver#getWindowSize return value in one statement; r?automatedtester
draft
Andreas Tolfsen <ato@mozilla.com> - Mon, 21 Nov 2016 23:36:29 +0100 - rev 442947
Push
36874 by bmo:ato@mozilla.com at Wed, 23 Nov 2016 16:09:45 +0000
Bug 1319237 - Assign GeckoDriver#getWindowSize return value in one statement; r?automatedtester
MozReview-Commit-ID: BGH1WkgH91p
ecaf001fc1da8dce9f97b6c1f8c9187cfeff9af6: Bug 1319237 - Mark yielding functions as generators; r?automatedtester
draft
Andreas Tolfsen <ato@mozilla.com> - Mon, 21 Nov 2016 23:34:05 +0100 - rev 442946
Push
36874 by bmo:ato@mozilla.com at Wed, 23 Nov 2016 16:09:45 +0000
Bug 1319237 - Mark yielding functions as generators; r?automatedtester
MozReview-Commit-ID: 1c0I4pFY4Dd
7807217154c93f5327dbe53f9c8eefe7b2a72348: Bug 1319237 - Calculate correct window position; r?automatedtester
draft
Andreas Tolfsen <ato@mozilla.com> - Mon, 21 Nov 2016 23:33:03 +0100 - rev 442945
Push
36874 by bmo:ato@mozilla.com at Wed, 23 Nov 2016 16:09:45 +0000
Bug 1319237 - Calculate correct window position; r?automatedtester
The testing/marionette/browser.js window getter does not return the
same window as `GeckoDriver#getCurrentWindow`. This is a problem,
but for now we can rely on `getCurrentWindow`.
MozReview-Commit-ID: PT9M7boPM7
390614ab1ad730cef3001a99263225653b25b524: Bug 1319237 - Correct window size- and position test; r?automatedtester,jgraham
draft
Andreas Tolfsen <ato@mozilla.com> - Mon, 21 Nov 2016 23:30:23 +0100 - rev 442944
Push
36874 by bmo:ato@mozilla.com at Wed, 23 Nov 2016 16:09:45 +0000
Bug 1319237 - Correct window size- and position test; r?automatedtester,jgraham
MozReview-Commit-ID: Fajaksg2DhG
efd85759eb7fe47035492782bb405b2472802081: Bug 1319237 - Make GeckoDriver#setWindowSize synchronous; r?automatedtester
draft
Andreas Tolfsen <ato@mozilla.com> - Mon, 21 Nov 2016 23:44:22 +0100 - rev 442943
Push
36873 by bmo:ato@mozilla.com at Wed, 23 Nov 2016 16:03:30 +0000
Bug 1319237 - Make GeckoDriver#setWindowSize synchronous; r?automatedtester
Return from the Set Window Size command only after the window resize
DOM event has occurred.
MozReview-Commit-ID: 7ygZuNJZzq2
87f9a058ec1e24a077ae48158024816f581b85d1: Bug 1319237 - Make GeckoDriver#setWindowPosition synchronous; r?automatedtester
draft
Andreas Tolfsen <ato@mozilla.com> - Mon, 21 Nov 2016 23:43:35 +0100 - rev 442942
Push
36873 by bmo:ato@mozilla.com at Wed, 23 Nov 2016 16:03:30 +0000
Bug 1319237 - Make GeckoDriver#setWindowPosition synchronous; r?automatedtester
This change makes the Set Window Position command synchronous by waiting
for the original window position to change before returning.
MozReview-Commit-ID: 3gOv6bNPASV
5f99ce6405ced8d073a046dcf443adf4f017baf2: Bug 1319237 - Generalise implicit wait utility; r?automatedtester
draft
Andreas Tolfsen <ato@mozilla.com> - Mon, 21 Nov 2016 23:41:20 +0100 - rev 442941
Push
36873 by bmo:ato@mozilla.com at Wed, 23 Nov 2016 16:03:30 +0000
Bug 1319237 - Generalise implicit wait utility; r?automatedtester
This makes the `implicitWaitFor` utility from
testing/marionette/element.js generally available in Marionette.
MozReview-Commit-ID: G8F99tdbiNb