7a3e5d9764999c06e46737cf4a9dcfecc7f77d20: Bug 1405832 - part 4: ContentCacheInParent::OnEventNeedingAckHandled() shouldn't crash in release build r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 20 Nov 2017 23:30:18 +0900 - rev 702217
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1405832 - part 4: ContentCacheInParent::OnEventNeedingAckHandled() shouldn't crash in release build r=m_kato For protecting main process, we should stop crashing main process in release build even when we detect our bug. However, we should keep crashing with MOZ_DIAGNOSTIC_ASSER which is enabled only on Night and Developer Edition. MozReview-Commit-ID: 5BQ46IFzXXj
3e4e219b8aebf8e439d8ac40738321d7c7c81c6f: Bug 1405832 - part 3: ContentCacheInParent::RequestIMEToCommitComposition() should call nsIWidget::NotifyIME() via TextComposition::RequestToCommit() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 20 Nov 2017 23:08:37 +0900 - rev 702216
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1405832 - part 3: ContentCacheInParent::RequestIMEToCommitComposition() should call nsIWidget::NotifyIME() via TextComposition::RequestToCommit() r=m_kato Now, TextComposition::RequestToCommit() manages if it has already requested IME to commit or cancel composition and this is important for redundant requests. Therefore, ContentCacheInParent::RequestIMEToCommitComposition() shouldn't call nsIWidget::NotifyIME() directly. MozReview-Commit-ID: 69VpgyK9Jk5
e8d7881af680c693612c2ed42d3486c5ad4c8e42: Bug 1405832 - part 2: TextComposition::RequestToCommit() should request IME to commit or cancel composition only when it hasn't been request it yet and hasn't received commit event yet r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 20 Nov 2017 22:59:04 +0900 - rev 702215
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1405832 - part 2: TextComposition::RequestToCommit() should request IME to commit or cancel composition only when it hasn't been request it yet and hasn't received commit event yet r=m_kato According to the log in crash reports, eCompositionCommitRequestHandled is sent to ContentCacheInParent twice or more for a composition. This causes breaking mPendingCompositionCount and mPendingEventsNeedingAck management. Currently, nsIWidget::NotifyIME() should be called only by TextComposition::RequestToCommit(). Therefore, the method should manage if it should request it actually. If the composition has already received eCompositionCommit(AsIs) event, it shouldn't request it because parent process may have already stated new composition and it shouldn't be broken by request for old composition. MozReview-Commit-ID: 2ekSa6EIeRP
21522127515146fb7742f4e52c5d4c860bc71562: Bug 1405832 - part 1: ContentCacheInParent::RequestIMEToCommitComposition() should increment mPendingEventsNeedingAck itself if it treat the request handled synchronously without actually requesting IME to commit composition r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 20 Nov 2017 22:20:02 +0900 - rev 702214
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1405832 - part 1: ContentCacheInParent::RequestIMEToCommitComposition() should increment mPendingEventsNeedingAck itself if it treat the request handled synchronously without actually requesting IME to commit composition r=m_kato This is a simple bug of ContentCacheInParent. When ContentCacheInParent::RequestIMEToCommitComposition() returns true, PuppetWidget::RequestIMEToCommitComposition() will send eCompositionCommitRequestHandled pseudo event message back to the main process. This causes counting down mPendingEventsNeedingAck in ContentCacheInParent::OnEventNeedingAckHandled(). Therefore, in the normal path, ContentCacheInParent::OnCompositionEvent() increments it for receiving the pseudo event message. However, if the tab parent has already lost focus, RequestIMEToCommitComposition() returns true without requesting native IME to commit composition. So, ContentCacheInParent::OnCompositionEvent() cannot increment mPendingEventsNeedingAck for coming eCompositionCommitRequestHandled. Therefore, RequestIMEToCommitComposition() needs to increment mPendingEventsNeedingAck by itself when it won't request IME to commit composition but it returns true. MozReview-Commit-ID: 4Alwfy8avB
e55035922259c5449c4004f23b87efe307c2606b: Bug 1381648 - Add non blocking time to the statistics panel of netmonitor; r=Honza
Vincent Lequertier <vi.le@autistici.org> - Fri, 06 Oct 2017 15:11:18 +0200 - rev 702213
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1381648 - Add non blocking time to the statistics panel of netmonitor; r=Honza MozReview-Commit-ID: Anw4hTlpPjH
dd5e0428476bb0dca53741e305db1c515513257b: Bug 1408401 - Release: Bump up devtools-reps bundle to 0.15.0; r=miker
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 21 Nov 2017 18:44:04 +0100 - rev 702212
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1408401 - Release: Bump up devtools-reps bundle to 0.15.0; r=miker MozReview-Commit-ID: ISudQK3C20A
84b90d871c2c14c24356f2840b5bbe9413a5e729: servo: Merge #19332 - moving :dir() param serialization FIXME (from wilsoniya:moving-fixme); r=emilio
Michael Wilson <wilsoniya@gmail.com> - Wed, 22 Nov 2017 04:04:39 -0600 - rev 702211
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
servo: Merge #19332 - moving :dir() param serialization FIXME (from wilsoniya:moving-fixme); r=emilio <!-- Please describe your changes on the following line: --> Per emilio's comment, https://github.com/servo/servo/pull/19195#discussion_r152205644, a `FIXME` regarding `:dir()` parameter serialization has been moved. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they only modify comment lines <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 3ecd0174cc7817cdd2007850c29b8b069a845b46
af8727e2028e660aa0f7525c0e1c784d8edafff7: Bug 1419456 - Disable full CSD support for XFCE as it does not support GDK_DECOR_BORDER, r=jhorak
Martin Stransky <stransky@redhat.com> - Tue, 21 Nov 2017 20:03:21 +0100 - rev 702210
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1419456 - Disable full CSD support for XFCE as it does not support GDK_DECOR_BORDER, r=jhorak MozReview-Commit-ID: BFOgxJ3abrT
b4a1ab50128ef069d2a1853c9f6ad462a1f7161d: Bug 1390396 - Reenable mochitests for custom elements lifecycle callbacks; r=smaug
Edgar Chen <echen@mozilla.com> - Tue, 03 Oct 2017 17:22:58 +0800 - rev 702209
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1390396 - Reenable mochitests for custom elements lifecycle callbacks; r=smaug Attribute changed callback now is fired only when the attribute is in observedAttributes list which is introduced in latest spec, so in this patch, we change the tests for attribute changed callback to use customElements.define() to register customElements definition instead. MozReview-Commit-ID: 2s1qj3UsFUS
18f77ef35a2231f8fa2d4ba37e3e5c7d3cbee469: Bug 1419665 - Support babel object-rest-spread syntax for launchpad r=Honza
Ricky Chien <ricky060709@gmail.com> - Wed, 22 Nov 2017 15:00:48 +0800 - rev 702208
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1419665 - Support babel object-rest-spread syntax for launchpad r=Honza MozReview-Commit-ID: JC6vWNMp3a7
ef9f30bea96d3be6ca7f384b733dc91ff6ad59e1: Bug 1418652: Migrate comm-central configure options to moz.configure; r=chmanchester,Fallen
Tom Prince <mozilla@hocat.ca> - Sat, 18 Nov 2017 10:21:38 -0700 - rev 702207
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1418652: Migrate comm-central configure options to moz.configure; r=chmanchester,Fallen MozReview-Commit-ID: JBRsgBnB9oF
5e6f9a196d6750f34ab0c5c04f3ff117023761ae: Bug 1418652: Remove non-existant comm-centrall configure option; r=chmanchester,Fallen
Tom Prince <mozilla@hocat.ca> - Sat, 18 Nov 2017 10:17:21 -0700 - rev 702206
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1418652: Remove non-existant comm-centrall configure option; r=chmanchester,Fallen It was removed in Bug 1318966. MozReview-Commit-ID: 6fckjVDubTT
3c351abd294d1542deff2c9600089368eb37b449: Bug 1413270 - Document how to interpret use counter data. r=chutten
Alessio Placitelli <alessio.placitelli@gmail.com> - Tue, 21 Nov 2017 14:28:55 +0100 - rev 702205
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1413270 - Document how to interpret use counter data. r=chutten This patch adds a new section to the use counters Telemetry docs that explains how one should think of the data gathered using them. MozReview-Commit-ID: 5mYIYubWxaz
7ca94f459acf231f774d3db2e7f8d0d1d4a8e0bb: Bug 1417498 - Account for aRequest being null in onLocationChange. r=JanH
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 17 Nov 2017 19:50:04 +0100 - rev 702204
Push 90416 by bgrinstead@mozilla.com at Wed, 22 Nov 2017 21:47:20 +0000
Bug 1417498 - Account for aRequest being null in onLocationChange. r=JanH According to the documentation, aRequest may be null in some cases, and one such case is when the location change was caused by a page using the history API. MozReview-Commit-ID: AUlHBgzaKDX
c3be9850edb5b24045703058e44458269313ea9f: Bug 1417658 - Move export_suffixes into GeneratedFile; r=nalexander draft
Mike Shal <mshal@mozilla.com> - Wed, 22 Nov 2017 14:14:30 -0500 - rev 702203
Push 90415 by bmo:mshal@mozilla.com at Wed, 22 Nov 2017 21:46:13 +0000
Bug 1417658 - Move export_suffixes into GeneratedFile; r=nalexander I believe all backends will need to know which GeneratedFiles are needed before compilation can start, so we should make that an attribute of the object. Each backend can then make its own decision about what to do with the different types of GeneratedFiles. MozReview-Commit-ID: ByburRx540b
13b94e29dc0a32185d9fcb60e503988a722ea60a: Bug 1415739 - Use type/autocomplete properties, instead of attributes, to decide whether to save FormData. r=mikedeboer draft
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 22 Nov 2017 16:37:40 -0500 - rev 702202
Push 90414 by mozilla@noorenberghe.ca at Wed, 22 Nov 2017 21:44:13 +0000
Bug 1415739 - Use type/autocomplete properties, instead of attributes, to decide whether to save FormData. r=mikedeboer The property values are already normalized according to the spec. MozReview-Commit-ID: DbKZf9KXCji
019c7b6b48a1aaf3e05b05c49fda9917523c20cc: Bug 1419792 - Shapes highlighter drawn inaccurately for shape-outside with margins. r=gl
Mike Park <mikeparkms@gmail.com> - Wed, 22 Nov 2017 12:05:55 -0500 - rev 702201
Push 90414 by mozilla@noorenberghe.ca at Wed, 22 Nov 2017 21:44:13 +0000
Bug 1419792 - Shapes highlighter drawn inaccurately for shape-outside with margins. r=gl MozReview-Commit-ID: 1MGCvsDXJ6O
b9dbe5af9a060de0b76c02ba491ed713f9a1fcae: Bug 1407423 - Part 3: Update Puppet Device Implementation,r=daoshengmu
Kearwood Gilbert <kgilbert@mozilla.com> - Tue, 21 Nov 2017 14:18:16 -0800 - rev 702200
Push 90414 by mozilla@noorenberghe.ca at Wed, 22 Nov 2017 21:44:13 +0000
Bug 1407423 - Part 3: Update Puppet Device Implementation,r=daoshengmu - Update prefs to accomodate tests, disabling enumeration throttling - Updated Puppet display and controller implementation to act more like the actual devices. - Updated tests to ensure that they explicitly create a VR mock display and don't create duplicate mock displays. MozReview-Commit-ID: 6RPVqekG2je
16d247b8091dcd2edd937a2cf473d1f0f948a3eb: Bug 1407423 - Part 2: Update gfxVRGVR to match refactoring,r=rbarker
Kearwood "Kip" Gilbert <kgilbert@mozilla.com> - Tue, 14 Nov 2017 10:42:46 -0800 - rev 702199
Push 90414 by mozilla@noorenberghe.ca at Wed, 22 Nov 2017 21:44:13 +0000
Bug 1407423 - Part 2: Update gfxVRGVR to match refactoring,r=rbarker MozReview-Commit-ID: DmKnEZanQ3f
2b625d265761d30e103eecc442d07f18f41887ce: Bug 1407423 - Ensure that any time we have loaded the Oculus runtime libary, we are polling ShouldQuit,r=daoshengmu
Kearwood "Kip" Gilbert <kgilbert@mozilla.com> - Tue, 10 Oct 2017 14:42:37 -0700 - rev 702198
Push 90414 by mozilla@noorenberghe.ca at Wed, 22 Nov 2017 21:44:13 +0000
Bug 1407423 - Ensure that any time we have loaded the Oculus runtime libary, we are polling ShouldQuit,r=daoshengmu - Ensure ovr_GetSessionStatus is polled even when a VR presentation is not active. - When we fail to initialize an Oculus Session or detect VR hardware, immediately unload the Oculus Library as we can't poll for ShouldQuit without a valid Oculus session. - When we poll ovr_GetSessionStatus, we are now updating the mounted state in VRDisplayInfo::mIsMounted. - Added prefs to control enumeration throttling and timeout to release VR hardware when inactive. - Some refactoring to make frame loop more understandable and less brittle. - When throttling enumeration, we ensure that all other VR apis also throttle enumeration so that they don't pick up the same device during throttling. - Some long functions in VRManager have been broken up and had their inner-workings documented in more detail. MozReview-Commit-ID: CEYwwQ9mYd0
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip