784eed0ec54f8f00ba4a812f7cacad729abb7fa8: Bug 1330533 - Use FuzzerDriver directly instead of wrapping it in a libfuzzer_main function. r?decoder draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 12 Jan 2017 14:44:18 +0900 - rev 462799
Push 41857 by bmo:mh+mozilla@glandium.org at Wed, 18 Jan 2017 00:24:11 +0000
Bug 1330533 - Use FuzzerDriver directly instead of wrapping it in a libfuzzer_main function. r?decoder Going further from the previous changes, all libfuzzer_main really does is call the init function, and then proceed to call the fuzzer driver with the testing function. So instead of calling that function for it to do all that, the LibFuzzerRunner can just call the init function itself, and then call the fuzzer driver with the testing function.
0e93348743fd3893c5095b80f68111f3d028cb15: Bug 1330533 - Pass LibFuzzerInitFunc and LibFuzzerTestingFunc to libfuzzer_main. r?decoder draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 12 Jan 2017 14:50:14 +0900 - rev 462798
Push 41857 by bmo:mh+mozilla@glandium.org at Wed, 18 Jan 2017 00:24:11 +0000
Bug 1330533 - Pass LibFuzzerInitFunc and LibFuzzerTestingFunc to libfuzzer_main. r?decoder The LibFuzzerRunner code lives in libxul. It's unnecessary complications to have it call back a function in the firefox executable just so that it calls another function that is in libxul. Passing the init and testing functions to the libfuzzer_main function allows to just bypass that roundtrip, simplifying the setup.
f8a2e2fbcecfe7839277dc14728c3ae2d76626d8: Bug 1330533 - Remove argc/argv arguments to XRE_LibFuzzerSetMain. r?decoder draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 12 Jan 2017 11:59:37 +0900 - rev 462797
Push 41857 by bmo:mh+mozilla@glandium.org at Wed, 18 Jan 2017 00:24:11 +0000
Bug 1330533 - Remove argc/argv arguments to XRE_LibFuzzerSetMain. r?decoder The function given to XRE_LibFuzzerSetMain is called from somewhere that does have access to argc/argv already, so we can avoid passing them to XRE_LibFuzzerSetMain. This actually might fix subtle issues with argc/argv not really matching reality when calling the LibFuzzerMain function in the current code: some arguments are handled before the call, and both argc and argv are modified from within XRE_main, but the values stored for the LibFuzzerMain call still are the original ones. Argv being a pointer, and it not being reallocated, the value stored for the LibFuzzerMain call points to the changed one, but argc, being an integer, is not modified accordingly. In fact, it's actually worse, because while the Gecko code doesn't reallocate argv, gtk_main might. So if some GTK flag is passed on the command line, there's also a possibility that the LibFuzzerMain function will do a use-after-free. So all in all, it's just better to use the set of modified argc/argv from XRE_main instead of storing them from main().
ac9b535141f31ad86545730a83c15655bf0aace7: Bug 1330481 - Fix "error: a storage class can only be specified for objects and functions". r?decoder draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 12 Jan 2017 11:01:37 +0900 - rev 462796
Push 41857 by bmo:mh+mozilla@glandium.org at Wed, 18 Jan 2017 00:24:11 +0000
Bug 1330481 - Fix "error: a storage class can only be specified for objects and functions". r?decoder
6b46b8d889dfcf921c7823655cf1b92c55451c2f: Bug 1306327 - Remove everything related to frozen functions from the XPCOM glue. r=bsmedberg
Mike Hommey <mh+mozilla@glandium.org> - Tue, 10 Jan 2017 17:12:43 +0900 - rev 462795
Push 41857 by bmo:mh+mozilla@glandium.org at Wed, 18 Jan 2017 00:24:11 +0000
Bug 1306327 - Remove everything related to frozen functions from the XPCOM glue. r=bsmedberg Now that nothing is using those functions, we can remove them and limit the scope of the standalone glue to initialize the new Bootstrap API.
908c2d41eeaafc34697261866d36206bfe896e4b: Bug 1306327 - Move reading application.ini to XRE_main. r=bsmedberg
Mike Hommey <mh+mozilla@glandium.org> - Tue, 10 Jan 2017 16:43:23 +0900 - rev 462794
Push 41857 by bmo:mh+mozilla@glandium.org at Wed, 18 Jan 2017 00:24:11 +0000
Bug 1306327 - Move reading application.ini to XRE_main. r=bsmedberg Reading application.ini involves using nsCOMPtr<nsIFile>, and that can only happen through the XPCOM glue, which we eventually want to get rid of. So, while keeping the command line argument/environment variable handling in nsBrowserApp, we move the actually parsing of the file to XRE_main, where things can be handled without the XPCOM glue.
517720b458ce9f10734b8fbf6943ca1a47066f42: Bug 1306327 - Use the new XRE Bootstrap API in Firefox for Android. r=bsmedberg
Mike Hommey <mh+mozilla@glandium.org> - Sat, 17 Dec 2016 06:48:01 +0900 - rev 462793
Push 41857 by bmo:mh+mozilla@glandium.org at Wed, 18 Jan 2017 00:24:11 +0000
Bug 1306327 - Use the new XRE Bootstrap API in Firefox for Android. r=bsmedberg Here, we also modify APKOpen to use the XPCOM glue loading process instead of custom symbol resolution, so that the Bootstrap API can be used in a more straightforward manner.
2a0edcbaebeeae1cd4cf1be3b0db127fa3bdd01f: Bug 1306327 - Use the new XRE Bootstrap API in Desktop Firefox. r=bsmedberg
Mike Hommey <mh+mozilla@glandium.org> - Fri, 16 Dec 2016 11:10:02 +0900 - rev 462792
Push 41857 by bmo:mh+mozilla@glandium.org at Wed, 18 Jan 2017 00:24:11 +0000
Bug 1306327 - Use the new XRE Bootstrap API in Desktop Firefox. r=bsmedberg This just wraps all the XRE method calls to go through the Bootstrap API instead of relying on the XPCOM glue methods.
a7dac14f91df3f94ed809465f80833c310a99f0c: Bug 1306327 - Add a new XRE Bootstrap API that wraps all the XRE methods. r=bsmedberg
Mike Hommey <mh+mozilla@glandium.org> - Thu, 15 Dec 2016 16:46:18 +0900 - rev 462791
Push 41857 by bmo:mh+mozilla@glandium.org at Wed, 18 Jan 2017 00:24:11 +0000
Bug 1306327 - Add a new XRE Bootstrap API that wraps all the XRE methods. r=bsmedberg This is the first step towards changing how nsBrowserApp and other current XPCOM glue users start up Gecko. The goal here is to expose the same API via a single object with a VTable instead of the current XPCOM glue machinery. Instead of creating an entirely new API and changing everything to use it, we go forward with smaller steps for a more comprehensible transition.
be999ce0e4fe0354bd2737504cca7fccf206f94e: Bug 1306327 - Avoid call to NS_DebugBreak from content_process_main(). r=billm
Mike Hommey <mh+mozilla@glandium.org> - Tue, 10 Jan 2017 17:50:04 +0900 - rev 462790
Push 41857 by bmo:mh+mozilla@glandium.org at Wed, 18 Jan 2017 00:24:11 +0000
Bug 1306327 - Avoid call to NS_DebugBreak from content_process_main(). r=billm We want to avoid calls to XPCOM glue functions, in order to remove them later on.
8e583d30ce9816b92a180ce34b0559c7e09e04a3: Bug 1306327 - Remove NS_XRE_DLL_BLOCKLIST_ENABLED. r=bsmedberg
Mike Hommey <mh+mozilla@glandium.org> - Tue, 10 Jan 2017 09:10:36 +0900 - rev 462789
Push 41857 by bmo:mh+mozilla@glandium.org at Wed, 18 Jan 2017 00:24:11 +0000
Bug 1306327 - Remove NS_XRE_DLL_BLOCKLIST_ENABLED. r=bsmedberg Instead of having nsBrowserApp.cpp set a flag in XREAppData to indicate whether the DLL blocklist properly initialized, just have XRE code ask the blocklist itself.
d6d7a6e9a3d9e9bace62823719517e7cbdb2bb5e: Bug 1306327 - Remove the flags argument to XRE_main. r=bsmedberg
Mike Hommey <mh+mozilla@glandium.org> - Tue, 10 Jan 2017 14:15:50 +0900 - rev 462788
Push 41857 by bmo:mh+mozilla@glandium.org at Wed, 18 Jan 2017 00:24:11 +0000
Bug 1306327 - Remove the flags argument to XRE_main. r=bsmedberg This hasn't been used since the removal of the Metro code in bug 1039866, close to two years ago.
398e907e9a9c44b7ff525b2199cb81cea7695f75: Bug 1306327 - Don't set XREAppData.xreDirectory from nsBrowserApp.cpp. r=bsmedberg
Mike Hommey <mh+mozilla@glandium.org> - Tue, 10 Jan 2017 08:02:43 +0900 - rev 462787
Push 41857 by bmo:mh+mozilla@glandium.org at Wed, 18 Jan 2017 00:24:11 +0000
Bug 1306327 - Don't set XREAppData.xreDirectory from nsBrowserApp.cpp. r=bsmedberg It turns out nsAppRunner.cpp sets it to the exact same thing when it's not already set, so we might as well use that.
b92d791582e5bbee2a681e48b6901cf601c35164: Bug 1306327 - Remove XPCOMGlueEnablePreload. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 15 Dec 2016 17:37:53 +0900 - rev 462786
Push 41857 by bmo:mh+mozilla@glandium.org at Wed, 18 Jan 2017 00:24:11 +0000
Bug 1306327 - Remove XPCOMGlueEnablePreload. r=froydnj Back in bug 632404, when the function was added, preloading was conditional. But after some A/B testing, the conclusion in bug 771745 was that we would just do preloading unconditionally. Which means in practice, we don't need to have a function to enable it manually anymore, since we're always enabling it.
64dcf6b92394480d0546657f3615a31a24c0f3b4: Bug 1306327 - Use UniquePtr for CreateGMPLoader. r=cpearce
Mike Hommey <mh+mozilla@glandium.org> - Thu, 15 Dec 2016 16:14:34 +0900 - rev 462785
Push 41857 by bmo:mh+mozilla@glandium.org at Wed, 18 Jan 2017 00:24:11 +0000
Bug 1306327 - Use UniquePtr for CreateGMPLoader. r=cpearce
eada8de7256f96997b44296c9d37805a4024dceb: Bug 1330791 - Enable the no-native-reassign rule for eslint in /services and fix the associated error. r=markh
Jared Wein <jwein@mozilla.com> - Thu, 12 Jan 2017 18:28:48 -0500 - rev 462784
Push 41857 by bmo:mh+mozilla@glandium.org at Wed, 18 Jan 2017 00:24:11 +0000
Bug 1330791 - Enable the no-native-reassign rule for eslint in /services and fix the associated error. r=markh MozReview-Commit-ID: 65EsZGCJPMD
a3c656a9f3ca909c07dcb98134dd8711b6753cb6: Bug 1330791 - Enable the no-ex-assign rule for eslint in /services. There are no associated errors with enabling this rule. r=markh
Jared Wein <jwein@mozilla.com> - Thu, 12 Jan 2017 18:27:39 -0500 - rev 462783
Push 41857 by bmo:mh+mozilla@glandium.org at Wed, 18 Jan 2017 00:24:11 +0000
Bug 1330791 - Enable the no-ex-assign rule for eslint in /services. There are no associated errors with enabling this rule. r=markh MozReview-Commit-ID: 8AsaN1gyjkm
e0cbc754e841f8009c07e7ba1a5dab8f5e1fe516: Bug 1330791 - Enable the no-cond-assign rule for eslint in /services. There are no associated errors with enabling this rule. r=markh
Jared Wein <jwein@mozilla.com> - Thu, 12 Jan 2017 18:27:00 -0500 - rev 462782
Push 41857 by bmo:mh+mozilla@glandium.org at Wed, 18 Jan 2017 00:24:11 +0000
Bug 1330791 - Enable the no-cond-assign rule for eslint in /services. There are no associated errors with enabling this rule. r=markh MozReview-Commit-ID: BM83kDZJpZ3
49d8016fab12d984512c4c912e7c5091c9984684: Bug 1330791 - Enable the brace-style rule for eslint in /services and fix the associated errors. r=markh
Jared Wein <jwein@mozilla.com> - Thu, 12 Jan 2017 18:24:52 -0500 - rev 462781
Push 41857 by bmo:mh+mozilla@glandium.org at Wed, 18 Jan 2017 00:24:11 +0000
Bug 1330791 - Enable the brace-style rule for eslint in /services and fix the associated errors. r=markh MozReview-Commit-ID: Ebl3bODX14z
53d4b83ccd2251b38652fa51c06580ffec93940f: Bug 1330791 - Enable the no-octal rule for eslint and fix the associated error. r=markh
Jared Wein <jwein@mozilla.com> - Thu, 12 Jan 2017 18:21:43 -0500 - rev 462780
Push 41857 by bmo:mh+mozilla@glandium.org at Wed, 18 Jan 2017 00:24:11 +0000
Bug 1330791 - Enable the no-octal rule for eslint and fix the associated error. r=markh MozReview-Commit-ID: LLYKmP7HOei
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip