Backed out changeset 838c0ab9cbdb (bug 1464084) for Linux static bustage on a CLOSED TREE

Bug 1465938 Fix a pair of WE theme issues r=zombie 1. Stop broadcasting an extra theme update event when changing themes 2. Use enable() to enable themes upon install MozReview-Commit-ID: CgWjNEihwmE

Bug 1466060 - Upgrade to binutils 2.28.1. r=nalexander Version 2.25.1's libiberty can choke on some symbols. That was fixed in 2.27. As of writing, the last version is 2.30. Conservatively go with 2.28.1, which is the same major version (2.28) as what is currently in Debian stable.

Bug 1466054 - Run `mach build-backend -b GnMozbuildWriter`. r=froydnj This refreshes the gn-generated moz.builds with the change from previous commit. Somehow, this does unrelated changes, there must be something funky in the gn-moz.build-generator.

Bug 1466054 - Enable STL wrapping in gn and gyp processed code. r=froydnj We wrap STL headers so as to ensure our inline infallible operator new definitions are used, but for some reason, STL wrappers were disabled in whatever code we used gyp for first, and that ended up spreading as more things used gyp, and now with gn, whose handling cargo culted STL disabling from the gyp code. We remove all this disabling, because it turns out it causes no build problem anymore.

Merge mozilla-central to autoland. a=merge CLOSED TREE

Bug 1463834 - vendored hglib, updated to python-hglib r=davehunt

Bug 1463183 - Remove all instances of isUniversalBinary since we no longer build universal binaries for macOS MozReview-Commit-ID: FZfVrYtEo13

Bug 1340498 - Fix unified sources build errors r?mrbkap Adding the Places* files into unified sources pushed the unified sources into a situation that exposed a strangely large number of errors. This seems to be the minimum set of changes I could make to resolve all of the issues. MozReview-Commit-ID: C2H9ce8FmE4

Bug 1340498 - Add new globals to lint config MozReview-Commit-ID: 360gup8cWvi

Bug 1340498 - Update onVisits tests to use 'page-visited' r?mak MozReview-Commit-ID: FxC3gcUF9hl

Bug 1340498 - Update onVisits uses to 'page-visited' r?mak Consuming the new 'page-visited' notification was fairly trivial, since it was already brought over to onVisits. There's not much to say about this other than that I'm a little bit uncertain about all the hoops we have to jump through to get a JSContext and GlobalObject from History.cpp (which is discussed in the earlier commit in the series). MozReview-Commit-ID: LHaBWSylyLI

Bug 1340498 - Implement new Places Observers interface r?mrbkap See the design doc[1] for further info. We would like to redesign the places observer system to be more performant and more friendly to consume. WebIDL was recommended as it simplifies creating simple dictionary payloads while allowing dynamic typing with `any`. There were some difficulties with WebIDL though, most of which revolved around allowing consumers to be weakly referenced, from both C++ and JS. The simplest solution I could come up with was to create a simple native interface for the C++ case, and a WebIDL wrapper for a JS callback in the JS case. Suggestions for simpler alternatives are very welcome though. [1] https://docs.google.com/document/d/1G45vfd6RXFXwNz7i4FV40lDCU0ao-JX_bZdgJV4tLjk/edit?usp=sharing MozReview-Commit-ID: ACnAEfa5WxO

Bug 1348145 - Remove getWindowPosition/setWindowPosition and getWindowSize/setWindowSize. MozReview-Commit-ID: AUxPhJwOKB6

Bug 1462725 - Add 'end_study' event; r=rhelmer This `end_study` event will be recorded when an ending condition has been met: the study has expired, the user is ineligible, or the study has been disabled (the study pref has been turned off). MozReview-Commit-ID: 6WKL4hqWliz

Bug 1462725 - Add study expiration and testing override pref; r=rhelmer The study will shutdown on its own after a specified period of time. The testing override pref allows for changing the study duration from the default, which is 4 weeks. MozReview-Commit-ID: GEWpCaJX3Mr

Bug 1462725 - Add eligibility check; r=rhelmer On startup, ends the study if auto private browsing mode is enabled. I did not add a pref observer for this, since when the pref is changed, the changes won't take effect until the next startup anyway. MozReview-Commit-ID: DqABLEai8zx

Bug 1462725 - Uninit study on Firefox shutdown; r=rhelmer Intended to undo study-related changes that don't need to persist between sessions: clear prefs, remove observers, etc. MozReview-Commit-ID: 4Eyyq7vMm13

Bug 1462725 - Rename study module; r=rhelmer Module was renamed in order to be more consistent with references to this study elsewhere, as in the tracking bug 1457226. Also removed TelemetryEvents.sendEvent method, set log level to 'warn' and added milestone bug to search probe. MozReview-Commit-ID: 6J87TUjXf6X

Bug 1462725 - Dupe 'search' event probe under 'savant' category; r=rhelmer The duplication is so that this study’s use of the probe does not affect and is not affected by other uses of the probe. MozReview-Commit-ID: ILYu2izhMDB