734640228fbc00212f96ea1a362247887d739b73: Bug 1369009 - Intermittent layout/style/test/browser_newtab_share_rule_processors.js. r=honzab
Michal Novotny <michal.novotny@gmail.com> - Fri, 07 Jul 2017 04:58:00 -0400 - rev 607779
Push
68110 by bmo:nchen@mozilla.com at Wed, 12 Jul 2017 21:26:51 +0000
Bug 1369009 - Intermittent layout/style/test/browser_newtab_share_rule_processors.js. r=honzab
6506888c5f7b25b2a690117fb60fe79a90d274e6: Bug 1376459 - Prevent Offline Application Cache fallback namespace and fallback page be from a parent directory relative to the manifest. r=jduell
Honza Bambas <honzab.moz@firemni.cz> - Wed, 12 Jul 2017 16:58:19 -0400 - rev 607778
Push
68110 by bmo:nchen@mozilla.com at Wed, 12 Jul 2017 21:26:51 +0000
Bug 1376459 - Prevent Offline Application Cache fallback namespace and fallback page be from a parent directory relative to the manifest. r=jduell
f5687797261d69daf1a788d15275909be03c4c2f: Bug 1294139 - [debugger.html] Turn new debugger on by default for all channels. r=jdescottes
Jason Laster <jason.laster.11@gmail.com> - Wed, 12 Jul 2017 13:29:00 -0400 - rev 607777
Push
68110 by bmo:nchen@mozilla.com at Wed, 12 Jul 2017 21:26:51 +0000
Bug 1294139 - [debugger.html] Turn new debugger on by default for all channels. r=jdescottes
f5897aea60b5c0e0b01227dfadf9311fbc35b143: Bug 1380461 part 1: Clarify ancient code-comment about the helper-variables we use as AddRemoveScrollbar outparams. r?jfkthame
draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 12 Jul 2017 14:26:29 -0700 - rev 607776
Push
68109 by dholbert@mozilla.com at Wed, 12 Jul 2017 21:26:41 +0000
Bug 1380461 part 1: Clarify ancient code-comment about the helper-variables we use as AddRemoveScrollbar outparams. r?jfkthame
MozReview-Commit-ID: Fxzes2yuLHJ
671f6bdbb5517716dcead0431f073d6421d562bc: Bug 1380461 part 0: Fix indentation in nsXULScrollFrame::AddRemoveScrollbar. (whitespace-only) r?jfkthame
draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 12 Jul 2017 14:25:46 -0700 - rev 607775
Push
68109 by dholbert@mozilla.com at Wed, 12 Jul 2017 21:26:41 +0000
Bug 1380461 part 0: Fix indentation in nsXULScrollFrame::AddRemoveScrollbar. (whitespace-only) r?jfkthame
MozReview-Commit-ID: zJBPEUa4Po
08994294cc23b764d2bab98a398e5402ed73cc99: Bug 1380461 part 1: Clarify ancient code-comment about the helper-variables we use as AddRemoveScrollbar outparams. r?jfkthame
draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 12 Jul 2017 14:24:19 -0700 - rev 607774
Push
68108 by dholbert@mozilla.com at Wed, 12 Jul 2017 21:24:32 +0000
Bug 1380461 part 1: Clarify ancient code-comment about the helper-variables we use as AddRemoveScrollbar outparams. r?jfkthame
MozReview-Commit-ID: Fxzes2yuLHJ
f7db6ee4ab4ca159b9dfb35358833daa814ff790: Bug 1380461 part 0: Fix indentation in nsXULScrollFrame::AddRemoveScrollbar. (whitespace-only) r?jfkthame
draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 12 Jul 2017 14:24:16 -0700 - rev 607773
Push
68108 by dholbert@mozilla.com at Wed, 12 Jul 2017 21:24:32 +0000
Bug 1380461 part 0: Fix indentation in nsXULScrollFrame::AddRemoveScrollbar. (whitespace-only) r?jfkthame
MozReview-Commit-ID: zJBPEUa4Po
4cb6299806578650895c819750dfb1402c1191ab: Bug 1380461: Clarify ancient code-comment about the helper-variables we use as AddRemoveScrollbar outparams. r?jfkthame
draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 12 Jul 2017 14:17:47 -0700 - rev 607772
Push
68107 by dholbert@mozilla.com at Wed, 12 Jul 2017 21:18:00 +0000
Bug 1380461: Clarify ancient code-comment about the helper-variables we use as AddRemoveScrollbar outparams. r?jfkthame
MozReview-Commit-ID: Fxzes2yuLHJ
cf78c3e822fec439a7a568b5f6597dabd4c65ed5: Bug 1380461: Clarify code-comment about AddRemoveScrollbar helper-variables. r?jfkthame
draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 12 Jul 2017 14:16:58 -0700 - rev 607771
Push
68106 by dholbert@mozilla.com at Wed, 12 Jul 2017 21:17:12 +0000
Bug 1380461: Clarify code-comment about AddRemoveScrollbar helper-variables. r?jfkthame
MozReview-Commit-ID: Fxzes2yuLHJ
833795f91bae9cd01bdf7e4f8cc9a96a6e97f633: Bug 1380461: Clarify code-comment about AddRemoveScrollbar helper-variables. r?jfkthame
draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 12 Jul 2017 14:15:55 -0700 - rev 607770
Push
68105 by dholbert@mozilla.com at Wed, 12 Jul 2017 21:16:09 +0000
Bug 1380461: Clarify code-comment about AddRemoveScrollbar helper-variables. r?jfkthame
MozReview-Commit-ID: Fxzes2yuLHJ
859b3cefd177551aadadd0a6ed98bef561a1e2af: Bug 1379334 - Make XULScrollFrame test for needing a vertical scrollbar because of the size of the horizontal scrollbar.
draft
L. David Baron <dbaron@dbaron.org> - Tue, 11 Jul 2017 14:56:24 -0700 - rev 607769
Push
68105 by dholbert@mozilla.com at Wed, 12 Jul 2017 21:16:09 +0000
Bug 1379334 - Make XULScrollFrame test for needing a vertical scrollbar because of the size of the horizontal scrollbar.
This fixes an incremental layout bug, where the number of times we
reflow the frame affects its layout. This is because we make the
decisions about the vertical scrollbar before the horizontal scrollbar
(and, when making the decision, adjust mHelper.mScrollPort for the size
of the scrollbar). Thus, in order to avoid a situation where reflowing
the scrollframe once leads us to have no vertical scrollbar, but
reflowing it a second time leads us to add that scrollbar, we need to
retest for the need for a vertical scrollbar after we add the horizontal
one.
(It's possible there are some other missing cases here, but this is the
one that (a) already existed in the code and (b) is needed to fix the
reftest failure on Windows that I got on
bug 1308876, in
layout/reftests/text-overflow/xulscroll.html .
The reftest here shows the bug even without
bug 1308876 (though I
confirmed that only by loading the test and reference in a nightly
build, not in the reftest harness). I did test that, in combination
with
bug 1308876, the test fails without the patch and passes with the
patch.
MozReview-Commit-ID: LhMi7LbmB6J
de7260da8e7acc006431c32492e1d6ac272a0e2c: Bug 1379334 - Convert mis-indented code to 2-space indent, plus bracing and logical operator position fixes when reindenting.
draft
L. David Baron <dbaron@dbaron.org> - Mon, 10 Jul 2017 18:55:39 -0700 - rev 607768
Push
68105 by dholbert@mozilla.com at Wed, 12 Jul 2017 21:16:09 +0000
Bug 1379334 - Convert mis-indented code to 2-space indent, plus bracing and logical operator position fixes when reindenting.
MozReview-Commit-ID: ElsSNF40LZQ
a8809f15b58213f3292b9eaf7fa9583377d1fa30: Bug 1378727: Use the zip reader cache when reading extension locales. r=aswan
Kris Maglione <maglione.k@gmail.com> - Sat, 08 Jul 2017 16:48:54 -0700 - rev 607767
Push
68105 by dholbert@mozilla.com at Wed, 12 Jul 2017 21:16:09 +0000
Bug 1378727: Use the zip reader cache when reading extension locales. r=aswan
MozReview-Commit-ID: BOoVcyypdRN
8843a6e3840586fe05a1434484a848d48b2a6e8b: Bug 1371445 - Add |mach android {lint,findbugs,checkstyle,test}| commands for running Android-specific test suites. r=gps
draft
Nick Alexander <nalexander@mozilla.com> - Mon, 12 Jun 2017 08:55:54 -0700 - rev 607766
Push
68104 by nalexander@mozilla.com at Wed, 12 Jul 2017 21:11:53 +0000
Bug 1371445 - Add |mach android {lint,findbugs,checkstyle,test}| commands for running Android-specific test suites. r=gps
It be ideal to have |mach test {findbugs,test}| and |mach lint
{lint,checkstyle}|, but the |mach test| command is very difficult to
extend in a direction orthogonal to the existing direction. The
existing |mach test| is built around in-tree manifests, tagged and
divided into suites, intended to support |mach test
path/to/arbitrary/test|. The Android findbugs task is a global static
analysis that doesn't fit into the path/manifest model. The Android
test task is based on JUnit and not easy to build manifest support
for. The |mach lint| command is intended to be extended, but the
effort to extend it is non-trivial and not worth the effort (at this
time).
Therefore, I've taken the existing, little used |mach android| command
and added subcommands for use by local developers and automation. If
nothing else, this reduces the number of "special Gradle targets" --
the equivalent of "special Make targets" -- sprinkled throughout the
tree, which can only be a good thing!
MozReview-Commit-ID: 24b1vbgykpN
1850e7365b903269c034efc6b89257ebe3834161: Bug 1371445 - Pre: Upload HTML checkstyle report. r=maliu
draft
Nick Alexander <nalexander@mozilla.com> - Tue, 04 Jul 2017 13:06:08 -0700 - rev 607765
Push
68104 by nalexander@mozilla.com at Wed, 12 Jul 2017 21:11:53 +0000
Bug 1371445 - Pre: Upload HTML checkstyle report. r=maliu
I think this was just oversight.
MozReview-Commit-ID: 4hC48BEqfu8
783c40122a0e50eb62d8b12ccbfc4f8457724e0f: Bug 1371445 - Pre: Fail unit tests if unlimited strength JCE is not installed. r=maliu
draft
Nick Alexander <nalexander@mozilla.com> - Tue, 04 Jul 2017 13:57:27 -0700 - rev 607764
Push
68104 by nalexander@mozilla.com at Wed, 12 Jul 2017 21:11:53 +0000
Bug 1371445 - Pre: Fail unit tests if unlimited strength JCE is not installed. r=maliu
This has been a problem as far back as the android-sync repository --
https://github.com/mozilla-services/android-sync#download-prerequisites!
MozReview-Commit-ID: dIWI8WtHKu
8d48b664903bce32def8f0762a86d31c250c3853: Bug 1371445 - Pre: Produce and upload XML and HTML findbugs reports. r=maliu
draft
Nick Alexander <nalexander@mozilla.com> - Tue, 04 Jul 2017 13:05:20 -0700 - rev 607763
Push
68104 by nalexander@mozilla.com at Wed, 12 Jul 2017 21:11:53 +0000
Bug 1371445 - Pre: Produce and upload XML and HTML findbugs reports. r=maliu
We want HTML reports for humans and XML reports for processing. It's
unfortunate that we need to handle this manually, but here we are.
MozReview-Commit-ID: BKEhl7cInPP
45b1d63374cd9ae4b64c75ca65b2d8b3296f5ac5: Bug 1344244 - Part 1: Accept newer Android lint version. r=glandium
draft
mozilla@mozilla-23773 - Thu, 29 Jun 2017 11:43:22 -0700 - rev 607762
Push
68104 by nalexander@mozilla.com at Wed, 12 Jul 2017 21:11:53 +0000
Bug 1344244 - Part 1: Accept newer Android lint version. r=glandium
MozReview-Commit-ID: KRwU0UKjkZZ
13b1f7d43127c4b4b3bb1d236b31b5b202db533a: Bug 1344244 - Pre: Support mobile/android in bootstrap on CentOS. r=glandium
draft
Nick Alexander <nalexander@mozilla.com> - Wed, 05 Jul 2017 15:06:46 -0700 - rev 607761
Push
68104 by nalexander@mozilla.com at Wed, 12 Jul 2017 21:11:53 +0000
Bug 1344244 - Pre: Support mobile/android in bootstrap on CentOS. r=glandium
This works in a centos:7 docker image.
MozReview-Commit-ID: LZEgSho7xb
926f11ffe7ba183c884ca2c51280bce517f8e232: Bug 1380165 Part 1: Remove no-longer-used NS_MACOSX_JAVA2_PLUGIN_DIR variable and a comment that referenced a closed bug that conditionally used it.
draft
Brad Werth <bwerth@mozilla.com> - Wed, 12 Jul 2017 14:01:12 -0700 - rev 607760
Push
68103 by bwerth@mozilla.com at Wed, 12 Jul 2017 21:01:36 +0000
Bug 1380165 Part 1: Remove no-longer-used NS_MACOSX_JAVA2_PLUGIN_DIR variable and a comment that referenced a closed bug that conditionally used it.
MozReview-Commit-ID: 7Qbel0gmEAI