7294757d2ceafa82898ab581b857631f5088fe8d: Bug 1297306 - part6:replace NS_STYLE_CLEAR_* with StyleClear enum class. draft
Jeremy Chen <jeremychen@mozilla.com> - Mon, 29 Aug 2016 16:46:43 +0800 - rev 406659
Push 27787 by jichen@mozilla.com at Mon, 29 Aug 2016 08:47:21 +0000
Bug 1297306 - part6:replace NS_STYLE_CLEAR_* with StyleClear enum class. After using enum class, a switch-case warning in CombineBreakType is caught. This is one of such kind safty checks that we would like to gain. Fix it by adding default case for switch-case in CombineBreakType. MozReview-Commit-ID: BdS3LPN6qzX
4953ca8aa15099d3293b64bc134b631a1c9d0e13: Bug 1297306 - part5:create enum constructors for EnumTable. draft
Jeremy Chen <jeremychen@mozilla.com> - Mon, 29 Aug 2016 16:46:43 +0800 - rev 406658
Push 27787 by jichen@mozilla.com at Mon, 29 Aug 2016 08:47:21 +0000
Bug 1297306 - part5:create enum constructors for EnumTable. Enable nsAttrValue::EnumTable to be initialized with enum. So, we could get rid of the castings in EnumTable. Fix EnumTable initialization comment. For those untyped enumerations, declare them with uint8_t, as to other typed enumerations with type size larger than int16_t, force casting to int16_t. Use {nullptr,0} instead of {0} to represent the last entry. MozReview-Commit-ID: 7Dma3Apkmxj
389acf256abd9468cd0a94f4b83d5a30dc594e67: Bug 1297306 - part4:move IsEnumFittingWithin to mfbt/EnumTypeTraits.h. draft
Jeremy Chen <jeremychen@mozilla.com> - Mon, 29 Aug 2016 16:46:42 +0800 - rev 406657
Push 27787 by jichen@mozilla.com at Mon, 29 Aug 2016 08:47:21 +0000
Bug 1297306 - part4:move IsEnumFittingWithin to mfbt/EnumTypeTraits.h. With this change, we could share this EnumTypeTraits between files easily. MozReview-Commit-ID: 9Q2augati7l
fbcf8504408b059a0219cb94c40759bd4fc82326: Bug 1297306 - part3:make BreakTypeToString() to be a member of nsLineBox. draft
Jeremy Chen <jeremychen@mozilla.com> - Mon, 29 Aug 2016 16:46:42 +0800 - rev 406656
Push 27787 by jichen@mozilla.com at Mon, 29 Aug 2016 08:47:21 +0000
Bug 1297306 - part3:make BreakTypeToString() to be a member of nsLineBox. With this change, we could export BreakTypeToString() to other files that desire to print break type for debugging. MozReview-Commit-ID: 34m1BWAmZTB
1a5b3ef58354d2199cb018fbc6046e50a77c332a: Bug 1297306 - part2:make the implementation of nsLineBox::LastChild() be behind DEBUG_FRAME_DUMP flag. draft
Jeremy Chen <jeremychen@mozilla.com> - Mon, 29 Aug 2016 16:46:42 +0800 - rev 406655
Push 27787 by jichen@mozilla.com at Mon, 29 Aug 2016 08:47:21 +0000
Bug 1297306 - part2:make the implementation of nsLineBox::LastChild() be behind DEBUG_FRAME_DUMP flag. This should've been covered in Bug 956447. The declaration is already behind DEBUG_FRAME_DUMP in nsLineBox.h. Just move the implementation to agreee with that. MozReview-Commit-ID: 9N0WxKkajF1
45b4d4cddc648af2c7b77439aaddec16b2464ec0: Bug 1297306 - part1:remove unused NS_STYLE_CLEAR_* condition. draft
Jeremy Chen <jeremychen@mozilla.com> - Mon, 29 Aug 2016 16:46:42 +0800 - rev 406654
Push 27787 by jichen@mozilla.com at Mon, 29 Aug 2016 08:47:21 +0000
Bug 1297306 - part1:remove unused NS_STYLE_CLEAR_* condition. NS_STYLE_CLEAR_NONE has been defined to 0 for like forever, so this code should never be run. Remove it. MozReview-Commit-ID: IQ73H6QGsPX
bcff709130397ebad1b9d97d8d9bc0a96119184e: Bug 1297306 - part7:replace StyleClear related NS_ASSERTION with MOZ_ASSERT. draft
Jeremy Chen <jeremychen@mozilla.com> - Mon, 29 Aug 2016 16:38:57 +0800 - rev 406653
Push 27786 by jichen@mozilla.com at Mon, 29 Aug 2016 08:39:41 +0000
Bug 1297306 - part7:replace StyleClear related NS_ASSERTION with MOZ_ASSERT. MozReview-Commit-ID: Dzd3uOoQCI
0635d9d2857277284e5532d8dfac874330197e1f: Bug 1297306 - part6:replace NS_STYLE_CLEAR_* with StyleClear enum class. draft
Jeremy Chen <jeremychen@mozilla.com> - Mon, 29 Aug 2016 16:38:57 +0800 - rev 406652
Push 27786 by jichen@mozilla.com at Mon, 29 Aug 2016 08:39:41 +0000
Bug 1297306 - part6:replace NS_STYLE_CLEAR_* with StyleClear enum class. After using enum class, a switch-case warning in CombineBreakType is caught. This is one of such kind safty checks that we would like to gain. Fix it by adding default case for switch-case in CombineBreakType. MozReview-Commit-ID: BdS3LPN6qzX
1a91917d0f8ef98195868935b912ce77233cb55d: Bug 1297306 - part5:create enum constructors for EnumTable. draft
Jeremy Chen <jeremychen@mozilla.com> - Mon, 29 Aug 2016 16:38:57 +0800 - rev 406651
Push 27786 by jichen@mozilla.com at Mon, 29 Aug 2016 08:39:41 +0000
Bug 1297306 - part5:create enum constructors for EnumTable. Enable nsAttrValue::EnumTable to be initialized with enum. So, we could get rid of the castings in EnumTable. Fix EnumTable initialization comment. For those untyped enumerations, declare them with uint8_t, as to other typed enumerations with type size larger than int16_t, force casting to int16_t. Use {nullptr,0} instead of {0} to represent the last entry. MozReview-Commit-ID: 7Dma3Apkmxj
23ee557bded81661355097b2bb2718abc0d76758: Bug 1297306 - part4:move IsEnumFittingWithin to mfbt/EnumTypeTraits.h. draft
Jeremy Chen <jeremychen@mozilla.com> - Mon, 29 Aug 2016 16:38:57 +0800 - rev 406650
Push 27786 by jichen@mozilla.com at Mon, 29 Aug 2016 08:39:41 +0000
Bug 1297306 - part4:move IsEnumFittingWithin to mfbt/EnumTypeTraits.h. With this change, we could share this EnumTypeTraits between files easily. MozReview-Commit-ID: 9Q2augati7l
c98ae9401b2c97b11948bb80e152d9fc74ebb108: Bug 1297306 - part3:make BreakTypeToString() to be a member of nsLineBox. draft
Jeremy Chen <jeremychen@mozilla.com> - Mon, 29 Aug 2016 16:38:56 +0800 - rev 406649
Push 27786 by jichen@mozilla.com at Mon, 29 Aug 2016 08:39:41 +0000
Bug 1297306 - part3:make BreakTypeToString() to be a member of nsLineBox. With this change, we could export BreakTypeToString() to other files that desire to print break type for debugging. MozReview-Commit-ID: 34m1BWAmZTB
01f65e1feb9b734ec7af8c233da142b82377cc9a: Bug 1297306 - part2:make the implementation of nsLineBox::LastChild() be behind DEBUG_FRAME_DUMP flag. draft
Jeremy Chen <jeremychen@mozilla.com> - Mon, 29 Aug 2016 16:38:56 +0800 - rev 406648
Push 27786 by jichen@mozilla.com at Mon, 29 Aug 2016 08:39:41 +0000
Bug 1297306 - part2:make the implementation of nsLineBox::LastChild() be behind DEBUG_FRAME_DUMP flag. This should've been covered in Bug 956447. The declaration is already behind DEBUG_FRAME_DUMP in nsLineBox.h. Just move the implementation to agreee with that. MozReview-Commit-ID: 9N0WxKkajF1
a9c03fcdadacf7fae9c373b21c41f7cbee7a163d: Bug 1297306 - part1:remove unused NS_STYLE_CLEAR_* condition. draft
Jeremy Chen <jeremychen@mozilla.com> - Mon, 29 Aug 2016 16:38:56 +0800 - rev 406647
Push 27786 by jichen@mozilla.com at Mon, 29 Aug 2016 08:39:41 +0000
Bug 1297306 - part1:remove unused NS_STYLE_CLEAR_* condition. NS_STYLE_CLEAR_NONE has been defined to 0 for like forever, so this code should never be run. Remove it. MozReview-Commit-ID: IQ73H6QGsPX
29db5fe94296e0636f0ac61c95b50601e8f848d0: Bug 1298704 - Use flag to avoid calling AccessibleCaretEventHub::Reflow() recursively. r?mats draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 29 Aug 2016 15:36:45 +0800 - rev 406646
Push 27785 by bmo:tlin@mozilla.com at Mon, 29 Aug 2016 08:02:29 +0000
Bug 1298704 - Use flag to avoid calling AccessibleCaretEventHub::Reflow() recursively. r?mats MozReview-Commit-ID: Jkf7sSqxG2d
88cec41626bf83be5d54ce13e1566846e547ba6d: Bug 1298704 - Use flag to avoid calling AccessibleCaretEventHub::Reflow() recursively. r?mats draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 29 Aug 2016 15:36:45 +0800 - rev 406645
Push 27784 by bmo:tlin@mozilla.com at Mon, 29 Aug 2016 07:56:52 +0000
Bug 1298704 - Use flag to avoid calling AccessibleCaretEventHub::Reflow() recursively. r?mats MozReview-Commit-ID: Jkf7sSqxG2d
def5b2ffbff3fa45258585a8942f74f6597949b3: Bug 1298594: P5. Fix mochitest. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 29 Aug 2016 16:07:38 +1000 - rev 406644
Push 27783 by bmo:jyavenard@mozilla.com at Mon, 29 Aug 2016 07:55:20 +0000
Bug 1298594: P5. Fix mochitest. r?gerald The assumption was that the waiting event would be fired once the last frame prior the gap had been played. This is however incorrect, as per spec, the waiting event is to be fired once readyState is <= HAVE_CURRENT_DATA. So the waiting event is actually fired anytime between the start of the last frame and its end. MozReview-Commit-ID: AA4Qhn7okhB
e54896c8837ab050f359cd35afc8fe99340c2893: Bug 1298594: P4. When calculating the next frame status, only check that we have at least one. r?jwwang draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 29 Aug 2016 15:46:56 +1000 - rev 406643
Push 27783 by bmo:jyavenard@mozilla.com at Mon, 29 Aug 2016 07:55:20 +0000
Bug 1298594: P4. When calculating the next frame status, only check that we have at least one. r?jwwang Otherwise, we will set readyState to HAVE_CURRENT_DATA one frame too early. This is a partial reversal of commit 3577cfb4353 (part of bug 1143575), MDSM::HaveNextFrameData is only used for readyState calculation. MozReview-Commit-ID: H92Bmiki49Q
f0c5b9fa7d50107668cc5665292c845074f33141: Bug 1298594: P3. Ensure currentTime is updated prior changing readyState. r?jwwang draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Sun, 28 Aug 2016 21:20:52 +1000 - rev 406642
Push 27783 by bmo:jyavenard@mozilla.com at Mon, 29 Aug 2016 07:55:20 +0000
Bug 1298594: P3. Ensure currentTime is updated prior changing readyState. r?jwwang Otherwise we get intermittent in mochitests checking the value of currenTime when events are fired MozReview-Commit-ID: AVktWrXochp
01f3436435ccb1fb189ec7fb884cdf4405716c84: Bug 1298594: P2. Fire waiting event when readyState move back to HAVE_CURRENT_DATA. r?jwwang draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 27 Aug 2016 22:23:52 +1000 - rev 406641
Push 27783 by bmo:jyavenard@mozilla.com at Mon, 29 Aug 2016 07:55:20 +0000
Bug 1298594: P2. Fire waiting event when readyState move back to HAVE_CURRENT_DATA. r?jwwang MozReview-Commit-ID: BpwYY6njXGC
67a1ceb1b3a5f58add879065d5ef5d3f1b16ca0e: Bug 1298594: [MSE] P1. Add mochitest to verify correct behavior. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 27 Aug 2016 00:08:38 +1200 - rev 406640
Push 27783 by bmo:jyavenard@mozilla.com at Mon, 29 Aug 2016 07:55:20 +0000
Bug 1298594: [MSE] P1. Add mochitest to verify correct behavior. r?gerald 1- We shouldn't reach ended if we have a gap in the buffered range prior the end of the file (see bug 1297036) 2- Waiting should be fired when readyState goes below HAVE_FUTURE_DATA MozReview-Commit-ID: 18bEnkNpYvO
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip