716f03d7be35f8ea5bc54cdb2e3fe9b5fde88221: Bug 1343753 - Part 9: Remove assertions from ConsiderInitiatingTransition. draft
Boris Chiou <boris.chiou@gmail.com> - Thu, 09 Mar 2017 17:27:29 +0800 - rev 496511
Push 48621 by bmo:boris.chiou@gmail.com at Fri, 10 Mar 2017 08:37:49 +0000
Bug 1343753 - Part 9: Remove assertions from ConsiderInitiatingTransition. MozReview-Commit-ID: 2rlq5E7bJxZ
dfaaa2cca156885aff771210dfd36f30ecfefeed: Bug 1343753 - Part 8: Move mAnimationGeneration into RestyleManager. draft
Boris Chiou <boris.chiou@gmail.com> - Thu, 09 Mar 2017 17:15:08 +0800 - rev 496510
Push 48621 by bmo:boris.chiou@gmail.com at Fri, 10 Mar 2017 08:37:49 +0000
Bug 1343753 - Part 8: Move mAnimationGeneration into RestyleManager. So stylo can also use mAnimationGeneration. MozReview-Commit-ID: KTc8vs2RKMm
2530da39d99484174416803b220fd549b3e7d2d4: Bug 1343753 - Part 7: Use template for UpdateTransitions and ConsiderInitiatingTransition. draft
Boris Chiou <boris.chiou@gmail.com> - Thu, 09 Mar 2017 15:37:17 +0800 - rev 496509
Push 48621 by bmo:boris.chiou@gmail.com at Fri, 10 Mar 2017 08:37:49 +0000
Bug 1343753 - Part 7: Use template for UpdateTransitions and ConsiderInitiatingTransition. We use the template to replace the type, nsStyleContext and ServoComputedStyleValues, and so we also need to revise the caller, StyleContextChanged, to use ServoComputedStyleValues as the function parameter. MozReview-Commit-ID: JFPdODZAwX8
3af401b5add17500bc522cb4c768cf283fb5d3bc: Bug 1343753 - Part 6: Support ServoComputedValues in ExtractNonDiscreteComputedValue. draft
Boris Chiou <boris.chiou@gmail.com> - Wed, 08 Mar 2017 18:09:58 +0800 - rev 496508
Push 48621 by bmo:boris.chiou@gmail.com at Fri, 10 Mar 2017 08:37:49 +0000
Bug 1343753 - Part 6: Support ServoComputedValues in ExtractNonDiscreteComputedValue. In order to use ServoComputedValues, we also introduce a new FFI, Servo_Extract_ComputedValues. We use ServoComputedStyleValues as the argument here, instead of ServoComputedValues, because I will use template for nsStyleContext and ServoComputedStyleValues in UpdateTransitions() and ConsiderInitiatingTransition(). MozReview-Commit-ID: 7VtcMDtgl55
7211f290e01e26325a5339d596cae1fee51fce93: Bug 1343753 - Part 5: Introduce AnimationValue::CanInterpolate. draft
Boris Chiou <boris.chiou@gmail.com> - Thu, 09 Mar 2017 13:52:40 +0800 - rev 496507
Push 48621 by bmo:boris.chiou@gmail.com at Fri, 10 Mar 2017 08:37:49 +0000
Bug 1343753 - Part 5: Introduce AnimationValue::CanInterpolate. We have different interpolation implementations on Gecko and Servo, so wrap the "CanInterpolate" in AnimationValue. This patch also introduces the FFI, Servo_Animationvalues_CanInterpolate. MozReview-Commit-ID: 92Yf1u84A3c
4bc418e06919a17c91236a00a1cce6f6f694124f: Bug 1343753 - Part 4: Use NonOwningAnimationTarget in UpdateTransitions. draft
Boris Chiou <boris.chiou@gmail.com> - Thu, 09 Mar 2017 14:29:13 +0800 - rev 496506
Push 48621 by bmo:boris.chiou@gmail.com at Fri, 10 Mar 2017 08:37:49 +0000
Bug 1343753 - Part 4: Use NonOwningAnimationTarget in UpdateTransitions. We use NonOwningAnimationTarget, so we can avoid using nsStyleContext to get the pseudo type. MozReview-Commit-ID: GSwxebE12CH
11256d608e01461ad745674b9768203a9b37806c: Bug 1343753 - Part 3: Use AnimationValue in ElementPropertyTransition and CSSTransition. draft
Boris Chiou <boris.chiou@gmail.com> - Thu, 09 Mar 2017 12:33:15 +0800 - rev 496505
Push 48621 by bmo:boris.chiou@gmail.com at Fri, 10 Mar 2017 08:37:49 +0000
Bug 1343753 - Part 3: Use AnimationValue in ElementPropertyTransition and CSSTransition. We also need to update the interpolation code based on ServoAnimationValue in ElementPropertyTransition::UpdateStartValueFromReplacedTransition(). Therefore, ElementPropertyTransition can be used by both Gecko and Servo. MozReview-Commit-ID: BrIpvRR3te8
d387d553401a046bec1b8e991aef248c0e591c20: Bug 1343753 - Part 2: Update GetTransitionKeyframes for stylo. draft
Boris Chiou <boris.chiou@gmail.com> - Thu, 09 Mar 2017 11:40:53 +0800 - rev 496504
Push 48621 by bmo:boris.chiou@gmail.com at Fri, 10 Mar 2017 08:37:49 +0000
Bug 1343753 - Part 2: Update GetTransitionKeyframes for stylo. Use AnimationValue as arguments, and add one FFI to uncompute the value. Therefore, we can use GetTransitionKeyframes for both Gecko and Servo backends. However, there are many "mGecko"s, which will be removed later. MozReview-Commit-ID: Dg5hrDdlIWb
e47234edccdabd063ef1ca8c6c79c0004b8a4491: Bug 1343753 - Part 1: Make GetTransitionKeyframes as local static function. draft
Boris Chiou <boris.chiou@gmail.com> - Thu, 09 Mar 2017 13:35:43 +0800 - rev 496503
Push 48621 by bmo:boris.chiou@gmail.com at Fri, 10 Mar 2017 08:37:49 +0000
Bug 1343753 - Part 1: Make GetTransitionKeyframes as local static function. GetTransitionKeyframes is a simple helper function, which is only used by ConsiderInitiatingTransition, so let's make it static to reduce the time to revise the header. MozReview-Commit-ID: HlztPxz8sMJ
954b07a63e22c6c83713f6a231b954a68e742c31: Bug 1330882 - Part 4: Making the window.open() can only open rounded windows for content windows when fingerprinting resistance is enabled. r?smaug,arthuredelstein draft
Tim Huang <tihuang@mozilla.com> - Fri, 10 Mar 2017 15:23:29 +0800 - rev 496502
Push 48620 by bmo:tihuang@mozilla.com at Fri, 10 Mar 2017 08:28:03 +0000
Bug 1330882 - Part 4: Making the window.open() can only open rounded windows for content windows when fingerprinting resistance is enabled. r?smaug,arthuredelstein This patch makes window.open() ignores 'width' and 'height' in its window features for content windows when fingerprinting is enabled, so the window.open() can only open a rounded window. The chrome window, however, can still specify window features when using window.open(). MozReview-Commit-ID: J2r3951vuNN
96fcb673ec7776f0207ac924af6278b636b615fe: Bug 1345853 - Part 2. If the transform matrix is singular, return DrawResult::SUCESS, instead of DrawResult::BAD_ARGS draft
cku <cku@mozilla.com> - Fri, 10 Mar 2017 15:25:34 +0800 - rev 496501
Push 48619 by bmo:cku@mozilla.com at Fri, 10 Mar 2017 08:25:11 +0000
Bug 1345853 - Part 2. If the transform matrix is singular, return DrawResult::SUCESS, instead of DrawResult::BAD_ARGS According to bug 1345853 comment 5, tn said: You probably want to return whatever was drawn there regardless of the DrawResult. SVGMaskFrame has the same problem. Keep in mind that DrawResult is only reporting on how drawing of any images went, not the drawing of anything else. Also looking over the patches from bug 1258510 I see a couple places where BAD_ARGS is returned if the transform matrix is singular. We would want to return SUCCESS in that case I think, because we drew what we were instructed to draw. MozReview-Commit-ID: 5XcDuKQwXTJ
8e1fb05d10a4ae6c49b233f45c78826b8a2b2744: Bug 1345853 - Pass DrawResult from nsSVGPatternFrame::PaintPattern back to nsDisplaySVGGeometry::Paint. draft
cku <cku@mozilla.com> - Fri, 10 Mar 2017 14:01:12 +0800 - rev 496500
Push 48619 by bmo:cku@mozilla.com at Fri, 10 Mar 2017 08:25:11 +0000
Bug 1345853 - Pass DrawResult from nsSVGPatternFrame::PaintPattern back to nsDisplaySVGGeometry::Paint. I did many change in many files in this patch. But the goal is pretty simple: To pass the return value of nsSVGPatternFrame::PaintPattern back to the display item (nsDisplaySVGGeometry) which use it. So, my suggestion is review this patch right from nsSVGPatternFrame.cpp. I made two mistakes in bug 1258510 1. We should not return directly at [1]. RemoveStateBits at l418 will be skip. 2. nsSVGPatternFrame::PaintPattern should return both SourceSurface and draw result. All the other changes are to 1. make sure the return value of nsSVGPatternFrame::PaintPattern goes back to nsDisplaySVGGeometry::Paint correctly. 2. Since the return value of nsSVGPatternFrame::PaintPattern change, we need modify all existed callers. I also filed bug 1346124 for handle the returning value of PaintMarkers. [1] https://hg.mozilla.org/mozilla-central/file/c0700bedb4f7/layout/svg/nsSVGPatternFrame.cpp#l415 MozReview-Commit-ID: Iq9RPQ6Omz0
4f4ae93c8658b90f4fce1aeeac062ab7363ba17a: Bug 1330882 - Part 4: Making the window.open() can only open rounded windows for content windows when fingerprinting resistance is enabled. r?smaug draft
Tim Huang <tihuang@mozilla.com> - Fri, 10 Mar 2017 15:23:29 +0800 - rev 496499
Push 48618 by bmo:tihuang@mozilla.com at Fri, 10 Mar 2017 08:24:41 +0000
Bug 1330882 - Part 4: Making the window.open() can only open rounded windows for content windows when fingerprinting resistance is enabled. r?smaug This patch makes window.open() ignores 'width' and 'height' in its window features for content windows when fingerprinting is enabled, so the window.open() can only open a rounded window. The chrome window, however, can still specify window features when using window.open(). MozReview-Commit-ID: J2r3951vuNN
aa6d0c2cd502a8394db5f3f504e4cbaeb2ad770d: Bug 1330882 - Part 4: Making the window.open() can only open rounded windows for content windows when fingerprinting resistance is enabled. r?smaug draft
Tim Huang <tihuang@mozilla.com> - Fri, 10 Mar 2017 15:23:29 +0800 - rev 496498
Push 48617 by bmo:tihuang@mozilla.com at Fri, 10 Mar 2017 08:21:11 +0000
Bug 1330882 - Part 4: Making the window.open() can only open rounded windows for content windows when fingerprinting resistance is enabled. r?smaug This patch makes window.open() ignores 'width' and 'height' in its window features for content windows when fingerprinting is enabled, so the window.open() can only open a rounded window. The chrome window, however, can still specify window features when using window.open(). MozReview-Commit-ID: J2r3951vuNN
344af585a60ffd35332c3c3538af7063db47757d: Bug 1330882 - Part 3: Add a test case for opening new windows as rounded size when fingerprinting resistance is enabled. r?smaug,arthuredelstein draft
Tim Huang <tihuang@mozilla.com> - Mon, 06 Mar 2017 14:25:40 +0800 - rev 496497
Push 48617 by bmo:tihuang@mozilla.com at Fri, 10 Mar 2017 08:21:11 +0000
Bug 1330882 - Part 3: Add a test case for opening new windows as rounded size when fingerprinting resistance is enabled. r?smaug,arthuredelstein MozReview-Commit-ID: Gvksnh3cKHM
ba45bedf65fbea336a4146586a1fbe1f5c80a005: Bug 1330882 - Part 2: Disallow the session restore to modify window size when fingerprinting resistance is enabled. r?mikedeboer,arthuredelstein draft
Tim Huang <tihuang@mozilla.com> - Fri, 03 Mar 2017 16:17:18 +0800 - rev 496496
Push 48617 by bmo:tihuang@mozilla.com at Fri, 10 Mar 2017 08:21:11 +0000
Bug 1330882 - Part 2: Disallow the session restore to modify window size when fingerprinting resistance is enabled. r?mikedeboer,arthuredelstein MozReview-Commit-ID: F1Ray6c5dzq
ac5dbf308e96a04c7a9678cb7cffb3ba2744d6e1: Bug 1330882 - Part 1: Making new windows to be rounded size when fingerprinting resistance is enabled (adopt from Tor #19459). r?smaug,arthuredelstein draft
Tim Huang <tihuang@mozilla.com> - Thu, 23 Feb 2017 15:36:53 +0800 - rev 496495
Push 48617 by bmo:tihuang@mozilla.com at Fri, 10 Mar 2017 08:21:11 +0000
Bug 1330882 - Part 1: Making new windows to be rounded size when fingerprinting resistance is enabled (adopt from Tor #19459). r?smaug,arthuredelstein MozReview-Commit-ID: 1qBNQhfdIYP
da7ea2b7d729fc52b1191f43074a9b1db23d9ea0: Bug 1340468 - Notify formautofill add-on of which item is being selected. r=MattN draft
Ray Lin <ralin@mozilla.com> - Fri, 24 Feb 2017 10:15:55 +0800 - rev 496494
Push 48616 by bmo:ralin@mozilla.com at Fri, 10 Mar 2017 08:12:46 +0000
Bug 1340468 - Notify formautofill add-on of which item is being selected. r=MattN MozReview-Commit-ID: 3YfW35Zon1Q
3af444933a429e3d62ebfc509748dbf1da484932: add mock data to result draft
Ray Lin <ralin@mozilla.com> - Mon, 20 Feb 2017 14:38:58 +0800 - rev 496493
Push 48616 by bmo:ralin@mozilla.com at Fri, 10 Mar 2017 08:12:46 +0000
add mock data to result MozReview-Commit-ID: HtrsgGDytwh
39f64a451b5380e6ab2d2033969556984173e5d5: Bug 1333003 part 6 - Fix test scripts to run ASan on Windows. r?ted draft
Ting-Yu Chou <janus926@gmail.com> - Fri, 10 Mar 2017 12:08:34 +0800 - rev 496492
Push 48615 by bmo:janus926@gmail.com at Fri, 10 Mar 2017 07:58:37 +0000
Bug 1333003 part 6 - Fix test scripts to run ASan on Windows. r?ted MozReview-Commit-ID: 6F9UXgTRb2Y
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip