71572cf68a078f33534b4ff30dc4ae14bb47ff72: Bug 1402481 - Reverse incorrect sign of margin calculation. r=mcomella, a=sledru
Chenxia Liu <liuche@mozilla.com> - Fri, 22 Sep 2017 09:12:38 -0700 - rev 670491
Push 81631 by Callek@gmail.com at Tue, 26 Sep 2017 12:25:14 +0000
Bug 1402481 - Reverse incorrect sign of margin calculation. r=mcomella, a=sledru MozReview-Commit-ID: ICS81o8pLOE
627ccc1a06115213bdb0d1fc3b91e4c2597519e7: Bug 1402145 - Use adapter child position rather than view position. r=mcomella, a=sledru
Chenxia Liu <liuche@mozilla.com> - Fri, 22 Sep 2017 09:09:23 -0700 - rev 670490
Push 81631 by Callek@gmail.com at Tue, 26 Sep 2017 12:25:14 +0000
Bug 1402145 - Use adapter child position rather than view position. r=mcomella, a=sledru MozReview-Commit-ID: ESi8MMYC1lp
5f814a1ccc2d8d8b16773562ae18667c96f74031: Bug 1402005 - Add telemetry for Learn More clicks. r=liuche, a=sledru
Michael Comella <michael.l.comella@gmail.com> - Fri, 22 Sep 2017 17:32:03 -0700 - rev 670489
Push 81631 by Callek@gmail.com at Tue, 26 Sep 2017 12:25:14 +0000
Bug 1402005 - Add telemetry for Learn More clicks. r=liuche, a=sledru MozReview-Commit-ID: GA4UBZ4fpK6
6e6c8c1988a94c5d7841b89351a3f9d5b1698656: Bug 1402005 - Add a learn more link to Top Sites. r=liuche, a=sledru
Michael Comella <michael.l.comella@gmail.com> - Fri, 22 Sep 2017 17:04:53 -0700 - rev 670488
Push 81631 by Callek@gmail.com at Tue, 26 Sep 2017 12:25:14 +0000
Bug 1402005 - Add a learn more link to Top Sites. r=liuche, a=sledru Explanation of our motivations are added in code comments. In testing locally, the link I was sent to was: - https://support.mozilla.org/1/mobile/58.0a1/Android/en-US/activity-stream Existing code does not use a referrer so I didn't add one: http://searchfox.org/mozilla-central/rev/56ad02e34d0d36ca4d5ccaa885d26aff270b8ff7/mobile/android/base/java/org/mozilla/gecko/preferences/LinkPreference.java#44 MozReview-Commit-ID: GTY1ku07uWy
2ac580ab92111b3601bea0a4a932c915fb68d913: Bug 1401706 - Crashtest. a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 04:10:22 +0200 - rev 670487
Push 81631 by Callek@gmail.com at Tue, 26 Sep 2017 12:25:14 +0000
Bug 1401706 - Crashtest. a=sledru MozReview-Commit-ID: Jf0n4f4kMhl
73daa36f9532fe15bfcdc4fd266a5deaa8f559f3: Bug 1401706 - Remove redundant UpdateValueDisplay call. r=Ehsan, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 14:48:02 +0200 - rev 670486
Push 81631 by Callek@gmail.com at Tue, 26 Sep 2017 12:25:14 +0000
Bug 1401706 - Remove redundant UpdateValueDisplay call. r=Ehsan, a=sledru This was just moved from the old code, but we always call that function in CreateAnonymousContent, so no need to. MozReview-Commit-ID: 1zqmQM2KdpW Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
a896c16082f45b30c18d0677d993d6d619d924b0: Bug 1401706 - Remove redundant boolean members from nsTextControlFrame. r=Ehsan, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 07:33:41 +0200 - rev 670485
Push 81631 by Callek@gmail.com at Tue, 26 Sep 2017 12:25:14 +0000
Bug 1401706 - Remove redundant boolean members from nsTextControlFrame. r=Ehsan, a=sledru MozReview-Commit-ID: Ka81vlPMa88 Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
f1e83779aee97be6a183bda6aed19ec04ade5af3: Bug 1401706 - Remove unused macro. r=Ehsan, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 07:33:30 +0200 - rev 670484
Push 81631 by Callek@gmail.com at Tue, 26 Sep 2017 12:25:14 +0000
Bug 1401706 - Remove unused macro. r=Ehsan, a=sledru MozReview-Commit-ID: EsvdnJkapgP Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
4d33cf91c8bd34351510604e5032b610fa4afa02: Bug 1401706 - Move ownership of editor anon content to nsTextControlFrame. r=Ehsan, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 02:18:30 +0200 - rev 670483
Push 81631 by Callek@gmail.com at Tue, 26 Sep 2017 12:25:14 +0000
Bug 1401706 - Move ownership of editor anon content to nsTextControlFrame. r=Ehsan, a=sledru MozReview-Commit-ID: 4QpbarX5dvf Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
fd78928b00d87444d1aefe942d0489e8682e0981: Bug 1401179 - Add snackbar for bookmark add/remove actions on newtab. r=mcomella, a=sledru
Chenxia Liu <liuche@mozilla.com> - Fri, 22 Sep 2017 18:08:07 -0700 - rev 670482
Push 81631 by Callek@gmail.com at Tue, 26 Sep 2017 12:25:14 +0000
Bug 1401179 - Add snackbar for bookmark add/remove actions on newtab. r=mcomella, a=sledru MozReview-Commit-ID: 7DzoyDSWmVq
3fa652b178a23dd826594355a18d008f0b976bf1: Bug 1402684 - Clear the servo data early, but the flags later, in UnbindFromTree. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 24 Sep 2017 19:16:10 +0200 - rev 670481
Push 81631 by Callek@gmail.com at Tue, 26 Sep 2017 12:25:14 +0000
Bug 1402684 - Clear the servo data early, but the flags later, in UnbindFromTree. r=bholley, a=sledru MozReview-Commit-ID: 5rRGKq39smW
99992ed2b3f326a71044f04106a4c7795c5fdb40: Bug 1400936 - Crashtests. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 00:12:33 +0200 - rev 670480
Push 81631 by Callek@gmail.com at Tue, 26 Sep 2017 12:25:14 +0000
Bug 1400936 - Crashtests. r=bholley, a=sledru MozReview-Commit-ID: 6Q07StWSog Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
ca0193447310df73222a91c485f6e41a8debe6f2: Bug 1400936 - Clear servo data after children data is cleared, and allow setting the root as the document if the tree is mid-unbind. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 00:05:47 +0200 - rev 670479
Push 81631 by Callek@gmail.com at Tue, 26 Sep 2017 12:25:14 +0000
Bug 1400936 - Clear servo data after children data is cleared, and allow setting the root as the document if the tree is mid-unbind. r=bholley, a=sledru This is the actual fix, and makes sure that the state is consistent even if we notify of state changes on a parent during unbind. We potentially do a bit more work than needed given we set the document as the root in that case instead of the parent which could potentially be the root itself, but that's not a huge deal I think, given these cases are rare. If this happens to be a perf problem, we may want to just drop the root during UnbindFromTree if aNullParent == true and the root is a descendant of `this`. MozReview-Commit-ID: A9d2igM0hMr Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
6b96a0fab002660434dc96f3ff8cf086cac1f4ac: Bug 1400936 - Only tear down the servo data in SetXBLInsertionParent if the parent actually changed. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 00:02:59 +0200 - rev 670478
Push 81631 by Callek@gmail.com at Tue, 26 Sep 2017 12:25:14 +0000
Bug 1400936 - Only tear down the servo data in SetXBLInsertionParent if the parent actually changed. r=bholley, a=sledru This is the reason similar assertion failures can't be reproduced with elements and stuff like fieldset and form validity changes. nsBindingManager::ContentRemoved calls SetXBLInsertionParent, which clears all the Servo data from the subtree eagerly, which is a waste when the actual binding parent is the same (null). MozReview-Commit-ID: A5wLKfD4OTL Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2d4c045f3066e9b6292bb8bf5571517be0161502: Bug 1400936 - Remove dumb null check. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 00:02:30 +0200 - rev 670477
Push 81631 by Callek@gmail.com at Tue, 26 Sep 2017 12:25:14 +0000
Bug 1400936 - Remove dumb null check. r=bholley, a=sledru MozReview-Commit-ID: CLs2UcA8DF9 Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
c7907ac20968c2311d83e5338158d5c6621c3852: Bug 1400825 - Collapse top sites if there are no sites. r=liuche, a=sledru
Michael Comella <michael.l.comella@gmail.com> - Fri, 22 Sep 2017 13:56:13 -0700 - rev 670476
Push 81631 by Callek@gmail.com at Tue, 26 Sep 2017 12:25:14 +0000
Bug 1400825 - Collapse top sites if there are no sites. r=liuche, a=sledru MozReview-Commit-ID: D0eNQBp6IZB
2ac4b62c58a1dda9582e521459dc2827626b90eb: Bug 1400825 - Show option for removing suggested sites from top sites. r=mcomella, a=sledru
Sebastian Kaspari <s.kaspari@gmail.com> - Fri, 22 Sep 2017 19:59:08 +0200 - rev 670475
Push 81631 by Callek@gmail.com at Tue, 26 Sep 2017 12:25:14 +0000
Bug 1400825 - Show option for removing suggested sites from top sites. r=mcomella, a=sledru MozReview-Commit-ID: LyAqnlMfQvr
d285547c68af03aa5afd9e81a52a8ab2644ce69a: Bug 1397686 - The streams that cannot do 0RTT data need to be put in list and added to mReadyForWrite when 0RTT is done. r=hurley, a=sledru
Dragana Damjanovic <dd.mozilla@gmail.com> - Fri, 22 Sep 2017 09:09:57 +0200 - rev 670474
Push 81631 by Callek@gmail.com at Tue, 26 Sep 2017 12:25:14 +0000
Bug 1397686 - The streams that cannot do 0RTT data need to be put in list and added to mReadyForWrite when 0RTT is done. r=hurley, a=sledru
508f470ffb60f0135864855cf64f8374687b9438: Bug 1294788 - Disable AssumeThemePartAndStateAreTransparent() on high contrast mode since Win8.1. r=jrmuizel, a=sledru
sotaro <sotaro.ikeda.g@gmail.com> - Fri, 22 Sep 2017 19:07:15 +0900 - rev 670473
Push 81631 by Callek@gmail.com at Tue, 26 Sep 2017 12:25:14 +0000
Bug 1294788 - Disable AssumeThemePartAndStateAreTransparent() on high contrast mode since Win8.1. r=jrmuizel, a=sledru The problem happened only on themed widget. The problem was triggered by Bug 888870. It just added Windows 8.1 support. When high contrast mode was enabled on Win 10, background color problem happend on themed widgets. There were 2 patterns. - After hover the menu item, its background color remained highlighted - After hover the menu item, its background color became black From it, the problem seemed to be caused by background color drawing of themed widgets. nsNativeThemeWin::DrawWidgetBackground() does the background color drawing. AssumeThemePartAndStateAreTransparent() controls skipping background color drawing of themed widgets. If AssumeThemePartAndStateAreTransparent() was removed, the problem was addressed. From it, how DrawThemeBackground() works seems to be changed on high contrast mode since since Win8.1. To address the problem, the patch remove the skipping on high contrast mode since since Win8.1
f0c4b2d3fcb5afe3e4b75b24563e2084b61ca490: Bug 1402059 - Don't import editBookmarkOverlay.js in places.xul on Mac because it is imported elsewhere. r=florian, a=sledru
Mark Banner <standard8@mozilla.com> - Thu, 21 Sep 2017 19:35:04 +0100 - rev 670472
Push 81631 by Callek@gmail.com at Tue, 26 Sep 2017 12:25:14 +0000
Bug 1402059 - Don't import editBookmarkOverlay.js in places.xul on Mac because it is imported elsewhere. r=florian, a=sledru MozReview-Commit-ID: 5e32dMnLdik
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip