7126b5ad51b31465a7773c5c1945281060bb0473: Bug 1412460 - Move build output processing code out of mach_commands.py; r?build draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 10:45:41 -0700 - rev 688040
Push 86650 by gszorc@mozilla.com at Sat, 28 Oct 2017 01:33:47 +0000
Bug 1412460 - Move build output processing code out of mach_commands.py; r?build In general, we shouldn't have so much business logic in mach_commands.py files. I'd like to move more of the low-level "perform a build" logic out of mach_commands.py to facilitate some future work. That code makes use of this output processing code. So as the first step in moving the build code, we move its dependencies. As part of this, I also cleaned up some random unused imports around lines that were touched. No meaningful code changes were performed as part of the code move. MozReview-Commit-ID: 96mGWUJ7oLb
6bdd34b3caa370ba103699c9f03b621baf9c1ad6: Bug 1412431 - Remove support for MOZ_BUILD_PROJECTS; r?build draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 15:20:34 -0700 - rev 688039
Push 86649 by gszorc@mozilla.com at Sat, 28 Oct 2017 01:33:16 +0000
Bug 1412431 - Remove support for MOZ_BUILD_PROJECTS; r?build This was mainly used to support Universal MacOS builds, which were removed several months ago. In theory, someone could be using this feature to build multiple applications with one build system invocation. But given that client.mk is no longer the preferred interface to the build system and multiple applications can be built by running `mach build` with different mozconfigs, I don't think support for this feature is worth keeping. This commit removes support for MOZ_BUILD_PROJECTS and related functionality from client.mk. Support for recognizing MOZ_CURRENT_PROJECT in configure and mozconfig evaluation has also been removed. This includes support for the ac_add_app_options mozconfig function. Good riddance. MozReview-Commit-ID: 7xI2jYxDFFr
231035a6f129b5815e2ff4eb45dd86d8bd4f16d5: Bug 1412431 - Remove support for MOZ_PREFLIGHT and MOZ_POSTFLIGHT; r?build draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 14:55:31 -0700 - rev 688038
Push 86649 by gszorc@mozilla.com at Sat, 28 Oct 2017 01:33:16 +0000
Bug 1412431 - Remove support for MOZ_PREFLIGHT and MOZ_POSTFLIGHT; r?build These variables are unused in the repo. The %_ALL variation is used for sccache, however. The last use of these variables was removed when support for MacOS universal builds was removed. Someone somewhere may be relying on this functionality. But I don't think it is worth continuing to support in client.mk. If someone really needs it, we can reintroduce support for the feature elsewhere, like in mach or via mozconfig support somehow. MozReview-Commit-ID: 4KznCmK3JTN
ecb1e9a19f04beb0723829696b3c9c0ef3d67f2f: Bug 1412431 - Remove MOZ_UNIFY_BDATE; r?build draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 14:49:25 -0700 - rev 688037
Push 86649 by gszorc@mozilla.com at Sat, 28 Oct 2017 01:33:16 +0000
Bug 1412431 - Remove MOZ_UNIFY_BDATE; r?build There are no references to this variable outside client.mk. AFAICT it is unused. The only reasonable justification for retaining this support IMO was Universal MacOS builds. And those are no longer supported. MozReview-Commit-ID: 9MnC18Bd1ge
6642552fc361165274e5f07f0ea7f50e3fce52a1: Bug 1412431 - Remove unsued BASE_DIR variable; r?build draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 14:47:06 -0700 - rev 688036
Push 86649 by gszorc@mozilla.com at Sat, 28 Oct 2017 01:33:16 +0000
Bug 1412431 - Remove unsued BASE_DIR variable; r?build This variable has been unused since 683e59dc3094 (bug 1286934). MozReview-Commit-ID: FZ7D9mSIeME
64f710b3d9fadbf509ce5707976d8cfce5b49de2: Bug 1412356 - Update CLOBBER message to not recommend client.mk; r?build draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 10:19:05 -0700 - rev 688035
Push 86648 by gszorc@mozilla.com at Sat, 28 Oct 2017 01:32:17 +0000
Bug 1412356 - Update CLOBBER message to not recommend client.mk; r?build client.mk hasn't been well-supported for years. Stop recommending it. MozReview-Commit-ID: KWFhAQPIXWu
cb65d22ee5ae1d448b50e6fc9b703de5bd7d249c: Bug 1412356 - Update docs on PGO builds to not reference client.mk; r?build draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 10:14:40 -0700 - rev 688034
Push 86648 by gszorc@mozilla.com at Sat, 28 Oct 2017 01:32:17 +0000
Bug 1412356 - Update docs on PGO builds to not reference client.mk; r?build As part of moving away from client.mk. MozReview-Commit-ID: IMeM0k1tTsS
f7589b01b6b686cc98055180f9cf57f2c0bea847: Bug 1412356 - Don't invoke client.mk from root analysis builds; r?build draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 10:12:24 -0700 - rev 688033
Push 86648 by gszorc@mozilla.com at Sat, 28 Oct 2017 01:32:17 +0000
Bug 1412356 - Don't invoke client.mk from root analysis builds; r?build `mach configure` does the same thing as `make -f client.mk configure`. While we're here, also change a `make` invocation to use `mach build`. MozReview-Commit-ID: 4rgZN0dd0Jg
4b739dfcb56fce2c7e49458a6f170959cff30d32: Bug 1412356 - Invoke `mach build` for multi locale builds; r?build draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 10:10:14 -0700 - rev 688032
Push 86648 by gszorc@mozilla.com at Sat, 28 Oct 2017 01:32:17 +0000
Bug 1412356 - Invoke `mach build` for multi locale builds; r?build This should be functionally identical to `make -f client.mk`. MozReview-Commit-ID: GfKHtezLBNL
96a44558268371e335944e7fb2dfeaad30e4bcbf: Bug 1412356 - Don't invoke client.mk from mobile l10n automation; r?build draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 10:07:52 -0700 - rev 688031
Push 86648 by gszorc@mozilla.com at Sat, 28 Oct 2017 01:32:17 +0000
Bug 1412356 - Don't invoke client.mk from mobile l10n automation; r?build The old code was simply running configure and manually invoking some make targets via client.mk. These can both be done via `mach`. As part of the change, the build targets have been consolidated. There is still an abstraction leak here. But at least we aren't using client.mk. MozReview-Commit-ID: 7oMXPWPZS6V
f679d00892766ed861e8227569f656609cf3ee6d: Bug 1412460 - Remove targets related to VCS operations; r?build-peer draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 17:23:50 -0700 - rev 688030
Push 86647 by gszorc@mozilla.com at Sat, 28 Oct 2017 01:26:32 +0000
Bug 1412460 - Remove targets related to VCS operations; r?build-peer These targets no longer exist. I'm not sure when they were removed. But this is obviously dead code. MozReview-Commit-ID: 5v1MOOTP3qq
5dd93ebe89d3446a12109c878ea45602b5050731: Bug 1412460 - Remove everything target; r?build-peer draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 17:22:06 -0700 - rev 688029
Push 86647 by gszorc@mozilla.com at Sat, 28 Oct 2017 01:26:32 +0000
Bug 1412460 - Remove everything target; r?build-peer Our march towards nuking client.mk continues. MozReview-Commit-ID: FdlPOjStBeR
369076bf0132ccb812478b6e2e1ec5546067864f: Bug 1412460 - Always evaluate config environment; r?build-peer draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 17:14:00 -0700 - rev 688028
Push 86647 by gszorc@mozilla.com at Sat, 28 Oct 2017 01:26:32 +0000
Bug 1412460 - Always evaluate config environment; r?build-peer I /think/ the only scenario where we wouldn't be able to evaluate a config environment after configure was the case where MOZ_BUILD_PROJECTS was in play. Since we removed support for that feature, let's drop support for treating the config environment as optional. MozReview-Commit-ID: 4sz9dOwaA3y
aa971df370f174430f505cae2c213fb57541a919: Bug 1412460 - Simplify config.guess invocation; r?build-peer draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 16:05:03 -0700 - rev 688027
Push 86647 by gszorc@mozilla.com at Sat, 28 Oct 2017 01:26:32 +0000
Bug 1412460 - Simplify config.guess invocation; r?build-peer The config.guess file is checked into source control. I'm not sure under what conditions we wouldn't fail to find this file. So the $(wildcard) shouldn't be necessary. MozReview-Commit-ID: KCctPFW3Eab
984b3dc4afd07b2f32e39f298d5021a3d4d1edb8: Bug 1412460 - Don't write make variable in configure.d; r?build-peer draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 14:23:25 -0700 - rev 688026
Push 86647 by gszorc@mozilla.com at Sat, 28 Oct 2017 01:26:32 +0000
Bug 1412460 - Don't write make variable in configure.d; r?build-peer So the file can be more easily consumed without this variable defined. MozReview-Commit-ID: DF3ASwx4SZP
67eff5f10ce436905c4a9c0e60ae3cfe99e140d2: Bug 1412460 - Remove unused CONFIG_CACHE variable; r?build-peer draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 13:56:55 -0700 - rev 688025
Push 86647 by gszorc@mozilla.com at Sat, 28 Oct 2017 01:26:32 +0000
Bug 1412460 - Remove unused CONFIG_CACHE variable; r?build-peer This likely became unused with the port to moz.configure. MozReview-Commit-ID: FoIDg6Q2K4J
3ee73e25b8dbb4f9a0d4683584af5036b36d0a7e: Bug 1412460 - Remove redundant configure dependency checking in client.mk; r?build-peer draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 13:51:05 -0700 - rev 688024
Push 86647 by gszorc@mozilla.com at Sat, 28 Oct 2017 01:26:32 +0000
Bug 1412460 - Remove redundant configure dependency checking in client.mk; r?build-peer moz.configure invokes autoconf to generate old-configure. As part of this it checks mtimes of dependencies. The logic in client.mk is old and redundant. So remove it. MozReview-Commit-ID: FG2lWiIjKqV
31130f4ee1a86d5d768b55287813fbb2807db285: Bug 1412460 - Update client.mk comments to match reality; r?build-peer draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 13:10:12 -0700 - rev 688023
Push 86647 by gszorc@mozilla.com at Sat, 28 Oct 2017 01:26:32 +0000
Bug 1412460 - Update client.mk comments to match reality; r?build-peer We don't want to encourage people to use client.mk. MozReview-Commit-ID: 53uLrINdHJE
b91de334f546f5b8e2c5039ce9b5c259b532b175: Bug 1412460 - Move configure invocation out of mach_commands.py; r?build-peer draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 11:58:50 -0700 - rev 688022
Push 86647 by gszorc@mozilla.com at Sat, 28 Oct 2017 01:26:32 +0000
Bug 1412460 - Move configure invocation out of mach_commands.py; r?build-peer While we're here, also move the low-level code to invoke configure to a proper Python module. We needed to muck around with the log manager because the underlying logger for output changed from "mach" (which is registered by default) to something under the "mozbuild" hierarchy. MozReview-Commit-ID: 4rlCxOwcVu1
8f7dcf2408d9d2937656d50363eacab262c3cc08: Bug 1412460 - Move code for invoking build system out of mach_commands.py; r?build-peer draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 10:58:30 -0700 - rev 688021
Push 86647 by gszorc@mozilla.com at Sat, 28 Oct 2017 01:26:32 +0000
Bug 1412460 - Move code for invoking build system out of mach_commands.py; r?build-peer The goal is to move this lower-level code somewhere where it can be reused. The only meaningful code change as part of the move was handling of the mach context. Before, we could access self._mach_context. After, we need to pass it as an argument. This also uncovered a bug where "telemetry_handler" could be None but we called it unconditionally. We now guard this call with an "if." MozReview-Commit-ID: FWw4l6H1ayS
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip