709a3cd34fb3eebe4fd40b8fcdde56bae59e43c2: Bug 1372829 - part2: mozilla::EditorBase should cache raw pointer of nsISelectionController and nsIDocument with nsWeakPtr r?m_kato, froydnj draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 20 Jun 2017 00:55:00 +0900 - rev 596709
Push 64725 by masayuki@d-toybox.com at Mon, 19 Jun 2017 16:51:03 +0000
Bug 1372829 - part2: mozilla::EditorBase should cache raw pointer of nsISelectionController and nsIDocument with nsWeakPtr r?m_kato, froydnj mozilla::EditorBase stores nsISelectionController and nsIDocument with nsWeakPtr. However, nsWeakPtr requires QI to retrieve actual pointer and it makes some damage to the performance. If mozilla::WeakPter were available for them, it'd be great. However, it's not available with nsISelectionController nor nsIDocument because it's possible to implement SupportsWeakPtr only with their subclasses but the subclasses shouldn't be referred by editor. Therefore, this patch creates mozilla::CachedWeakPtr<class T> which stores both raw pointer (as cache) and nsWeakPtr and when its cache is requested, it checks if the object referred by nsWeakPtr is still alive. Additionally, this patch hides the members from subclasses of EditorBase for reducing the maintenance cost. MozReview-Commit-ID: FvtM7453Vv8
e0285d6baadc31117ea40c42085b01aa091074b5: Bug 1372829 - part1: Make mozilla::PlaceholderTransaction inherit mozilla::SupportsWeakPtr instead of nsSupportsWeakReference r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 14 Jun 2017 19:05:48 +0900 - rev 596708
Push 64725 by masayuki@d-toybox.com at Mon, 19 Jun 2017 16:51:03 +0000
Bug 1372829 - part1: Make mozilla::PlaceholderTransaction inherit mozilla::SupportsWeakPtr instead of nsSupportsWeakReference r?m_kato EditorBase stores PlaceholderTransaction with nsWeakPtr. However, retrieving its pointer requires a QI. So, for reducing the QI cost, EditorBase should use WeakPtr instead and PlaceholderTransaction needs to inherit SupportsWeakPtr instead of nsSupportsWeakReference. MozReview-Commit-ID: IYwSTbJebMk
9f095b624323c561a278c84808d94c792fa30fd8: Bug 1373271 - Handle crashes in preloaded browsers in tabbrowser draft
k88hudson <khudson@mozilla.com> - Thu, 15 Jun 2017 12:27:06 -0400 - rev 596707
Push 64724 by khudson@mozilla.com at Mon, 19 Jun 2017 16:38:45 +0000
Bug 1373271 - Handle crashes in preloaded browsers in tabbrowser MozReview-Commit-ID: IVMQOOsyMnZ
c3493e9836921208bfcf85e9111f8d43ce6c9e22: bug 1370506, chrome-% android target thinks it's en-US, r?glandium draft
Axel Hecht <axel@pike.org> - Mon, 19 Jun 2017 16:51:05 +0200 - rev 596706
Push 64723 by axel@mozilla.com at Mon, 19 Jun 2017 16:29:28 +0000
bug 1370506, chrome-% android target thinks it's en-US, r?glandium Set AB_CD on the rule to make the merge dir pick the right value. MozReview-Commit-ID: JqrLYyEyvvb
2e04e1b5123d0125d7e9d80293749cebe31af781: Bug 1363428 - Use the internal reftest implementation by default on Linux and OSX, r=ato draft
James Graham <james@hoppipolla.co.uk> - Fri, 16 Jun 2017 18:05:50 +0100 - rev 596705
Push 64722 by bmo:james@hoppipolla.co.uk at Mon, 19 Jun 2017 16:22:31 +0000
Bug 1363428 - Use the internal reftest implementation by default on Linux and OSX, r=ato This is faster and works better in some cases (e.g. with SVG). However it doesn't work correctly on Windows yet, so remains disabled there by default. MozReview-Commit-ID: AXyeFUGfVgx
525ee54eec80b710490e23917251b6283d440451: Bug 1363428 - Update expectation data for reftest changes, r=ato draft
James Graham <james@hoppipolla.co.uk> - Fri, 16 Jun 2017 17:38:15 +0100 - rev 596704
Push 64722 by bmo:james@hoppipolla.co.uk at Mon, 19 Jun 2017 16:22:31 +0000
Bug 1363428 - Update expectation data for reftest changes, r=ato The internal reftest harness changes some results, but it's not clear that it's overall better or worse than the old one, so just update the expectation metadata for now. MozReview-Commit-ID: KSE2z1Ct72t
eeb56fcb7b79efee0dd77248e6e6aac5bc1ba8c1: Bug 1363428 - Copy the Ahem font into the bundled font directory, r=maja_zf draft
James Graham <james@hoppipolla.co.uk> - Thu, 01 Jun 2017 15:20:11 +0100 - rev 596703
Push 64722 by bmo:james@hoppipolla.co.uk at Mon, 19 Jun 2017 16:22:31 +0000
Bug 1363428 - Copy the Ahem font into the bundled font directory, r=maja_zf MozReview-Commit-ID: 3VgrawYWoWp
714498a1dfb9aaf475bf3bcc81cffb624bb58524: Bug 1363428 - Add Ahem to wpt fonts directory, r=maja_zf draft
James Graham <james@hoppipolla.co.uk> - Thu, 01 Jun 2017 11:24:17 +0100 - rev 596702
Push 64722 by bmo:james@hoppipolla.co.uk at Mon, 19 Jun 2017 16:22:31 +0000
Bug 1363428 - Add Ahem to wpt fonts directory, r=maja_zf MozReview-Commit-ID: 8UWoXdDBNhp
5a5dc173f147dd9e0e234e6588599b2ea0310b76: Bug 1363428 - Add per-test-queue metadata to wptrunner, r=maja_zf draft
James Graham <james@hoppipolla.co.uk> - Wed, 10 May 2017 14:56:20 +0100 - rev 596701
Push 64722 by bmo:james@hoppipolla.co.uk at Mon, 19 Jun 2017 16:22:31 +0000
Bug 1363428 - Add per-test-queue metadata to wptrunner, r=maja_zf This adds a metadata object associated with each test queue, and uses it to pass cache information into the marionette internal reftest implementation so that we are able to cache only those canvases that will be reused. MozReview-Commit-ID: zASrlvnri3
d0a8266b64e7084b16589f8f3f172e5a8638bad6: Bug 1363428 - Switch wptrunner to use a deque for test groups, r=maja_zf, jdm draft
James Graham <james@hoppipolla.co.uk> - Sun, 28 May 2017 21:14:28 +0100 - rev 596700
Push 64722 by bmo:james@hoppipolla.co.uk at Mon, 19 Jun 2017 16:22:31 +0000
Bug 1363428 - Switch wptrunner to use a deque for test groups, r=maja_zf, jdm Initially wptrunner had a single test queue that was shared between all processes. Then for --run-by-dir it changed to a queue of queues. This change makes it a queue of deques, which is simpler, since the test queues themselves are no longer shared between processes. It also changes the implementation when we aren't using --run-by-dir but are using multiple processes to pre-group the tests into N queues rather than sharing a single queue between all processes. This is necessary to use the deque of course, but importantly anticipates a change in which we will pre-compute per queue metdata for each queue; that doesn't work well with one shared queue. The downside of this change is that there is no work stealing, so it may be less efficient if we randomly assign many slow jobs to one particular process. MozReview-Commit-ID: 7e0Odk7yDwr
d9ab4ec95a26e11c9637f516f27569d2b57230d4: Bug 1363428 - Support Marionette reftest implementation in wptrunner, r=maja_zf draft
James Graham <james@hoppipolla.co.uk> - Wed, 10 May 2017 11:41:33 +0100 - rev 596699
Push 64722 by bmo:james@hoppipolla.co.uk at Mon, 19 Jun 2017 16:22:31 +0000
Bug 1363428 - Support Marionette reftest implementation in wptrunner, r=maja_zf Add an InternalReftestImplmentation that runs reftests using the built-in Marionette reftest primitives rather than screenshots. This is actiivated using the --internal-reftest switch, although that may become the default in the future. MozReview-Commit-ID: 6HxGuBsTITf
b998bde62aa89f88ab3b2ce75513956465e89193: Bug 1363428 - Add reftest-specific endpoints to Marionette, r=ato draft
James Graham <james@hoppipolla.co.uk> - Wed, 10 May 2017 10:51:10 +0100 - rev 596698
Push 64722 by bmo:james@hoppipolla.co.uk at Mon, 19 Jun 2017 16:22:31 +0000
Bug 1363428 - Add reftest-specific endpoints to Marionette, r=ato This adds commands to start a reftest session, run a test, and end the session. It as assumed that after you start a reftest session you will just run reftests until you end the session. When starting a session the user provides a string indicating when screenshots should be taken, and an object mapping urls to a count of the number of times that url is expected to be used in the session, to help with caching. Running the tests takes a url to a test, an expected status, a timeout, and a nested list of possible references, in which each entry at a specific level is combined by OR and nested references are combined by AND. The implementation is heavilly inspired by the existing reftest harness, starting a minimal window with no tabs, and loading the urls directly in there. In order to get a screenshot in the e10s case we have to pass the DRAW_VIEW and USE_WIDGET_LAYERS flags when taking the screenshot. For performance we heavily cache canvases; for references that will be repeated we cache the full canvas with image, and we also cache a single canvas to use for all other screenshots to avoid the overhead of repeatedly creating a new canvas element. MozReview-Commit-ID: JOFvtmH7tg
c1ca05c45a6fb18b013f52ab89814530939a2ba1: Bug 1363428 - Make it possible to close tabless content windows, r=ato draft
James Graham <james@hoppipolla.co.uk> - Fri, 09 Jun 2017 18:28:10 +0100 - rev 596697
Push 64722 by bmo:james@hoppipolla.co.uk at Mon, 19 Jun 2017 16:22:31 +0000
Bug 1363428 - Make it possible to close tabless content windows, r=ato MozReview-Commit-ID: 8xltsYCN3QA
f704523f15750072ecc66dddb9be41ad60eef010: Bug 1363428 - Handle top level reftest window specially in Marionette, r=ato draft
James Graham <james@hoppipolla.co.uk> - Tue, 09 May 2017 19:05:49 +0100 - rev 596696
Push 64722 by bmo:james@hoppipolla.co.uk at Mon, 19 Jun 2017 16:22:31 +0000
Bug 1363428 - Handle top level reftest window specially in Marionette, r=ato Because this window is a normal Firefox window but doesn't contain any tabs, the normal Marionette functions for iterating over windows don't work well. As a sort of hack, identify this window by the id of its root element, and special case it when finding windows in Marionette. MozReview-Commit-ID: LxPv13YDXDu
371e3ae4543d30bbf26dab13efba944ededd9321: Bug 1363428 - Refactor Marionette switchToWindow implementation, r=ato draft
James Graham <james@hoppipolla.co.uk> - Tue, 09 May 2017 18:59:09 +0100 - rev 596695
Push 64722 by bmo:james@hoppipolla.co.uk at Mon, 19 Jun 2017 16:22:31 +0000
Bug 1363428 - Refactor Marionette switchToWindow implementation, r=ato This allows other commands to implicitly change the window handle, by calling findWindow with appropriate arguments to get a window properties object and then passing that to setWindowHandle. MozReview-Commit-ID: 4NpYxjsMM4T
31c15974ff11df8e8b8940653b5c5253f39d8388: Bug 1363428 - Use an iterator for iterating windows, r=ato draft
James Graham <james@hoppipolla.co.uk> - Tue, 09 May 2017 17:49:09 +0100 - rev 596694
Push 64722 by bmo:james@hoppipolla.co.uk at Mon, 19 Jun 2017 16:22:31 +0000
Bug 1363428 - Use an iterator for iterating windows, r=ato MozReview-Commit-ID: FKsw9EST2H7
0bf68eb2b3588e22c30648cca60b640764373a22: Bug 1363428 - Skip element highlighting if there are no highlights, r=ato draft
James Graham <james@hoppipolla.co.uk> - Tue, 09 May 2017 17:26:45 +0100 - rev 596693
Push 64722 by bmo:james@hoppipolla.co.uk at Mon, 19 Jun 2017 16:22:31 +0000
Bug 1363428 - Skip element highlighting if there are no highlights, r=ato MozReview-Commit-ID: 3rc4XnykV1S
e3946a2dd72856598e219eb340e065d5ab2f961f: Bug 1363428 - Allow passing flags when drawing to a canavs, r=ato draft
James Graham <james@hoppipolla.co.uk> - Tue, 09 May 2017 17:26:08 +0100 - rev 596692
Push 64722 by bmo:james@hoppipolla.co.uk at Mon, 19 Jun 2017 16:22:31 +0000
Bug 1363428 - Allow passing flags when drawing to a canavs, r=ato MozReview-Commit-ID: 8QAFiWcsKNE
d88c977e947bdc5352e307bc0fdc6d2d0888c3db: Bug 1363428 - Allow passing in an existing canvas to capture.canvas, r=ato draft
James Graham <james@hoppipolla.co.uk> - Tue, 09 May 2017 17:23:47 +0100 - rev 596691
Push 64722 by bmo:james@hoppipolla.co.uk at Mon, 19 Jun 2017 16:22:31 +0000
Bug 1363428 - Allow passing in an existing canvas to capture.canvas, r=ato MozReview-Commit-ID: EGvEr7XfHH9
7e589c73dc7b668ad9d6c4fe459fd5035ca01109: Bug 1373229: P2. Update mochitest expectations. r?jgilbert draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Sun, 18 Jun 2017 16:14:05 +0200 - rev 596690
Push 64721 by bmo:jyavenard@mozilla.com at Mon, 19 Jun 2017 16:13:55 +0000
Bug 1373229: P2. Update mochitest expectations. r?jgilbert MozReview-Commit-ID: 37IluaeewKk
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip