6f15eecb6ba1198798bfbaf34391fd0344d2930c: Bug 1272964: P1. Only activate skip to next keyframe logic when next keyframe time is known. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 17 May 2016 22:26:34 +0800 - rev 369397
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1272964: P1. Only activate skip to next keyframe logic when next keyframe time is known. r=gerald MozReview-Commit-ID: DoAstqSRnyc
3c46096adeaf7611bed1588d6adfa0c7c7b2d5e3: Bug 1272592 Merge "MediaSelect" key value into "LaunchMediaPlayer" r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 19 May 2016 20:47:32 +0900 - rev 369396
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1272592 Merge "MediaSelect" key value into "LaunchMediaPlayer" r=smaug "MediaSelect" is merged into "LanuchMediaPlayer" in the spec since there is no difference between them and "LaunchMediaPlayer" explains the meaning clearer. This patch removes "MediaSelect" key value and maps all keys which are mapped to "MediaSelect" to "LaunchMediaPlayer". MozReview-Commit-ID: IEZhV4p6Qag
392304ae5264da68fb3e2be789bcbe34137f6951: Bug 1274272 - fix RTL issues with about:privatebrowsing, r=mikedeboer
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 19 May 2016 22:59:09 +0100 - rev 369395
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1274272 - fix RTL issues with about:privatebrowsing, r=mikedeboer MozReview-Commit-ID: rFNLKSWnSX
fdccec38636a68423966a49bbb4b3e3bba095ea2: Bug 1274271 - Remove unused function applyNamedArgs; r=automatedtester
Andreas Tolfsen <ato@mozilla.com> - Thu, 19 May 2016 14:53:00 +0100 - rev 369394
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1274271 - Remove unused function applyNamedArgs; r=automatedtester MozReview-Commit-ID: DU5xHDLL4Ww
63cfc2bd51fab69b6d4f3803af86c4b5a3a0eb01: Bug 1273998 - Proper export of printing IPDL with --disable-printing r=bobowen,glandium,?glandium
Alexandre Lissy <lissyx@lissyx.dyndns.org> - Thu, 19 May 2016 12:25:22 +0200 - rev 369393
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1273998 - Proper export of printing IPDL with --disable-printing r=bobowen,glandium,?glandium MozReview-Commit-ID: GNUrl6LKcMm
9145f902d54fe189169db465e6e8be9c7eba21e3: Bug 1262937 - part 8 - factor out array length deserialization errors; r=jld
Nathan Froyd <froydnj@gmail.com> - Sat, 21 May 2016 04:07:56 -0400 - rev 369392
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1262937 - part 8 - factor out array length deserialization errors; r=jld
fc5bd59a1e7e194cea24f307b42d6e2a01377381: Bug 1262937 - part 7 - factor out union type deserialization errors; r=jld
Nathan Froyd <froydnj@gmail.com> - Sat, 21 May 2016 04:07:56 -0400 - rev 369391
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1262937 - part 7 - factor out union type deserialization errors; r=jld
6d963cab433c29fbf3e3bd3f1d889867abeb258d: Bug 1262937 - part 6 - enable custom error message for ipdl.py's checkedRead; r=jld
Nathan Froyd <froydnj@gmail.com> - Sat, 21 May 2016 04:07:56 -0400 - rev 369390
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1262937 - part 6 - enable custom error message for ipdl.py's checkedRead; r=jld To enable string sharing, we're going to have helpful functions that take a small, distinguishable, sharable string and construct a more complete error message out of that. To do that easily with checkedRead, we need to be able to pass custom parameters into the error function.
9aa3fa0eb1cc13457961f091babf6aa1a9e0b652: Bug 1262937 - part 5 - factor out actor reading code to a common base class; r=jld
Nathan Froyd <froydnj@gmail.com> - Sat, 21 May 2016 04:07:56 -0400 - rev 369389
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1262937 - part 5 - factor out actor reading code to a common base class; r=jld Actor reading from IPC message is codegen'd with a lot of repeated code. We can improve that by moving the core actor reading code out of subclasses into IProtocolmanager. While we still need to codegen a bit of code to cast the read actor to the proper type, the code overall is smaller. The lone downside is that if we do encounter an error reading the actor id out of the message, the precision of our crash messages is reduced somewhat: we no longer have the protocol name doing the reading, nor do we get crash report annotations, since we can't tell whether we're in the parent or child process.
49c0e922c3ffa997338aea278517b2806fcd7caa: Bug 1262937 - part 4 - publically inherit from MessageListener in IProtocol; r=jld
Nathan Froyd <froydnj@gmail.com> - Sat, 21 May 2016 04:07:56 -0400 - rev 369388
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1262937 - part 4 - publically inherit from MessageListener in IProtocol; r=jld IProtocolManager is templated over some listener type. In our IPDL code, that type is always IProtocol, which is a subclass of MessageListener. It's also important to note that IProtocol uses protected inheritance from MessageListener; the generated code takes advantage of this inheritance structure when it reads actors: // ChannelListener is typedef'd to MessageListener // Lookup here is IProtocolManager::Lookup ChannelListener* listener = Lookup(id); Lookup returns a pointer to the type over which IProtocolManager is templated. As mentioned above, that type is always IProtocol. But thanks to the containing class inheriting from *both* IProtocolManager and IProtocol, the returned pointer can be silently upcasted to MessageListener thanks to C++ visibility rules. It's not clear that this restricted inheritance structure is actually benefitting anybody, or that the inheritance hierarchy of protocol classes is the best way to do things. This particular implementation detail is getting in the way for the next improvement, so let's make the protected inheritance public instead.
89b98926c2fdd4fad17285c0cfc8029277c6b0b0: Bug 1262937 - part 3 - move quoting out of checkedRead; r=jld
Nathan Froyd <froydnj@gmail.com> - Sat, 21 May 2016 04:07:56 -0400 - rev 369387
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1262937 - part 3 - move quoting out of checkedRead; r=jld checkedRead is set up to single-quote whatever message is passed in. This scheme works great for all existing messages, but it makes some callsites a little surprising ("where's the matching quote?") and doesn't work well with message changes to be made in future patches. Let's move the quoting out to client code.
63a20cf3a66d8b845df443b1bfe1d1ce41b5821c: Bug 1262937 - part 2 - don't include the message name when complaining about handler failure; r=jld
Nathan Froyd <froydnj@gmail.com> - Sat, 21 May 2016 04:07:56 -0400 - rev 369386
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1262937 - part 2 - don't include the message name when complaining about handler failure; r=jld Similar to part 1, this change enables the strings passed to ProtocolErrorBreakpoint to be collapsed into a single string, saving ~60K of read-only data (!). This change does affect debuggability slightly, but given that ProtocolErrorBreakpoint only tries to throw the passed-in string to stderr, I don't think it's a huge deal.
7ad129583196b1f1b7b060f7a8caee3909ea18a1: Bug 1262937 - part 1 - don't include the protocol name in Clone error messages; r=jld
Nathan Froyd <froydnj@gmail.com> - Sat, 21 May 2016 04:07:56 -0400 - rev 369385
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1262937 - part 1 - don't include the protocol name in Clone error messages; r=jld We have better ways of getting the protocol name at the point of the error (e.g. backtraces). Removing it means the error message can be condensed to a single string by the compiler/linking, saving ~8k of read-only data.
4174c9e21a403c08491127884ab0bc0d8db819cd: Bug 1273405. Part 4 - add assertions. r=jya.
JW Wang <jwwang@mozilla.com> - Tue, 17 May 2016 17:32:55 +0800 - rev 369384
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1273405. Part 4 - add assertions. r=jya. MozReview-Commit-ID: 6tbA0aj5Rto
c123be7651413615bb9886d074c783f4227de06a: Bug 1273405. Part 3 - remove use of FlushableTaskQueue. r=jya.
JW Wang <jwwang@mozilla.com> - Tue, 17 May 2016 17:30:53 +0800 - rev 369383
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1273405. Part 3 - remove use of FlushableTaskQueue. r=jya. MozReview-Commit-ID: Do9REbjltEW
7be21b2402d1240667468d33f0dae4e226eda497: Bug 1273405. Part 2 - remove use of FlushableTaskQueue::Flush(). r=jya.
JW Wang <jwwang@mozilla.com> - Tue, 17 May 2016 17:22:45 +0800 - rev 369382
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1273405. Part 2 - remove use of FlushableTaskQueue::Flush(). r=jya. MozReview-Commit-ID: bchmGXw1fw
64e64f5a50357d60ed34f16f57ae8dcf90a75aa2: Bug 1273405. Part 1 - rename some functions to be consistent with other MediaDataDecoder sub-classes. r=jya.
JW Wang <jwwang@mozilla.com> - Tue, 17 May 2016 16:05:30 +0800 - rev 369381
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1273405. Part 1 - rename some functions to be consistent with other MediaDataDecoder sub-classes. r=jya. MozReview-Commit-ID: 1CpEZktGNia
53e791a65fa2be8a94fedb0a70d47cfa152ce2c8: bug 1272194 explicitly invalidate after change style contexts belonging to widgets r=stransky+263117
Karl Tomlinson <karlt+@karlt.net> - Tue, 17 May 2016 18:15:12 +1200 - rev 369380
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
bug 1272194 explicitly invalidate after change style contexts belonging to widgets r=stransky+263117 This fixes menu item rendering during hover. MozReview-Commit-ID: CEa6aorqBZM
764650604afd8277b6bd58cb2100c7aa52e5ccba: bug 1272194 use WidgetStyleCache for menus r=stransky+263117
Karl Tomlinson <karlt+@karlt.net> - Tue, 17 May 2016 18:24:55 +1200 - rev 369379
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
bug 1272194 use WidgetStyleCache for menus r=stransky+263117 Unnecessary widget realization is also removed. MozReview-Commit-ID: A5HuE5bqf4x
3909bcf5501b7ee54ba3252a6a32044d22ea4207: bug 1272194 only add menubar class to menu items with GTK 3.4 r=stransky+263117
Karl Tomlinson <karlt+@karlt.net> - Tue, 17 May 2016 18:02:00 +1200 - rev 369378
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
bug 1272194 only add menubar class to menu items with GTK 3.4 r=stransky+263117 and save/restore context consistent with GTK 3.4. MozReview-Commit-ID: GdMoAmzOJlf
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip