6c23401e0513ce34319f0de743f020a3234f807b: Automatic version bump. CLOSED TREE NO BUG a=release
ffxbld <release@mozilla.com> - Fri, 25 Nov 2016 07:23:34 -0800 - rev 445087
Push 37411 by martin.thomson@gmail.com at Tue, 29 Nov 2016 03:34:58 +0000
Automatic version bump. CLOSED TREE NO BUG a=release
8ae84e740f35e596a2b55390b0d72a4fd674a67b: No bug, Automated blocklist update from host bld-linux64-spot-384 - a=blocklist-update
ffxbld - Fri, 25 Nov 2016 03:07:32 -0800 - rev 445086
Push 37411 by martin.thomson@gmail.com at Tue, 29 Nov 2016 03:34:58 +0000
No bug, Automated blocklist update from host bld-linux64-spot-384 - a=blocklist-update
aaa739912343078f3b197fd494d061f23254ee9c: Bug 1317725 -Correct creation of Sliced Remote Blob actorss when used in FormData in workers, r=smaug, a=gchang
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 16 Nov 2016 15:04:23 +0100 - rev 445085
Push 37411 by martin.thomson@gmail.com at Tue, 29 Nov 2016 03:34:58 +0000
Bug 1317725 -Correct creation of Sliced Remote Blob actorss when used in FormData in workers, r=smaug, a=gchang
cd9c48229ba3fdd0d0c0267f268c3d2ac64e421d: Bug 1319543: Prevent overflow if sample's time is negative. r=gerald a=gchang
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 23 Nov 2016 11:21:42 +1100 - rev 445084
Push 37411 by martin.thomson@gmail.com at Tue, 29 Nov 2016 03:34:58 +0000
Bug 1319543: Prevent overflow if sample's time is negative. r=gerald a=gchang MozReview-Commit-ID: I94vvJccOqE
3a4718648de748edb16bb356858493e810067913: bug 1315668 construct menuitem style contexts from paths r=stransky a=gchang
Karl Tomlinson <karlt+@karlt.net> - Tue, 15 Nov 2016 17:11:14 +1300 - rev 445083
Push 37411 by martin.thomson@gmail.com at Tue, 29 Nov 2016 03:34:58 +0000
bug 1315668 construct menuitem style contexts from paths r=stransky a=gchang instead of using the context belonging to a widget. Only the style context is cached, instead of the whole widget. Using the style context from a widget meant that rendering displayed the initial appearance of animations after state changes, but there was no invalidation to trigger the final rendering in the animations. Style contexts constructed from paths do not incorporate animations. (See gtk_css_path_node_update_style() in GTK.) Therefore they provide the appropriate rendering for Gecko's model, which is not expecting animations. There is no mechanism available to display animations when using style contexts constructed from paths, but the GtkWidget animation design is also not suitable for rendering potentially multiple elements each in a different state of their animation. This contexts-from-paths approach can be extended also to other widget types, but this is a smaller change intended for uplift to other branches to address a regression in menuitem rendering. MozReview-Commit-ID: EFV7swWQtm4
c0681f9b8c05fee80959d57ba314f01294696052: bug 1315668 CreateStyleForWidget: store classes on context instead of path r=stransky+263117
Karl Tomlinson <karlt+@karlt.net> - Tue, 15 Nov 2016 15:29:06 +1300 - rev 445082
Push 37411 by martin.thomson@gmail.com at Tue, 29 Nov 2016 03:34:58 +0000
bug 1315668 CreateStyleForWidget: store classes on context instead of path r=stransky+263117 CreateStyleForWidget() then provides the same behavior with g_style_context_save() as contexts from widget root style nodes. MozReview-Commit-ID: 6lRCp3XOoRr
9961ffa21ba646b1b13c4453b4c26d412e2b4321: bug 1315668 use style context instead of widget for menuitem dimensions r=stransky+263117
Karl Tomlinson <karlt+@karlt.net> - Tue, 15 Nov 2016 16:11:38 +1300 - rev 445081
Push 37411 by martin.thomson@gmail.com at Tue, 29 Nov 2016 03:34:58 +0000
bug 1315668 use style context instead of widget for menuitem dimensions r=stransky+263117 This is necessary to switch from caching GtkWidgets to caching GtkStyleContexts only. MozReview-Commit-ID: 6Rwinr4AY8l
427a01f3d6a48626cb1081be8d7ccb94c50e74f4: bug 1315668 remove use of gtk_container_get_border_width from menuitems r=stransky+263117
Karl Tomlinson <karlt+@karlt.net> - Mon, 14 Nov 2016 16:13:50 +1300 - rev 445080
Push 37411 by martin.thomson@gmail.com at Tue, 29 Nov 2016 03:34:58 +0000
bug 1315668 remove use of gtk_container_get_border_width from menuitems r=stransky+263117 The GtkContainer border-width property defaults to zero. It is not influenced by theme CSS. While theme engines can theoretically modify default values for properties of any class, I don't think that is something that needs to be supported. Removing this code is necessary to switch from caching GtkWidgets to caching GtkStyleContexts only. MozReview-Commit-ID: IxgM8qjfK3a
f37e99ebc6e0c682003b52573f415e5fd78d425a: Bug 1318333 - Fix SEARCH_COUNTS not counting one-off searches. r=mak, a=gchang FIREFOX_51_0b3_BUILD1 FIREFOX_51_0b3_RELEASE
Alessio Placitelli <alessio.placitelli@gmail.com> - Mon, 21 Nov 2016 04:56:00 +0100 - rev 445079
Push 37411 by martin.thomson@gmail.com at Tue, 29 Nov 2016 03:34:58 +0000
Bug 1318333 - Fix SEARCH_COUNTS not counting one-off searches. r=mak, a=gchang MozReview-Commit-ID: 2HTJBzbpUK2
ebddbe716951a92bc9104d85e56a68ed31258ed0: Bug 1318926 - constant-fold asm.js RSh expressions again. r=nbp a=gchang
Pip Cet <pipcet@gmail.com> - Sun, 20 Nov 2016 23:16:00 +0100 - rev 445078
Push 37411 by martin.thomson@gmail.com at Tue, 29 Nov 2016 03:34:58 +0000
Bug 1318926 - constant-fold asm.js RSh expressions again. r=nbp a=gchang
881b37dc7f945c1d1031284abe03b15049254565: Bug 1314790 - Part 3. Ignore nsIEditor::eNone case. r=masayuki a=gchang
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Sun, 20 Nov 2016 10:35:17 +0900 - rev 445077
Push 37411 by martin.thomson@gmail.com at Tue, 29 Nov 2016 03:34:58 +0000
Bug 1314790 - Part 3. Ignore nsIEditor::eNone case. r=masayuki a=gchang MozReview-Commit-ID: 6KHFQ84J7dU
ba5384798a4d821d60c188f1deffeecc86b19fd3: Bug 1314790 - Part 1. GetGoodSelPointForNode doesn't work with ePrevousWord action. r=masayuki, a=gchang
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Sat, 12 Nov 2016 21:59:04 +0900 - rev 445076
Push 37411 by martin.thomson@gmail.com at Tue, 29 Nov 2016 03:34:58 +0000
Bug 1314790 - Part 1. GetGoodSelPointForNode doesn't work with ePrevousWord action. r=masayuki, a=gchang Although GetGoodSelPointForNode only supports ePrevious or eNext as action, we use other action. So we should add aseetion for it. MozReview-Commit-ID: 3gLFFTAdNxU
9f89f9027a358144c9b064c028738075f617c23d: Bug 1315905 - "Cleanup Necko http security check test" r=me a=test-only
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 24 Nov 2016 07:01:00 +0100 - rev 445075
Push 37411 by martin.thomson@gmail.com at Tue, 29 Nov 2016 03:34:58 +0000
Bug 1315905 - "Cleanup Necko http security check test" r=me a=test-only
823df64d0f5080e9ee482dad0f40bb0c89fe8832: Bug 1315905 - Fix a mochitest, r=me a=test-only
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 24 Nov 2016 15:49:06 +0100 - rev 445074
Push 37411 by martin.thomson@gmail.com at Tue, 29 Nov 2016 03:34:58 +0000
Bug 1315905 - Fix a mochitest, r=me a=test-only
ed3bae0b42fba0ab8393dade9412a2436a495291: Bug 1315905 - "Cleanup Necko http security check tests". r=valentin a=gchang
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 16 Nov 2016 00:16:00 +0100 - rev 445073
Push 37411 by martin.thomson@gmail.com at Tue, 29 Nov 2016 03:34:58 +0000
Bug 1315905 - "Cleanup Necko http security check tests". r=valentin a=gchang
a5cf41cc6a0d305968ac833d300a68f0d8da7898: Bug 1315905 - Cleanup Necko http security check - part 1, r=valentin, a=gchang
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 17 Nov 2016 14:52:16 +0100 - rev 445072
Push 37411 by martin.thomson@gmail.com at Tue, 29 Nov 2016 03:34:58 +0000
Bug 1315905 - Cleanup Necko http security check - part 1, r=valentin, a=gchang
434ad784075de46014f18e9d1b20c082295e90fd: Bug 1317906 - When a key press causes a call of InsertText(), it shouldn't mark keypress as consumed but instead, should mark InsertText() caused composition. r=m_kato, a=gchang
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 17 Nov 2016 13:35:21 +0900 - rev 445071
Push 37411 by martin.thomson@gmail.com at Tue, 29 Nov 2016 03:34:58 +0000
Bug 1317906 - When a key press causes a call of InsertText(), it shouldn't mark keypress as consumed but instead, should mark InsertText() caused composition. r=m_kato, a=gchang Currently, when InsertText() which is caused by a key press causes committing composition, it consumes keypress event. However, Korean 2-set IME calls InsertText() two times when there is composition and key press causes inserting another character next to the composition. In this case, current design ignores second InsertText() becuase keypress event is already consumed by the first InsertText() call. For solving this issue safely, InsertText() should mark current key event as "dispatched composition event". Then, following InsertText() calls should cause composition events instead of keypress events since following event order is too odd: 1. keydown (currently not dispatched by TextEventDisaptcher) 2. compositionupdate 3. compositionend 4. keypress 5. keyup with the new design this becomes: 1. keydown (currently not dispatched by TextEventDispatcher) 2. compositionupdate 3. compositionend 4. compositionstart 5. compositionupdate 6. compositionend 7. keyup This is similar to Chromium, although, Chromium includes the second InsertText() call into the first composition, we need to fix it later due to risky. MozReview-Commit-ID: GL42cU2WIL0
dfb217a85b4154c5877090e6e1a2826816e958d4: Bug 1312649 part.1 TextInputHandler::InsertText() should dispatch composition events instead of keypress events when it replaces a range which is different from current selection r=m_kato, a=gchang
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 07 Nov 2016 10:30:05 +0900 - rev 445070
Push 37411 by martin.thomson@gmail.com at Tue, 29 Nov 2016 03:34:58 +0000
Bug 1312649 part.1 TextInputHandler::InsertText() should dispatch composition events instead of keypress events when it replaces a range which is different from current selection r=m_kato, a=gchang Vietnamese Telex IME handles Backspace key immediately after inputting a word even when there is no marked text. At this time, it tries to replace the word with specific string. In such case, our editor shouldn't remove anything at handling the Backspace keypress event. For avoiding this issue, InserText() should dispatch a set of composition for inserting the specified text into the range. Then, editor won't perform any action of the key. Additionally, when a Backspace keydown tries to remove the last character of the word, Telex removes it with a composition. At this time, it creates dummy marked text "a" and make it empty later. So, in this case, InsertText() won't be called, therefore, we need to consume the Backspace keypress when SetMarkedText() is called for preventing removing the previous character of the word. MozReview-Commit-ID: LfeEHDWn0cZ
de40de49d38983e9bc745f305f509acb92876e12: Bug 1312649 part.2 IMEInputHandler::GetVaildAttributesForMarkedText() should return non-empty array r=m_kato, a=gchang
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 07 Nov 2016 16:19:41 +0900 - rev 445069
Push 37411 by martin.thomson@gmail.com at Tue, 29 Nov 2016 03:34:58 +0000
Bug 1312649 part.2 IMEInputHandler::GetVaildAttributesForMarkedText() should return non-empty array r=m_kato, a=gchang Vietnamese Telex perhaps referes this result and change its behavior. When typying something, Telex starts composition on Chrome but may not behave so on Gecko. Fortunately, Chromium just returns some attributes when validAttributesForMarkedText: of NSTextInputClient [1] but it doesn't return these styles when attributedSubstringForProposedRange: of NSTextInputClient is called (always returns non-styled plain text) [2]. Therefore, this patch does not touch IMEInputHandler::GetAttributedSubstringFromRange(). *1 <https://chromium.googlesource.com/chromium/src/+/7d85f23cb0235db06b0b6c2de1dc29ae5eaeb8f5/content/browser/renderer_host/render_widget_host_view_mac.mm#2936> *2 <https://chromium.googlesource.com/chromium/src/+/7d85f23cb0235db06b0b6c2de1dc29ae5eaeb8f5/content/browser/renderer_host/render_widget_host_view_mac.mm#3036> MozReview-Commit-ID: 1gPIiu4Qbud
2d052cc5f70016e56e41cdc741573e5c967e9aed: Bug 1310565 TextInputHandler shouldn't dispatch a composition events when a key press causes 2 or more characters r=m_kato, a=gchang
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 24 Nov 2016 14:08:15 +0900 - rev 445068
Push 37411 by martin.thomson@gmail.com at Tue, 29 Nov 2016 03:34:58 +0000
Bug 1310565 TextInputHandler shouldn't dispatch a composition events when a key press causes 2 or more characters r=m_kato, a=gchang TextInputHandler::InsertText() dispatches a set of composition events when a key press causes 2 or more characters (Note that InsertText() is typically called only when IME is available because it's called via [NSResponder interpretKeyEvents]). However, this is different from the behavior of Windows. On Windows, NativeKey dispatches two ore more eKeyPress events in this case.
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip