6ba9173012e688a64425f36fcd37578c68c5757f: Bug 1351739 - Part 3 - Switch activities when a custom tab is selected/unselected. r?sebastian,walkingice draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 08 Apr 2017 23:10:51 +0200 - rev 565873
Push 55049 by mozilla@buttercookie.de at Thu, 20 Apr 2017 17:00:09 +0000
Bug 1351739 - Part 3 - Switch activities when a custom tab is selected/unselected. r?sebastian,walkingice On tab selection, the Tabs instance now checks whether the type of the tab to be selected matches the currently running activity. If it doesn't, the tab switching is aborted and instead, an intent for the correct activity is sent. When the new activity launches, it finds that the intent also includes a tab ID, which means that instead of opening a new tab we retry the tab selection, which will then succeed now that we're in the correct activity. Because for custom tabs the launch intent can contain all sorts of customisations, we now have to save the intent when a custom tab is opened for the first time, so that later on, when switching e.g. from BrowserApp back to a custom tab we can use the correct intent to launch the custom tab activity. MozReview-Commit-ID: KWdkweKBocz
3aeacb72d12beafc178dfe5d783295533e770251: Bug 1351739 - Part 2 - Convert CustomTabsActivity to SafeIntents. r?sebastian,walkingice draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 02 Apr 2017 14:09:36 +0200 - rev 565872
Push 55049 by mozilla@buttercookie.de at Thu, 20 Apr 2017 17:00:09 +0000
Bug 1351739 - Part 2 - Convert CustomTabsActivity to SafeIntents. r?sebastian,walkingice These are potentially untrusted external intents, so we should use SafeIntents for interacting with them. MozReview-Commit-ID: 3nmjg85wbr1
828ec5265255663489887d0b847fc234e8860004: Bug 1351739 - Part 1 - Track the currently active activity. r?sebastian,walkingice draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 02 Apr 2017 11:22:12 +0200 - rev 565871
Push 55049 by mozilla@buttercookie.de at Thu, 20 Apr 2017 17:00:09 +0000
Bug 1351739 - Part 1 - Track the currently active activity. r?sebastian,walkingice Required because later on, we'll need to know if we're in the correct activity for a tab or need to switch activities. As a follow-up, we can later also hook up our current manual activity tracking from GeckoApplication to this (we most probably won't be able to get rid of the GeckoActivityStatus shenanigans, though). MozReview-Commit-ID: 5lZrAMsB9Gy
9199be920ebd2c4a4e2b91cdd6eaad241668a3d9: Bug 1351739 - Part 0 - Use INVALID_TAB_ID more. r?sebastian,walkingice draft
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 06 Apr 2017 21:30:55 +0200 - rev 565870
Push 55049 by mozilla@buttercookie.de at Thu, 20 Apr 2017 17:00:09 +0000
Bug 1351739 - Part 0 - Use INVALID_TAB_ID more. r?sebastian,walkingice -1 is probably not all that mysterious as far as magic numbers go, but still... MozReview-Commit-ID: zK3P6HeWzK
06cf7a712ab7f056cc3ffd5c4ad2af9f990308ae: Bug 1351739 - Part -1 - Housekeeping. r?sebastian,walkingice draft
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 07 Apr 2017 20:51:41 +0200 - rev 565869
Push 55049 by mozilla@buttercookie.de at Thu, 20 Apr 2017 17:00:09 +0000
Bug 1351739 - Part -1 - Housekeeping. r?sebastian,walkingice MozReview-Commit-ID: Ev6jl4N3K0g
208424fa6848749fc2cd7613157e2e88997cc8f4: bug 1318143 - add a --with-visual-studio-version to choose which VS version configure chooses when multiple versions are installed. r?gps draft
Ted Mielczarek <ted@mielczarek.org> - Thu, 20 Apr 2017 12:43:44 -0400 - rev 565868
Push 55048 by bmo:ted@mielczarek.org at Thu, 20 Apr 2017 16:53:17 +0000
bug 1318143 - add a --with-visual-studio-version to choose which VS version configure chooses when multiple versions are installed. r?gps MozReview-Commit-ID: C6IoZJNHR4G
9e64ee6fbd3bc87e262bfcd0cd42b4795883c636: bug 1318143 - add support for detecting Visual Studio 2017 to configure. r?gps draft
Ted Mielczarek <ted@mielczarek.org> - Thu, 20 Apr 2017 12:49:12 -0400 - rev 565867
Push 55048 by bmo:ted@mielczarek.org at Thu, 20 Apr 2017 16:53:17 +0000
bug 1318143 - add support for detecting Visual Studio 2017 to configure. r?gps This patch adds a copy of vswhere.exe to build/win32, downloaded from the current latest release (1.0.62): https://github.com/Microsoft/vswhere/releases/download/1.0.62/vswhere.exe It changes toolchain.configure to invoke vswhere.exe instead of reading the registry, since that no longer works for VS2017 (but vswhere can locate VS2015). It also removes a layer of complexity in that code by dropping support for non-64-bit host systems, since we don't really support building on 32-bit Windows anymore anyway. There's a little bit of fixup in windows.configure where some LIB paths have changed in 2017. MozReview-Commit-ID: 5XLWjidS6W4
4837dcd736eb613923a8b3be677d8e863a659525: Bug 1334642 - Cache luminance values for each toolbar in ToolbarIconColor. r=dao r=mconley draft
Sam Foster <sfoster@mozilla.com> - Thu, 06 Apr 2017 10:50:09 -0700 - rev 565866
Push 55047 by bmo:sfoster@mozilla.com at Thu, 20 Apr 2017 16:33:51 +0000
Bug 1334642 - Cache luminance values for each toolbar in ToolbarIconColor. r=dao r=mconley * Track window states: active, fullscreen and tabsintitlebar for each window * Use toolbar.id and window state to store and retrieve values from cache * Note: As each window has its own ToolbarIconColor object, the cache is not currently shared across windows * inferFromText callers pass in a reason and associated value, which is used to update the state we track, and potentially clear out the cache * Create new windows test directory for browser-window-specific tests like this * Test for the ToolbarIconColor changes to avoid sync style flushes when windows activate/deactivate MozReview-Commit-ID: JDJ3RtL4Lge
1555ddae7ab9ed5292725bd552d9086c38981853: Bug 1354038 - [push-apk] taskgraph: Use rollout and deactivate dry-run on release r=aki draft
Johan Lorenzo <jlorenzo@mozilla.com> - Thu, 20 Apr 2017 18:21:52 +0200 - rev 565865
Push 55046 by bmo:jlorenzo@mozilla.com at Thu, 20 Apr 2017 16:24:45 +0000
Bug 1354038 - [push-apk] taskgraph: Use rollout and deactivate dry-run on release r=aki MozReview-Commit-ID: 4Rc0Qd5ZI4Z
ef190bd203cfaa3a91e3cc3287e98f3b64aeb71e: Bug 1354116 - add open, save, page setup, print buttons to main hamburger panel, r?mikedeboer draft
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 20 Apr 2017 17:21:26 +0100 - rev 565864
Push 55045 by gijskruitbosch@gmail.com at Thu, 20 Apr 2017 16:21:59 +0000
Bug 1354116 - add open, save, page setup, print buttons to main hamburger panel, r?mikedeboer MozReview-Commit-ID: 7mq4QpsoSPK
e8d00eb5d688c862581fd06edfbb7240b7158030: bug 1357457 - Report non-overlapping Input Responses to Telemetry. r?masayuki data-r=bsmedberg draft
Chris H-C <chutten@mozilla.com> - Wed, 19 Apr 2017 15:53:30 -0400 - rev 565863
Push 55044 by bmo:chutten@mozilla.com at Thu, 20 Apr 2017 16:21:46 +0000
bug 1357457 - Report non-overlapping Input Responses to Telemetry. r?masayuki data-r=bsmedberg Say there's a single lag event, a GC or a busy loop, during which the user types several characters. Is this one (lag) event? Several (input) events? We have INPUT_EVENT_RESPONSE_MS which will accumulate several lagged events in this case. However, that is more of an indication of how users use Firefox than how good we've been at eliminating sources of lag. INPUT_EVENT_RESPONSE_COALESCED_MS records the coalesced time spend waiting for responses to input events. So in this case it will record one value for the entire duration of the lag. MozReview-Commit-ID: H5rYnhwF0q3
0ef44baeecc240a1de77f03f1be1957b52988d1e: bug 1318143 - add support for detecting Visual Studio 2017 to configure. r?gps draft
Ted Mielczarek <ted@mielczarek.org> - Thu, 20 Apr 2017 11:58:49 -0400 - rev 565862
Push 55043 by bmo:ted@mielczarek.org at Thu, 20 Apr 2017 16:20:14 +0000
bug 1318143 - add support for detecting Visual Studio 2017 to configure. r?gps This patch adds a copy of vswhere.exe to build/win32, downloaded from the current latest release (1.0.62): https://github.com/Microsoft/vswhere/releases/download/1.0.62/vswhere.exe It changes toolchain.configure to invoke vswhere.exe instead of reading the registry, since that no longer works for VS2017 (but vswhere can locate VS2015). It also removes a layer of complexity in that code by dropping support for non-64-bit host systems, since we don't really support building on 32-bit Windows anymore anyway. There's a little bit of fixup in windows.configure where some LIB paths have changed in 2017. MozReview-Commit-ID: 5XLWjidS6W4
6a1d52177563739fa07be521841688f412aea62b: Bug 1355331 - Move sidebar to the right edge of the window;r=mikedeboer draft
Brian Grinstead <bgrinstead@mozilla.com> - Thu, 20 Apr 2017 09:18:08 -0700 - rev 565861
Push 55042 by bgrinstead@mozilla.com at Thu, 20 Apr 2017 16:18:15 +0000
Bug 1355331 - Move sidebar to the right edge of the window;r=mikedeboer MozReview-Commit-ID: GTnr6ppleWL
11bddad3b260b4020ac1d862a433349d488b78e8: Bug 1355331 - Move sidebar to the right edge of the window;r=mdeboer draft
Brian Grinstead <bgrinstead@mozilla.com> - Thu, 20 Apr 2017 09:14:09 -0700 - rev 565860
Push 55041 by bgrinstead@mozilla.com at Thu, 20 Apr 2017 16:17:06 +0000
Bug 1355331 - Move sidebar to the right edge of the window;r=mdeboer MozReview-Commit-ID: GTnr6ppleWL
5701cc05398ef22d0a21ae15fee7e29559990d83: Bug 1304605: Part 2. Optimizing NormalizeIPv4. Seems to be 4-6x faster. r?valentin.gosu draft
Milan Sreckovic <milan@mozilla.com> - Thu, 20 Apr 2017 11:17:39 -0400 - rev 565859
Push 55040 by bmo:milan@mozilla.com at Thu, 20 Apr 2017 16:14:14 +0000
Bug 1304605: Part 2. Optimizing NormalizeIPv4. Seems to be 4-6x faster. r?valentin.gosu MozReview-Commit-ID: 5AdXA8bU5TO
a527418dcad48781f415213c945ee5bcc0e69170: Bug 1304605: Part 1. Unit tests, including performance, for NormalizeIPv4. r?valentin.gosu draft
Milan Sreckovic <milan@mozilla.com> - Thu, 20 Apr 2017 10:38:12 -0400 - rev 565858
Push 55040 by bmo:milan@mozilla.com at Thu, 20 Apr 2017 16:14:14 +0000
Bug 1304605: Part 1. Unit tests, including performance, for NormalizeIPv4. r?valentin.gosu MozReview-Commit-ID: KL1eH92YQyo
0892f7ebfe41983793847903b91423211e987575: Bug 1358041 - Hoist some eslint rules from browser/ subdirectories to browser/.eslintrc. r?standard8 draft
Chris Peterson <cpeterson@mozilla.com> - Wed, 19 Apr 2017 16:53:43 -0700 - rev 565857
Push 55039 by cpeterson@mozilla.com at Thu, 20 Apr 2017 16:07:07 +0000
Bug 1358041 - Hoist some eslint rules from browser/ subdirectories to browser/.eslintrc. r?standard8 All of browser/ JS code passes these eslint rules, so we can hoist them from subdirectories' .eslintrc to the common browser/.eslintrc. MozReview-Commit-ID: GMidHq0UIlH
56accf3a83efa1ebd93c7dad8a914bc8580c6640: Bug 1357878 - Maximize window synchronously and restore when maximized; r?maja_zf draft
Andreas Tolfsen <ato@mozilla.com> - Thu, 20 Apr 2017 17:04:58 +0100 - rev 565856
Push 55038 by bmo:ato@mozilla.com at Thu, 20 Apr 2017 16:05:29 +0000
Bug 1357878 - Maximize window synchronously and restore when maximized; r?maja_zf When refactoring the tests for the Set Window Rect command, it was discovered that the Maximize Window command was not synchronous. This patch makes GeckoDriver#maximizeWindow synchronous by waiting for the DOM resize event to fire before returning the window rect to the user. It also aligns the command with the WebDriver standard by making it restore the window to its original size when calling the command a second time. MozReview-Commit-ID: Ft3tn2A4m7u
170a56d46bdc7264a6d08aa1418ad9263f42aa54: Bug 1357878 - Prevent hang on setting window size to existing size; r?maja_zf draft
Andreas Tolfsen <ato@mozilla.com> - Wed, 19 Apr 2017 21:19:36 +0100 - rev 565855
Push 55038 by bmo:ato@mozilla.com at Thu, 20 Apr 2017 16:05:29 +0000
Bug 1357878 - Prevent hang on setting window size to existing size; r?maja_zf When the window's size is being set to the window's existing size, Marionette unconditionally listens for the DOM resize event. When a window is not resized, no such event fires. This patch skips setting the window size when the window's current size is the requested size. This bypasses the problem of listening for an event that never occurs. It also combines the window position- and size tests into a test_window_rect.py test, since they share many of the same characteristics. Fixes: https://github.com/mozilla/geckodriver/issues/643 MozReview-Commit-ID: IUtCFXwT1fh
edbac0b94d67bdb925a2a3fa49c0ab2073bc0fe9: Bug 1121966 - Change DISPLAY_SCALING_<OS> histograms to a single draft
flyingrub <flyinggrub@gmail.com> - Fri, 17 Mar 2017 11:31:10 +0100 - rev 565854
Push 55037 by bmo:flyinggrub@gmail.com at Thu, 20 Apr 2017 15:33:35 +0000
Bug 1121966 - Change DISPLAY_SCALING_<OS> histograms to a single DISPLAY_SCALING Replaced the os specific histograms by a single one. MozReview-Commit-ID: FTwJmxh9sGu
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip