6b7c1986d7ecc870c32e10b44f1a128b41f44c59: Bug 1317880 - Move adjust and thirdparty jars into GECKOVIEW_JARS to fix annotation processing r=sebastian
Andrzej Hunt <ahunt@mozilla.com> - Wed, 16 Nov 2016 15:30:16 +0800 - rev 439706
Push
36064 by rthijssen@mozilla.com at Wed, 16 Nov 2016 13:38:27 +0000
Bug 1317880 - Move adjust and thirdparty jars into GECKOVIEW_JARS to fix annotation processing r=sebastian
GECKOVIEW_JARS contains two Adjust classes (within constants.jar). These depend on the rest of adjust,
which was previously within FENNEC_JARS. Without the remaining adjust jars being on the classpath during
annotation processing for GECKOVIEW_JARS, we are unable to correctly process those Adjust classes
(i.e. we get a NoClassDefFoundError).
The minimal fix is to process adjust as part of GECKOVIEW_JARS. Because adjust depends on HttpClientLib,
we also need to move the relevant jars into GECKOVIEW_JARS too (sync-thirparty contains HttpClientLib).
This will probably require further untangling, this is a minimal patch to allow beta to actually build.
MozReview-Commit-ID: DLtazTrg3hV
163281db1563a70e3e9c15669c67d478d2223991: Bug 1317347 - Fix exception in network monitor for requests coming from iframes added to the hidden window. r=jryans
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 14 Nov 2016 08:21:50 -0800 - rev 439705
Push
36064 by rthijssen@mozilla.com at Wed, 16 Nov 2016 13:38:27 +0000
Bug 1317347 - Fix exception in network monitor for requests coming from iframes added to the hidden window. r=jryans
MozReview-Commit-ID: eRVaHTbyx1
d282d9e8232adadbf9664f2aa2cc18ceeb0b35af: Bug 1317570 - Add a mochitest to test 'ended' fires only once when seeking to the end. r=cpearce
JW Wang <jwwang@mozilla.com> - Tue, 15 Nov 2016 10:41:42 +0800 - rev 439704
Push
36064 by rthijssen@mozilla.com at Wed, 16 Nov 2016 13:38:27 +0000
Bug 1317570 - Add a mochitest to test 'ended' fires only once when seeking to the end. r=cpearce
MozReview-Commit-ID: KRm1shND6lL
1f9d289e8272f27659bf980528b6d89f61f7ac87: Bug 1317576. Part 7 - remove the assertion that doesn't make sense anymore. r=cpearce
JW Wang <jwwang@mozilla.com> - Tue, 15 Nov 2016 15:13:21 +0800 - rev 439703
Push
36064 by rthijssen@mozilla.com at Wed, 16 Nov 2016 13:38:27 +0000
Bug 1317576. Part 7 - remove the assertion that doesn't make sense anymore. r=cpearce
It is possible to call AudioEndTime() in CompletedState::Step() with MedisSink
not started at all. This happens when seeking to the end on a video only file.
MozReview-Commit-ID: 78P72DAPpWI
6f39dfa71498b1398c4a6573dafc0ae3283c0409: Bug 1317576. Part 6 - ensure 'playbackEnded' is notified when seeking to the end on a paused media element. r=cpearce
JW Wang <jwwang@mozilla.com> - Tue, 15 Nov 2016 12:06:17 +0800 - rev 439702
Push
36064 by rthijssen@mozilla.com at Wed, 16 Nov 2016 13:38:27 +0000
Bug 1317576. Part 6 - ensure 'playbackEnded' is notified when seeking to the end on a paused media element. r=cpearce
MozReview-Commit-ID: 4fzru2oHaPV
16b9dfb4ca47b34e41e300b59fc1804a4b20abcc: Bug 1317576. Part 5 - run Step() in CompletedState::Enter() without scheduling an additional cycle. r=cpearce
JW Wang <jwwang@mozilla.com> - Tue, 15 Nov 2016 11:54:52 +0800 - rev 439701
Push
36064 by rthijssen@mozilla.com at Wed, 16 Nov 2016 13:38:27 +0000
Bug 1317576. Part 5 - run Step() in CompletedState::Enter() without scheduling an additional cycle. r=cpearce
MDSM might have reached the end of playback. We want to notify 'playbackEnded' ASAP.
MozReview-Commit-ID: FYI6xTWuNSD
efdc26b14ffa13ea55f3674bb1ba9540b70daf1f: Bug 1317576. Part 4 - remove unused MediaDecoder::SeekResolveValue. r=cpearce
JW Wang <jwwang@mozilla.com> - Mon, 14 Nov 2016 17:00:53 +0800 - rev 439700
Push
36064 by rthijssen@mozilla.com at Wed, 16 Nov 2016 13:38:27 +0000
Bug 1317576. Part 4 - remove unused MediaDecoder::SeekResolveValue. r=cpearce
MozReview-Commit-ID: 9H6e0gFvWeT
8f2dc4f621b57ccf0651b0a5b7db2f11d96685d8: Bug 1317576. Part 3 - remove unused parameter/member. r=cpearce
JW Wang <jwwang@mozilla.com> - Mon, 14 Nov 2016 16:47:07 +0800 - rev 439699
Push
36064 by rthijssen@mozilla.com at Wed, 16 Nov 2016 13:38:27 +0000
Bug 1317576. Part 3 - remove unused parameter/member. r=cpearce
MozReview-Commit-ID: Ff6a8MKVY8q
aafde76b36ae23a0f3772b7743c6d8577621f3a2: Bug 1317576. Part 2 - always transition to DECODING when seek is done. r=cpearce
JW Wang <jwwang@mozilla.com> - Tue, 15 Nov 2016 14:53:50 +0800 - rev 439698
Push
36064 by rthijssen@mozilla.com at Wed, 16 Nov 2016 13:38:27 +0000
Bug 1317576. Part 2 - always transition to DECODING when seek is done. r=cpearce
DecodingState::Enter() will check whether decoding is completed and transition to COMPLETED.
MozReview-Commit-ID: 5abPWWulGWo
860e550daed62b41081d5877039c5f5badce7712: Bug 1317576. Part 1 - add some helper functions. r=cpearce
JW Wang <jwwang@mozilla.com> - Mon, 14 Nov 2016 16:31:48 +0800 - rev 439697
Push
36064 by rthijssen@mozilla.com at Wed, 16 Nov 2016 13:38:27 +0000
Bug 1317576. Part 1 - add some helper functions. r=cpearce
MozReview-Commit-ID: FNWmQohsDRq
b84a197304d6e5e6bcbcefc8c2bbedbc0053f2bd: Bug 1317587 - don't start scheduled sync after shutdown. r=rnewman
Mark Hammond <mhammond@skippinet.com.au> - Tue, 15 Nov 2016 15:28:52 +1100 - rev 439696
Push
36064 by rthijssen@mozilla.com at Wed, 16 Nov 2016 13:38:27 +0000
Bug 1317587 - don't start scheduled sync after shutdown. r=rnewman
MozReview-Commit-ID: GSyWAUa1qyr
5f5e46d71cbf98eb61db0e5e934fd5ed7efc6109: Backed out changeset 21b69215ab80 (bug 1316870) for forthcoming merge conflicts
Phil Ringnalda <philringnalda@gmail.com> - Tue, 15 Nov 2016 19:53:23 -0800 - rev 439695
Push
36064 by rthijssen@mozilla.com at Wed, 16 Nov 2016 13:38:27 +0000
Backed out changeset 21b69215ab80 (
bug 1316870) for forthcoming merge conflicts
399dea6e9200b57cf8ba98cf6c3490d103973652: Bug 1317631 - Post: add more cursor position sanity checks r=sebastian
Andrzej Hunt <ahunt@mozilla.com> - Tue, 15 Nov 2016 17:03:03 +0800 - rev 439694
Push
36064 by rthijssen@mozilla.com at Wed, 16 Nov 2016 13:38:27 +0000
Bug 1317631 - Post: add more cursor position sanity checks r=sebastian
MozReview-Commit-ID: 7CBnLZDkExI
c6f5da9786e92fd3add8a460f3a8dc1c87b55277: Bug 1317631 - Only handle clicks for highlights r=sebastian
Andrzej Hunt <ahunt@mozilla.com> - Tue, 15 Nov 2016 17:01:46 +0800 - rev 439693
Push
36064 by rthijssen@mozilla.com at Wed, 16 Nov 2016 13:38:27 +0000
Bug 1317631 - Only handle clicks for highlights r=sebastian
This avoids us trying to obtain an invalid cursor position, since
the cursor only maps to highlights items (and not the headers).
MozReview-Commit-ID: 1NtJuvDRa5r
004c203d59178a71cf21cb820df9ab84064dc989: Bug 1315391 - Clean up actor destruction after changing to `destroy`. r=ochameau
J. Ryan Stinnett <jryans@gmail.com> - Fri, 11 Nov 2016 18:24:41 -0600 - rev 439692
Push
36064 by rthijssen@mozilla.com at Wed, 16 Nov 2016 13:38:27 +0000
Bug 1315391 - Clean up actor destruction after changing to `destroy`. r=ochameau
The `destroy` method in some actors would throw errors or was incomplete,
leading to various issues closing the toolbox after the previous patch.
This cleans up all such cases noticed through manual testing of the toolbox.
MozReview-Commit-ID: 6EZYFwjSri
44d12580b8c6d216e6afdc44d981378dad03d0b1: Bug 1315391 - Rename all `disconnect` methods to `destroy` in actors. r=ochameau
J. Ryan Stinnett <jryans@gmail.com> - Fri, 11 Nov 2016 18:24:58 -0600 - rev 439691
Push
36064 by rthijssen@mozilla.com at Wed, 16 Nov 2016 13:38:27 +0000
Bug 1315391 - Rename all `disconnect` methods to `destroy` in actors. r=ochameau
Ever since protocol.js was added as a way to create DevTools actors, we've had
lots of confusion about the correct way to implement actor destruction. If your
actor's _parent_ was the legacy kind, you had to use `disconnect`. If it was
protocol.js, you had to use `destroy`.
There is no reason for this madness, which makes reasoning about destruction
quite hard. Here we rename `disconnect` to `destroy` so there is only one name
for every destruction path.
MozReview-Commit-ID: C1Yw9NfUUR2
21b69215ab80c3db3ecf571352ede55413bb052a: Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop
Jared Wein <jwein@mozilla.com> - Tue, 15 Nov 2016 21:09:00 -0500 - rev 439690
Push
36064 by rthijssen@mozilla.com at Wed, 16 Nov 2016 13:38:27 +0000
Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop
MozReview-Commit-ID: 17vLN6W4BVj
935b2ee4256fcbfe9d1fad9221bd4ae3665b7230: Bug 1313788 - Remove DOM/wifi and related code. r=jst
Michelangelo De Simone <mdesimone@mozilla.com> - Tue, 08 Nov 2016 15:02:45 -0800 - rev 439689
Push
36064 by rthijssen@mozilla.com at Wed, 16 Nov 2016 13:38:27 +0000
Bug 1313788 - Remove DOM/wifi and related code. r=jst
MozReview-Commit-ID: BRT6bSvPpT
3e47666dbac8edfd480d8b349d6e630d0c709fde: Bug 1317822 - Move GMPCrashHelper into its own file. r=gerald
Chris Pearce <cpearce@mozilla.com> - Wed, 16 Nov 2016 11:35:36 +1300 - rev 439688
Push
36064 by rthijssen@mozilla.com at Wed, 16 Nov 2016 13:38:27 +0000
Bug 1317822 - Move GMPCrashHelper into its own file. r=gerald
MozReview-Commit-ID: 7CinZ2Y2Fmz
13a9d632e987199ac804ebfcba5678be29179d51: Bug 1317592 - don't try syncing other engines after one fails with a shutdown error. r=rnewman
Mark Hammond <mhammond@skippinet.com.au> - Tue, 15 Nov 2016 16:15:03 +1100 - rev 439687
Push
36064 by rthijssen@mozilla.com at Wed, 16 Nov 2016 13:38:27 +0000
Bug 1317592 - don't try syncing other engines after one fails with a shutdown error. r=rnewman
MozReview-Commit-ID: LZ72JbOtpm4