6a3e1d1984081fbda11e9225ab74ec798537a63e: Bug 1411786 - Use mozilla::Atomic for the recycled size count. r?njn draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 26 Oct 2017 09:51:00 +0900 - rev 686648
Push 86234 by bmo:mh+mozilla@glandium.org at Thu, 26 Oct 2017 05:06:52 +0000
Bug 1411786 - Use mozilla::Atomic for the recycled size count. r?njn
edebf42d73d0e7367d6cc56a03e0ff31bcc913c9: Bug 1411786 - Rename chunk recycling-related globals. r?njn draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 26 Oct 2017 09:43:43 +0900 - rev 686647
Push 86234 by bmo:mh+mozilla@glandium.org at Thu, 26 Oct 2017 05:06:52 +0000
Bug 1411786 - Rename chunk recycling-related globals. r?njn
9ac16f7e3e9eb1cc600edf0bd2f0581e58e46576: Bug 1411786 - Make the chunk size and recycle limit constant. r?njn draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 26 Oct 2017 09:38:48 +0900 - rev 686646
Push 86234 by bmo:mh+mozilla@glandium.org at Thu, 26 Oct 2017 05:06:52 +0000
Bug 1411786 - Make the chunk size and recycle limit constant. r?njn Bug 1403843 made more things constant, but missed a few that don't depend on the page size.
124d2e277a55cb09dc499c5c9c0ce9eb0cc327d0: Bug 1411786 - More tidying of chunk allocation and recycling code. r?njn draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 26 Oct 2017 08:50:49 +0900 - rev 686645
Push 86234 by bmo:mh+mozilla@glandium.org at Thu, 26 Oct 2017 05:06:52 +0000
Bug 1411786 - More tidying of chunk allocation and recycling code. r?njn - Move variable declarations to their initialization. - Remove gotos and use RAII.
5020684d66ccfe6dd3ef4fe0a23403f551146a80: Bug 1411786 - Rename chunk_{recycle,record,alloc,dealloc} arguments. r?njn draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 26 Oct 2017 08:48:18 +0900 - rev 686644
Push 86234 by bmo:mh+mozilla@glandium.org at Thu, 26 Oct 2017 05:06:52 +0000
Bug 1411786 - Rename chunk_{recycle,record,alloc,dealloc} arguments. r?njn Also reformat a few things clang-format left out.
37bf3caa9a0e60f4b50d10992961365411a71761: Bug 1411786 - clang-format chunk_{recycle,record,alloc,dealloc}. r?njn draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 26 Oct 2017 08:36:26 +0900 - rev 686643
Push 86234 by bmo:mh+mozilla@glandium.org at Thu, 26 Oct 2017 05:06:52 +0000
Bug 1411786 - clang-format chunk_{recycle,record,alloc,dealloc}. r?njn
6cb10204ba6a1e1209faa4920038e817b844d943: Bug 1411786 - Use globals for chunk recycling. r?njn draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 26 Oct 2017 08:29:07 +0900 - rev 686642
Push 86234 by bmo:mh+mozilla@glandium.org at Thu, 26 Oct 2017 05:06:52 +0000
Bug 1411786 - Use globals for chunk recycling. r?njn The chunk_recycle and chunk_record functions are never called with different red-black trees than the globals, so just use them directly instead of passing them as argument. The functions were already using the associated global mutex anyways. At the same time, rename them.
b7eae144e1290db3bce111589086dde2c2b5456d: Bug 1411786 - Don't call chunk_recycle for base allocations. r?njn draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 26 Oct 2017 08:24:08 +0900 - rev 686641
Push 86234 by bmo:mh+mozilla@glandium.org at Thu, 26 Oct 2017 05:06:52 +0000
Bug 1411786 - Don't call chunk_recycle for base allocations. r?njn Instead of calling it with a boolean indicating whether the call was for base allocations or not, and return immediately if it was, avoid the call altogether.
886593c39794c7afbd9fe8ef0090f44c45dedb26: Bug 1300900 - Add a helper around jemalloc_ptr_info for debuggers. r?njn draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 25 Oct 2017 08:01:41 +0900 - rev 686640
Push 86234 by bmo:mh+mozilla@glandium.org at Thu, 26 Oct 2017 05:06:52 +0000
Bug 1300900 - Add a helper around jemalloc_ptr_info for debuggers. r?njn jemalloc_ptr_info takes an outparam, which makes it harder to use in a debugger: you'd need to find some memory to use as outparam and pass that in. So for convenience, we add a non-exported symbol for use in debuggers, which just returns a pointer to a static buffer for the result. lldb: (lldb) print *Debug::jemalloc_ptr_info($0) (jemalloc_ptr_info_t) $1 = (tag = TagLiveSmall, addr=0x000000011841dd80, size = 160) gdb: (gdb) print *Debug::jemalloc_ptr_info($0) $1 = {tag = TagLiveSmall, addr = 0x7f8e7ebd0dc0, size = 96} windbg: 0:040> .call Debug::jemalloc_ptr_info(0x6187880) Thread is set up for call, 'g' will execute. WARNING: This can have serious side-effects, including deadlocks and corruption of the debuggee. 0:040> g .call returns: struct jemalloc_ptr_info_t * 0x7501f3f4 +0x000 tag : 1 ( TagLiveSmall ) +0x004 addr : 0x06187880 Void +0x008 size : 0x20
d156c4455bbb6fa2418e7b7ea796c2a9526639e1: Bug 1406715 - Use the RenderFrameParent's content rect as the bounds of the webrender iframe display item. r?kats draft
Markus Stange <mstange@themasta.com> - Sun, 22 Oct 2017 00:48:01 -0400 - rev 686639
Push 86233 by bmo:mstange@themasta.com at Thu, 26 Oct 2017 04:39:49 +0000
Bug 1406715 - Use the RenderFrameParent's content rect as the bounds of the webrender iframe display item. r?kats It was using the visible rect of the display item before, which can be larger than the frame for various reasons. But the bounds we pass for the webrender iframe item determines the iframe's position, so it needs to be informed by the layout position of the frame, not by circumstances of the paint. MozReview-Commit-ID: JSmFGLmAm0h
4421d3085270375a912e2611377ba2299c41d132: Bug 1411825 - Capture browser-screenshots on try without MOZSCREENSHOTS_SETS. r=bgrins draft
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 25 Oct 2017 19:55:45 -0700 - rev 686638
Push 86232 by mozilla@noorenberghe.ca at Thu, 26 Oct 2017 04:38:34 +0000
Bug 1411825 - Capture browser-screenshots on try without MOZSCREENSHOTS_SETS. r=bgrins MozReview-Commit-ID: 5xI6hTVFSXh
6725b54ac153c9cb488e21d09211acc514b9314d: Bug 1411825 - Stop running browser-screenshots for "-u mochitests" and "-u all". r=ahal draft
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 25 Oct 2017 19:39:51 -0700 - rev 686637
Push 86232 by mozilla@noorenberghe.ca at Thu, 26 Oct 2017 04:38:34 +0000
Bug 1411825 - Stop running browser-screenshots for "-u mochitests" and "-u all". r=ahal MozReview-Commit-ID: 1YbPjs85YIx
6d867f842fc011f8e03dc3ac56e967ef405842c7: Bug 1409166 - Check whether the target animating frame is scrolled out of each scrollable ancestor. r?mattwoodrow,birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 26 Oct 2017 13:33:28 +0900 - rev 686636
Push 86231 by hikezoe@mozilla.com at Thu, 26 Oct 2017 04:36:03 +0000
Bug 1409166 - Check whether the target animating frame is scrolled out of each scrollable ancestor. r?mattwoodrow,birtles Before this patch, we had been checking each scrollable ancestor is scrolled out of its scrollable ancestor. So if the target animating frame is at the bottom of its scrollable parent and if half of the scrollable parent is scrolled out of its ancestor, the animating frame was considered as 'in-view'. MozReview-Commit-ID: BDueuF3cT4I
cb048d1f6c10f4718fb32cad8d81ffacb136ed48: Bug 1409166 - Check whether the target animating frame is scrolled out of each scrollable ancestor. r?mattwoodrow,birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 26 Oct 2017 12:45:57 +0900 - rev 686635
Push 86230 by hikezoe@mozilla.com at Thu, 26 Oct 2017 03:50:39 +0000
Bug 1409166 - Check whether the target animating frame is scrolled out of each scrollable ancestor. r?mattwoodrow,birtles Before this patch, we had been checking each scrollable ancestor is scrolled out of its scrollable ancestor. So if the target animating frame is at the bottom of its scrollable parent and if half of the scrollable parent is scrolled out of its ancestor, the animating frame was considered as 'in-view'. MozReview-Commit-ID: BDueuF3cT4I
8abcddf86280fb1fb3ee0986f0bc6c6deccd6df2: Bug 1411318 - Don't consider an animation playing if its timeline is inactive; r?hiro draft
Brian Birtles <birtles@gmail.com> - Thu, 26 Oct 2017 10:18:42 +0900 - rev 686634
Push 86229 by bmo:bbirtles@mozilla.com at Thu, 26 Oct 2017 03:35:15 +0000
Bug 1411318 - Don't consider an animation playing if its timeline is inactive; r?hiro When we receive animations on the compositor, we assert that either they're not playing, or they have a resolved start and origin time. However, on the main thread we determine if an animation is playing by checking if it has a timeline, if it's in the correct state, and if it has a non-zero playback rate. The problem with this check is that if an animation has a timeline but it is inactive, that is, its current time is null, we will not be able to get a resolved origin time -- yet we will still report that is is playing. This patch fixes this mismatch by treating animations with an inactive timeline as "not playing". The IsPlaying() method is used a number of call sites but it appears that they all would expect an animation with an inactive timeline to be considered "not playing". Furthermore, this makes IsPlaying() consistent with the check we do for an active timeline in other functions such as Animation::Tick(), TriggerNow(), SilentlySetCurrentTime(), UpdateFinishedState(), and IsPossibleOrphanedPendingAnimation(). MozReview-Commit-ID: BQOBpHHFMoD
345ae674e2ebaac5e2425323f824182a3923466c: Bug 1411765 - Convert an Incomplete reflow status to OverflowIncomplete also when our size is exactly the available size, not just less. r=mats draft
fantasai <fantasai.cvs@inkedblade.net> - Wed, 25 Oct 2017 14:21:19 -0700 - rev 686633
Push 86228 by bmo:npancholi@mozilla.com at Thu, 26 Oct 2017 03:27:57 +0000
Bug 1411765 - Convert an Incomplete reflow status to OverflowIncomplete also when our size is exactly the available size, not just less. r=mats MozReview-Commit-ID: JikD7p70pJy
3c71880b30a78b95271fb20a7ed11296bf517378: Bug 1411825 - Capture browser-screenshots on try without MOZSCREENSHOTS_SETS. r=bgrins draft
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 25 Oct 2017 19:55:45 -0700 - rev 686632
Push 86227 by mozilla@noorenberghe.ca at Thu, 26 Oct 2017 03:23:25 +0000
Bug 1411825 - Capture browser-screenshots on try without MOZSCREENSHOTS_SETS. r=bgrins MozReview-Commit-ID: 5xI6hTVFSXh
675dc2d06f0ee7a7d4a0dfa36874a258215aba81: Bug 1411825 - Rename mochitest-browser-screenshots test to browser-screenshots to avoid "-u mochitest". r=ahal draft
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 25 Oct 2017 19:39:51 -0700 - rev 686631
Push 86227 by mozilla@noorenberghe.ca at Thu, 26 Oct 2017 03:23:25 +0000
Bug 1411825 - Rename mochitest-browser-screenshots test to browser-screenshots to avoid "-u mochitest". r=ahal MozReview-Commit-ID: 1YbPjs85YIx
0211d26e9e2fd0c26211867217bfca0afead54f1: Bug 1411817: Add do_AddRef overloads for nsCOMPtr<T> and nsRevocableEventPtr<T>. r?froydnj draft
Kris Maglione <maglione.k@gmail.com> - Wed, 25 Oct 2017 19:46:50 -0700 - rev 686630
Push 86226 by maglione.k@gmail.com at Thu, 26 Oct 2017 03:22:13 +0000
Bug 1411817: Add do_AddRef overloads for nsCOMPtr<T> and nsRevocableEventPtr<T>. r?froydnj MozReview-Commit-ID: gEU7whtNHc
2f5bd89c17cb554541be38444672a827c1392f3f: Bug 1409249: Require singleton constructors to return explicit already_AddRefed. r=froydnj draft
Kris Maglione <maglione.k@gmail.com> - Mon, 16 Oct 2017 21:08:42 -0700 - rev 686629
Push 86226 by maglione.k@gmail.com at Thu, 26 Oct 2017 03:22:13 +0000
Bug 1409249: Require singleton constructors to return explicit already_AddRefed. r=froydnj Right now, NS_GENERIC_FACTORY_SINGLETON_CONSTRUCTOR expects singleton constructors to return already-addrefed raw pointers, and while it accepts constructors that return already_AddRefed, most existing don't do so. Meanwhile, the convention elsewhere is that a raw pointer return value is owned by the callee, and that the caller needs to addref it if it wants to keep its own reference to it. The difference in convention makes it easy to leak (I've definitely caused more than one shutdown leak this way), so it would be better if we required the singleton getters to return an explicit already_AddRefed, which would behave the same for all callers. This also cleans up several singleton constructors that left a dangling pointer to their singletons when their initialization methods failed, when they released their references without clearing their global raw pointers. MozReview-Commit-ID: 9peyG4pRYcr
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip