68e32f5b50e77717939fbf4f7a96bda0eaa2561b: Bug 1444554: Add Telemetry scalars for BrowserErrorReporter.jsm. r=Gijs,chutten
Michael Kelly <mkelly@mozilla.com> - Fri, 16 Mar 2018 13:24:39 -0700 - rev 770388
Push
103397 by bmo:gl@mozilla.com at Wed, 21 Mar 2018 05:36:22 +0000
Bug 1444554: Add Telemetry scalars for BrowserErrorReporter.jsm. r=Gijs,chutten
Differential Revision:
https://phabricator.services.mozilla.com/D725
MozReview-Commit-ID: KY90uSslMmb
5c612345552cdf2ffa4b0c127b412b1083e61fb7: Bug 1445009: Tag errors from extensions with isExtensionError. r=Gijs
Michael Kelly <mkelly@mozilla.com> - Mon, 19 Mar 2018 13:40:53 -0700 - rev 770387
Push
103397 by bmo:gl@mozilla.com at Wed, 21 Mar 2018 05:36:22 +0000
Bug 1445009: Tag errors from extensions with isExtensionError. r=Gijs
MozReview-Commit-ID: AQrlvTfJUUS
df318dd1a27e2dc63852224264af3bbf635bc63d: Bug 1445009: Refactor BrowserErrorReporter.jsm and tests. r=Gijs
Michael Kelly <mkelly@mozilla.com> - Mon, 19 Mar 2018 12:41:30 -0700 - rev 770386
Push
103397 by bmo:gl@mozilla.com at Wed, 21 Mar 2018 05:36:22 +0000
Bug 1445009: Refactor BrowserErrorReporter.jsm and tests. r=Gijs
The transforms for turning an nsIScriptError into a payload that Sentry
understands were getting a bit complex for a single function, so they're
refactored into a list of transform functions that are applied in sequence to
produce the payload. This will make it easier to manage adding new transforms to
the list.
Refactoring this revaled a problem with the test code: it assumed that listeners
for console messages were notified in order of registration (since it used a
temporary listener to determine when the rest of the listeners had been notified
of a message). Changing the async evaluation of the code broke the tests, so
they had to be refactored as well.
Without a way to know when all console listeners have been notified, we can't
assert that a message will not be received by BrowserErrorReporter. We do two
things to get around this:
- Where possible, call `observe` directly on the reporter instance.
- Add constructor params for registering and unregistering listeners so we can
test that logic without relying on messages being received or not.
MozReview-Commit-ID: EEH6IROOuHD
5bf16c2dca2275996db533045e1e8b4c3324ba7e: Merge central to inbound. a=merge on a CLOSED TREE
Cosmin Sabou <csabou@mozilla.com> - Wed, 21 Mar 2018 04:06:42 +0200 - rev 770385
Push
103397 by bmo:gl@mozilla.com at Wed, 21 Mar 2018 05:36:22 +0000
Merge central to inbound. a=merge on a CLOSED TREE
daacd9e7fe1cf8726f2f8f1da6aa8bcfcc4c41e4: Bug 1447517: Stop running Windows WebExtensions tests in non-OOP mode. r=mixedpuppy DONTBUILD
Kris Maglione <maglione.k@gmail.com> - Tue, 20 Mar 2018 17:32:47 -0700 - rev 770384
Push
103397 by bmo:gl@mozilla.com at Wed, 21 Mar 2018 05:36:22 +0000
Bug 1447517: Stop running Windows WebExtensions tests in non-OOP mode. r=mixedpuppy DONTBUILD
Now that WebExtensions run OOP in Windows by default, and we have no intention
of going back, there's no need to run an extra set of in-process tests for
them.
MozReview-Commit-ID: t8ryuuNFHe
03e98994cc009311ed83b400a4fefbb91c26d9d3: Bug 1400233 - Remove ContentWebElement.LegacyIdentifier key from Marionette; r?ato
draft
wambui <wambui.dev@gmail.com> - Wed, 21 Mar 2018 07:26:19 +0300 - rev 770383
Push
103396 by bmo:wambui.dev@gmail.com at Wed, 21 Mar 2018 05:10:41 +0000
Bug 1400233 - Remove ContentWebElement.LegacyIdentifier key from Marionette; r?ato
Marionette currently uses the ContentWebElement.Identifier key but also has the legacy key.
The key is removed by making changes to testing/marionette/element.js, testing/marionette/test_element.js
and testing/marionette/client/marionette_driver/marionette.py.
MozReview-Commit-ID: J12uSJikQDY
850220edc3ca03c2efbe247b0bc62a90ec435732: Bug 1444489 - Part VII, Transition the visibility property instead of using transitionend event
draft
Timothy Guan-tin Chien <timdream@gmail.com> - Fri, 16 Mar 2018 06:55:58 +0800 - rev 770382
Push
103395 by timdream@gmail.com at Wed, 21 Mar 2018 04:29:57 +0000
Bug 1444489 - Part VII, Transition the visibility property instead of using transitionend event
Fades out all the UIs by applying CSS transition on opacity and visibility.
Stop relying on transitionend event to set the hidden state.
This removes a source of intermittent failure and while making sure UIs are
hidden.
MozReview-Commit-ID: FR7JQn4eO3X
149a3e3eb344e94a6d7d24df5372ef9bd5ee9499: Bug 1444489 - Part VI, nit: Improve naming consistency in videocontrols.xml
draft
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 14 Mar 2018 13:41:20 +0800 - rev 770381
Push
103395 by timdream@gmail.com at Wed, 21 Mar 2018 04:29:57 +0000
Bug 1444489 - Part VI, nit: Improve naming consistency in videocontrols.xml
Convert all is* methods to getter or rename them if they take arguments.
MozReview-Commit-ID: GOJzz0JYGnq
e56823bbbcb546486420c09356a55bc64338d23f: Bug 1444489 - Part V, Enlarge the size of controls on mobile
draft
Timothy Guan-tin Chien <timdream@gmail.com> - Fri, 09 Mar 2018 17:00:51 -0800 - rev 770380
Push
103395 by timdream@gmail.com at Wed, 21 Mar 2018 04:29:57 +0000
Bug 1444489 - Part V, Enlarge the size of controls on mobile
Enlarge controls by around 1.3x, which is the size of the original touch controls.
MozReview-Commit-ID: kpgFFIW2hh
1dc608b5def890fc2370e22610dd4e98abe485eb: Bug 1444489 - Part IV, Remove XUL videocontrols reflow code on Android
draft
Timothy Guan-tin Chien <timdream@gmail.com> - Mon, 12 Mar 2018 21:39:13 +0800 - rev 770379
Push
103395 by timdream@gmail.com at Wed, 21 Mar 2018 04:29:57 +0000
Bug 1444489 - Part IV, Remove XUL videocontrols reflow code on Android
With all videocontrols UIs implemented in HTML, there is no need to handle
XUL content in videocontrols.
MozReview-Commit-ID: Jq3SecscssO
3ca8aa85bcb4153cdb8a743b669cfbd945d6684f: Bug 1444489 - Part III, Implement Casting UI on videoControls
draft
Timothy Guan-tin Chien <timdream@gmail.com> - Fri, 09 Mar 2018 17:39:44 -0800 - rev 770378
Push
103395 by timdream@gmail.com at Wed, 21 Mar 2018 04:29:57 +0000
Bug 1444489 - Part III, Implement Casting UI on videoControls
Optimize and re-commit the casting buttons SVG removed from the previous commit.
MozReview-Commit-ID: GICxaRZXTiJ
b46d58c929f3fcd62fff242b3c2596a10c8fa334: Bug 1444489 - Part II, Replace touchControls with videoControls and remove touchControls
draft
Timothy Guan-tin Chien <timdream@gmail.com> - Fri, 09 Mar 2018 21:20:52 -0800 - rev 770377
Push
103395 by timdream@gmail.com at Wed, 21 Mar 2018 04:29:57 +0000
Bug 1444489 - Part II, Replace touchControls with videoControls and remove touchControls
Also migrates TouchUtils to videoControls in order to keep some interactions.
Removed the casting button from TouchUtils (to be add back to Utils in the next
commit; not removing the SVG images for hg annotation)
MozReview-Commit-ID: DzhmjykCLzu
7a4ca1798d7df1d0a7a3aa3e515ca3d26c13e2d6: Bug 1444489 - Part I, Convert noControls binding to HTML content
draft
Timothy Guan-tin Chien <timdream@gmail.com> - Mon, 12 Mar 2018 22:30:03 +0800 - rev 770376
Push
103395 by timdream@gmail.com at Wed, 21 Mar 2018 04:29:57 +0000
Bug 1444489 - Part I, Convert noControls binding to HTML content
The noControls binding is bound to <video> without controls on mobile
(see geckoview/content.css), and is only visible when the video is
blocked because of background autoplay.
MozReview-Commit-ID: KZqlQedCjd5
b7805f695d1ea9901fe64db3968e8a5c3e915331: Bug 1442791 - Unbreak ANGLE build on Tier3 after bug 1440849. r?jgilbert
draft
Jan Beich <jbeich@FreeBSD.org> - Sat, 03 Mar 2018 22:20:09 +0000 - rev 770375
Push
103394 by bmo:jbeich@FreeBSD.org at Wed, 21 Mar 2018 04:25:16 +0000
Bug 1442791 - Unbreak ANGLE build on Tier3 after
bug 1440849. r?jgilbert
system_utils* are unused in Gecko, so just build Linux version as a stub.
https://searchfox.org/mozilla-central/search?regexp=true&q=\bGetExecutable%28Path%7CDirectory%29\B
MozReview-Commit-ID: Imu1HGavlVz
30ff2b150715e8aaf860d89be45afebc4e23708e: Bug 1442791 - Unbreak ANGLE build on Tier3 after bug 1440849. r?jgilbert
draft
Jan Beich <jbeich@FreeBSD.org> - Sat, 03 Mar 2018 22:20:09 +0000 - rev 770374
Push
103393 by bmo:jbeich@FreeBSD.org at Wed, 21 Mar 2018 04:17:31 +0000
Bug 1442791 - Unbreak ANGLE build on Tier3 after
bug 1440849. r?jgilbert
system_utils* are unused in Gecko, so just build Linux version as a stub.
https://searchfox.org/mozilla-central/search?regexp=true&q=\bGetExecutable%28Path%7CDirectory%29\B
MozReview-Commit-ID: Imu1HGavlVz
3d21d31141dc5e2d2aff89203458125a3cce6c64: Backed out changeset a760e111f2f1 (bug 1444554) for merge conflicts on browser_BrowserErrorReporter.js and failures after merging to autoland. a=backout
Cosmin Sabou <csabou@mozilla.com> - Wed, 21 Mar 2018 02:51:03 +0200 - rev 770373
Push
103393 by bmo:jbeich@FreeBSD.org at Wed, 21 Mar 2018 04:17:31 +0000
Backed out changeset a760e111f2f1 (
bug 1444554) for merge conflicts on browser_BrowserErrorReporter.js and failures after merging to autoland. a=backout
08ad5a6dd1cad4f8475bcc5f5301808ae2b65bb9: Bug 1446508 - Create test file that makes it easier to add tests for simple policies. r=MattN
draft
Felipe Gomes <felipc@gmail.com> - Wed, 21 Mar 2018 01:12:26 -0300 - rev 770372
Push
103392 by felipc@gmail.com at Wed, 21 Mar 2018 04:12:56 +0000
Bug 1446508 - Create test file that makes it easier to add tests for simple policies. r=MattN
MozReview-Commit-ID: E5Niwsq3cBB
35417378df1b4c349463e5afacbf14b12176ac7f: Bug 1446508 - Track prefs that had their default values changed, and restore them automatically when restarting the policy engine. r=MattN
draft
Felipe Gomes <felipc@gmail.com> - Wed, 21 Mar 2018 01:10:17 -0300 - rev 770371
Push
103392 by felipc@gmail.com at Wed, 21 Mar 2018 04:12:56 +0000
Bug 1446508 - Track prefs that had their default values changed, and restore them automatically when restarting the policy engine. r=MattN
MozReview-Commit-ID: 1pASgMovedA
06f8dc75c01b6623dacdd954fbadc9f85f2fdd7b: Bug 1446508 - Create test file that makes it easier to add tests for simple policies. r=MattN
draft
Felipe Gomes <felipc@gmail.com> - Wed, 21 Mar 2018 01:01:30 -0300 - rev 770370
Push
103391 by felipc@gmail.com at Wed, 21 Mar 2018 04:02:10 +0000
Bug 1446508 - Create test file that makes it easier to add tests for simple policies. r=MattN
MozReview-Commit-ID: AautRIp2Xnj
e470a2567b5f372c606afa00d93cbe02d07ed8d9: Bug 1446508 - Track prefs that had their default values changed, and restore them automatically when restarting the policy engine. r=MattN
draft
Felipe Gomes <felipc@gmail.com> - Wed, 21 Mar 2018 01:01:28 -0300 - rev 770369
Push
103391 by felipc@gmail.com at Wed, 21 Mar 2018 04:02:10 +0000
Bug 1446508 - Track prefs that had their default values changed, and restore them automatically when restarting the policy engine. r=MattN
MozReview-Commit-ID: pM1mTLG6SV