6658264285b6ce0eef36b7d92cb5a40b751f4215: Bug 1476345 - Disable the address form save button when the form is invalid. r=jaws
draft
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 14 Aug 2018 16:32:24 -0700 - rev 829242
Push
118754 by mozilla@noorenberghe.ca at Wed, 15 Aug 2018 01:07:56 +0000
Bug 1476345 - Disable the address form save button when the form is invalid. r=jaws
Tests for this are in the next commit (e.g. test_address_form.html) because this can't be tested properly due to existing tests not filling fields in ways that fire input/change events.
MozReview-Commit-ID: 62CckFP6Ou3
3d45beaaee246d7f08b7f79d6a7fae2958e5c0d0: Bug 1476345 - Fix debugging names and add records with missing required fields. r=jaws
draft
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 24 Jul 2018 22:14:53 -0700 - rev 829241
Push
118754 by mozilla@noorenberghe.ca at Wed, 15 Aug 2018 01:07:56 +0000
Bug 1476345 - Fix debugging names and add records with missing required fields. r=jaws
MozReview-Commit-ID: LaOJMF6GLuZ
15994306413cbf5b878a8a278e2707afde16667a: Bug 1476345 - Fix console listener to not spew when .message doesn't exist. r=jaws
draft
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 14 Aug 2018 16:26:36 -0700 - rev 829240
Push
118754 by mozilla@noorenberghe.ca at Wed, 15 Aug 2018 01:07:56 +0000
Bug 1476345 - Fix console listener to not spew when .message doesn't exist. r=jaws
Sometimes .errorMessage exists without .message
MozReview-Commit-ID: D4zBJKxfJba
dd18de833bde92996a90b55fe70ae8d47d440ed4: Bug 1483408 - Set focus to video element when the media document loads
draft
Timothy Guan-tin Chien <timdream@gmail.com> - Tue, 14 Aug 2018 16:40:11 -0700 - rev 829239
Push
118753 by timdream@gmail.com at Tue, 14 Aug 2018 23:54:14 +0000
Bug 1483408 - Set focus to video element when the media document loads
For some reason we might miss the initial focus event. This ensures the video
element is focused when the document loads.
MozReview-Commit-ID: JiDeMWjit9a
64ae564043411ff18fd659f270ca0e68956734b8: Bug 1476345 - Fix console listener to not spew when .message doesn't exist. r=jaws
draft
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 14 Aug 2018 16:25:18 -0700 - rev 829238
Push
118752 by mozilla@noorenberghe.ca at Tue, 14 Aug 2018 23:26:13 +0000
Bug 1476345 - Fix console listener to not spew when .message doesn't exist. r=jaws
Sometimes .errorMessage exists without .message
MozReview-Commit-ID: D4zBJKxfJba
520e75a9b34c2a9e6f86dcefdc9cbc490734b3db: Bug 1483401 - Fix scrollable area for the payment request page-body. r=jaws
draft
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 14 Aug 2018 16:19:26 -0700 - rev 829237
Push
118752 by mozilla@noorenberghe.ca at Tue, 14 Aug 2018 23:26:13 +0000
Bug 1483401 - Fix scrollable area for the payment request page-body. r=jaws
Differential Revision:
https://phabricator.services.mozilla.com/D3374
MozReview-Commit-ID: C9q3VPKDOXt
d7d33bba9aa921eb77b59d4873ab4c8d9ba9fea9: Bug 1431255 - Part XIII, Make <link> in UA Widget load stylesheets synchronously
draft
Timothy Guan-tin Chien <timdream@gmail.com> - Tue, 07 Aug 2018 11:20:31 -0700 - rev 829236
Push
118751 by timdream@gmail.com at Tue, 14 Aug 2018 22:59:07 +0000
Bug 1431255 - Part XIII, Make <link> in UA Widget load stylesheets synchronously
Set SheetLoadData::mSyncLoad to true when the link element is in a UA Widget.
MozReview-Commit-ID: 2NPSJnL0rKl
cced124a6e88c8a6bb4a0c1b27317a87dd83d3ef: Bug 1431255 - Part XII, Don't set hidden explicitly on animating elements
draft
Timothy Guan-tin Chien <timdream@gmail.com> - Tue, 17 Jul 2018 23:01:00 +0800 - rev 829235
Push
118751 by timdream@gmail.com at Tue, 14 Aug 2018 22:59:07 +0000
Bug 1431255 - Part XII, Don't set hidden explicitly on animating elements
For elements with an animationProp, always set its hidden state from the
startFade() method, so the reverse-direction animation can be correctly
cancelled.
Additionally, considers elements with "fadeout" class as hidden,
so other states can be toggled correctly.
This patch fixes intermittent failures on slower platforms, and perma-orange
on Windows.
MozReview-Commit-ID: KgQXaryEHad
c372ffe446cc1dbb2f57be3ce2500dedaa85846c: Bug 1431255 - Part XI, Remove bogus comments in videocontrols.js
draft
Timothy Guan-tin Chien <timdream@gmail.com> - Fri, 06 Jul 2018 22:39:10 +0800 - rev 829234
Push
118751 by timdream@gmail.com at Tue, 14 Aug 2018 22:59:07 +0000
Bug 1431255 - Part XI, Remove bogus comments in videocontrols.js
Also removing unremoved <xul:slider> properties and workarounds.
MozReview-Commit-ID: 8JrcDyDOBWS
fab5b5533ff034b05f65167d675fa910a2e9c0b6: Bug 1431255 - Part X, Remove XBL workaround in bug 462114
draft
Timothy Guan-tin Chien <timdream@gmail.com> - Fri, 06 Jul 2018 20:51:22 +0800 - rev 829233
Push
118751 by timdream@gmail.com at Tue, 14 Aug 2018 22:59:07 +0000
Bug 1431255 - Part X, Remove XBL workaround in
bug 462114
This is documented throughly in
bug 448909 comment 79.
It is no longer needed for our current setup.
MozReview-Commit-ID: 9XWCqGUYHW4
dbb6bb51df0b9cd23309b33e2e4c9dd96da40881: Bug 1431255 - Part IX, Remove fullscreenchange workaround for bug 718107
draft
Timothy Guan-tin Chien <timdream@gmail.com> - Fri, 06 Jul 2018 18:37:10 +0800 - rev 829232
Push
118751 by timdream@gmail.com at Tue, 14 Aug 2018 22:59:07 +0000
Bug 1431255 - Part IX, Remove fullscreenchange workaround for
bug 718107
Acknowledge the control bar hidden behavior caused by the bug.
Also, set the cursor state before early return, because the video might not
be in the same fullsreen state the last time control bar is hidden/shown.
MozReview-Commit-ID: 3oN3r8dsUvH
4e0d6afe214087a718fc8d7f8359b0819fa85477: Bug 1431255 - Part VIII, Adjust videocontrols tests to test on UA Widget
draft
Timothy Guan-tin Chien <timdream@gmail.com> - Fri, 06 Jul 2018 13:27:12 +0800 - rev 829231
Push
118751 by timdream@gmail.com at Tue, 14 Aug 2018 22:59:07 +0000
Bug 1431255 - Part VIII, Adjust videocontrols tests to test on UA Widget
Duplicates the unchanged tests to xbl dir, ensuring the legacy XBL
videocontrols continue to work.
Opt out of related reftests until we've found a way to load the UA Widget in
reftests. Also opt out of DevTools test until a decision is made on the
representation of UA Widgets in the inspector.
MozReview-Commit-ID: 9sDD7xeuv2H
91e136a4307ee130936f9a72028e6439d3f1c35a: Bug 1431255 - Part VII, Trap mouse/touch/pointer events in audio/video element for UI Widgets
draft
Timothy Guan-tin Chien <timdream@gmail.com> - Thu, 12 Jul 2018 12:32:44 +0800 - rev 829230
Push
118751 by timdream@gmail.com at Tue, 14 Aug 2018 22:59:07 +0000
Bug 1431255 - Part VII, Trap mouse/touch/pointer events in audio/video element for UI Widgets
This is akin to what's done in
bug 1327097.
MozReview-Commit-ID: EERkjrxWZOu
772deae141080a3376c7054f317c28cf8e9e6734: Bug 1431255 - Part VI, Redirect target in ContextMenu.jsm to HTMLMediaElement
draft
Timothy Guan-tin Chien <timdream@gmail.com> - Fri, 06 Jul 2018 13:26:59 +0800 - rev 829229
Push
118751 by timdream@gmail.com at Tue, 14 Aug 2018 22:59:07 +0000
Bug 1431255 - Part VI, Redirect target in ContextMenu.jsm to HTMLMediaElement
Set the referenced node to that of the containing media element so related
menu items will be shown in the context menu.
MozReview-Commit-ID: 4BKlINHmTSb
39006693c5b9dfa57385173e99654c1bb4d3740d: Bug 1431255 - Part V, Set the reflectors of the UA Widget DOM to UA Widget Scope
draft
Timothy Guan-tin Chien <timdream@gmail.com> - Fri, 29 Jun 2018 13:39:46 -0700 - rev 829228
Push
118751 by timdream@gmail.com at Tue, 14 Aug 2018 22:59:07 +0000
Bug 1431255 - Part V, Set the reflectors of the UA Widget DOM to UA Widget Scope
The DOM elements within the UA Widget Shadow DOM should have its reflectors in
the UA Widget Scope. This is done by calling nsINode::IsInUAWidget() which
would check its containing shadow and its UA Widget bit.
To prevent JS access of the DOM element before it is in the
UA Widget Shadom DOM tree, various DOM methods are set to inaccessible to
UA Widget script. It would need to use the two special methods in ShadowRoot
instead to insert the DOM directly into the shadow tree.
MozReview-Commit-ID: Jz9iCaVIoij
ba60d0e8270c76af610a1d55073aa1089db9d211: Bug 1431255 - Part IV, Load videocontrols.js, migrated from videoControls binding
draft
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 27 Jun 2018 11:55:38 -0700 - rev 829227
Push
118751 by timdream@gmail.com at Tue, 14 Aug 2018 22:59:07 +0000
Bug 1431255 - Part IV, Load videocontrols.js, migrated from videoControls binding
videocontrols.js handles the controls attribute with a callback named
"onattributechange" called by UAWidgets, replaces the CSS selectors.
MozReview-Commit-ID: 8rrw0Pbu8Dj
1de4ed1e6272e03ab715c0fbf40f6821631650a1: Bug 1431255 - Part III, Create per-origin sandboxes from XPCJSRuntime and load UA widgets scripts
draft
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 27 Jun 2018 11:34:07 -0700 - rev 829226
Push
118751 by timdream@gmail.com at Tue, 14 Aug 2018 22:59:07 +0000
Bug 1431255 - Part III, Create per-origin sandboxes from XPCJSRuntime and load UA widgets scripts
This patch creates the basic structure on how the widget scripts can be loaded
and be pointed to the Shadow Root, from tab-content.js. This should be
moved to another JSM later so we could reuse it on Fennec.
The UAWidgets class asks for a sandbox from Cu.getUAWidgetScope(), which calls
into XPCJSRuntime::GetUAWidgetScope(). It creates and keeps the sandboxes,
in a GCHashMap keyed to the origin, so we could reuse it if needed.
MozReview-Commit-ID: J6W4PDQWMcN
a25bc4882e8dc21e2d51f00ec1b8e9acaafc3cf6: Bug 1431255 - Part II, Create a Shadow Root in HTMLMediaElement when enabled, skipping <xul:videocontrols>
draft
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 27 Jun 2018 11:12:38 -0700 - rev 829225
Push
118751 by timdream@gmail.com at Tue, 14 Aug 2018 22:59:07 +0000
Bug 1431255 - Part II, Create a Shadow Root in HTMLMediaElement when enabled, skipping <xul:videocontrols>
This prevents XBL binding from being attached, and create the Shadow Root to
host controls to be created by the script.
Shadow Root and the JS controls are lazily constructed when the controls
attribute is set.
Set nsVideoFrame as dynamic-leaf so it will ignore content child frames when
the controls are XBL anonymous content, and handles child frames from controls
in the Shadow DOM. The content nodes are still ignored since there is no
<slot>s in our Shadow DOM.
MozReview-Commit-ID: 3hk41iMa07n
0ab72fa3cf05ef9719b1fd61f678ed8ac0bee616: Bug 1467572 - Part 19: Remove responsive-ua.css. r=rcaliman
draft
Gabriel Luong <gabriel.luong@gmail.com> - Tue, 14 Aug 2018 17:54:55 -0400 - rev 829224
Push
118750 by bmo:gl@mozilla.com at Tue, 14 Aug 2018 21:55:43 +0000
Bug 1467572 - Part 19: Remove responsive-ua.css. r=rcaliman
MozReview-Commit-ID: Fmsyt3mIFLS
51fedae0567e4fe24765681ab881bb76fa3315fc: Bug 1467572 - Part 18: Show an onboarding tooltip for the setting menu button in RDM. r=jdescottes
draft
Gabriel Luong <gabriel.luong@gmail.com> - Tue, 14 Aug 2018 17:54:55 -0400 - rev 829223
Push
118750 by bmo:gl@mozilla.com at Tue, 14 Aug 2018 21:55:43 +0000
Bug 1467572 - Part 18: Show an onboarding tooltip for the setting menu button in RDM. r=jdescottes
Design https://mozilla.invisionapp.com/d/main#/console/12408235/300479943/preview
MozReview-Commit-ID: K1vIjMc685u