64e68f3cb6b98f03c67bd4fe4f085dd4cf27755f: Bug 1278014 part.10 Rename SelectionType::SELECTION_IME_SELECTEDCONVERTEDTEXT to SelectionType::eIMESelectedClause r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 09 Jun 2016 19:29:29 +0900 - rev 377655
Push 20850 by masayuki@d-toybox.com at Sat, 11 Jun 2016 06:51:43 +0000
Bug 1278014 part.10 Rename SelectionType::SELECTION_IME_SELECTEDCONVERTEDTEXT to SelectionType::eIMESelectedClause r?smaug MozReview-Commit-ID: 8v3mqcYorOI
6b1d8664f2d9e1054cf5ccd1d3b2763bba33d620: Bug 1278014 part.9 Rename SelectionType::SELECTION_IME_CONVERTEDTEXT to SelectionType::eIMEConvertedClause r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 09 Jun 2016 19:14:17 +0900 - rev 377654
Push 20850 by masayuki@d-toybox.com at Sat, 11 Jun 2016 06:51:43 +0000
Bug 1278014 part.9 Rename SelectionType::SELECTION_IME_CONVERTEDTEXT to SelectionType::eIMEConvertedClause r?smaug MozReview-Commit-ID: 5UNqhB2ZEcZ
5145503b9f81398dd9206b0fcdc38b32516d94d5: Bug 1278014 part.8 Rename SelectionType::SELECTION_IME_SELECTEDRAWTEXT to SelectionType::eIMESelectedRawClause r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 09 Jun 2016 19:03:40 +0900 - rev 377653
Push 20850 by masayuki@d-toybox.com at Sat, 11 Jun 2016 06:51:43 +0000
Bug 1278014 part.8 Rename SelectionType::SELECTION_IME_SELECTEDRAWTEXT to SelectionType::eIMESelectedRawClause r?smaug MozReview-Commit-ID: DgprOxg87K6
85aace2eb3d5cbdd0f468987a79860f7e8874a0b: Bug 1278014 part.7 Rename SelectionType::SELECTION_IME_RAWINPUT to SelectionType::eIMERawClause r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 09 Jun 2016 18:51:49 +0900 - rev 377652
Push 20850 by masayuki@d-toybox.com at Sat, 11 Jun 2016 06:51:43 +0000
Bug 1278014 part.7 Rename SelectionType::SELECTION_IME_RAWINPUT to SelectionType::eIMERawClause r?smaug MozReview-Commit-ID: BRe10Lyx5mt
ddf076a9c1fe6c00d7404ac6432d0d2bb9e5b1b8: Bug 1278014 part.6 Rename SelectionType::SELECTION_SPELLCHECK to SelectionType::eSpellCheck r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 09 Jun 2016 18:37:36 +0900 - rev 377651
Push 20850 by masayuki@d-toybox.com at Sat, 11 Jun 2016 06:51:43 +0000
Bug 1278014 part.6 Rename SelectionType::SELECTION_SPELLCHECK to SelectionType::eSpellCheck r?smaug MozReview-Commit-ID: 4n2jEVax37O
c9ebef101aab87cc3ddd9132bbf148071dde686a: Bug 1278014 part.5 Rename SelectionType::SELECTION_NORMAL to SelectionType::eNormal r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 09 Jun 2016 18:35:22 +0900 - rev 377650
Push 20850 by masayuki@d-toybox.com at Sat, 11 Jun 2016 06:51:43 +0000
Bug 1278014 part.5 Rename SelectionType::SELECTION_NORMAL to SelectionType::eNormal r?smaug MozReview-Commit-ID: AAdxTTKEvrk
af4076e96f5a3559c8e05e95f6dbfceb7edbc559: Bug 1278014 part.4 Rename SelectionType::SELECTION_NONE to SelectionType::eNone r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 09 Jun 2016 18:07:18 +0900 - rev 377649
Push 20850 by masayuki@d-toybox.com at Sat, 11 Jun 2016 06:51:43 +0000
Bug 1278014 part.4 Rename SelectionType::SELECTION_NONE to SelectionType::eNone r?smaug MozReview-Commit-ID: BRfzs8sColP
dd16a236ffd9fa152f2a985c63c4e7263845a994: Bug 1278014 part.3 Define 2 constants for number of SelectionType and number of SelectionType except "none" r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Sat, 11 Jun 2016 11:12:26 +0900 - rev 377648
Push 20850 by masayuki@d-toybox.com at Sat, 11 Jun 2016 06:51:43 +0000
Bug 1278014 part.3 Define 2 constants for number of SelectionType and number of SelectionType except "none" r?smaug This patch defines two constants kSelectionTypeCount and kPresentSelectionTypeCount. The former is same as nsISelectionController::NUM_SELECTIONTYPES. The latter is kSelectionTypeCount - 1 for excluding SELECTION_NONE. The latter is useful in some loops which handle all selection types except SELECTION_NONE. Note that this patch fixes a bug of nsFrameSelection. That doesn't treat SELECTION_NONE as a selection (see the definition of index), however, it defines redundant item and doesn't use it actually. Additionally, it computes invalid selection type in each loop. Therefore, without this patch, debug build hits MOZ_ASSERT() in ToSelectionType(RawSelectionType). Note that these constants are defined as anonymous enum because we cannot define as const (or static) even with extern. If we'd try to do it, it caused link error or not available in nsFrameSelection.cpp as constant value since they were not initialized if they were initialized in nsSelection.cpp. Therefore, these constants are defined as enum items but using "k" prefix. MozReview-Commit-ID: H6sH7NBEXlE
99021b91157ba83400a4241eebb231a678628b82: Bug 1278014 part.2 Define mozilla::SelectionType as an enum class and use it instead of RawSelectionType as far as possible r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Sat, 11 Jun 2016 11:06:37 +0900 - rev 377647
Push 20850 by masayuki@d-toybox.com at Sat, 11 Jun 2016 06:51:43 +0000
Bug 1278014 part.2 Define mozilla::SelectionType as an enum class and use it instead of RawSelectionType as far as possible r?smaug This patch defines mozilla::SelectionType as an enum class. This is safer than nsISelectionController::SELECTION_* since setting illegal value to its variable is checked at build time. So, as far as possible, this should be used everywhere (but of course, this isn't available in scriptable interfaces). And also this implements some useful methods for managing SelectionType and RawSelectionType which are implemented in layout/nsSelection.cpp because nsISelectionController is implemented by both PresShell and nsTextEditorState. Therefore, implementing one of them may make hard to find them. On the other hand, nsSelection.cpp is a better file name to look for them. Note that this patch creates mozilla::Selection::RawType() for binding. Native code should keep using Selection::Type() but the binding code needs to use RawType() due to impossible to convert from SelectionType to RawSelectionType without explicit cast. MozReview-Commit-ID: 81vX7A0hHQN
9c41a1850cfa78710d721d4b7994159132b8f042: Bug 1278014 part.1 Rename SelectionType in nsISelectionController.idl to mozilla::RawSelectionType r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 07 Jun 2016 22:42:06 +0900 - rev 377646
Push 20850 by masayuki@d-toybox.com at Sat, 11 Jun 2016 06:51:43 +0000
Bug 1278014 part.1 Rename SelectionType in nsISelectionController.idl to mozilla::RawSelectionType r?smaug mozilla::SelectionType will be an enum class. Therefore, we need to rename SelectionType with a word "raw" since it's a type for raw nsISelectionController::SELECTION_*. MozReview-Commit-ID: K8SO0bbpv0Y
aec6ebda33a6d3afc31f5c7c134aacbe3ce90d7f: Bug 1180944 - Implement one-off searches from Awesomebar draft
Drew Willcoxon <adw@mozilla.com> - Fri, 10 Jun 2016 22:55:44 -0700 - rev 377645
Push 20849 by dwillcoxon@mozilla.com at Sat, 11 Jun 2016 05:56:04 +0000
Bug 1180944 - Implement one-off searches from Awesomebar Work in progress. This factors out the one-off code from the browser-search-autocomplete-result-popup binding in search.xml into its own binding and uses it in both the searchbar and awesomebar. The major things left to do are: * Seamless key handling in the awesomebar * Change the one-off UI design to match Stephen's spec? Although I think I'd like to leave that for a follow-up, after we have a single implementation that's used in both places. * Make sure current searchbar one-off tests still work, write new tests for the awesomebar MozReview-Commit-ID: HL37ZXAAnHN
2719065dd5a6045af640e32222b5d4359ae87000: Bug 1252509 - Use a sliding panel overlay from the downloads panel to display the available actions. r=jaws
Drew Willcoxon <adw@mozilla.com> - Fri, 10 Jun 2016 22:08:59 -0700 - rev 377644
Push 20849 by dwillcoxon@mozilla.com at Sat, 11 Jun 2016 05:56:04 +0000
Bug 1252509 - Use a sliding panel overlay from the downloads panel to display the available actions. r=jaws MozReview-Commit-ID: FhRlxcPeWu3
0201cd2703b878af094e95de65087d1f606f4650: Merge m-c to f-t
Phil Ringnalda <philringnalda@gmail.com> - Fri, 10 Jun 2016 18:49:05 -0700 - rev 377643
Push 20849 by dwillcoxon@mozilla.com at Sat, 11 Jun 2016 05:56:04 +0000
Merge m-c to f-t
618a8336136754762b1002f9838fa574ffc60937: Bug 1266478 - Eslint fixes followup;r=me
Brian Grinstead <bgrinstead@mozilla.com> - Fri, 10 Jun 2016 16:51:47 -0700 - rev 377642
Push 20849 by dwillcoxon@mozilla.com at Sat, 11 Jun 2016 05:56:04 +0000
Bug 1266478 - Eslint fixes followup;r=me MozReview-Commit-ID: 2BtKqZ23Qna
fb3a694a5c432916d9414b698efe1ffd0d461db1: Bug 1266478 - Integrate Menu API with inspector;r=pbro
Brian Grinstead <bgrinstead@mozilla.com> - Fri, 10 Jun 2016 15:52:27 -0700 - rev 377641
Push 20849 by dwillcoxon@mozilla.com at Sat, 11 Jun 2016 05:56:04 +0000
Bug 1266478 - Integrate Menu API with inspector;r=pbro This patch converts the inspector's context menu implementation away from directly using XUL menus, and updates a number of tests to match. MozReview-Commit-ID: L8aL23BUmXS
9545df18ca9eaa35915df14e23543c02363ff83e: bug 1265723 - Decouple the MemoryFront from the MemoryActor; r=ejpbruel
Nick Fitzgerald <fitzgen@gmail.com> - Fri, 10 Jun 2016 13:28:15 -0700 - rev 377640
Push 20849 by dwillcoxon@mozilla.com at Sat, 11 Jun 2016 05:56:04 +0000
bug 1265723 - Decouple the MemoryFront from the MemoryActor; r=ejpbruel
ebba00e03483cc04be35248e03f427d227c5dd7d: Bug 1279302 - Decouple the ReflowFront from the ReflowActor; r=ejpbruel
Nick Fitzgerald <fitzgen@gmail.com> - Fri, 10 Jun 2016 13:28:15 -0700 - rev 377639
Push 20849 by dwillcoxon@mozilla.com at Sat, 11 Jun 2016 05:56:04 +0000
Bug 1279302 - Decouple the ReflowFront from the ReflowActor; r=ejpbruel
87accbed30f040029676cd5b8e578d0b6b75fdc1: Bug 1279598 - Fix checkstyle trailing space issues r=me
Andrzej Hunt <ahunt@mozilla.com> - Fri, 10 Jun 2016 12:26:32 -0700 - rev 377638
Push 20849 by dwillcoxon@mozilla.com at Sat, 11 Jun 2016 05:56:04 +0000
Bug 1279598 - Fix checkstyle trailing space issues r=me
0cdadfe2548071a155138fa486b7ed7753f68bee: Disable browser_CaptivePortalWatcher.js on Windows for intermittent failures (bug 1279491). r=bustage
Panos Astithas <past@mozilla.com> - Fri, 10 Jun 2016 20:26:59 +0300 - rev 377637
Push 20849 by dwillcoxon@mozilla.com at Sat, 11 Jun 2016 05:56:04 +0000
Disable browser_CaptivePortalWatcher.js on Windows for intermittent failures (bug 1279491). r=bustage MozReview-Commit-ID: LXYKoIq1OfU
52b012fa432c0b10381dcd168a766e49d4e5ac2a: Bug 1279441 - fix HTMLTooltip closing after click on inner iframe;r=bgrins
Julian Descottes <jdescottes@mozilla.com> - Fri, 10 Jun 2016 11:24:04 +0200 - rev 377636
Push 20849 by dwillcoxon@mozilla.com at Sat, 11 Jun 2016 05:56:04 +0000
Bug 1279441 - fix HTMLTooltip closing after click on inner iframe;r=bgrins MozReview-Commit-ID: EggheTpU2y3
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip