6465253a72d37dc1dcc79fbda0692f39471eedc5: Bug 1332633 - Part 2: Implement FFI for compute distance. draft
Boris Chiou <boris.chiou@gmail.com> - Tue, 21 Mar 2017 14:24:23 +0800 - rev 565609
Push 54918 by bmo:boris.chiou@gmail.com at Thu, 20 Apr 2017 03:16:15 +0000
Bug 1332633 - Part 2: Implement FFI for compute distance. This FFI will be used by nsDOMWindowUtils::ComputeAnimationDistance, which will be implemented in another bug. MozReview-Commit-ID: G3aYICDnCLA
714b42fafd94a104a7b262d4a47caa6262d26847: Bug 1332633 - Part 1: Implement ComputeDistance trait. draft
Boris Chiou <boris.chiou@gmail.com> - Sat, 18 Mar 2017 19:47:04 +0800 - rev 565608
Push 54918 by bmo:boris.chiou@gmail.com at Thu, 20 Apr 2017 03:16:15 +0000
Bug 1332633 - Part 1: Implement ComputeDistance trait. Introduce ComputeDistance trait, which implement compute_distance and compute_squared_distance. For vector, compute_squared_distance is necessary because we use Euclidean distance as the distance between two values. The easier way to implement compute_squared_distance is to square the result from compute_distance, but for some property values, they may have many components, e.g. (v1, v2, v3). If we just square the result from compute_distance, the computation is (sqrt(v1^2 + v2^2 + v3^2))^2. There are two redundant operators: "square-root" and then "square". In order to avoid this, we should implement compute_squared_distance separately for these types. MozReview-Commit-ID: LmmrUXYlDb6
6c88a749721ace488e2143e459a75242f157d7cc: Bug 1353523 - Add adjustable threshold value for VR controller trigger inputs; r?kip draft
Daosheng Mu <daoshengmu@gmail.com> - Wed, 19 Apr 2017 13:14:13 +0800 - rev 565607
Push 54917 by bmo:dmu@mozilla.com at Thu, 20 Apr 2017 03:11:22 +0000
Bug 1353523 - Add adjustable threshold value for VR controller trigger inputs; r?kip MozReview-Commit-ID: KQMccZeE2IK
d475b4dfdfcf98b3c54dde37eb9c7589dbf15f00: Bug 1332633 - Part 2: Implement FFI for compute distance. draft
Boris Chiou <boris.chiou@gmail.com> - Tue, 21 Mar 2017 14:24:23 +0800 - rev 565606
Push 54916 by bmo:boris.chiou@gmail.com at Thu, 20 Apr 2017 03:06:35 +0000
Bug 1332633 - Part 2: Implement FFI for compute distance. This FFI will be used by nsDOMWindowUtils::ComputeAnimationDistance, which will be implemented in another bug. MozReview-Commit-ID: G3aYICDnCLA
c0ca97f8319f3ff73b9bbabe640926dcdc1e15d2: Bug 1332633 - Part 1: Implement ComputeDistance trait. draft
Boris Chiou <boris.chiou@gmail.com> - Sat, 18 Mar 2017 19:47:04 +0800 - rev 565605
Push 54916 by bmo:boris.chiou@gmail.com at Thu, 20 Apr 2017 03:06:35 +0000
Bug 1332633 - Part 1: Implement ComputeDistance trait. Introduce ComputeDistance trait, which implement compute_distance and compute_squared_distance. For vector, compute_squared_distance is necessary because we use Euclidean distance as the distance between two values. The easier way to implement compute_squared_distance is to square the result from compute_distance, but for some property values, they may have many components, e.g. (v1, v2, v3). If we just square the result from compute_distance, the computation is (sqrt(v1^2 + v2^2 + v3^2))^2. There are two redundant operators: "square-root" and then "square". In order to avoid this, we should implement compute_squared_distance separately for these types. MozReview-Commit-ID: LmmrUXYlDb6
56ccde5ab392b67a49b05729fa3db44229f06e71: Bug 1356530 - Change the type of MediaData::mTime to TimeUnit since int64_t is ambiguous. draft
JW Wang <jwwang@mozilla.com> - Fri, 14 Apr 2017 17:13:36 +0800 - rev 565604
Push 54915 by jwwang@mozilla.com at Thu, 20 Apr 2017 03:04:37 +0000
Bug 1356530 - Change the type of MediaData::mTime to TimeUnit since int64_t is ambiguous. MozReview-Commit-ID: 4bVeqIuWO2O
cc0a6010d1f673149c31198548ee455beb038dbe: Bug 1331742 - Part 5 - Add unit tests for browserAction.onClicked r?mixedpuppy draft
Matthew Wein <mwein@mozilla.com> - Mon, 10 Apr 2017 16:15:54 -0400 - rev 565603
Push 54914 by mwein@mozilla.com at Thu, 20 Apr 2017 03:01:40 +0000
Bug 1331742 - Part 5 - Add unit tests for browserAction.onClicked r?mixedpuppy MozReview-Commit-ID: Ko8eQYfIM0H
9e644d6b7cb97a5c601f94841900e00a48a6b427: Bug 1331742 - Part 4 - Add a position property to keep track of the menu item's position instead of using the ID r?sebastian draft
Matthew Wein <mwein@mozilla.com> - Sat, 25 Mar 2017 22:35:54 -0700 - rev 565602
Push 54914 by mwein@mozilla.com at Thu, 20 Apr 2017 03:01:40 +0000
Bug 1331742 - Part 4 - Add a position property to keep track of the menu item's position instead of using the ID r?sebastian MozReview-Commit-ID: 7ZtfaVQFhKX
2808dba2ece79d5f47c621dbaa4378becfb2b501: Bug 1331742 - Part 3 - Create and register ext-browserAction.js r?mixedpuppy draft
Matthew Wein <mwein@mozilla.com> - Wed, 19 Apr 2017 21:44:41 -0400 - rev 565601
Push 54914 by mwein@mozilla.com at Thu, 20 Apr 2017 03:01:40 +0000
Bug 1331742 - Part 3 - Create and register ext-browserAction.js r?mixedpuppy MozReview-Commit-ID: CGR4689b6oo
d4aa430ca90fd7d7b7ae2cf93b3ca0bd09de7753: Bug 1331742 - Part 2 - Create a module for managing browser actions similar to PageActions.jsm r?sebastian draft
Matthew Wein <mwein@mozilla.com> - Sat, 25 Mar 2017 22:36:05 -0700 - rev 565600
Push 54914 by mwein@mozilla.com at Thu, 20 Apr 2017 03:01:40 +0000
Bug 1331742 - Part 2 - Create a module for managing browser actions similar to PageActions.jsm r?sebastian MozReview-Commit-ID: 2epdMD75e84
552c4727e7d2128e0fb66387f01aabef206cdd77: Bug 1331742 - Part 1 - Create and register browser_action.json r?mixedpuppy draft
Matthew Wein <mwein@mozilla.com> - Wed, 15 Mar 2017 21:02:56 -0400 - rev 565599
Push 54914 by mwein@mozilla.com at Thu, 20 Apr 2017 03:01:40 +0000
Bug 1331742 - Part 1 - Create and register browser_action.json r?mixedpuppy MozReview-Commit-ID: AwYuTDU3Ki4
ffbb175ffad0191ffb8ff6cf108d79afe6583ea8: Bug 1355427 - Part 3: stylo: Update test expectations; r?heycam draft
Manish Goregaokar <manishearth@gmail.com> - Thu, 13 Apr 2017 13:25:01 +0800 - rev 565598
Push 54913 by bmo:manishearth@gmail.com at Thu, 20 Apr 2017 02:57:45 +0000
Bug 1355427 - Part 3: stylo: Update test expectations; r?heycam MozReview-Commit-ID: EACZDmSxGCE
5f9bac0e840c67c8ccfaa38751315147ab96d501: Bug 1355427 - Part 3: stylo: Update test expectations; r?heycam draft
Manish Goregaokar <manishearth@gmail.com> - Thu, 13 Apr 2017 13:25:01 +0800 - rev 565597
Push 54912 by bmo:manishearth@gmail.com at Thu, 20 Apr 2017 02:56:39 +0000
Bug 1355427 - Part 3: stylo: Update test expectations; r?heycam MozReview-Commit-ID: EACZDmSxGCE
748aed5f8abd0b13a0a14a940cf14540f0787073: Bug 1355427 - Part 2: stylo: Support scriptlevel computation and scriptminsize; r?heycam draft
Manish Goregaokar <manishearth@gmail.com> - Thu, 13 Apr 2017 13:25:01 +0800 - rev 565596
Push 54911 by bmo:manishearth@gmail.com at Thu, 20 Apr 2017 02:52:48 +0000
Bug 1355427 - Part 2: stylo: Support scriptlevel computation and scriptminsize; r?heycam scriptlevel is a property that affects how font-size is inherited. If scriptlevel is +1, for example, it will inherit as the script size multiplier times the parent font. This does not affect cases where the font-size is explicitly set. However, this transformation is not allowed to reduce the size below scriptminsize. If this inheritance will reduce it to below scriptminsize, it will be set to scriptminsize or the parent size, whichever is smaller (the parent size could be smaller than the min size because it was explicitly specified). Now, within a node that has inherited a font-size which was crossing scriptminsize once the scriptlevel was applied, a negative scriptlevel may be used to increase the size again. This should work, however if we have already been capped by the scriptminsize multiple times, this can lead to a jump in the size. For example, if we have text of the form: huge large medium small tiny reallytiny tiny small medium huge which is represented by progressive nesting and scriptlevel values of +1 till the center after which the scriptlevel is -1, the "tiny"s should be the same size, as should be the "small"s and "medium"s, etc. However, if scriptminsize kicked it at around "medium", then medium/tiny/reallytiny will all be the same size (the min size). A -1 scriptlevel change after this will increase the min size by the multiplier, making the second tiny larger than medium. Instead, we wish for the second "tiny" to still be capped by the script level, and when we reach the second "large", it should be the same size as the original one. We do this by cascading two separate font sizes. The font size (mSize) is the actual displayed font size. The unconstrained font size (mScriptUnconstrainedSize) is the font size in the situation where scriptminsize never applied. We calculate the proposed inherited font size based on scriptlevel and the parent unconstrained size, instead of using the parent font size. This is stored in the node's unconstrained size and will also be stored in the font size provided that it is above the min size. All of this only applies when inheriting. When the font size is manually set, scriptminsize does not apply, and both the real and unconstrained size are set to the explicit value. However, if the font size is manually set to an em or percent unit, the unconstrained size will be set to the value of that unit computed against the parent unconstrained size, whereas the font size will be set computing against the parent font size. MozReview-Commit-ID: 820BIWqno3L
5f28ce3d9e82e512ef9bbc1dd0156ce44ff91a86: Bug 1356305 - stylo: Initialize system metrics before traversing; r?bholley r?sfink draft
Manish Goregaokar <manishearth@gmail.com> - Fri, 14 Apr 2017 09:28:25 +0800 - rev 565595
Push 54910 by bmo:manishearth@gmail.com at Thu, 20 Apr 2017 02:52:33 +0000
Bug 1356305 - stylo: Initialize system metrics before traversing; r?bholley r?sfink MozReview-Commit-ID: IOeT4qSHTy5
7471f7632b527226ecdf7259786df1415d1d92a5: Bug 1332633 - Part 2: Implement FFI for compute distance. draft
Boris Chiou <boris.chiou@gmail.com> - Tue, 21 Mar 2017 14:24:23 +0800 - rev 565594
Push 54909 by bmo:boris.chiou@gmail.com at Thu, 20 Apr 2017 02:50:04 +0000
Bug 1332633 - Part 2: Implement FFI for compute distance. This FFI will be used by nsDOMWindowUtils::ComputeAnimationDistance, which will be implemented in another bug. MozReview-Commit-ID: G3aYICDnCLA
72bfe46abfcb52a44d4b3a00a6a66cd7ce06724c: Bug 1332633 - Part 1: Implement ComputeDistance trait. draft
Boris Chiou <boris.chiou@gmail.com> - Sat, 18 Mar 2017 19:47:04 +0800 - rev 565593
Push 54909 by bmo:boris.chiou@gmail.com at Thu, 20 Apr 2017 02:50:04 +0000
Bug 1332633 - Part 1: Implement ComputeDistance trait. Introduce ComputeDistance trait, which implement compute_distance and compute_squared_distance. For vector, compute_squared_distance is necessary because we use Euclidean distance as the distance between two values. The easier way to implement compute_squared_distance is to square the result from compute_distance, but for some property values, they may have many components, e.g. (v1, v2, v3). If we just square the result from compute_distance, the computation is (sqrt(v1^2 + v2^2 + v3^2))^2. There are two redundant operators: "square-root" and then "square". In order to avoid this, we should implement compute_squared_distance separately for these types. MozReview-Commit-ID: LmmrUXYlDb6
f03fba7dd02665f30d8b1bd292acd2311b02242a: Bug 1356305 - stylo: Initialize system metrics with the style system; r?bholley r?sfink draft
Manish Goregaokar <manishearth@gmail.com> - Fri, 14 Apr 2017 09:28:25 +0800 - rev 565592
Push 54908 by bmo:manishearth@gmail.com at Thu, 20 Apr 2017 02:45:46 +0000
Bug 1356305 - stylo: Initialize system metrics with the style system; r?bholley r?sfink MozReview-Commit-ID: IOeT4qSHTy5
0828c458ca240f178f8fa6ca2c7e1bbf18a5df38: Bug 1356452 - Part 6: Simplfying fire events to global window listeners in GamepadManager: r?lenzak draft
Daosheng Mu <daoshengmu@gmail.com> - Thu, 20 Apr 2017 10:27:19 +0800 - rev 565591
Push 54907 by bmo:dmu@mozilla.com at Thu, 20 Apr 2017 02:43:33 +0000
Bug 1356452 - Part 6: Simplfying fire events to global window listeners in GamepadManager: r?lenzak MozReview-Commit-ID: FLQyVAARwK1
52491f1927a86789231f238ffa9b236a47006467: Bug 1356452 - Part 5: Detect hand changing at runtime for OpenVR controllers; r?kip draft
Daosheng Mu <daoshengmu@gmail.com> - Tue, 18 Apr 2017 15:58:34 +0800 - rev 565590
Push 54907 by bmo:dmu@mozilla.com at Thu, 20 Apr 2017 02:43:33 +0000
Bug 1356452 - Part 5: Detect hand changing at runtime for OpenVR controllers; r?kip MozReview-Commit-ID: AR5zpxryIw6