606b6857c9a47628cc257e0bdfab89e6d6b966c9: Bug 1467743 - [marionette] Handle errors for nested promise in dispatchPointerMove. r=ato, a=test-only
Henrik Skupin <mail@hskupin.info> - Fri, 08 Jun 2018 13:11:30 +0200 - rev 810174
Push 113918 by bmo:jacek@codeweavers.com at Mon, 25 Jun 2018 14:21:39 +0000
Bug 1467743 - [marionette] Handle errors for nested promise in dispatchPointerMove. r=ato, a=test-only Because the nested promise doesn't use the "catch()" method a possible raised error by its code is not handled, and will cause the outer promise never to resolve, which results in an infinite hang. MozReview-Commit-ID: 1MFyKpmOjYz
726e50cb332d92f6ee315bb6733df0d395bb564a: Bug 1466387 - Set up the gray root tracer on worker thread. r=jonco, a=RyanVM
Steve Fink <sfink@mozilla.com> - Tue, 05 Jun 2018 16:03:36 -0700 - rev 810173
Push 113918 by bmo:jacek@codeweavers.com at Mon, 25 Jun 2018 14:21:39 +0000
Bug 1466387 - Set up the gray root tracer on worker thread. r=jonco, a=RyanVM
3f8c13e5e03e5a147d68119b9efb334c25327584: Bug 1466606 - Calculate the current GetSample index when needed. r=bryce, a=RyanVM
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 06 Jun 2018 15:14:24 +0200 - rev 810172
Push 113918 by bmo:jacek@codeweavers.com at Mon, 25 Jun 2018 14:21:39 +0000
Bug 1466606 - Calculate the current GetSample index when needed. r=bryce, a=RyanVM The assumption that when calling GetNextRandomAccessPoint the next GetSample index would always be known was incorrect. It assumed that the call to GetNextRandomAccessPoint would always be preceded by a call to GetSample. This is not always how the MediaSourceDemuxer called it. MozReview-Commit-ID: H1MyPpDEytk
14a7aa94151de0f29f92e008ef37f89511633d70: Bug 1401883 - Don't hold unnecessary references to the Windows app shell. r=jimm, a=RyanVM
Ting-Yu Chou <janus926@gmail.com> - Wed, 06 Jun 2018 11:05:18 -0400 - rev 810171
Push 113918 by bmo:jacek@codeweavers.com at Mon, 25 Jun 2018 14:21:39 +0000
Bug 1401883 - Don't hold unnecessary references to the Windows app shell. r=jimm, a=RyanVM When runnables are posted to the main thread's event loop, the event loop notifies any thread observers that this has been done. The app shell registers itself as just such a runnable, and posts messages to the native event loop that processing native events needs to be done. On Windows, this posting takes an extra reference to the app shell, to keep it alive until the message is processed by the native event loop, since app shell code needs to be invoked during that processing. The processing releases this extra reference, so everything stays balanced. Except that it's possible for messages to be posted to the native event loop, and then browser shutdown happens. Those messages are not processed and the associated references taken are not released. This imbalance means that in debug builds, we appear to be leaking the app shell, and that leaking results in intermittent oranges. This intermittent orange has manifested itself in a variety of ways over the years, depending on how big the app shell itself was (since that changes the number of bytes leaked) and how many leak-checked things the app shell was holding on to. This bug is merely the latest manifestation; the last serious work on analyzing the phenomenon and fixing it was done in bug 1220517. The solution proposed in that bug was that we simply stop the extra reference counting; when the app shell is destroyed normally, we shouldn't be processing the native event loop any more anyway. So even if the native event loop is holding (freed) pointers to the app shell, we'd never execute the callback and perform a use-after-free. Reading through the code suggests that this *ought* to be the case, but the potential for shooting ourselves in the foot seems awfully high. In any event, this is not a problem unique to Windows; we have seen this same sort of thing happen on OS X. See nsAppShell::ProcessGeckoEvents in widget/cocoa/nsAppShell.mm. Here we propose a slightly different solution: we keep track of the number of native event callbacks we have scheduled, incrementing when we schedule, and decrementing when we actually run one. When the app shell is destroyed, we simply set the number of outstanding events to zero, and we prohibit the callback from accessing the app shell if there are no outstanding events. This solution is analogous to dropping the extra reference counting, but avoids potential badness if we do wind up processing native events after the app shell is destroyed.
e3a1391a1ae0496007159264fad8a40e05f75dca: Bug 1461619 - Don't update atoms marking bitmaps in parallel due to potential races. r=sfink, a=RyanVM
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 04 Jun 2018 11:18:27 +0100 - rev 810170
Push 113918 by bmo:jacek@codeweavers.com at Mon, 25 Jun 2018 14:21:39 +0000
Bug 1461619 - Don't update atoms marking bitmaps in parallel due to potential races. r=sfink, a=RyanVM
f620aed6dc0d8358e6936d6d310295fb8c5ee303: Bug 1456652 - Use triggering principal when leaving reader mode. r=mgoodwin, a=RyanVM
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 26 Apr 2018 12:30:34 +0100 - rev 810169
Push 113918 by bmo:jacek@codeweavers.com at Mon, 25 Jun 2018 14:21:39 +0000
Bug 1456652 - Use triggering principal when leaving reader mode. r=mgoodwin, a=RyanVM
9875e9b3e0ca4f5846247f16feacec2b50e52ca5: Bug 1467938 - Fix out-of-bounds memory access in WebRTC VP9 Missing Frame Processing. r=ng, a=RyanVM
Nils Ohlmeier [:drno] <drno@ohlmeier.org> - Fri, 08 Jun 2018 19:49:40 -0700 - rev 810168
Push 113918 by bmo:jacek@codeweavers.com at Mon, 25 Jun 2018 14:21:39 +0000
Bug 1467938 - Fix out-of-bounds memory access in WebRTC VP9 Missing Frame Processing. r=ng, a=RyanVM
123bd919d459bf2c4f9921a584e44578b8b8272d: Bug 1464084 - Don't export std::thread::_M_start_thread symbols with --enable-stdcxx-compat. r=froydnj, a=RyanVM
Mike Hommey <mh+mozilla@glandium.org> - Fri, 01 Jun 2018 08:10:25 +0900 - rev 810167
Push 113918 by bmo:jacek@codeweavers.com at Mon, 25 Jun 2018 14:21:39 +0000
Bug 1464084 - Don't export std::thread::_M_start_thread symbols with --enable-stdcxx-compat. r=froydnj, a=RyanVM This relies on the fact that providing multiple --version-script combines them all, so we effectively create a new symbol version that has no global symbol, but hides the std::thread::_M_start_thread symbols. This version script trick happens to work with BFD ld, gold, and lld. The downside is that when providing multiple --version-script's, ld doesn't want any of them to have no version at all. So for the libraries that do already have a version script (through SYMBOLS_FILE), we use a version where there used to be none, using the library name as the version. Practically speaking, this binds the libraries a little closer than they used to be, kind of non-flat namespace on OSX (which is the default there), meaning the dynamic linker will actively want to use symbols from those libraries instead of a system library that might happen to have the same symbol name.
7d96e64a45748da951ebcb6a30d99b7156494bec: Bug 1467462 - Adjust test_developer_options after bug 1467041. r=froydnj, a=RyanVM
Mike Hommey <mh+mozilla@glandium.org> - Fri, 08 Jun 2018 07:11:42 +0900 - rev 810166
Push 113918 by bmo:jacek@codeweavers.com at Mon, 25 Jun 2018 14:21:39 +0000
Bug 1467462 - Adjust test_developer_options after bug 1467041. r=froydnj, a=RyanVM Bug 1467041 changed the default for --enable-release such that it is affected by the milestone. Test both possible cases for milestones.
100458d997b97d2d85e6d5855dfc5ecedc76c923: Bug 1467041 - Default to --enable-release when milestone is beta/release. r=froydnj, a=RyanVM
Mike Hommey <mh+mozilla@glandium.org> - Wed, 06 Jun 2018 16:13:09 +0900 - rev 810165
Push 113918 by bmo:jacek@codeweavers.com at Mon, 25 Jun 2018 14:21:39 +0000
Bug 1467041 - Default to --enable-release when milestone is beta/release. r=froydnj, a=RyanVM --enable-release not being passed means developer options are enabled, which is generally speaking not desirable for builds meant to be shipped. This is somewhat alleviated for Firefox by MOZILLA_OFFICIAL implying --enable-release (as well as MOZ_AUTOMATION), but that doesn't apply to e.g. standalone js builds (even some of the standalone js jobs on our automation don't set MOZ_AUTOMATION for some reason). A reasonable thing to do is just to default builds for release/beta milestones to --enable-release, but still allow --disable-release to enable the developer options.
25ae084a7fc71cc2079b0dde0ad818666d5931ca: Bug 1411908 - Part 2: Wait for all factory operations to finish when shutting down. r=asuth, a=RyanVM
Jan Varga <jan.varga@gmail.com> - Fri, 04 May 2018 06:32:23 +0200 - rev 810164
Push 113918 by bmo:jacek@codeweavers.com at Mon, 25 Jun 2018 14:21:39 +0000
Bug 1411908 - Part 2: Wait for all factory operations to finish when shutting down. r=asuth, a=RyanVM
5c3a2242b2744a4a1f2c19ceb51a248d256cba33: Bug 1411908 - Part 1: Wait for all live database objects to finish when shutting down. r=asuth, a=RyanVM
Jan Varga <jan.varga@gmail.com> - Fri, 04 May 2018 06:32:11 +0200 - rev 810163
Push 113918 by bmo:jacek@codeweavers.com at Mon, 25 Jun 2018 14:21:39 +0000
Bug 1411908 - Part 1: Wait for all live database objects to finish when shutting down. r=asuth, a=RyanVM
9bdbe902cb7ecfec9dac7f2c27bf5c58e77d35f0: Bug 1467924 - Correctly calculate add-on install location at startup. r=aswan, a=RyanVM
Kris Maglione <maglione.k@gmail.com> - Fri, 08 Jun 2018 15:18:41 -0700 - rev 810162
Push 113918 by bmo:jacek@codeweavers.com at Mon, 25 Jun 2018 14:21:39 +0000
Bug 1467924 - Correctly calculate add-on install location at startup. r=aswan, a=RyanVM MozReview-Commit-ID: 2Hl3be03ovA
eed4d71dbb8d08f604bc4b8788bbcedd2185cc29: Backed out changeset 74c9ff1f6b3c (bug 1463786) for bustage.
Ryan VanderMeulen <ryanvm@gmail.com> - Fri, 08 Jun 2018 15:46:05 -0400 - rev 810161
Push 113918 by bmo:jacek@codeweavers.com at Mon, 25 Jun 2018 14:21:39 +0000
Backed out changeset 74c9ff1f6b3c (bug 1463786) for bustage.
4461cd174c66424fb7da115812a933e73a9a01ee: Backed out changeset 1248809b8616 (bug 1413868) for bustage.
Ryan VanderMeulen <ryanvm@gmail.com> - Fri, 08 Jun 2018 15:45:59 -0400 - rev 810160
Push 113918 by bmo:jacek@codeweavers.com at Mon, 25 Jun 2018 14:21:39 +0000
Backed out changeset 1248809b8616 (bug 1413868) for bustage.
6c4ecbb0e0dca9f5474bfc19e3cf943be987e196: Bug 1464461 - implement unix style syntax for console commands; r=ochameau, nchevobbe draft
yulia <ystartsev@mozilla.com> - Tue, 05 Jun 2018 17:27:07 +0200 - rev 810159
Push 113917 by bmo:ystartsev@mozilla.com at Mon, 25 Jun 2018 13:52:38 +0000
Bug 1464461 - implement unix style syntax for console commands; r=ochameau, nchevobbe MozReview-Commit-ID: 8rQ9IQdsZkm
070d33dd4d436d04665d6f883b5e4e2587e52ad3: Bug 1464461 - implement screenshot command in console panel; r=ochameau, nchevobbe draft
yulia <ystartsev@mozilla.com> - Mon, 04 Jun 2018 17:46:48 +0200 - rev 810158
Push 113917 by bmo:ystartsev@mozilla.com at Mon, 25 Jun 2018 13:52:38 +0000
Bug 1464461 - implement screenshot command in console panel; r=ochameau, nchevobbe MozReview-Commit-ID: 8MDZglPqTz9
2c589502a05f7997d14433e7403fe522b9659bb1: Bug 1461793 - Remove the "popup-base" binding and import the "popup.css" file as a document stylesheet. r=bgrins draft
Paolo Amadini <paolo.mozmail@amadzone.org> - Mon, 25 Jun 2018 14:37:51 +0100 - rev 810157
Push 113916 by paolo.mozmail@amadzone.org at Mon, 25 Jun 2018 13:40:35 +0000
Bug 1461793 - Remove the "popup-base" binding and import the "popup.css" file as a document stylesheet. r=bgrins MozReview-Commit-ID: ADWsFTNPfhw
8b18f652066905c8c51f077b706dfc6217a6170b: Bug 1347204 - Activity stream changes. draft
Tim Nguyen <ntim.bugs@gmail.com> - Mon, 25 Jun 2018 14:24:08 +0100 - rev 810156
Push 113915 by bmo:ntim.bugs@gmail.com at Mon, 25 Jun 2018 13:26:23 +0000
Bug 1347204 - Activity stream changes. MozReview-Commit-ID: JGVv1g6NYLU
7f12066519a7959320601aeca879f5d7ac6307e0: Bug 1470872 - Load "dropmarker.css", "groupbox.css", and "splitter.css" as document stylesheets. r=bgrins draft
Paolo Amadini <paolo.mozmail@amadzone.org> - Mon, 25 Jun 2018 14:12:51 +0100 - rev 810155
Push 113914 by paolo.mozmail@amadzone.org at Mon, 25 Jun 2018 13:20:14 +0000
Bug 1470872 - Load "dropmarker.css", "groupbox.css", and "splitter.css" as document stylesheets. r=bgrins MozReview-Commit-ID: 3jF7wbLpc7R
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip