5f4e93314bf20e3d3a8df1dd221b677b2f102bbb: Bug 1351739 - Part 0 - Use INVALID_TAB_ID more. r?sebastian,walkingice draft
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 06 Apr 2017 21:30:55 +0200 - rev 568903
Push 56020 by mozilla@buttercookie.de at Wed, 26 Apr 2017 18:35:14 +0000
Bug 1351739 - Part 0 - Use INVALID_TAB_ID more. r?sebastian,walkingice -1 is probably not all that mysterious as far as magic numbers go, but still... MozReview-Commit-ID: zK3P6HeWzK
124980c46974278db889ef2186e8ce475956dc2f: Bug 1351739 - Part -1 - Housekeeping. r?sebastian,walkingice draft
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 07 Apr 2017 20:51:41 +0200 - rev 568902
Push 56020 by mozilla@buttercookie.de at Wed, 26 Apr 2017 18:35:14 +0000
Bug 1351739 - Part -1 - Housekeeping. r?sebastian,walkingice MozReview-Commit-ID: Ev6jl4N3K0g
a296075e7cefbaad8168c6ef57265bd551540582: Local Gradle tweaks draft
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 28 Jul 2016 20:04:34 +0200 - rev 568901
Push 56020 by mozilla@buttercookie.de at Wed, 26 Apr 2017 18:35:14 +0000
Local Gradle tweaks MozReview-Commit-ID: H5pdKja8p2a
f15b077cbc604c892824d864923547a930e79247: Bug 1347413 - Remove the unused browser-fullZoom:zoomReset and browser-fullZoom:zoomChange notifications. r?dao,mccr8
Jared Wein <jwein@mozilla.com> - Wed, 15 Mar 2017 11:26:57 -0400 - rev 568900
Push 56019 by bmo:jaws@mozilla.com at Wed, 26 Apr 2017 18:34:27 +0000
Bug 1347413 - Remove the unused browser-fullZoom:zoomReset and browser-fullZoom:zoomChange notifications. r?dao,mccr8 MozReview-Commit-ID: GeqfVngo9QT
3e468dc5d5e89a7cdf550889dae103f06a5e24b1: Bug 1359822 - Match standard for colSpan/rowSpan draft
Aryeh Gregor <ayg@aryeh.name> - Wed, 26 Apr 2017 21:22:43 +0300 - rev 568899
Push 56018 by bmo:ayg@aryeh.name at Wed, 26 Apr 2017 18:31:16 +0000
Bug 1359822 - Match standard for colSpan/rowSpan Previously, the spec for these attributes didn't match implementations at all, and that was just fixed: <https://github.com/whatwg/html/issues/1198>. There are two differences to our previous implementation: 1) The IDL property should be set as an unsigned int, not signed. This was just a bug. 2) When parsing the IDL property, the value is now clamped to the minimum/maximum value instead of being set to 1. Negative values still get set to 1 instead of 0, even for rowSpan which allows 0 as a value. The test changes are copied from the wpt test submitted upstream. An additional rendering test using getBoundingClientRect() is also accepted upstream: https://github.com/w3c/web-platform-tests/pull/4115 MozReview-Commit-ID: FQzPhgqNTBy
8acee07a60dc4a322d51d981f34d7d950c1d6ea2: Bug 1359907 - Add ellipsis back to Sync pane of preferences since these two buttons require additional confirmation or input. r?mconley draft
Jared Wein <jwein@mozilla.com> - Wed, 26 Apr 2017 14:29:11 -0400 - rev 568898
Push 56017 by bmo:jaws@mozilla.com at Wed, 26 Apr 2017 18:29:25 +0000
Bug 1359907 - Add ellipsis back to Sync pane of preferences since these two buttons require additional confirmation or input. r?mconley MozReview-Commit-ID: O6vSp37vYx
46e4243f9bd1154e0d88d81acb5ecdab66b4ffce: Bug 1359844 - Ensure full decode be triggered after style-image was downloaded, draft
cku <cku@mozilla.com> - Mon, 17 Apr 2017 15:10:52 +0800 - rev 568897
Push 56016 by bmo:cku@mozilla.com at Wed, 26 Apr 2017 18:16:33 +0000
Bug 1359844 - Ensure full decode be triggered after style-image was downloaded, In nsCSSRendering::PaintBorderWithStyleBorder: DrawResult nsCSSRendering::PaintBorderWithStyleBorder() { if (aStyleBorder.IsBorderImageLoaded()) { (1) } (2) } At (1), we create a nsCSSBorderImageRenderer object. While creating it, we call imgRenderer.PrepareImage() to ensure a full image decode at [1]. PrepareImage is used in both bg-image/mask-image and border-image. The difference is, in bg-image/mask-image painting path, we unconditionally use PrepareImage(in nsCSSRendering::PrepareImageLayer), whereas in border-image painting path we use it only after border-image was downloaded. This difference does cause a problem. After border image was downloaded, the decoder will not do full decoding since we did not ask for it, so there will be no repaint notification and no chance to paint border-image again. In this patch, I try to align the behavior between bg-image/mask-image and border-image: always call nsImageRenderer::PrepareImage. This is a generic fix for both stylo-enable and stylo-disable build. We do not find this problem in reftest is because we use SYNC_DECODE in reftest harness, which hides this race condition. When daily using firefox, if nsCSSRendering::PaintBorderWithStyleBorder is called after border-image was loaded, your program run into (1), border-image will be drawn correctly; In the case that nsCSSRendering::PaintBorderWithStyleBorder is called before border-image is loaded, your program run into (2), and you can only see border-color. [1] https://hg.mozilla.org/mozilla-central/file/a6f35285bd1e/layout/painting/nsCSSRenderingBorders.cpp#l3598 MozReview-Commit-ID: 6pidHJdPG8I
28ac3df85281f0a706f5b9725e11aa7095c6f75b: Bug 1347413 - Remove the unused browser-fullZoom:zoomReset and browser-fullZoom:zoomChange notifications. r?dao,mccr8 draft
Jared Wein <jwein@mozilla.com> - Wed, 15 Mar 2017 11:26:57 -0400 - rev 568896
Push 56015 by bmo:jaws@mozilla.com at Wed, 26 Apr 2017 18:12:38 +0000
Bug 1347413 - Remove the unused browser-fullZoom:zoomReset and browser-fullZoom:zoomChange notifications. r?dao,mccr8 MozReview-Commit-ID: GeqfVngo9QT
7a36ebb89a8d20a0da3a8069705e33b6280fa2c1: Bug 1359844 - Ensure full decode be triggered after style-image was downloaded, draft
cku <cku@mozilla.com> - Mon, 17 Apr 2017 15:10:52 +0800 - rev 568895
Push 56014 by bmo:cku@mozilla.com at Wed, 26 Apr 2017 18:09:34 +0000
Bug 1359844 - Ensure full decode be triggered after style-image was downloaded, In nsCSSRendering::PaintBorderWithStyleBorder: DrawResult nsCSSRendering::PaintBorderWithStyleBorder() { if (aStyleBorder.IsBorderImageLoaded()) { (1) } (2) } At (1), we create a nsCSSBorderImageRenderer object. While creating it, we call imgRenderer.PrepareImage() to ensure a full image decode at [1]. PrepareImage is used in both bg-image/mask-image and border-image. The difference is, in bg-image/mask-image painting path, we unconditionally use PrepareImage(in nsCSSRendering::PrepareImageLayer), whereas in border-image painting path we use it only after border-image was downloaded. This difference does cause a problem. After border image was downloaded, the decoder will not do full decoding since we did not ask for it, so there will be no repaint notification and no chance to paint border-image again. In this patch, I try to align the behavior between bg-image/mask-image and border-image: always call nsImageRenderer::PrepareImage. This is a generic fix for both stylo-enable and stylo-disable build. We do not find this problem in reftest is because we use SYNC_DECODE in reftest harness, which hides this race condition. When daily using firefox, if nsCSSRendering::PaintBorderWithStyleBorder is called after border-image was loaded, your program run into (1), border-image will be drawn correctly; In the case that nsCSSRendering::PaintBorderWithStyleBorder is called before border-image is loaded, your program run into (2), and you can only see border-color. [1] https://hg.mozilla.org/mozilla-central/file/a6f35285bd1e/layout/painting/nsCSSRenderingBorders.cpp#l3598 MozReview-Commit-ID: 6pidHJdPG8I
f6f531aa1edca9097bbdb6050399880011b8517a: bug 1319026 - Put an arbitrary upper-limit on TelemetryLog r?gfritzsche draft
Chris H-C <chutten@mozilla.com> - Wed, 26 Apr 2017 13:35:00 -0400 - rev 568894
Push 56013 by bmo:chutten@mozilla.com at Wed, 26 Apr 2017 18:09:29 +0000
bug 1319026 - Put an arbitrary upper-limit on TelemetryLog r?gfritzsche To protect against pathalogically-bad cases of log abuse, limit to an arbitrary 5k ring buffer for TelemetryLog. MozReview-Commit-ID: yoTFVS1VdQ
282107883769b4f406f31f1460be372e91ad8c8a: bug 1319026 - Log failed Telemetry send requests. r?gfritzsche r?bsmedberg draft
Chris H-C <chutten@mozilla.com> - Thu, 06 Apr 2017 15:10:15 -0400 - rev 568893
Push 56013 by bmo:chutten@mozilla.com at Wed, 26 Apr 2017 18:09:29 +0000
bug 1319026 - Log failed Telemetry send requests. r?gfritzsche r?bsmedberg Roughly one in three telemetry sends fail according to telemetry.mozilla.org. Unfortunately, we have little idea about why. This patch logs the failure paths in an effort to identify the worst offenders. This is a temporary measure not meant to survive for long. The data it gathers will be used to write appropriate longer-term error probes. MozReview-Commit-ID: 9IMrLNH2AD
b1bd89334ee5a2f92aa087e2c1f28f19ded0d399: Bug 1254355 - Follow-up: Use #ifdef, not #if, for MOZ_CRASHREPORTER. r=gps
Nick Alexander <nalexander@mozilla.com> - Tue, 18 Apr 2017 17:26:15 -0700 - rev 568892
Push 56013 by bmo:chutten@mozilla.com at Wed, 26 Apr 2017 18:09:29 +0000
Bug 1254355 - Follow-up: Use #ifdef, not #if, for MOZ_CRASHREPORTER. r=gps On a CLOSED TREE Style varies across the tree, and this matters as we transition to Python and moz.build. AppConstants.jsm already uses #ifdef, so this is consistent with that. MozReview-Commit-ID: Bal37lqlvjq
0c3b3c4e0ba6efdb3be17c10319e9967e076d46f: Bug 1254355 - Post: Make android-* jobs depend on more of the build. r=gps
Nick Alexander <nalexander@mozilla.com> - Tue, 18 Apr 2017 21:17:28 -0700 - rev 568891
Push 56013 by bmo:chutten@mozilla.com at Wed, 26 Apr 2017 18:09:29 +0000
Bug 1254355 - Post: Make android-* jobs depend on more of the build. r=gps MozReview-Commit-ID: mJrHfbw9XL
c556baa9feb8a9beae76a667458dc32043c3a4b7: Bug 1254355 - Part 2: Generate AndroidManifest.xml using GENERATED_FILES. r=gps,mshal
Nick Alexander <nalexander@mozilla.com> - Tue, 25 Apr 2017 13:42:19 -0700 - rev 568890
Push 56013 by bmo:chutten@mozilla.com at Wed, 26 Apr 2017 18:09:29 +0000
Bug 1254355 - Part 2: Generate AndroidManifest.xml using GENERATED_FILES. r=gps,mshal MozReview-Commit-ID: BVYylS4qsP1
272037dc7f5763e96cf7cb0e25375656f5ac769a: Bug 1357846 - Introducing nsIFilePicker.displaySpecialDirectory, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 26 Apr 2017 18:20:19 +0200 - rev 568889
Push 56013 by bmo:chutten@mozilla.com at Wed, 26 Apr 2017 18:09:29 +0000
Bug 1357846 - Introducing nsIFilePicker.displaySpecialDirectory, r=smaug nsIFilePicker.displaySpecialDirectory is a string that can be set to TmpD, Desk, or any other special directory value. The real value of this directory will be read in the parent process.
7ea39575ae0cf1ae5a0958c1bc3de9ac9e3a37e1: Backed out changeset b06d30abb358 (bug 1354308) for failing test_basic.html, test_formSubmission.html and test_no_dnd.html. r=backout
Sebastian Hengst <archaeopteryx@coole-files.de> - Wed, 26 Apr 2017 17:56:55 +0200 - rev 568888
Push 56013 by bmo:chutten@mozilla.com at Wed, 26 Apr 2017 18:09:29 +0000
Backed out changeset b06d30abb358 (bug 1354308) for failing test_basic.html, test_formSubmission.html and test_no_dnd.html. r=backout
5590452f092c5cbd29054f024094031ae7df4971: Bug 1359205 - Make XUL pseudo values nsICSSAnonBoxPseudo* instead of nsIAtom* and assert that IsTreePseudoElement() got a pseudo tag of the right type. r=bz
Mats Palmgren <mats@mozilla.com> - Wed, 26 Apr 2017 17:54:43 +0200 - rev 568887
Push 56013 by bmo:chutten@mozilla.com at Wed, 26 Apr 2017 18:09:29 +0000
Bug 1359205 - Make XUL pseudo values nsICSSAnonBoxPseudo* instead of nsIAtom* and assert that IsTreePseudoElement() got a pseudo tag of the right type. r=bz MozReview-Commit-ID: G2WFsNV4Fjz
8457e1358dda18f6e8d3ab787f306314668e5fb9: Bug 1359415 - move threadsafety checks inside nsAutoOwningThread; r=erahm
Nathan Froyd <froydnj@mozilla.com> - Wed, 26 Apr 2017 11:41:32 -0400 - rev 568886
Push 56013 by bmo:chutten@mozilla.com at Wed, 26 Apr 2017 18:09:29 +0000
Bug 1359415 - move threadsafety checks inside nsAutoOwningThread; r=erahm This change moves most of the logic for the threadsafety check into nsAutoOwningThread, rather than having part of the logic live in nsAutoOwningThread and part of the logic live in nsDebug.h. Changing this also forces us to clean up a couple of places that replicated the logic that lived in nsDebug.h as well.
57624ab56af4ae9305d9d5db5605dccbf012c104: Bug 1359420 - Send correct status code in GeckoView security change listener r=esawin
James Willcox <snorp@snorp.net> - Tue, 25 Apr 2017 09:17:47 -0500 - rev 568885
Push 56013 by bmo:chutten@mozilla.com at Wed, 26 Apr 2017 18:09:29 +0000
Bug 1359420 - Send correct status code in GeckoView security change listener r=esawin MozReview-Commit-ID: 3B3PNxCNnm3
0a18abb7a8f373df8cf8123b9ec7681c352cbef7: Bug 1359419 - Add GeckoView.preload() r=esawin
James Willcox <snorp@snorp.net> - Tue, 25 Apr 2017 09:15:06 -0500 - rev 568884
Push 56013 by bmo:chutten@mozilla.com at Wed, 26 Apr 2017 18:09:29 +0000
Bug 1359419 - Add GeckoView.preload() r=esawin MozReview-Commit-ID: 6DYq2oiz1Ug
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip