5ec55f7a95f94cf39d57cdf36abecab914ea48eb: Backed out changeset 3ff8ce674396 (bug 1447460) on request of tomprince a=backout
arthur.iakab <aiakab@mozilla.com> - Tue, 03 Apr 2018 18:30:58 +0300 - rev 776748
Push 104978 by bogdan@pozderca.com at Tue, 03 Apr 2018 16:55:00 +0000
Backed out changeset 3ff8ce674396 (bug 1447460) on request of tomprince a=backout
5aee20889155d69e40cfa54e4c7969f6ce243d80: Bug 1449532 - Part III, Polyfill Web Animation API features draft
Timothy Guan-tin Chien <timdream@gmail.com> - Sat, 31 Mar 2018 11:31:36 +0800 - rev 776747
Push 104977 by timdream@gmail.com at Tue, 03 Apr 2018 16:54:46 +0000
Bug 1449532 - Part III, Polyfill Web Animation API features The Animation and KeyframeEffect constructors and the finshed promise are not enabled on release channel currently. The polyfill is added to make sure we don't break on release. When the feature ships, removing the polyfill should be as easy as reverting this changeset. MozReview-Commit-ID: 2EWN7hBN5tj
1fed748a6b6acc89800d4d19508716f505a9ad91: Bug 1449532 - Part II, Use Web Animation API to animate video control transition draft
Timothy Guan-tin Chien <timdream@gmail.com> - Fri, 30 Mar 2018 00:21:03 +0800 - rev 776746
Push 104977 by timdream@gmail.com at Tue, 03 Apr 2018 16:54:46 +0000
Bug 1449532 - Part II, Use Web Animation API to animate video control transition Web Animation API should give us deterministic timing when the transition ends or aborts. Additional clean-ups: - Make sure hidden status is always set/get from the hidden property, instead of the hidden attribute. - Remove the unused isControlBarHidden property. - controlsSpacer no longer has a background color (removed in bug 1374007), therefore it no longer needs a transition and there is no need to test its state with the test added in bug 1319301. - Fix a logic error at hideByAdjustment property, revealed by the changed transition timing, in which adjustControlSize() would show the controlBar set hidden by the transition. MozReview-Commit-ID: DB2cgQcUEXi
4d590b256da371edd96704c0cfa48cd1bcfa6454: Bug 1440777 - Add support for local actions and implement console-log as a local action r?Gijs draft
Mike Cooper <mcooper@mozilla.com> - Thu, 15 Mar 2018 13:14:56 -0700 - rev 776745
Push 104976 by bmo:mcooper@mozilla.com at Tue, 03 Apr 2018 16:54:24 +0000
Bug 1440777 - Add support for local actions and implement console-log as a local action r?Gijs * Add ActionsManager to provide a common interface to local and remote actions * Move action handle logic from RecipeRunner to new ActionsManager * Implement BaseAction for all local actions * Implement ConsoleLog as a subclass of BaseAction * Validate action arguments with schema validator from PolicyEngine MozReview-Commit-ID: E2cxkkvYjCz
9214cb39b88900fd506a18b23a532f9cda08751f: Bug 1179698 - Part 1 - Put input focus on the URL bar when opening a new tab via keyboard. r?jchen draft
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 29 Mar 2018 20:55:11 +0200 - rev 776744
Push 104975 by mozilla@buttercookie.de at Tue, 03 Apr 2018 16:50:30 +0000
Bug 1179698 - Part 1 - Put input focus on the URL bar when opening a new tab via keyboard. r?jchen MozReview-Commit-ID: 2iZkO8FDB3R
5bcbd9a7f654412c10a0d72765c32b7db861928b: Bug 1179698 - Part 0 - Remove superfluous true/false ternary operator. r?jchen draft
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 29 Mar 2018 20:51:07 +0200 - rev 776743
Push 104975 by mozilla@buttercookie.de at Tue, 03 Apr 2018 16:50:30 +0000
Bug 1179698 - Part 0 - Remove superfluous true/false ternary operator. r?jchen Somehow I must have overlooked that during review, but if I'm touching something in the neighbourhood I might just as well clean this up. MozReview-Commit-ID: 95gnzSebGyf
f82bb37c625e4649422e40ea7853dbdeda4c7df9: Bug 1281907 - Part 2 - Add reftest for scrollbars with pinch-zooming. r?botond draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 01 Apr 2018 17:40:04 +0200 - rev 776742
Push 104975 by mozilla@buttercookie.de at Tue, 03 Apr 2018 16:50:30 +0000
Bug 1281907 - Part 2 - Add reftest for scrollbars with pinch-zooming. r?botond MozReview-Commit-ID: K7YoEPQLJzU
36b55a3e847aa576fe4b2cd75acf73f156bf6c1d: Bug 1281907 - Part 1 - Include zoom level compensation in clip transform passed to caller. r?botond draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 24 Mar 2018 21:27:06 +0100 - rev 776741
Push 104975 by mozilla@buttercookie.de at Tue, 03 Apr 2018 16:50:30 +0000
Bug 1281907 - Part 1 - Include zoom level compensation in clip transform passed to caller. r?botond If we don't do that, in the case of a root scrollbar the clip transform passed to our caller will incorrectly be scaled with the current content resolution. This means that that the position of the clip rect won't match the actual position of the scrollbar if the resolution isn't ~1.0, so the scrollbars will be clipped out of existence when the content is (pinch-) zoomed in or out. MozReview-Commit-ID: 5yXa9EpTJ2g
8870af69b3077719ee1f3daf30154b4c41fd7367: Bug 1447607 - Correctly init and update ElfLoader::Singleton::lastError r=glandium draft
James Willcox <snorp@snorp.net> - Fri, 30 Mar 2018 09:57:43 -0500 - rev 776740
Push 104975 by mozilla@buttercookie.de at Tue, 03 Apr 2018 16:50:30 +0000
Bug 1447607 - Correctly init and update ElfLoader::Singleton::lastError r=glandium MozReview-Commit-ID: r1bclXdt4V
1fd8465ddaf2a0b3f6dcadd3b39e67660f606fc1: Bug 1414084 - Part 17 - Fix setting of private browsing theme state. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 02 Mar 2018 18:01:28 +0100 - rev 776739
Push 104974 by mozilla@buttercookie.de at Tue, 03 Apr 2018 16:46:20 +0000
Bug 1414084 - Part 17 - Fix setting of private browsing theme state. r?grisha Previously, this wasn't noticeable since adding/removing a PageAction would call refreshPageActionIcons(), which would do the correct thing, but now a newly created PageActionLayout can start with an already pre-populated mPageAction- List, which means that the subsequently arriving call to setPrivateMode() will erroneously activate the private mode tinting for all PageActions that support it. MozReview-Commit-ID: EvNx1Q9vwZ5
d867d05c132476895f4d52e21c79633cf69e62fd: Bug 1414084 - Part 16 - Add some tests for the handling of PageActions. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 19 Mar 2018 20:27:01 +0100 - rev 776738
Push 104974 by mozilla@buttercookie.de at Tue, 03 Apr 2018 16:46:20 +0000
Bug 1414084 - Part 16 - Add some tests for the handling of PageActions. r?grisha MozReview-Commit-ID: EUl19vyK3Ra
fe80e3b8de1cbf8972f8667eb23fe64282aa94cc: Bug 1414084 - Part 15 - Correctly remove already resolved PageActions, too. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 03 Mar 2018 18:11:57 +0100 - rev 776737
Push 104974 by mozilla@buttercookie.de at Tue, 03 Apr 2018 16:46:20 +0000
Bug 1414084 - Part 15 - Correctly remove already resolved PageActions, too. r?grisha When a PageActions:Remove message arrives and we cannot simply forward it, we need to remove not just pending PageActions:Add messages, but also any already present PageActions objects that a former PageActionLayout had handed to us. MozReview-Commit-ID: 3jnGsmMuVfa
74a5a153ed894febebb777355800303630be08b8: Bug 1414084 - Part 14 - Rename isPwaAdded for more clarity. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 20:39:00 +0100 - rev 776736
Push 104974 by mozilla@buttercookie.de at Tue, 03 Apr 2018 16:46:20 +0000
Bug 1414084 - Part 14 - Rename isPwaAdded for more clarity. r?grisha Despite its name and the original purpose for which it was added, that function generically checks for duplicates among all PageActions, not just the PWA badge. MozReview-Commit-ID: Ae6FsLb9F3S
f3365d02f1c1ee13edce0e7d28129089b02a3bff: Bug 1414084 - Part 13 - Cache PageActions. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 26 Feb 2018 21:50:50 +0100 - rev 776735
Push 104974 by mozilla@buttercookie.de at Tue, 03 Apr 2018 16:46:20 +0000
Bug 1414084 - Part 13 - Cache PageActions. r?grisha Since converting a PageAction message into an actual PageAction object also en- tails parsing the image data URL into a drawable, we leave that task to the PageActionLayout. This means that the PageAction cache needs to operate slightly differently than the MenuItem cache. First, we store all PageAction BundleEvent messages that arrive while no PageActionLayout is ready and then forward them en masse when one becomes available. Secondly, if the PageActionLayout is going away again, we then also take a list of already parsed PageAction objects for safekeeping. MozReview-Commit-ID: AcPPONXqe46
1e42342b101661c5ab4f83dbe536e296d25258f5: Bug 1414084 - Part 12 - Add some tests for the processing of Menu messages. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 19 Mar 2018 20:06:32 +0100 - rev 776734
Push 104974 by mozilla@buttercookie.de at Tue, 03 Apr 2018 16:46:20 +0000
Bug 1414084 - Part 12 - Add some tests for the processing of Menu messages. r?grisha MozReview-Commit-ID: D8Aujo1PgIk
9c31a941566d46386d8a330762070c56a4d551de: Bug 1414084 - Part 11 - Use a Map for the MenuItemInfo list. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 18:07:16 +0100 - rev 776733
Push 104974 by mozilla@buttercookie.de at Tue, 03 Apr 2018 16:46:20 +0000
Bug 1414084 - Part 11 - Use a Map for the MenuItemInfo list. r?grisha Since all related EventDispatcher messages use UUIDs, it makes sense to store our MenuItemInfos in a Map, so we can access them directly by UUID instead of having to iterate over them until we've found the desired one. Since we want to preserve the order in which MenuItemInfos were added, we use a LinkedHashMap. MozReview-Commit-ID: BEtJ59tX59m
5098a3edf98618341e6596bfd06ed84de22c3b8a: Bug 1414084 - Part 10 - Init MenuItemInfo list right from the start. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 17:47:33 +0100 - rev 776732
Push 104974 by mozilla@buttercookie.de at Tue, 03 Apr 2018 16:46:20 +0000
Bug 1414084 - Part 10 - Init MenuItemInfo list right from the start. r?grisha The small savings in initialising this on demand the first time a menu item is added, are not worth the additional complexity in null checks and the like. MozReview-Commit-ID: Lcz09Ds8NxJ
8f9f347a896d1264588805e1ebbb0f285740384e: Bug 1414084 - Part 9 - Move add-on menu item cache out of BrowserApp. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 25 Feb 2018 22:22:37 +0100 - rev 776731
Push 104974 by mozilla@buttercookie.de at Tue, 03 Apr 2018 16:46:20 +0000
Bug 1414084 - Part 9 - Move add-on menu item cache out of BrowserApp. r?grisha Bug 832990 solved the issue of us losing the menu item cache if BrowserApp was destroyed, however the issue remains that we'll miss any Menu:... messages that are sent while BrowserApp doesn't exist, e.g. if Gecko is initially loaded through a GeckoView-based activity. Therefore we now move the menu item cache and the listener for those messages into a separate class, whose lifetime better matches that of Gecko. Apart from any necessary changes, we move the existing code as is. The only additional change is that we make addAddonMenuItemToMenu() static, because we can. MozReview-Commit-ID: BJleonLnjmo
3f5bd3c587f50790da58bf9c83d0460589baed4e: Bug 1414084 - Part 8 - Unify menu item EventDispatcher messages. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 16:42:57 +0100 - rev 776730
Push 104974 by mozilla@buttercookie.de at Tue, 03 Apr 2018 16:46:20 +0000
Bug 1414084 - Part 8 - Unify menu item EventDispatcher messages. r?grisha As a final step, these can be merged as well. The same reasoning as in the previous patch applies with regards to additional functionality that isn't (yet) used by webextensions. MozReview-Commit-ID: Ezx2mQY0s85
e889c16f134e23561db8ba86211fd74b9feedc43: Bug 1414084 - Part 7 - Use one set of functions for managing MenuItems in the UI. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 14:17:03 +0100 - rev 776729
Push 104974 by mozilla@buttercookie.de at Tue, 03 Apr 2018 16:46:20 +0000
Bug 1414084 - Part 7 - Use one set of functions for managing MenuItems in the UI. r?grisha The original add-on functions have some additional capabilities regarding e.g. checkboxes, disabling the menu, etc. that right now aren't required for Webextensions (yet?), but in that case they will simply not be used - in any case BrowserActions.jsm controls what functionality is actually exposed to add-ons. MozReview-Commit-ID: DPT8gV2gb6q
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip