5e8406f38c0936d8626a9dc0debc23b5ea7138bd: Bug 1319496 - 5. Change prompt response to use GeckoBundle; r=sebastian
Jim Chen <nchen@mozilla.com> - Tue, 29 Nov 2016 12:25:53 -0500 - rev 445498
Push 37520 by dholbert@mozilla.com at Tue, 29 Nov 2016 19:41:37 +0000
Bug 1319496 - 5. Change prompt response to use GeckoBundle; r=sebastian Change prompt response from using JSONObject/String to using GeckoBundle. The GeckoBundle is automatically translated to a JS object, like before, when dispatched to JS code.
16dbb57af3e2888827ef2db6d6e17d28cdab1379: Bug 1319496 - 4. Fix context menu item IDs; r=sebastian
Jim Chen <nchen@mozilla.com> - Tue, 29 Nov 2016 12:25:53 -0500 - rev 445497
Push 37520 by dholbert@mozilla.com at Tue, 29 Nov 2016 19:41:37 +0000
Bug 1319496 - 4. Fix context menu item IDs; r=sebastian Context menu items used UUIDs as their prompt list item IDs. However, prompt list items only support integers as IDs. This error didn't show up before because JSONObject was silently ignoring the error. This patch changes to using an incremental integer as the ID and fixes the error.
10a6565daede03fcb1b5d4c7bfbfa499dfec404c: Bug 1319496 - 3. Convert prompts to BundleEventListener; r=sebastian
Jim Chen <nchen@mozilla.com> - Tue, 29 Nov 2016 12:25:53 -0500 - rev 445496
Push 37520 by dholbert@mozilla.com at Tue, 29 Nov 2016 19:41:37 +0000
Bug 1319496 - 3. Convert prompts to BundleEventListener; r=sebastian Convert prompts to use BundleEventListener and GeckoBundle. DefaultDoorHanger.setOptions accepts a JSONObject argument, but if we converted it to GeckoBundle, it would involve a lot of extra changes in the other doorhanger code. So this patch adds GeckoBundle.fromJSONObject and converts JSONObject to GeckoBundle within DefaultDoorHanger.setOptions. In the future, another patch would convert all doorhanger code to use GeckoBundle instead of JSONObject.
15407fdf9c663cfd195b28920da5a2d9084eba49: Bug 1319496 - 2. Add more GeckoBundle tests in testEventDispatcher; r=snorp
Jim Chen <nchen@mozilla.com> - Tue, 29 Nov 2016 12:25:53 -0500 - rev 445495
Push 37520 by dholbert@mozilla.com at Tue, 29 Nov 2016 19:41:37 +0000
Bug 1319496 - 2. Add more GeckoBundle tests in testEventDispatcher; r=snorp Add more tests for edge cases in testEventDispatcher, such as null arrays, nonexistent values, and object arrays containing only nulls.
7cf56f4e7c0de931e35f56d7220e4b99d0dd3fdf: Bug 1319496 - 1. Fix GeckoBundle array handling; r=snorp
Jim Chen <nchen@mozilla.com> - Tue, 29 Nov 2016 12:25:52 -0500 - rev 445494
Push 37520 by dholbert@mozilla.com at Tue, 29 Nov 2016 19:41:37 +0000
Bug 1319496 - 1. Fix GeckoBundle array handling; r=snorp Fix several bugs when handling arrays in GeckoBundle. 1. Correctly return null when getting an array that is not in the bundle, instead of crashing. 2. Convert object arrays to GeckoBundle arrays in EventDispatcher instead of leaving it as a single GeckoBundle with integer keys, due to lack of object array support in NativeJSObject.toBundle. 3. Return error when trying to convert a JS array of arrays to GeckoBundle, instead of crashing. 4. Add convenience methods for setting arrays; for example, setting boolean arrays from Boolean[] and Collection<Boolean>.
23990c75a5e36eb5ecbb551cfcbcb8ae152c764d: Bug 1320997 - Ignore disconnected iframe nsPIDOMWindowOuters in TabGroup::GetTopLevelWindows, r=smaug
Michael Layzell <michael@thelayzells.com> - Tue, 29 Nov 2016 11:50:13 -0500 - rev 445493
Push 37520 by dholbert@mozilla.com at Tue, 29 Nov 2016 19:41:37 +0000
Bug 1320997 - Ignore disconnected iframe nsPIDOMWindowOuters in TabGroup::GetTopLevelWindows, r=smaug MozReview-Commit-ID: 8wQSmcS1sUn
334758dabe03d652b633736f71c8544c9c9d19cc: Bug 1319973 - tls proxy null in nshttpconnection::onsocketwritable after timer r=hurley
Patrick McManus <mcmanus@ducksong.com> - Mon, 28 Nov 2016 11:05:33 -0500 - rev 445492
Push 37520 by dholbert@mozilla.com at Tue, 29 Nov 2016 19:41:37 +0000
Bug 1319973 - tls proxy null in nshttpconnection::onsocketwritable after timer r=hurley
e6459d80bf245d1f5e2f46bda884878548d58126: Bug 1316005 - fixed unused methods, made methods use actual signature and added @Override; r=sebastian
Tomislav Jurin <svezauzeto12@hotmail.com> - Thu, 24 Nov 2016 22:30:04 +0100 - rev 445491
Push 37520 by dholbert@mozilla.com at Tue, 29 Nov 2016 19:41:37 +0000
Bug 1316005 - fixed unused methods, made methods use actual signature and added @Override; r=sebastian
b24e8ff760ba7b27b8ba2fceb9a90bd079b7bd19: Bug 1320374: Add missing null-checks; r=bustage
Benjamin Bouvier <benj@benj.me> - Tue, 29 Nov 2016 17:23:54 +0100 - rev 445490
Push 37520 by dholbert@mozilla.com at Tue, 29 Nov 2016 19:41:37 +0000
Bug 1320374: Add missing null-checks; r=bustage
61fa1151977344c3b7628692b076c64876aa6181: Bug 1319742 - UUIDs should be strings, not objects, r?markh draft
Ethan Glasser-Camp <eglassercamp@mozilla.com> - Tue, 29 Nov 2016 14:15:55 -0500 - rev 445489
Push 37519 by eglassercamp@mozilla.com at Tue, 29 Nov 2016 19:19:54 +0000
Bug 1319742 - UUIDs should be strings, not objects, r?markh `generateUUID()` returns an `nsID`, which is not exactly the same as a UUID. `nsID`s can be converted to strings using `toString()`, but if you use `JSON.stringify()`, they become `{}`. Object comparison in JS performs identity comparison, which would be useless even if the UUIDs were sensible, which they aren't. As a result, trying to sync keyrings always failed, because it always seemed like UUIDs had changed, even when they hadn't. Because it never occurred to me that UUIDs wouldn't be strings, I never even wrote a test for this. Correct this, and fix the test. Thanks to :vasilica_mihasca and :markh for reporting and diagnosing this. MozReview-Commit-ID: EthxkFFwRbQ
a42dc8932dd314252138e192d51dfe827b1bc2b8: Bug 1319742 - UUIDs should be strings, not objects draft
Ethan Glasser-Camp <eglassercamp@mozilla.com> - Tue, 29 Nov 2016 14:15:55 -0500 - rev 445488
Push 37518 by eglassercamp@mozilla.com at Tue, 29 Nov 2016 19:17:37 +0000
Bug 1319742 - UUIDs should be strings, not objects `generateUUID()` returns an `nsID`, which is not exactly the same as a UUID. `nsID`s can be converted to strings using `toString()`, but if you use `JSON.stringify()`, they become `{}`. Object comparison in JS performs identity comparison, which would be useless even if the UUIDs were sensible, which they aren't. As a result, trying to sync keyrings always failed, because it always seemed like UUIDs had changed, even when they hadn't. Because it never occurred to me that UUIDs wouldn't be strings, I never even wrote a test for this. Correct this, and fix the test. Thanks to :vasilica_mihasca and :markh for reporting and diagnosing this. MozReview-Commit-ID: EthxkFFwRbQ
a7a4e76f5e12f0785a6ef6e911a37cb2636f7720: Bug 1295948 - fixing method so it works with encoded URLs r?aki draft
Tomislav Jurin <svezauzeto12@hotmail.com> - Tue, 29 Nov 2016 20:03:47 +0100 - rev 445487
Push 37517 by bmo:svezauzeto12@hotmail.com at Tue, 29 Nov 2016 19:13:18 +0000
Bug 1295948 - fixing method so it works with encoded URLs r?aki MozReview-Commit-ID: I6Fq2Wxmvsw *** Bug 1295948 - fixing method so it works with encoded URLs, changed return method r?aki MozReview-Commit-ID: J9kBeUBDtOh *** return just url MozReview-Commit-ID: 3xB727QAvse
0fd8c61f58d493eb8e15f00ce7ddcbb7566a692a: Bug 1316008: Use explicit charset encoding draft
Adrian Zatreanu <adrianzatreanu1@gmail.com> - Tue, 29 Nov 2016 20:42:08 +0200 - rev 445486
Push 37516 by bmo:adrianzatreanu1@gmail.com at Tue, 29 Nov 2016 18:49:25 +0000
Bug 1316008: Use explicit charset encoding MozReview-Commit-ID: 3y2CKQZrLtl
bdb5222ec1a63215fbea54b3ed7857f7bf9ffb06: Bug 1303298 - Work around intermittent browser_mixed_content_cert_override.js. r=nhnt11 draft
Johann Hofmann <jhofmann@mozilla.com> - Tue, 29 Nov 2016 18:01:35 +0100 - rev 445485
Push 37515 by bmo:jhofmann@mozilla.com at Tue, 29 Nov 2016 18:47:58 +0000
Bug 1303298 - Work around intermittent browser_mixed_content_cert_override.js. r=nhnt11 MozReview-Commit-ID: 5srDm58jz5M
4bcbd5a371c1e6874b1523949652aa0c80836ff9: Bug 1245921 - Update tests for toolbox toolbar; r?miker draft
Greg Tatum <tatum.creative@gmail.com> - Fri, 18 Nov 2016 15:05:02 -0600 - rev 445484
Push 37514 by bmo:gtatum@mozilla.com at Tue, 29 Nov 2016 18:47:00 +0000
Bug 1245921 - Update tests for toolbox toolbar; r?miker MozReview-Commit-ID: EnFqSy2day4
6529343e280320001829dcedef543082b60938cf: Bug 1245921 - Turn toolbox toolbar into a React component r?miker draft
Greg Tatum <tatum.creative@gmail.com> - Fri, 18 Nov 2016 15:02:21 -0600 - rev 445483
Push 37514 by bmo:gtatum@mozilla.com at Tue, 29 Nov 2016 18:47:00 +0000
Bug 1245921 - Turn toolbox toolbar into a React component r?miker I separated out the tests from this commit to make the review easier, but I will squash the two whenever I land them. I apologize in advance for the size of this patch. I didn't see any way to do it in small incremental work. MozReview-Commit-ID: 4UZbcfw2YI9
e9e673a23711c5d7de516a17ccc42da0368a26e1: Bug 1245921 - Update tests for toolbox toolbar; r?mratcliffe draft
Greg Tatum <tatum.creative@gmail.com> - Fri, 18 Nov 2016 15:05:02 -0600 - rev 445482
Push 37513 by bmo:gtatum@mozilla.com at Tue, 29 Nov 2016 18:43:54 +0000
Bug 1245921 - Update tests for toolbox toolbar; r?mratcliffe MozReview-Commit-ID: EnFqSy2day4
86bb76960478e6819d4922deeef3cc194a4d0694: Bug 1245921 - Turn toolbox toolbar into a React component r?mratcliffe draft
Greg Tatum <tatum.creative@gmail.com> - Fri, 18 Nov 2016 15:02:21 -0600 - rev 445481
Push 37513 by bmo:gtatum@mozilla.com at Tue, 29 Nov 2016 18:43:54 +0000
Bug 1245921 - Turn toolbox toolbar into a React component r?mratcliffe I separated out the tests from this commit to make the review easier, but I will squash the two whenever I land them. I apologize in advance for the size of this patch. I didn't see any way to do it in small incremental work. MozReview-Commit-ID: 4UZbcfw2YI9
a42416f1aa0fbf9d539fcdbe669be35618f040e2: Bug 1319560 Part 3: Change nsDisplayList::HitTest to exit early when HitTestShouldStopAtFirstOpaque() is true. draft
Brad Werth <bwerth@mozilla.com> - Mon, 28 Nov 2016 13:22:15 -0800 - rev 445480
Push 37512 by bwerth@mozilla.com at Tue, 29 Nov 2016 18:23:05 +0000
Bug 1319560 Part 3: Change nsDisplayList::HitTest to exit early when HitTestShouldStopAtFirstOpaque() is true. MozReview-Commit-ID: D8aKGX6z2TV
d46d96e56d8b8f426be3b65a014c321de5d000fb: Bug 1319560 Part 2: Add a nsLayoutUtils::FrameForPointFlags value to only retrieve visible frames. draft
Brad Werth <bwerth@mozilla.com> - Mon, 28 Nov 2016 14:50:34 -0800 - rev 445479
Push 37512 by bwerth@mozilla.com at Tue, 29 Nov 2016 18:23:05 +0000
Bug 1319560 Part 2: Add a nsLayoutUtils::FrameForPointFlags value to only retrieve visible frames. MozReview-Commit-ID: 1mNIXdyBkw4
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip