5dead291436ff211037507e96fe71e091279aed1: Bug 1411462 - Abort when I/O error seen; r?glandium
draft
Gregory Szorc <gps@mozilla.com> - Thu, 09 Nov 2017 20:44:10 -0800 - rev 696036
Push
88618 by bmo:gps@mozilla.com at Fri, 10 Nov 2017 04:44:25 +0000
Bug 1411462 - Abort when I/O error seen; r?glandium
Before, I/O errors writing to stdout/stderr (e.g. due to broken pipe)
would result in handleError() being called and execution would
keep running. This would potentially result in an error message for
every log/line failure being printed to stderr.
We change the behavior so I/O failures are fatal and abort
execution.
We test the new behavior by changing a test to pipe to `head`
directly. Since `head` exits once it has seen sufficient output,
this results in an EPIPE which now results in immediate program
termination.
MozReview-Commit-ID: 1UecZJ56h4r
461c9b31684c4cf935c339cb7ccb95872d4fe343: Bug 1411462 - Add test for `configure --help`; r?glandium
draft
Gregory Szorc <gps@mozilla.com> - Tue, 24 Oct 2017 17:10:55 -0700 - rev 696035
Push
88618 by bmo:gps@mozilla.com at Fri, 10 Nov 2017 04:44:25 +0000
Bug 1411462 - Add test for `configure --help`; r?glandium
We add a simple cram test that `configure --help` works.
I added the test to build/tests because I'm not sure where else it should go.
This test uncovers a few interesting things:
1) piping `./configure --help` to `head` directly causes a Python
traceback (presumably due to the pipe disappearing once N lines
have been read)
2) "checking for vcs source checkout" is printed for --help
3) It is printed twice (!!)
These will be addressed later. Establishing test coverage is
more important.
MozReview-Commit-ID: 9zQ5X8ulTkc
5923f383ba014d75db1fa70aa76073465b03f68e: Bug 1411462 - Normalize when argument earlier in imply_option(); r?glandium
draft
Gregory Szorc <gps@mozilla.com> - Tue, 24 Oct 2017 12:56:10 -0700 - rev 696034
Push
88618 by bmo:gps@mozilla.com at Fri, 10 Nov 2017 04:44:25 +0000
Bug 1411462 - Normalize when argument earlier in imply_option(); r?glandium
This makes `configure --help` work again (it stopped working due to
370a4a2a7898 (
bug 1405982).
MozReview-Commit-ID: 2gCmAAsE0qW
a678c880543329ba57ce993eda838fe2b967b04b: Bug 1415772: Implement MNearbyInt recover instruction
draft
Jeff Hemphill <jthemphill@gmail.com> - Thu, 09 Nov 2017 20:33:02 -0800 - rev 696033
Push
88617 by bmo:jthemphill@gmail.com at Fri, 10 Nov 2017 04:35:00 +0000
Bug 1415772: Implement MNearbyInt recover instruction
MozReview-Commit-ID: D7JdEHjDl2W
a986bb89cb0dd1099504e3bf5c3f67fdf41d334b: Bug 1415448 - Move tests from AnimationEffectTiming/getAnimations.html to Animatable/getAnimations.html; r?hiro
draft
Brian Birtles <birtles@gmail.com> - Thu, 09 Nov 2017 16:00:36 +0900 - rev 696032
Push
88616 by bbirtles@mozilla.com at Fri, 10 Nov 2017 04:12:48 +0000
Bug 1415448 - Move tests from AnimationEffectTiming/getAnimations.html to Animatable/getAnimations.html; r?hiro
As well as moving these tests, this patch simplifies them in several cases and
tries to make them match the existing tests in that file (e.g. using 'animation'
instead of 'anim', using MS_PER_SEC, using assert_array_equals, etc.)
MozReview-Commit-ID: Gf7rucG9ml1
901decbd0d09446251756894b79179d0b94d6ba6: Bug 1415448 - Update test descriptions in interfaces/Animatable/getAnimations.html; r?hiro
draft
Brian Birtles <birtles@gmail.com> - Thu, 09 Nov 2017 15:40:50 +0900 - rev 696031
Push
88616 by bbirtles@mozilla.com at Fri, 10 Nov 2017 04:12:48 +0000
Bug 1415448 - Update test descriptions in interfaces/Animatable/getAnimations.html; r?hiro
We plan to merge in tests here from AnimationEffectTiming/getAnimations.html so
in this patch we update the test descriptions first.
MozReview-Commit-ID: 6yK6E0cNTKd
0ee73d0d3af168ef35459d05d5dd23f634360aad: Bug 1415448 - Drop getComputedStyle.html test in interfaces/AnimationEffectTiming; r?hiro
draft
Brian Birtles <birtles@gmail.com> - Thu, 09 Nov 2017 15:38:03 +0900 - rev 696030
Push
88616 by bbirtles@mozilla.com at Fri, 10 Nov 2017 04:12:48 +0000
Bug 1415448 - Drop getComputedStyle.html test in interfaces/AnimationEffectTiming; r?hiro
This test feels out of place -- there's no getComputedStyle method on
AnimationEffectTiming and we generally test timing properties by calling
getComputedTiming.
This patch moves most of the tests in this file to the corresponding members
whose liveness they check while updating them to use getComputedTiming instead.
The remaining tests that seek the currentTime and check the style with various
values of endDelay should be covered by
timing-model/animation-effects/simple-iteration-progress.html
MozReview-Commit-ID: 3qyXgJ7qRVy
58548ed62b7e8d87f3ff3e4e1954399766f60485: Bug 1415448 - Tidy up test descriptions for AnimationEffectTiming tests; r?hiro
draft
Brian Birtles <birtles@gmail.com> - Thu, 09 Nov 2017 15:30:10 +0900 - rev 696029
Push
88616 by bbirtles@mozilla.com at Fri, 10 Nov 2017 04:12:48 +0000
Bug 1415448 - Tidy up test descriptions for AnimationEffectTiming tests; r?hiro
The test descriptions should generally be testable statements. I'm following the
convention of BDD-style naming where the subject is implied (e.g. 'Has the
default value 0' should be read as '<test subject> has the default value 0').
MozReview-Commit-ID: L2i5AlyIMva
188c5f09d31864b2b7f08e1f665ef81aa8f4559c: Bug 1415448 - Rename discrete-animation.html test file to discrete-type.html; r?hiro
draft
Brian Birtles <birtles@gmail.com> - Wed, 08 Nov 2017 16:27:49 +0900 - rev 696028
Push
88616 by bbirtles@mozilla.com at Fri, 10 Nov 2017 04:12:48 +0000
Bug 1415448 - Rename discrete-animation.html test file to discrete-type.html; r?hiro
For consistency with visibility-type.html.
MozReview-Commit-ID: 5yUGo2X1cNd
da688e9b702deb51f78408665f0284c16bd24244: Bug 1415448 - Move the tests for the type of the 'visibility' property to the animation-types section; r?hiro
draft
Brian Birtles <birtles@gmail.com> - Wed, 08 Nov 2017 16:26:02 +0900 - rev 696027
Push
88616 by bbirtles@mozilla.com at Fri, 10 Nov 2017 04:12:48 +0000
Bug 1415448 - Move the tests for the type of the 'visibility' property to the animation-types section; r?hiro
MozReview-Commit-ID: WgicxIVrZ3
33305c9f74f64062444234d6201c3d848a9b59f3: Bug 1415448 - Rename setTarget.html to target.html; r?hiro
draft
Brian Birtles <birtles@gmail.com> - Wed, 08 Nov 2017 16:20:10 +0900 - rev 696026
Push
88616 by bbirtles@mozilla.com at Fri, 10 Nov 2017 04:12:48 +0000
Bug 1415448 - Rename setTarget.html to target.html; r?hiro
This matches better the naming of other test files.
MozReview-Commit-ID: 3rzEwBhum3E
72f7428148ac3f210286a09962c7ef10462dc193: Bug 1415448 - Tidy up titles of Web Animations web-platform-tests; r?hiro
draft
Brian Birtles <birtles@gmail.com> - Wed, 08 Nov 2017 16:16:14 +0900 - rev 696025
Push
88616 by bbirtles@mozilla.com at Fri, 10 Nov 2017 04:12:48 +0000
Bug 1415448 - Tidy up titles of Web Animations web-platform-tests; r?hiro
It's not necessary to say "tests" or "tests for" in the title of these tests.
It's obvious from the context that these are test files.
This patch:
* Remove "Tests for" and "tests" from the titles
* Makes the titles match the spec sections they test more closely where
practical
* Makes the titles more consistent in general (e.g. not putting () after method
names)
* Updates a few spec links
* Drops a few author annotations since we decided to no longer use them
There are still some inconsistencies:
- The naming of the setTarget.html test file
- The location of the effect-value-visibility.html file
- The getComputedStyle.html test
- etc.
These will be fixed in subsequent patches in this series.
MozReview-Commit-ID: Ghl0dWalYZE
34dcccb2948d84fd503d58e7dd707b466401f525: Bug 1415448 - Update web-platform-tests manifest; r?hiro
draft
Brian Birtles <birtles@gmail.com> - Wed, 08 Nov 2017 16:15:14 +0900 - rev 696024
Push
88616 by bbirtles@mozilla.com at Fri, 10 Nov 2017 04:12:48 +0000
Bug 1415448 - Update web-platform-tests manifest; r?hiro
This is simply the result of running:
./mach wpt-manifest-update
MozReview-Commit-ID: EKoDVNn7yA2
6781c119176c9b6cdd7283a7a799304c32e4dd6a: Bug 1416067 - Avoid doing a bunch of useless event-regions work for frames with empty border boxes. r?mstange
draft
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 09 Nov 2017 19:40:44 -0500 - rev 696023
Push
88615 by kgupta@mozilla.com at Fri, 10 Nov 2017 04:10:48 +0000
Bug 1416067 - Avoid doing a bunch of useless event-regions work for frames with empty border boxes. r?mstange
MozReview-Commit-ID: 8gsIJojhQ6t
043e71f0626fc4621872fb46ed244a79fda61fd1: Bug 1413830 - PART 2: introduce root/parent session_id
draft
Fred Lin <gasolin@gmail.com> - Fri, 10 Nov 2017 12:06:37 +0800 - rev 696022
Push
88614 by bmo:gasolin@mozilla.com at Fri, 10 Nov 2017 04:09:12 +0000
Bug 1413830 - PART 2: introduce root/parent session_id
MozReview-Commit-ID: ATyRNzky8R4
0a531def292f9ffea61f5f4f578d03713abb1538: Bug 1413830 - PART 1: track new events for onboarding telemetry;
draft
Fred Lin <gasolin@gmail.com> - Tue, 31 Oct 2017 12:01:30 +0800 - rev 696021
Push
88614 by bmo:gasolin@mozilla.com at Fri, 10 Nov 2017 04:09:12 +0000
Bug 1413830 - PART 1: track new events for onboarding telemetry;
MozReview-Commit-ID: 3jNAmOcrvEa
30e52aa95d880eca40c3b94d2dd9b5f6f22cef0b: Bug 1413830 - PART 2: introduce root/parent session_id
draft
Fred Lin <gasolin@gmail.com> - Fri, 10 Nov 2017 12:06:37 +0800 - rev 696020
Push
88613 by bmo:gasolin@mozilla.com at Fri, 10 Nov 2017 04:07:24 +0000
Bug 1413830 - PART 2: introduce root/parent session_id
MozReview-Commit-ID: ATyRNzky8R4
2fe72741eb9ee31553108effdbec484b57dc8de3: fixup! Bug 1413830 - PART 1: track new events for onboarding telemetry;
draft
Fred Lin <gasolin@gmail.com> - Fri, 10 Nov 2017 11:06:22 +0800 - rev 696019
Push
88613 by bmo:gasolin@mozilla.com at Fri, 10 Nov 2017 04:07:24 +0000
fixup!
Bug 1413830 - PART 1: track new events for onboarding telemetry;
ae5539a11d9fbe472d545136e5d764822f4efbb3: Bug 1413830 - PART 1: track new events for onboarding telemetry;
draft
Fred Lin <gasolin@gmail.com> - Tue, 31 Oct 2017 12:01:30 +0800 - rev 696018
Push
88613 by bmo:gasolin@mozilla.com at Fri, 10 Nov 2017 04:07:24 +0000
Bug 1413830 - PART 1: track new events for onboarding telemetry;
MozReview-Commit-ID: 3jNAmOcrvEa
320fd9dfd0aed1e6c0011dd9538fa31ead604bd1: Bug 1412608 - Fix comment selection color in markup view. r=jdescottes
draft
Gabriel Luong <gabriel.luong@gmail.com> - Thu, 09 Nov 2017 23:06:37 -0500 - rev 696017
Push
88612 by bmo:gl@mozilla.com at Fri, 10 Nov 2017 04:07:09 +0000
Bug 1412608 - Fix comment selection color in markup view. r=jdescottes
MozReview-Commit-ID: 9G5efQSPHCf