5beab75354125ea6ec905968675171de4fdcf40e: Bug 1265342 Part 10: Update a shape-outside circle test to make it more precise and correct. draft
Brad Werth <bwerth@mozilla.com> - Tue, 17 Apr 2018 13:19:36 -0700 - rev 787959
Push 107854 by bwerth@mozilla.com at Wed, 25 Apr 2018 18:14:35 +0000
Bug 1265342 Part 10: Update a shape-outside circle test to make it more precise and correct. The test shape-outside-circle-027.html has two issues that prevent it from matching the reference image. For that test to pass, the text must be floated right by 75 pixels. The two issues are: 1) The circle is defined as 35% of 170 pixels, which calculates to 59.5px. Since the shape-margin is 15px, this makes the total offset less than the target of 75px. 2) The circle is offset upwards by 10 pixels, which introduces a slight angle between the block start of the text and the center of the circle. The cosine of this small angle is slightly less than 1, which reduces the offset by some amount. The changes made here specify the circle radius in whole pixels, and move the center of the circle such that it is between the block start and block end of the floated text, ensuring that the full width of the circle + shape-margin will be used for calculating the float area. MozReview-Commit-ID: JQ9Mc3GU4tW
d6061ae7c5bf4ee928455cdb0f4678d9cf8480c2: Bug 1265342 Part 9: Update shape-outside ellipse tests to correct invalid use of only one radius parameter. draft
Brad Werth <bwerth@mozilla.com> - Wed, 14 Mar 2018 14:21:12 -0700 - rev 787958
Push 107854 by bwerth@mozilla.com at Wed, 25 Apr 2018 18:14:35 +0000
Bug 1265342 Part 9: Update shape-outside ellipse tests to correct invalid use of only one radius parameter. https://www.w3.org/TR/css-shapes-1/#funcdef-ellipse states that the grammar for ellipse is: ellipse() = ellipse( [<shape-radius>{2}]? [at <position>]? ) This permits either 0 or 2 shape-radius tokens, but not 1. These two tests use 1 shape-radius token and do not parse correctly. https://www.w3.org/TR/css-shapes-1/#typedef-shape-radius states that omitted shape-radius values default to closest-side. This change updates these two tests to add the closest-side value for the missing shape-radius tokens. MozReview-Commit-ID: 9UKxJel1b50
1367373ee4ef67454bd8bd7bc95940c793899c55: Bug 1265342 Part 8: Update shape-outside inset tests to explicitly set a line-height of 1, and not rely on a UA-specific value. draft
Brad Werth <bwerth@mozilla.com> - Wed, 14 Mar 2018 14:49:57 -0700 - rev 787957
Push 107854 by bwerth@mozilla.com at Wed, 25 Apr 2018 18:14:35 +0000
Bug 1265342 Part 8: Update shape-outside inset tests to explicitly set a line-height of 1, and not rely on a UA-specific value. https://www.w3.org/TR/CSS2/visudet.html#propdef-line-height specifies that line-height is given an initial value of normal, which is defined: Tells user agents to set the used value to a "reasonable" value based on the font of the element. The value has the same meaning as <number>. We recommend a used value for 'normal' between 1.0 to 1.2. The computed value is 'normal'. These tests are designed to work correctly if and only if the line-height is 1. This change specifies line-height: 1 explicitly. MozReview-Commit-ID: 3Ueassok0f
52390d12e68722ea260604bdeb4337fb2f6df47b: Bug 1265342 Part 7: Implement shape-margin for shape-outside: shape-box. draft
Brad Werth <bwerth@mozilla.com> - Mon, 26 Feb 2018 14:47:31 -0800 - rev 787956
Push 107854 by bwerth@mozilla.com at Wed, 25 Apr 2018 18:14:35 +0000
Bug 1265342 Part 7: Implement shape-margin for shape-outside: shape-box. MozReview-Commit-ID: 67vq9Gcr8qJ
cd2ea0ddb67a5d4efcbbca0aa83544c82631ed3e: Bug 1265342 Part 6b: Implement shape-margin for shape-outside: inset, for general case of shape-margin > 0. draft
Brad Werth <bwerth@mozilla.com> - Tue, 17 Apr 2018 11:39:50 -0700 - rev 787955
Push 107854 by bwerth@mozilla.com at Wed, 25 Apr 2018 18:14:35 +0000
Bug 1265342 Part 6b: Implement shape-margin for shape-outside: inset, for general case of shape-margin > 0. MozReview-Commit-ID: 4pjALPSIBhI
70a84de16cc8a89ffa4256dc6485d24df3f28afe: Bug 1265342 Part 6a: Implement shape-margin for shape-outside: inset, for some special cases with shape-margin > 0. draft
Brad Werth <bwerth@mozilla.com> - Fri, 13 Apr 2018 11:29:14 -0700 - rev 787954
Push 107854 by bwerth@mozilla.com at Wed, 25 Apr 2018 18:14:35 +0000
Bug 1265342 Part 6a: Implement shape-margin for shape-outside: inset, for some special cases with shape-margin > 0. MozReview-Commit-ID: AEOksiuM0GJ
c898ec3dddef1c061a7b5f79714f085f10726e06: Bug 1265342 Part 5d: Move EllipseShapeInfo class definition ahead of RoundedBoxShapeInfo so it can be referenced by rounded boxes. draft
Brad Werth <bwerth@mozilla.com> - Tue, 17 Apr 2018 11:59:11 -0700 - rev 787953
Push 107854 by bwerth@mozilla.com at Wed, 25 Apr 2018 18:14:35 +0000
Bug 1265342 Part 5d: Move EllipseShapeInfo class definition ahead of RoundedBoxShapeInfo so it can be referenced by rounded boxes. MozReview-Commit-ID: G8qdPlnh8kY
1bae7f3258cfcaa20ad46f814117be746eb22316: Bug 1265342 Part 5c: Add some asserts to ensure ellipse distance field index values are in-bounds. draft
Brad Werth <bwerth@mozilla.com> - Fri, 20 Apr 2018 13:43:36 -0700 - rev 787952
Push 107854 by bwerth@mozilla.com at Wed, 25 Apr 2018 18:14:35 +0000
Bug 1265342 Part 5c: Add some asserts to ensure ellipse distance field index values are in-bounds. MozReview-Commit-ID: CpuWWaLh1CX
007cf6da59bc29b0209af30d6455207065d7a456: Bug 1265342 Part 5b: Complete the implementation of shape-margin for ellipse (handling shape-margin: > 0). draft
Brad Werth <bwerth@mozilla.com> - Wed, 11 Apr 2018 15:18:32 -0700 - rev 787951
Push 107854 by bwerth@mozilla.com at Wed, 25 Apr 2018 18:14:35 +0000
Bug 1265342 Part 5b: Complete the implementation of shape-margin for ellipse (handling shape-margin: > 0). MozReview-Commit-ID: CovCfk5ryEn
26e6bb2ebd8612506a7052601686cb952c733b81: Bug 1265342 Part 5a: Implement shape-margin for shape-outside: circle and ellipse (ellipse only for shape-margin: 0). draft
Brad Werth <bwerth@mozilla.com> - Mon, 26 Feb 2018 13:13:03 -0800 - rev 787950
Push 107854 by bwerth@mozilla.com at Wed, 25 Apr 2018 18:14:35 +0000
Bug 1265342 Part 5a: Implement shape-margin for shape-outside: circle and ellipse (ellipse only for shape-margin: 0). MozReview-Commit-ID: HeipoUTkqUE
1e6b11d7440889cfd5a80a1b1d45e04f634b92a2: Bug 1265342 Part 4b: Add some logic and asserts to ensure distance field index values and image index values are in-bounds. draft
Brad Werth <bwerth@mozilla.com> - Fri, 20 Apr 2018 14:04:15 -0700 - rev 787949
Push 107854 by bwerth@mozilla.com at Wed, 25 Apr 2018 18:14:35 +0000
Bug 1265342 Part 4b: Add some logic and asserts to ensure distance field index values and image index values are in-bounds. MozReview-Commit-ID: 1C9vB14Qhyj
0ab5069aaa05f9c6dc21bcd556ab84a7d3b8b71f: Bug 1265342 Part 4a: Complete the implementation of shape-margin for shape-outside: image (handling shape-margin: > 0). draft
Brad Werth <bwerth@mozilla.com> - Thu, 22 Feb 2018 11:11:03 -0800 - rev 787948
Push 107854 by bwerth@mozilla.com at Wed, 25 Apr 2018 18:14:35 +0000
Bug 1265342 Part 4a: Complete the implementation of shape-margin for shape-outside: image (handling shape-margin: > 0). MozReview-Commit-ID: 4xqfqWB78Oh
754d0696cc20ba754d2abf632ed3343518e577bd: Bug 1265342 Part 3: Stub in shape-margin for shape-outside: image, by implementing only for shape-margin: 0. draft
Brad Werth <bwerth@mozilla.com> - Mon, 12 Mar 2018 17:04:34 -0700 - rev 787947
Push 107854 by bwerth@mozilla.com at Wed, 25 Apr 2018 18:14:35 +0000
Bug 1265342 Part 3: Stub in shape-margin for shape-outside: image, by implementing only for shape-margin: 0. MozReview-Commit-ID: 2gVRyQtd7Io
c74ab8bdb317ce51e011c10cb6d1f1cd50697e2b: Bug 1265342 Part 2b: Refactor interval creation for shape-outside:image. draft
Brad Werth <bwerth@mozilla.com> - Wed, 28 Feb 2018 10:43:43 -0800 - rev 787946
Push 107854 by bwerth@mozilla.com at Wed, 25 Apr 2018 18:14:35 +0000
Bug 1265342 Part 2b: Refactor interval creation for shape-outside:image. MozReview-Commit-ID: LnzQPsSBVqY
7a5d88647099dd268174d7f3327c7ff10f4b3424: Bug 1265342 Part 2a: Move interval binary search method into ShapeInfo. draft
Brad Werth <bwerth@mozilla.com> - Wed, 11 Apr 2018 14:05:06 -0700 - rev 787945
Push 107854 by bwerth@mozilla.com at Wed, 25 Apr 2018 18:14:35 +0000
Bug 1265342 Part 2a: Move interval binary search method into ShapeInfo. MozReview-Commit-ID: BxJxIU0RVAo
f7fa75645645fd8e308f134b3f166e07a15189e6: Bug 1265342 Part 1: Add shape-margin to style system (Gecko bindings). draft
Brad Werth <bwerth@mozilla.com> - Wed, 07 Feb 2018 17:27:04 -0800 - rev 787944
Push 107854 by bwerth@mozilla.com at Wed, 25 Apr 2018 18:14:35 +0000
Bug 1265342 Part 1: Add shape-margin to style system (Gecko bindings). MozReview-Commit-ID: 3G0ZpWDrumg
ac09f7403915e73e47fb7e0545fec3aa4e9ba041: Bug 1265342 Part 0: Servo changes to add shape-margin. draft
Brad Werth <bwerth@mozilla.com> - Thu, 08 Feb 2018 11:00:56 -0800 - rev 787943
Push 107854 by bwerth@mozilla.com at Wed, 25 Apr 2018 18:14:35 +0000
Bug 1265342 Part 0: Servo changes to add shape-margin. MozReview-Commit-ID: 99pLZsFA9mj
1e787ca2ca79467558adc9fe72999ab4f5a54c02: Bug 1456591 - Underline only the accesskey in XUL UI draft
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 25 Apr 2018 10:51:45 -0700 - rev 787942
Push 107853 by timdream@gmail.com at Wed, 25 Apr 2018 17:53:10 +0000
Bug 1456591 - Underline only the accesskey in XUL UI MozReview-Commit-ID: 3x1hQSJ1yTW
cfe7ad973601ab1414f566659f36198b4d04f50b: Bug 1386807 - Part 4: Add hidden WebExtension window to a11y tests to make them pass draft
Dennis Schubert <dschubert@mozilla.com> - Wed, 25 Apr 2018 16:47:30 +0200 - rev 787941
Push 107852 by bmo:dschubert@mozilla.com at Wed, 25 Apr 2018 17:42:21 +0000
Bug 1386807 - Part 4: Add hidden WebExtension window to a11y tests to make them pass This is actually a workaround for the test not ignoring hidden windows. There is ongoing work in bug 1440106 that will get rid of this issue altogether, but for now, we need to add hidden windows ourselves. MozReview-Commit-ID: 2rQoz4KLHv3
1d3ba3da76ed529b2666f1985ef62ec9b89bdda3: Bug 1386807 - Part 3: Make the UA pref actually disable UA overrides draft
Dennis Schubert <dschubert@mozilla.com> - Fri, 09 Feb 2018 18:53:33 +0100 - rev 787940
Push 107852 by bmo:dschubert@mozilla.com at Wed, 25 Apr 2018 17:42:21 +0000
Bug 1386807 - Part 3: Make the UA pref actually disable UA overrides MozReview-Commit-ID: 25YsSg7P8DP
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip