5a9a72c9a56b3c76808ebd98ab96dd19dca2a26a: Bug 1402284 - Move arena tree related globals to a static singleton of a new class. r?njn
draft
Mike Hommey <mh+mozilla@glandium.org> - Sat, 28 Oct 2017 07:13:58 +0900 - rev 689871
Push
87124 by bmo:mh+mozilla@glandium.org at Wed, 01 Nov 2017 02:13:24 +0000
Bug 1402284 - Move arena tree related globals to a static singleton of a new class. r?njn
We create the ArenaCollection class to handle operations on the
arena tree. Ideally, iter() would trigger locking, but the
prefork/postfork code complicates things, so we leave this for later.
61aefc0bf2a20e7dc85a207dbe634720acde4e00: Bug 1402284 - Separate arenas created from moz_arena_* functions from others. r?njn
draft
Mike Hommey <mh+mozilla@glandium.org> - Tue, 31 Oct 2017 07:13:39 +0900 - rev 689870
Push
87123 by bmo:mh+mozilla@glandium.org at Wed, 01 Nov 2017 02:12:10 +0000
Bug 1402284 - Separate arenas created from moz_arena_* functions from others. r?njn
We introduce the notion of private arenas, separate from other arenas
(main and thread-local). They are kept in a separate arena tree, and
arena lookups from moz_arena_* functions only access the tree of
private arenas. Iteration still goes through all arenas, private and
non-private.
fd1eb04314c0549e4abba3ff0b6f2d6cd7be3975: Bug 1402284 - Move arena tree related globals to a static singleton of a new class. r?njn
draft
Mike Hommey <mh+mozilla@glandium.org> - Sat, 28 Oct 2017 07:13:58 +0900 - rev 689869
Push
87123 by bmo:mh+mozilla@glandium.org at Wed, 01 Nov 2017 02:12:10 +0000
Bug 1402284 - Move arena tree related globals to a static singleton of a new class. r?njn
We create the arena_t::Collection class to handle operations on the
arena tree. Ideally, iter() would trigger locking, but the
prefork/postfork code complicates things, so we leave this for later.
eb6f9f3810fdc84596674ea05d4910f0f16cd976: Bug 1402284 - Initialize arena_t objects via a constructor instead of manually with an Init method. r?njn
draft
Mike Hommey <mh+mozilla@glandium.org> - Sat, 28 Oct 2017 08:42:59 +0900 - rev 689868
Push
87123 by bmo:mh+mozilla@glandium.org at Wed, 01 Nov 2017 02:12:10 +0000
Bug 1402284 - Initialize arena_t objects via a constructor instead of manually with an Init method. r?njn
Note we use the deprecated `new (fallible_t())` form because using `new
(fallible)` would require some figuring out for non-Firefox builds (e.g.
standalone js).
1540940b9ca8a28718e1ecdc2ed02d53540dbd2f: Bug 1402284 - Make RedBlackTree::{Insert,Remove} work when the type has a constructor. r?njn
draft
Mike Hommey <mh+mozilla@glandium.org> - Mon, 30 Oct 2017 09:55:18 +0900 - rev 689867
Push
87123 by bmo:mh+mozilla@glandium.org at Wed, 01 Nov 2017 02:12:10 +0000
Bug 1402284 - Make RedBlackTree::{Insert,Remove} work when the type has a constructor. r?njn
RedBlackTree::{Insert,Remove} allocate an object on the stack for its
RedBlackTreeNode, and that shouldn't have side effects if the type
happens to have a constructor. This will allow to add constructors to
some of the mozjemalloc types.
2db67ea386eec4d7b62095df233dff9dbdde8ab3: Bug 1413096 - Remove SIZEOF_PTR and SIZEOF_PTR_2POW. r?njn
draft
Mike Hommey <mh+mozilla@glandium.org> - Mon, 30 Oct 2017 11:43:10 +0900 - rev 689866
Push
87123 by bmo:mh+mozilla@glandium.org at Wed, 01 Nov 2017 02:12:10 +0000
Bug 1413096 - Remove SIZEOF_PTR and SIZEOF_PTR_2POW. r?njn
248bc3ec5135a7be58b7b4140abc6987bf843253: Bug 1413096 - Replace ffs with MathAlgorithms functions. r?njn
draft
Mike Hommey <mh+mozilla@glandium.org> - Mon, 30 Oct 2017 17:44:16 +0900 - rev 689865
Push
87123 by bmo:mh+mozilla@glandium.org at Wed, 01 Nov 2017 02:12:10 +0000
Bug 1413096 - Replace ffs with MathAlgorithms functions. r?njn
- In the cases where it's used on powers of 2, replace it with
FloorLog2() + 1.
- In the cases where it's used on any kind of number, replace it with
CountTrailingZeroes, which is `ffs(x) - 1`.
- In the case of tiny allocations in arena_t::MallocSmall, we rearrange
the code so that the intent is clearer, which also simplifies the
expression for the mBins offset: mBins[0] is the first tiny bucket,
for allocations of sizes 1 << TINY_MIN_2POW, mBins[1] for allocations
of size 1 << (TINY_MIN_2POW + 1), etc. up to small_min. So the offset
is really the log2 of the normalized size.
9d3c6e404d6cfd015b9f892bd5138114018b7ab0: Bug 1413096 - Remove unnecessary call to ffs. r?njn
draft
Mike Hommey <mh+mozilla@glandium.org> - Mon, 30 Oct 2017 17:57:55 +0900 - rev 689864
Push
87123 by bmo:mh+mozilla@glandium.org at Wed, 01 Nov 2017 02:12:10 +0000
Bug 1413096 - Remove unnecessary call to ffs. r?njn
Comparing ffs(x) == ffs(y), when x and y are guaranteed to be powers of
2 (or 0, or 1), is the same as x == y.
ed248bca4be8a2015d6adf8450b542791f523da7: Bug 1413096 - Remove pow2_ceil in favor of RoundUpPow2. r?njn
draft
Mike Hommey <mh+mozilla@glandium.org> - Mon, 30 Oct 2017 17:22:36 +0900 - rev 689863
Push
87123 by bmo:mh+mozilla@glandium.org at Wed, 01 Nov 2017 02:12:10 +0000
Bug 1413096 - Remove pow2_ceil in favor of RoundUpPow2. r?njn
ebc5389e7f90d9945aed0874695804106d75d155: Bug 1413096 - Use CheckedInt for overflow check in calloc. r?njn
draft
Mike Hommey <mh+mozilla@glandium.org> - Mon, 30 Oct 2017 11:28:17 +0900 - rev 689862
Push
87123 by bmo:mh+mozilla@glandium.org at Wed, 01 Nov 2017 02:12:10 +0000
Bug 1413096 - Use CheckedInt for overflow check in calloc. r?njn
Also use in in _recalloc.
1e1d234282a8d53b4e1dca301f75964ca11f3022: Bug 1413096 - Add "using namespace mozilla" to mozjemalloc.cpp. r?njn
draft
Mike Hommey <mh+mozilla@glandium.org> - Mon, 30 Oct 2017 17:19:44 +0900 - rev 689861
Push
87123 by bmo:mh+mozilla@glandium.org at Wed, 01 Nov 2017 02:12:10 +0000
Bug 1413096 - Add "using namespace mozilla" to mozjemalloc.cpp. r?njn
b7b59b14b91824ba30b426f68aa6fd87cbb3794e: Bug 1413096 - Add missing header guard. r?njn
draft
Mike Hommey <mh+mozilla@glandium.org> - Mon, 30 Oct 2017 11:00:46 +0900 - rev 689860
Push
87123 by bmo:mh+mozilla@glandium.org at Wed, 01 Nov 2017 02:12:10 +0000
Bug 1413096 - Add missing header guard. r?njn
e16b59febff8a6013a0f34b3585a4e6ddcfc3082: Bug 1412722 - Remove RedBlackTree sentinel. r?njn
draft
Mike Hommey <mh+mozilla@glandium.org> - Sat, 28 Oct 2017 08:36:32 +0900 - rev 689859
Push
87123 by bmo:mh+mozilla@glandium.org at Wed, 01 Nov 2017 02:12:10 +0000
Bug 1412722 - Remove RedBlackTree sentinel. r?njn
The sentinel was taking as much space as one element of the tree, while
only really used for its RedBlackTreeNode, wasting space.
This results in some decrease in struct sizes, for example on 64-bits
linux:
- arena_bin_t: 80 -> 56
- arena_t (excluding mBins): 224 -> 144
- arena_t + dynamic size of mBins: 3024 -> 2104
It also decreases the size of several globals:
- gChunksBySize, gChunksByAddress, huge: 64 -> 8
- gArenaTree: 312 -> 8
210f0243747609500e19694b57674b4436b730ce: Bug 1411855 - remove unused and no inline function in toolbar;r=rickychien
draft
Fred Lin <gasolin@gmail.com> - Wed, 01 Nov 2017 10:05:18 +0800 - rev 689858
Push
87122 by bmo:gasolin@mozilla.com at Wed, 01 Nov 2017 02:05:45 +0000
Bug 1411855 - remove unused and no inline function in toolbar;r=rickychien
MozReview-Commit-ID: HXiTJSskRPr
b32d9710013caae8fdb5a464559e06dec0e1534a: Bug 1412437 - Remove nsIDOMHTMLTextAreaElement
draft
Kyle Machulis <kyle@nonpolynomial.com> - Mon, 30 Oct 2017 16:14:51 -0700 - rev 689857
Push
87121 by bmo:kyle@nonpolynomial.com at Wed, 01 Nov 2017 01:58:12 +0000
Bug 1412437 - Remove nsIDOMHTMLTextAreaElement
MozReview-Commit-ID: JAON7Rd7IAo
84cf98512d5a7e597755721a3af790f0f1778801: Bug 1412761 - copy editing;r=fischer
draft
Fred Lin <gasolin@gmail.com> - Wed, 01 Nov 2017 09:55:09 +0800 - rev 689856
Push
87120 by bmo:gasolin@mozilla.com at Wed, 01 Nov 2017 01:57:15 +0000
Bug 1412761 - copy editing;r=fischer
MozReview-Commit-ID: LDZFo94cMNZ
432ca099ea25a3928c99808ef67e8ee3d0965597: Bug 1412761 - remove dup test case;r=fischer
draft
Fred Lin <gasolin@gmail.com> - Wed, 01 Nov 2017 09:54:13 +0800 - rev 689855
Push
87120 by bmo:gasolin@mozilla.com at Wed, 01 Nov 2017 01:57:15 +0000
Bug 1412761 - remove dup test case;r=fischer
MozReview-Commit-ID: 9MLGQI3SiIf
5b0b1f06c2384d18841073358aab75d37648f1f4: Bug 1413111 - Use nsTSubstring::Split in nsCSSRuleProcessor::LangPseudoMatches instead of manually go through with FindChar.
draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 01 Nov 2017 10:19:56 +0900 - rev 689854
Push
87119 by bmo:mh+mozilla@glandium.org at Wed, 01 Nov 2017 01:39:40 +0000
Bug 1413111 - Use nsTSubstring::Split in nsCSSRuleProcessor::LangPseudoMatches instead of manually go through with FindChar.
f0ab124bd2e0b2365f41f5d6ce4233230c40d945: Bug 1413111 - Use nsTSubstring::Split in nsCSSRuleProcessor::LangPseudoMatches instead of manually go through with FindChar.
draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 01 Nov 2017 10:19:56 +0900 - rev 689853
Push
87118 by bmo:mh+mozilla@glandium.org at Wed, 01 Nov 2017 01:21:41 +0000
Bug 1413111 - Use nsTSubstring::Split in nsCSSRuleProcessor::LangPseudoMatches instead of manually go through with FindChar.
ab39396b70e0e791d2f7091b079fcb41c9a4fac4: Bug 1405506: Flush buffered data when disconnecting suspended channel. r?mixedpuppy
draft
Kris Maglione <maglione.k@gmail.com> - Tue, 31 Oct 2017 18:19:40 -0700 - rev 689852
Push
87117 by maglione.k@gmail.com at Wed, 01 Nov 2017 01:20:44 +0000
Bug 1405506: Flush buffered data when disconnecting suspended channel. r?mixedpuppy
MozReview-Commit-ID: F9rIhQHr8i