56c80b02deae61670c0e9b6a1b7ea266cf0dbe26: Bug 1405286: Part 3 - Test that filterResponseData from cached onHeadersReceived doesn't crash. r?mixedpuppy draft
Kris Maglione <maglione.k@gmail.com> - Sat, 14 Oct 2017 19:25:35 -0700 - rev 680559
Push 84532 by maglione.k@gmail.com at Sun, 15 Oct 2017 03:07:18 +0000
Bug 1405286: Part 3 - Test that filterResponseData from cached onHeadersReceived doesn't crash. r?mixedpuppy It currently isn't possible to suspend a channel from onHeadersReceived for a cached response. And since it's not possible to add a new stream filter after a response has started, adding a stream filter at that point will crash if the channel is still registered. This test is a basic sanity check for that scenario. MozReview-Commit-ID: ALYUtxX7mci
c0e8ab1c9368b546a98019ca70086630680b85e7: Bug 1405286: Part 2 - Ensure ordered processing of StreamFilter events. r?mixedpuppy draft
Kris Maglione <maglione.k@gmail.com> - Sat, 14 Oct 2017 18:58:53 -0700 - rev 680558
Push 84532 by maglione.k@gmail.com at Sun, 15 Oct 2017 03:07:18 +0000
Bug 1405286: Part 2 - Ensure ordered processing of StreamFilter events. r?mixedpuppy Our current StreamFilter code doesn't behave well when data delivery is targeted to a thread pool, rather than a single thread. Thread pools don't guarantee ordered processing of events. It's theoretically always possible for multiple events dispatched to a pool to be processed in parallel, or even slightly out of order. For the most part, this should only be a theoretical concern, unless several data events are dispatched at the same time, and the pool has enough available threads to service all of them (which is an unlikely scenario in this code). However, when data delivery is targeted to a thread pool, the OnDataAvailable callbacks do not have access to the thread pool itself, only the thread that the callback was dispatched to. This means that after each OnDataAvailable call, we likely store a new IO thread, and writes end up queued to a different single thread depending on exactly when they happen. Threads in thread pools often wind up executing long-running runnables, such as synchronous IO or network operations. Which means that we introduce arbitrary delays for some writes, and are likely to wind up with highly arbitrary ordering. This patch solves both of these problems by introducing strict event queue ordering, and also dispatching IO events to the original explicit delivery target, rather than whatever the current thread happened to be at the time of the last data event. MozReview-Commit-ID: 1SdYjS6ltqw
a2571644a61a3457956a659173e776237ed93ede: Bug 1405286: Part 1 - Allow retrieving the delivery target from retargetable requests. r?dragana draft
Kris Maglione <maglione.k@gmail.com> - Sat, 14 Oct 2017 18:30:38 -0700 - rev 680557
Push 84532 by maglione.k@gmail.com at Sun, 15 Oct 2017 03:07:18 +0000
Bug 1405286: Part 1 - Allow retrieving the delivery target from retargetable requests. r?dragana After data delivery for a request has been retargeted, there's no reliable way to get the appropriate event target to re-dispatch data events after asynchronous processing. While it's technically possible to retrieve the current thread from OnDataAvailable callbacks and re-use that for later dispatch, that approach has some issues: 1) It's not currently possible to reliably map the current thread to the thread pool that owns it. That means that if data delivery is being targetted to a thread pool, attempts to redispatch events to the previous delivery thread might lead to long delays when one thread in a pool is blocked. 2) If a filter wishes to dispatch data events to the wrapped listeners before it's recieved any data (as extensions StreamFilters sometimes do), there's no way to determine the proper event target without waiting for initial data to be received. Simply returning the correct event target from the request solves both of these problems. MozReview-Commit-ID: CJxq7O4399R
911885ad45d39d03a79ab95c2ea608d2027b1709: Bug 1403131 - Run linters against mozharness scripts and configs. r?rail draft
Steve Armand <stevea1@mac.com> - Sun, 08 Oct 2017 21:07:17 -0400 - rev 680556
Push 84531 by bmo:stevea1@mac.com at Sun, 15 Oct 2017 02:53:14 +0000
Bug 1403131 - Run linters against mozharness scripts and configs. r?rail MozReview-Commit-ID: HjsBIHY0x1F
d71e8e0053d8043bc9deb98b35ca5220a0c9adea: merge mozilla-inbound to mozilla-central. r=merge a=merge
Sebastian Hengst <archaeopteryx@coole-files.de> - Sat, 14 Oct 2017 23:56:50 +0200 - rev 680555
Push 84531 by bmo:stevea1@mac.com at Sun, 15 Oct 2017 02:53:14 +0000
merge mozilla-inbound to mozilla-central. r=merge a=merge MozReview-Commit-ID: IIgLYyM2O1l
ec0d413df945b26b2470e9b32423cdf9b1f84e29: merge autoland to mozilla-central. r=merge a=merge
Sebastian Hengst <archaeopteryx@coole-files.de> - Sat, 14 Oct 2017 23:53:59 +0200 - rev 680554
Push 84531 by bmo:stevea1@mac.com at Sun, 15 Oct 2017 02:53:14 +0000
merge autoland to mozilla-central. r=merge a=merge MozReview-Commit-ID: 4FxW8x0UspG
2ad47a18adf5f1b6bf6f167e5159368b9cc9b671: Bug 1312191 - Do not hardcode INDENT_LEVEL in xbl preprocessor. r=miker
Philipp Kewisch <mozilla@kewis.ch> - Sun, 08 Oct 2017 14:40:16 +0200 - rev 680553
Push 84531 by bmo:stevea1@mac.com at Sun, 15 Oct 2017 02:53:14 +0000
Bug 1312191 - Do not hardcode INDENT_LEVEL in xbl preprocessor. r=miker MozReview-Commit-ID: EiufIKCNfSs
d80fca44e81113afec89fa4e65ca15d922a88eae: servo: Merge #18880 - style: Fixup the hack added in #18867 (from emilio:fixup-parse-hack); r=emilio
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 14 Oct 2017 09:49:45 -0500 - rev 680552
Push 84531 by bmo:stevea1@mac.com at Sun, 15 Oct 2017 02:53:14 +0000
servo: Merge #18880 - style: Fixup the hack added in #18867 (from emilio:fixup-parse-hack); r=emilio The declaration can indeed have the same id if it contains variables, or is a CSS keyword value. This was making a WPT test fail, so this is tested, though Servo's WPT import didn't catch this for some reason. Source-Repo: https://github.com/servo/servo Source-Revision: de324f8b18a9728bbcd6c0874840262d0002bc23
83e55ee5843e87116e61fd9e15b4f9d4cac7f69a: servo: Merge #18877 - stylo: Dumb down the return value of SelectorList_Closest (from emilio:closest-why); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 14 Oct 2017 08:13:59 -0500 - rev 680551
Push 84531 by bmo:stevea1@mac.com at Sun, 15 Oct 2017 02:53:14 +0000
servo: Merge #18877 - stylo: Dumb down the return value of SelectorList_Closest (from emilio:closest-why); r=nox stylo: Dumb down the return value of SelectorList_Closest. So it builds with rust 1.21. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1408622 Source-Repo: https://github.com/servo/servo Source-Revision: 8b6207c0d689b0eff27965a60c8acfb9ad34252c
dfb2cb2683f15165e85d35bbcbccc6160c4f7b9e: Bug 1407548- Cache L10N values in request-list-empty-notice; r=gasolin
Pradeep <pradeepgangwar39@gmail.com> - Thu, 12 Oct 2017 16:36:28 +0530 - rev 680550
Push 84531 by bmo:stevea1@mac.com at Sun, 15 Oct 2017 02:53:14 +0000
Bug 1407548- Cache L10N values in request-list-empty-notice; r=gasolin MozReview-Commit-ID: 6V4MNg8LWwS *** Bug 1407548- Cache L10N values in request-list-empty-notice; r=gasolin MozReview-Commit-ID: FfojJJ6uBdI
385f9bbb4fd815828556ec0b99676c69f00c163e: Bug 1393672 - Show PWA onboarding and confrim prompt r=jwu
Nevin Chen(:nechen) <cnevinchen@gmail.com> - Tue, 26 Sep 2017 15:52:36 +0800 - rev 680549
Push 84531 by bmo:stevea1@mac.com at Sun, 15 Oct 2017 02:53:14 +0000
Bug 1393672 - Show PWA onboarding and confrim prompt r=jwu MozReview-Commit-ID: Kzih56Om7NO
b38a9374dabafc411db39a01ef050acf3120b7c5: Bug 1393672 - Add a badge (at the same position of Page Actio) for PWA. r=jwu
Nevin Chen(:nechen) <cnevinchen@gmail.com> - Tue, 26 Sep 2017 13:48:09 +0800 - rev 680548
Push 84531 by bmo:stevea1@mac.com at Sun, 15 Oct 2017 02:53:14 +0000
Bug 1393672 - Add a badge (at the same position of Page Actio) for PWA. r=jwu This bug is for the front end work to make users more engaged with PWA. Requirements 1. When the user goes to a web page that has manifest.json, we show a badge(in the same position of page action). 2. If the user switch to another normal page or other Java UI, the page action should be gone. 3. When the user see the PWA website for the first time, we will display a onboarding prompt to teach him how to add PWA to home screen. This prompt only shows once. MozReview-Commit-ID: AcyjHPVKg2b
521c3dd49ad33130d4cfe39acd20af9c7561a115: servo: Merge #18838 - Remove cssText from CSSStyleValue (from svanburen:remove_cssText); r=emilio
Stefan VanBuren <vanburenstefan@gmail.com> - Sat, 14 Oct 2017 06:58:29 -0500 - rev 680547
Push 84531 by bmo:stevea1@mac.com at Sun, 15 Oct 2017 02:53:14 +0000
servo: Merge #18838 - Remove cssText from CSSStyleValue (from svanburen:remove_cssText); r=emilio Removed from associated .rs and .webidl <!-- Please describe your changes on the following line: --> Not much more to add - let me know if it needs additional changes. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #17379 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because they remove a property that previously had no tests associated with it. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 240c05f13b859fc87531555cfd59fa273503a1a7
8b6e99d494b482b1199464428127ce43b2a1fba8: No bug - Remove declaration of non-existent function. r=me
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 14 Oct 2017 14:02:34 +0200 - rev 680546
Push 84531 by bmo:stevea1@mac.com at Sun, 15 Oct 2017 02:53:14 +0000
No bug - Remove declaration of non-existent function. r=me MozReview-Commit-ID: DftE7aBUhCc
de9496ac2ea813c8ff427b31e7d597153619868f: Bug 1408622: Dumb down the return value of Servo_SelectorList_Closest. r=me
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 14 Oct 2017 13:57:33 +0200 - rev 680545
Push 84531 by bmo:stevea1@mac.com at Sun, 15 Oct 2017 02:53:14 +0000
Bug 1408622: Dumb down the return value of Servo_SelectorList_Closest. r=me MozReview-Commit-ID: 2KRWlVAzj0D
91e5ad9c8c31f22cda3f3636b248c426b53f2809: Bug 1407952: Use stylo for Element::Closest. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 12 Oct 2017 11:42:17 +0200 - rev 680544
Push 84531 by bmo:stevea1@mac.com at Sun, 15 Oct 2017 02:53:14 +0000
Bug 1407952: Use stylo for Element::Closest. r=heycam MozReview-Commit-ID: 3H2piFT2CfF
a9e130bbaa956fa8c3c69fadaf69db19805287ff: servo: Merge #18867 - style: Dishonor display: -moz-box if -webkit-box was specified before (from emilio:parse-hack); r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 14 Oct 2017 05:27:51 -0500 - rev 680543
Push 84531 by bmo:stevea1@mac.com at Sun, 15 Oct 2017 02:53:14 +0000
servo: Merge #18867 - style: Dishonor display: -moz-box if -webkit-box was specified before (from emilio:parse-hack); r=heycam This is a compatibility hack that Gecko supports that is apparently important for android. I want to remove it, but let's see... See https://bugzilla.mozilla.org/show_bug.cgi?id=1407701 for reference. Source-Repo: https://github.com/servo/servo Source-Revision: 2be76c5fd7b74f334f8ce975e2051c77762314c2
169bde8f9f3c5fd07e7de900552fa544a62f1906: merge mozilla-central to autoland. r=merge a=merge
Sebastian Hengst <archaeopteryx@coole-files.de> - Sat, 14 Oct 2017 12:39:09 +0200 - rev 680542
Push 84531 by bmo:stevea1@mac.com at Sun, 15 Oct 2017 02:53:14 +0000
merge mozilla-central to autoland. r=merge a=merge
ab68cb44bb45aa73f0fa0a1eefe33430041b9872: servo: Merge #18873 - style: Remove Servo_GetStyleVariables test special case (from heycam:rm-gsv-check); r=emilio
Cameron McCormack <cam@mcc.id.au> - Sat, 14 Oct 2017 03:57:03 -0500 - rev 680541
Push 84531 by bmo:stevea1@mac.com at Sun, 15 Oct 2017 02:53:14 +0000
servo: Merge #18873 - style: Remove Servo_GetStyleVariables test special case (from heycam:rm-gsv-check); r=emilio This function disappeared a while ago. Source-Repo: https://github.com/servo/servo Source-Revision: 8b366a7441a7a4febcb5e2047807f9ad447c7adb
33f88f277d0ba2b04831c1d22970ed6185ae8440: Bug 1408118 - Disable Mac's insertion of its own full screen menu item as we already provide one. r=spohl
Mark Banner <standard8@mozilla.com> - Fri, 13 Oct 2017 08:47:56 +0100 - rev 680540
Push 84531 by bmo:stevea1@mac.com at Sun, 15 Oct 2017 02:53:14 +0000
Bug 1408118 - Disable Mac's insertion of its own full screen menu item as we already provide one. r=spohl MozReview-Commit-ID: EgCWL00ZfUT
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip