5563e7da39b265ed1ba7796ec058bdbcf6f792f6: Bug 1399536 - fix incorrect JS in test-onboarding-tour-type.js;r=Fischer
gasolin <gasolin@gmail.com> - Tue, 26 Sep 2017 16:03:21 +0800 - rev 671088
Push 81813 by bmo:standard8@mozilla.com at Wed, 27 Sep 2017 11:47:24 +0000
Bug 1399536 - fix incorrect JS in test-onboarding-tour-type.js;r=Fischer MozReview-Commit-ID: 8irepX9JY4o
984d5493a4b3a4d6b55a9ad6a83dba51ce73d250: Bug 1403022 - Abort session on BatchingUploader failures r=rnewman
Grigory Kruglov <gkruglov@mozilla.com> - Tue, 26 Sep 2017 17:36:22 -0400 - rev 671087
Push 81813 by bmo:standard8@mozilla.com at Wed, 27 Sep 2017 11:47:24 +0000
Bug 1403022 - Abort session on BatchingUploader failures r=rnewman The main goal of these changes is to ensure we're not doing any unnecessary work in the unahppy cases of BatchingUploader. We might fail in three general ways: - encounter a 412 error - encounter another type of HTTP error - encounter a GUID in the "failed" array Currently, in all of these cases, we de-facto abort the session, without performing an actual abort. E.g. we won't commit a batch, we'll refuse to upload any still-flowing records. This patch simplifies our unhappy-case behaviour: if something failed, actually abort the session (triggering a shutdownNow of the work queues), declare store as failed, etc. It's important to note that our "did the synchronization fail?" login in the SynchronizerSession depends on the store failure counts, and so this patch maintains the "record failed to store" delegate chain. However, these counts are largely meaningless. What does it mean to fail to store 50 records, if we abort on the 51st, and prevent the other 100 from flowing (and from being counted as failed?). This patch also fixes an omission in the verstion tracking logic: - prior, if we encountered a record in the "failed" array, we'd continue on with the flow, won't upload anything, mark the synchronization as failed, but we'd also call into 'onStoreCompleted' which will trigger an update of syncVersion for outflowing records - with this patch, we won't call into onStoreCompleted in the case above, and so won't update syncVersion in case of such failures - this is the correct behaviour for batching uploads (now enabled on all but one server), but possibly non-optimal behaviour if batching isn't enabled. However, this behaviour should be safe from a data consistency point of view regardless of the batching mode. MozReview-Commit-ID: LIYCPaRX8JA
1623a74b17bd2cf0aa121ea0937c2ecd243ac56f: Bug 1397486 - Update controlBar width according to videocontrols which really grows along <audio> width. r=jaws
Ray Lin <ralin@mozilla.com> - Thu, 14 Sep 2017 17:37:47 +0800 - rev 671086
Push 81813 by bmo:standard8@mozilla.com at Wed, 27 Sep 2017 11:47:24 +0000
Bug 1397486 - Update controlBar width according to videocontrols which really grows along <audio> width. r=jaws MozReview-Commit-ID: LpxH7Pnu7tQ
8bfe747029e1da11868bde9fdbf41b981af3bff9: No bug - Revendor rust dependencies
Servo VCS Sync <servo-vcs-sync@mozilla.com> - Wed, 27 Sep 2017 00:32:01 +0000 - rev 671085
Push 81813 by bmo:standard8@mozilla.com at Wed, 27 Sep 2017 11:47:24 +0000
No bug - Revendor rust dependencies
a51ac764452ac1939023f3d321febb9a67a362e4: Bug 1403048 - Update Rust deps for audioipc. r=kamidphish,rillian
Matthew Gregan <kinetik@flim.org> - Tue, 26 Sep 2017 15:51:30 +1300 - rev 671084
Push 81813 by bmo:standard8@mozilla.com at Wed, 27 Sep 2017 11:47:24 +0000
Bug 1403048 - Update Rust deps for audioipc. r=kamidphish,rillian
676427998df38ea39286b546b8b8ac372c9dee13: Bug 1403048 - Update media/audioipc to b5559d28. r=kamidphish
Matthew Gregan <kinetik@flim.org> - Tue, 26 Sep 2017 15:49:26 +1300 - rev 671083
Push 81813 by bmo:standard8@mozilla.com at Wed, 27 Sep 2017 11:47:24 +0000
Bug 1403048 - Update media/audioipc to b5559d28. r=kamidphish
17b17a40b14a376b5509b759b2de11d7d3456846: Merge m-c to autoland, a=merge
Wes Kocher <wkocher@mozilla.com> - Tue, 26 Sep 2017 17:15:46 -0700 - rev 671082
Push 81813 by bmo:standard8@mozilla.com at Wed, 27 Sep 2017 11:47:24 +0000
Merge m-c to autoland, a=merge MozReview-Commit-ID: Kjjgw1Pdb3U
4d35361e1aec0943999f72c83adb3b4089fd6c37: Bug 1399978 - Update cubeb-pulse-rs to git commit 2e22e53. r=kinetik
Dan Glastonbury <dglastonbury@mozilla.com> - Mon, 25 Sep 2017 15:23:30 +1000 - rev 671081
Push 81813 by bmo:standard8@mozilla.com at Wed, 27 Sep 2017 11:47:24 +0000
Bug 1399978 - Update cubeb-pulse-rs to git commit 2e22e53. r=kinetik MozReview-Commit-ID: INksO0nbT1F
e48250ab7382bc01d3f07e76ab04ad92fac6a5a2: Bug 1331769 - Test that there is no prompt for origin permission narrowing. r=aswan
Ian Moody <moz-ian@perix.co.uk> - Sun, 24 Sep 2017 01:34:10 +0100 - rev 671080
Push 81813 by bmo:standard8@mozilla.com at Wed, 27 Sep 2017 11:47:24 +0000
Bug 1331769 - Test that there is no prompt for origin permission narrowing. r=aswan MozReview-Commit-ID: 5twKRKK5uS2
1b732f1db72006bb01023dadae1fe4322e4c4f78: Bug 1331769 - Properly check whether new origin permissions are a subset of old origin permissions. r=aswan
Ian Moody <moz-ian@perix.co.uk> - Thu, 21 Sep 2017 17:03:15 +0100 - rev 671079
Push 81813 by bmo:standard8@mozilla.com at Wed, 27 Sep 2017 11:47:24 +0000
Bug 1331769 - Properly check whether new origin permissions are a subset of old origin permissions. r=aswan This prevents prompts occuring in cases where the new permissions are more specific but still covered by the old permissions. e.g.: ["<all_urls>"] -> ["<all_urls>", "*://*.example.com"] ["*://*.example.com"] -> ["http://subdomain.example.com"] MozReview-Commit-ID: B685pJ6kTNa
ea48aa0eb4dc8888c7eef37571d330d41f35bcdb: Bug 1402932 - Export Screenshots 19.1.0 to Firefox r=kmag
Ian Bicking <ianb@colorstudy.com> - Mon, 25 Sep 2017 13:17:43 -0500 - rev 671078
Push 81813 by bmo:standard8@mozilla.com at Wed, 27 Sep 2017 11:47:24 +0000
Bug 1402932 - Export Screenshots 19.1.0 to Firefox r=kmag MozReview-Commit-ID: A49wIA23mH9
ffcfc5b577221d93aaaa52babc30af96328d2c05: Backed out 3 changesets (bug 335545) for asan failures in test_bug1123480.xul a=backout
Wes Kocher <wkocher@mozilla.com> - Tue, 26 Sep 2017 15:26:07 -0700 - rev 671077
Push 81813 by bmo:standard8@mozilla.com at Wed, 27 Sep 2017 11:47:24 +0000
Backed out 3 changesets (bug 335545) for asan failures in test_bug1123480.xul a=backout Backed out changeset 25a686779a94 (bug 335545) Backed out changeset b83ddb70c8b5 (bug 335545) Backed out changeset ea69ee15ed90 (bug 335545) MozReview-Commit-ID: LkJgt3eSs2J
ade76994700a497c337cd70ca360365b58da70c2: Bug 1399642 - Use photon search icon in awesomebar. r=dao
Dale Harvey <dale@arandomurl.com> - Tue, 26 Sep 2017 11:13:56 +0100 - rev 671076
Push 81813 by bmo:standard8@mozilla.com at Wed, 27 Sep 2017 11:47:24 +0000
Bug 1399642 - Use photon search icon in awesomebar. r=dao MozReview-Commit-ID: Dzf8DqrGRam
a44a81c459ab2145cb40dfccbbedd85668c247f4: Bug 1401009 - Add border between notification buttons when highlight is disabled. r=johannh
Michael Kaply <mozilla@kaply.com> - Tue, 26 Sep 2017 14:25:33 -0500 - rev 671075
Push 81813 by bmo:standard8@mozilla.com at Wed, 27 Sep 2017 11:47:24 +0000
Bug 1401009 - Add border between notification buttons when highlight is disabled. r=johannh MozReview-Commit-ID: 4YGdUZstiDk
25a686779a940f1478aa2f4d1595f81344caac5c: Bug 335545 - Count FD instead of looking for clipboardcache in test_bug1123480.xul r=mstange
Rob Wu <rob@robwu.nl> - Thu, 21 Sep 2017 14:17:27 +0200 - rev 671074
Push 81813 by bmo:standard8@mozilla.com at Wed, 27 Sep 2017 11:47:24 +0000
Bug 335545 - Count FD instead of looking for clipboardcache in test_bug1123480.xul r=mstange - Count open file descriptors instead of testing the existence of a file (because the clipboard is now only reachable through file descriptors, and not through a file path). - Use a fixed string instead of a random string. The previous way of generating a string was non-deterministic, and there was a very small chance that the generated string was not large enough to trigger the cache-to-disk-mode. MozReview-Commit-ID: KOkYOm280Oh
b83ddb70c8b515b89b3e385d5b46f22b165792ed: Bug 335545 - Store clipboard data in memory XOR file r=mstange
Rob Wu <rob@robwu.nl> - Sun, 03 Sep 2017 03:21:45 +0200 - rev 671073
Push 81813 by bmo:standard8@mozilla.com at Wed, 27 Sep 2017 11:47:24 +0000
Bug 335545 - Store clipboard data in memory XOR file r=mstange Ensure that only DataStruct::mData + mDataLen, XOR DataStruct::mCacheFD is used. (Previously it was possible that all of these members were populated, which is a waste of memory.) The effect of this change is visible when SetTransferData is called multiple times with the same flavor, but with one below the threshold for storing in-memory, and the other above (=store in a file). MozReview-Commit-ID: 4UlkKAYsjf
ea69ee15ed90aa56ea1811b6ec473b0b0c31bad8: Bug 335545 - Use nsAnonymousTemporaryFile for clipboard cache r=mstange
Rob Wu <rob@robwu.nl> - Sun, 03 Sep 2017 02:29:10 +0200 - rev 671072
Push 81813 by bmo:standard8@mozilla.com at Wed, 27 Sep 2017 11:47:24 +0000
Bug 335545 - Use nsAnonymousTemporaryFile for clipboard cache r=mstange The cache file is never directly exposed to consumers of DataStruct, so it does not make sense to keep the clipboardcache file around forever. The only change in this commit is to switch from using a filename to using a file descriptor. In the destructor, the FD is explicitly closed (which releases the file data). nsAnonymousTemporaryFile takes care of removing the file when the destructor is not called (e.g. crashes). Previously, the clipboard cache was stored in a file called: TmpD/clipboardcache-N As of this commit, the clipboard cache is stored at: TmpD/mozilla-temp-randomN (macOS and Linux) TmpD/mozilla-temp-files/mozilla-temp-randomN (Windows) (see xpcom/io/nsAnonymousTemporaryFile.{h,cpp} for more details) To verify that these files are really gone: 1. Create a document with 500k+ characters, open it in Firefox. 2. Copy its content - this will trigger the clipboard cache. 3. Look for the open file descriptor of the deleted file: ( macOS and Linux: ) lsof +L1 | grep mozilla-temp 4. Copy anything (under the 500k threshold), or quit/kill Firefox. 5. Repeat step 3 and observe that the number of file descriptors has decreased. MozReview-Commit-ID: 85GlKQrNUl5
f31e9db442adf1a5bc208beabbcba435bc052ecf: servo: Merge #18641 - Improve DomRoot<T> (from servo:ROOT-ALL-THE-THINGS); r=SimonSapin
Anthony Ramine <n.oxyde@gmail.com> - Tue, 26 Sep 2017 14:25:20 -0500 - rev 671071
Push 81813 by bmo:standard8@mozilla.com at Wed, 27 Sep 2017 11:47:24 +0000
servo: Merge #18641 - Improve DomRoot<T> (from servo:ROOT-ALL-THE-THINGS); r=SimonSapin Source-Repo: https://github.com/servo/servo Source-Revision: 0160aaeeea848f685ba090b4541646b0429a37e1
50d414550fa4fe84656254dbdcac5e811a7fe6d9: Backed out changeset ff34580cb279 (bug 1394457) for failing many session store related tests due to exception, e.g. Marionette's test_refresh_firefox.py TestFirefoxRefresh.testReset. r=backout
Sebastian Hengst <archaeopteryx@coole-files.de> - Tue, 26 Sep 2017 23:06:25 +0200 - rev 671070
Push 81813 by bmo:standard8@mozilla.com at Wed, 27 Sep 2017 11:47:24 +0000
Backed out changeset ff34580cb279 (bug 1394457) for failing many session store related tests due to exception, e.g. Marionette's test_refresh_firefox.py TestFirefoxRefresh.testReset. r=backout
fe2e626594f52afdaa6c573de9615bb1b3cae197: Bug 1403292 - Add some comments to ignore the clang-format execution on these declarations r=jya
Sylvestre Ledru <sledru@mozilla.com> - Tue, 26 Sep 2017 21:11:33 +0200 - rev 671069
Push 81813 by bmo:standard8@mozilla.com at Wed, 27 Sep 2017 11:47:24 +0000
Bug 1403292 - Add some comments to ignore the clang-format execution on these declarations r=jya MozReview-Commit-ID: G30klPUAXTM
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip