549b5dfb1497f1a7ca4c084a9a9be4d007cf7dd9: Bug 1402170 - Use for...of instead of forEach for several tests in processing-a-keyframes-argument.html; r?hiro draft
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 11:36:42 +0900 - rev 673238
Push 82506 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:31:23 +0000
Bug 1402170 - Use for...of instead of forEach for several tests in processing-a-keyframes-argument.html; r?hiro for...of is generally preferred over forEach since it is a little easier to read and allows using 'break' and 'continue'. Furthermore it is supported in all major browsers. (It also makes wrapping one of the long lines in this file easier.) MozReview-Commit-ID: 1BuoW0QSxaG
19aa708f66fec84280e80ea88986e8c477e47a94: Bug 1404180 - Don't allow associating form elements by ID to <form>s across anonymous subtree boundaries. r?smaug draft
Cameron McCormack <cam@mcc.id.au> - Mon, 02 Oct 2017 13:10:18 +0800 - rev 673237
Push 82505 by bmo:cam@mcc.id.au at Mon, 02 Oct 2017 05:14:29 +0000
Bug 1404180 - Don't allow associating form elements by ID to <form>s across anonymous subtree boundaries. r?smaug MozReview-Commit-ID: KRJjrkL4FgZ
adcc117bc817f4b40c35f003665eebc64e5f55f6: Bug 1402170 - Rename copy-contructor.html to copy-constructor.html in two places in wpt for web-animations; r?hiro draft
Brian Birtles <birtles@gmail.com> - Mon, 02 Oct 2017 12:35:38 +0900 - rev 673236
Push 82504 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:09:17 +0000
Bug 1402170 - Rename copy-contructor.html to copy-constructor.html in two places in wpt for web-animations; r?hiro MozReview-Commit-ID: JxqRcQ5TJd5
e2043ad2ab8337305ae351aa8814d1218da6b830: Bug 1402170 - Add tests for error handling when parsing the 'easing' property on keyframes; r?hiro draft
Brian Birtles <birtles@gmail.com> - Mon, 02 Oct 2017 12:30:33 +0900 - rev 673235
Push 82504 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:09:17 +0000
Bug 1402170 - Add tests for error handling when parsing the 'easing' property on keyframes; r?hiro This tests the behavior clarified in the following spec changeset: https://github.com/w3c/web-animations/commit/d696468777c12a13bc7c46aa1a72c358e8da15fc MozReview-Commit-ID: 3hS7rHcTpUn
91aaa221c9232de5ac58855969c0f24d10c9d8d0: Bug 1402170 - Update test descriptions in processing-a-keyframes-argument-002.html; r?hiro draft
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 16:27:27 +0900 - rev 673234
Push 82504 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:09:17 +0000
Bug 1402170 - Update test descriptions in processing-a-keyframes-argument-002.html; r?hiro MozReview-Commit-ID: 8ofSWFs5b3u
98c0dd058a04f0fdd9e8c7dfe0455951787af504: Bug 1402170 - Use KeyframeEffect constructor in processing-a-keyframes-argument-002.html; r?hiro draft
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 16:12:44 +0900 - rev 673233
Push 82504 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:09:17 +0000
Bug 1402170 - Use KeyframeEffect constructor in processing-a-keyframes-argument-002.html; r?hiro MozReview-Commit-ID: 3JTFxw6Va1r
1fef9cd1843177b6a89c5742dd4b018e3b1c8d1c: Bug 1402170 - Move ease parsing tests to easing-tests.js; r?hiro draft
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 16:08:49 +0900 - rev 673232
Push 82504 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:09:17 +0000
Bug 1402170 - Move ease parsing tests to easing-tests.js; r?hiro MozReview-Commit-ID: JvUB6okJYI9
01f2208a99fddb3dce7c52b8bbb618429bef35cf: Bug 1402170 - Tidy up processing-a-keyframes-argument-002.html; r?hiro draft
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 16:03:01 +0900 - rev 673231
Push 82504 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:09:17 +0000
Bug 1402170 - Tidy up processing-a-keyframes-argument-002.html; r?hiro MozReview-Commit-ID: H7envMXOJhU
5f61687b2adae3dba91926df06eaea1796c13868: Bug 1402170 - Move tests for easing values on keyframes to processing-a-keyframes-argument-002.html; r?hiro draft
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 15:58:37 +0900 - rev 673230
Push 82504 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:09:17 +0000
Bug 1402170 - Move tests for easing values on keyframes to processing-a-keyframes-argument-002.html; r?hiro MozReview-Commit-ID: LEydYxdMoay
4e199d710850d763daaf7fbde12795af06c0eb3f: Bug 1402170 - Rename processing-a-keyframes-argument.html to have a 001 extension; r?hiro draft
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 15:52:37 +0900 - rev 673229
Push 82504 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:09:17 +0000
Bug 1402170 - Rename processing-a-keyframes-argument.html to have a 001 extension; r?hiro This naming is recommended by [1] and from a random sampling of tests in web-platform-tests it seems like most test don't use this, only tests that are split over multiple files. This "processing a keyframes argument" section is quite large so I intend to split the tests up into a number of files to cover: * Tests for property access * Tests for easing * Tests for offset * Tests for composite * Tests for equivalent forms [1] http://web-platform-tests.org/writing-tests/general-guidelines.html#file-paths-and-names MozReview-Commit-ID: JW2m50UnsKv
76753518497240d32e90084a72a8d0cece740c89: Bug 1402170 - Merge gInvalidEasingInKeyframeSequenceTests with gInvalidEasings; r?hiro draft
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 15:37:23 +0900 - rev 673228
Push 82504 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:09:17 +0000
Bug 1402170 - Merge gInvalidEasingInKeyframeSequenceTests with gInvalidEasings; r?hiro MozReview-Commit-ID: CIjKWyU2GIs
fab18aaab687800aa13a61317a5ca46a056baddf: Bug 1402170 - Consistently use spaces in object notation; r?hiro draft
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 15:20:13 +0900 - rev 673227
Push 82504 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:09:17 +0000
Bug 1402170 - Consistently use spaces in object notation; r?hiro This seems to be standard JS style recently (as used in prettier etc.): Use spaces to separate the { and } from the properties (but not for arrays). MozReview-Commit-ID: FRkFRwwcJJh
0d7f80ca9d6f0d4194420c0aae45a30b9078ec40: Bug 1402170 - Update various test descriptions to make them testable statements; r?hiro draft
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 15:14:45 +0900 - rev 673226
Push 82504 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:09:17 +0000
Bug 1402170 - Update various test descriptions to make them testable statements; r?hiro MozReview-Commit-ID: 9zVjiwb9vm8
3e537f0e2da1682d4438a60beff5bf668b41d4ed: Bug 1402170 - Tidy up test for property access order somewhat; r?hiro draft
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 15:04:54 +0900 - rev 673225
Push 82504 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:09:17 +0000
Bug 1402170 - Tidy up test for property access order somewhat; r?hiro MozReview-Commit-ID: 4JFae0SqMCX
b4d33eaf8bdbed71eb56b51fdf39995ef9888a9e: Bug 1402170 - Move test for accessing keyframe property order to processing-a-keyframes-argument.html; r?hiro draft
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 15:00:15 +0900 - rev 673224
Push 82504 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:09:17 +0000
Bug 1402170 - Move test for accessing keyframe property order to processing-a-keyframes-argument.html; r?hiro MozReview-Commit-ID: 3y6SnzAtNZZ
10f1ab8ce6292fe785e9427c52150b9e151840a0: Bug 1402170 - Update some test descriptions; r?hiro draft
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 11:54:50 +0900 - rev 673223
Push 82504 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:09:17 +0000
Bug 1402170 - Update some test descriptions; r?hiro * We should refer to reading or accessing properties, as opposed to "considering" them. * We should use "property-indexed" consistently. MozReview-Commit-ID: ItCE4g8LmOC
24ecd5e2ce63f339b74db6bc22e62c909970fb21: Bug 1402170 - Drop invalid test for offsets; r?hiro draft
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 11:43:11 +0900 - rev 673222
Push 82504 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:09:17 +0000
Bug 1402170 - Drop invalid test for offsets; r?hiro There is a test that assumes that an offset specified on a property-indexed keyframe is applied to all generated keyframes but that behavior is not (yet) specified. This behavior will be specified in [1] but until that happens it seems invalid to test for it. Furthermore, when that is specified we will need much more thorough tests than this one. [1] https://github.com/w3c/web-animations/issues/148 MozReview-Commit-ID: HUUw88dg2P7
b43a3bd7cf2e1ca41023a485d6c5ed8b9f329826: Bug 1402170 - Use template strings in processing-a-keyframes-argument.html; r?hiro draft
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 11:38:58 +0900 - rev 673221
Push 82504 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:09:17 +0000
Bug 1402170 - Use template strings in processing-a-keyframes-argument.html; r?hiro But only in a couple of places where it makes the test more readable. MozReview-Commit-ID: 6zVJ6h7Zb3k
317c4284979fdf2125e86d61abfb75de2359d620: Bug 1402170 - Use for...of instead of forEach for several tests in processing-a-keyframes-argument.html; r?hiro draft
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 11:36:42 +0900 - rev 673220
Push 82504 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:09:17 +0000
Bug 1402170 - Use for...of instead of forEach for several tests in processing-a-keyframes-argument.html; r?hiro for...of is generally preferred for over forEach and is supported in all major browsers. (It also makes wrapping one of the long lines in this file easier.) MozReview-Commit-ID: 1BuoW0QSxaG
c95c8a8940539127f552f7386b9832c26cadeb99: Bug 1402170 - Use ES6 let/const in processing-a-keyframes-argument.html; r?hiro draft
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 11:09:04 +0900 - rev 673219
Push 82504 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:09:17 +0000
Bug 1402170 - Use ES6 let/const in processing-a-keyframes-argument.html; r?hiro Gradually we plan to move all these tests to ES6 (or at least the subset supported by all UAs that are likely to implement this spec) so while we are touching this file we update a few uses of 'var' to let/const. MozReview-Commit-ID: 45OJyXmUzKu
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip