52a9e2f4bad0d145de4103ccf9f741ed279f50af: Bug 1353510 add PAC script API for compatibility, r?kmag draft
Shane Caraveo <scaraveo@mozilla.com> - Wed, 30 Aug 2017 16:59:31 -0700 - rev 656297
Push 77155 by mixedpuppy@gmail.com at Thu, 31 Aug 2017 00:01:51 +0000
Bug 1353510 add PAC script API for compatibility, r?kmag MozReview-Commit-ID: KuaUjLXqakU
8208f8b3d8f64971892d3503d784983e098c8633: Bug 1391534 - Fix computed prefixed linear gradient direction serialization r?dholbert draft
Nazım Can Altınova <canaltinova@gmail.com> - Wed, 30 Aug 2017 14:39:44 -0700 - rev 656296
Push 77154 by bmo:canaltinova@gmail.com at Wed, 30 Aug 2017 23:59:43 +0000
Bug 1391534 - Fix computed prefixed linear gradient direction serialization r?dholbert Prefixed linear gradients use direction keyword to indicate starting point of the gradient but modern syntax uses this keyword to indicate ending point of the gradient. Bottom-to-top direction is the default value for gradients. Therefore `top` is default value of prefixed linear gradients and `to bottom` is default one for unprefixed one. We were trying to remove `bottom` keyword from prefixed computed values which is wrong. MozReview-Commit-ID: 8UCsFE44LRX
21b02d4164abf75422920225749ffcfd3fc71e91: Bug 1392505 - Let RepositorySessions track their own lastFetch and lastStore timestamps r=rnewman draft
Grigory Kruglov <gkruglov@mozilla.com> - Wed, 30 Aug 2017 19:48:21 -0400 - rev 656295
Push 77153 by bmo:gkruglov@mozilla.com at Wed, 30 Aug 2017 23:49:05 +0000
Bug 1392505 - Let RepositorySessions track their own lastFetch and lastStore timestamps r=rnewman This patch moves some of the state tracking (fetchEnd/storeEnd timestamps) away from RecordsChannel and into individual RepositorySessions. The core assumption behind this move is that sessions are better suited to know when they were fetched from during this sync, and when they were stored to. Sessions are growing in complexity - local ones are wrapped in a buffer, remote now support batching downloads and uploads. In order to hide these details, it's easier to let sessions keep track of the fetch/store timestamps in the way that fits their implementations. Instead of flowing these timestamps upwards from sessions and into the SynchronizerSession, the latter now simply queries sessions at the end of their flows. The default behavior if a certain operation wasn't performed - that is, if fetchEnd or storeEnd aren't set during sync for a session - is to return timestamp persisted during the previous sync. This allows us to skip certain flows (no remote data available), and ensure that we're always using correct timestamps of the same origin for any given session. Prior behaviour was to "make up" a timestamp at the RecordsChannel level in cases of certain errors or skipped flows, which resulted in comparing timestamps of different origins on the consequent sync. MozReview-Commit-ID: 2wqeTo7mhz3
9f8927d4298759ca7f9b862e51932a54ed7cb590: Bug 1392505 - Pre: remove unused delegate interface r=rnewman draft
Grigory Kruglov <gkruglov@mozilla.com> - Fri, 25 Aug 2017 21:44:37 -0400 - rev 656294
Push 77153 by bmo:gkruglov@mozilla.com at Wed, 30 Aug 2017 23:49:05 +0000
Bug 1392505 - Pre: remove unused delegate interface r=rnewman MozReview-Commit-ID: K93rK1pILky
ea41cff7dc3ff007e6ec79512e34a17eca6d7b28: Bug 1395392 - Clean up unnecessary variable. r?chmanchester draft
Ralph Giles <giles@mozilla.com> - Wed, 30 Aug 2017 16:39:06 -0700 - rev 656293
Push 77152 by bmo:giles@thaumas.net at Wed, 30 Aug 2017 23:45:43 +0000
Bug 1395392 - Clean up unnecessary variable. r?chmanchester The `os` dereference here is only used in the error message, and using it in the conditional tree doesn't really help readability since it's too short; the target prefix is helpful. MozReview-Commit-ID: 4A8MpRH2r0p
20adc3d073d74901eb9e64d31fa48b0906c286ca: Bug 1395392 - Don't enable webspeech for b2g. r?chmanchester draft
Ralph Giles <giles@mozilla.com> - Wed, 30 Aug 2017 16:35:16 -0700 - rev 656292
Push 77152 by bmo:giles@thaumas.net at Wed, 30 Aug 2017 23:45:43 +0000
Bug 1395392 - Don't enable webspeech for b2g. r?chmanchester We no longer support b2g builds, so this is an unnecessary check. MozReview-Commit-ID: 5oie28IlRz1
c44cc81eed229c3844c2fa2f7e2682fa17716a34: Bug 1395392 - Remove support for non-standard implied toolkit configs. r?chmanchester draft
Ralph Giles <giles@mozilla.com> - Wed, 30 Aug 2017 16:30:52 -0700 - rev 656291
Push 77152 by bmo:giles@thaumas.net at Wed, 30 Aug 2017 23:45:43 +0000
Bug 1395392 - Remove support for non-standard implied toolkit configs. r?chmanchester This was a work-around for b2g work and is no longer used by code we have in-tree. MozReview-Commit-ID: DgZIecxqfB6
3945a3a878c54a613269d899d3f5c8d27177b6a5: Bug 1393098 part 1: Adjust nsTextFrame::CharacterDataChanged to skip redundant requests for reflow, via a new boolean member-var. r?jfkthame draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 30 Aug 2017 16:37:16 -0700 - rev 656290
Push 77151 by dholbert@mozilla.com at Wed, 30 Aug 2017 23:41:33 +0000
Bug 1393098 part 1: Adjust nsTextFrame::CharacterDataChanged to skip redundant requests for reflow, via a new boolean member-var. r?jfkthame Some benchmarks & use-cases cause nsTextFrame::CharacterDataChanged to be called multiple times for the same text between reflows. Each call triggers a slightly-expensive call to shell->FrameNeedsReflow(), for each affected nsTextFrame in the continuation chain. (OK, it's not quite that bad -- we skip the FrameNeedsReflow calls for siblings, since the ancestor notifications/tweaks would all be the same.) This patch makes us set a flag on the nsTextFrame to indicate that a reflow has *already* been requested by this chunk of code, and we'll now use that to skip the FrameNeedsReflow() call (and the dirty-bit-setting for siblings) on the next invocation. And we clear this new flag when the pending reflow actually happens. This shouldn't change behavior in a web-observable way, but it should speed things up by removing redundant work. MozReview-Commit-ID: 5nmbZHEFFDi
66f0be385f8921e6d53f2f4dbc09b4e89138c39d: Bug 1393098 part 0: Refactor logic (add helper bool & reduce GetParent calls), in nsTextFrame::CharacterDataChanged. r?jfkthame draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 30 Aug 2017 16:35:52 -0700 - rev 656289
Push 77151 by dholbert@mozilla.com at Wed, 30 Aug 2017 23:41:33 +0000
Bug 1393098 part 0: Refactor logic (add helper bool & reduce GetParent calls), in nsTextFrame::CharacterDataChanged. r?jfkthame This patch doesn't affect behavior at all -- it just adjusts the logic slightly. Specifically, this patch: (a) Changes some code that currently tracks a frame, to now instead track that frame's parent, since we only ever call GetParent() on it anyway. (b) Drops a null-check that becomes unnecessary as a result of that change. (It was only there to protect us from calling GetParent() on a null pointer during the first loop iteration, and now that's not a risk since we're tracking the parent itself, and a null value will fail the equality comparison and do the right thing.) (c) Captures the "are ancestors already aware of a reflow request for my subtree" if-condition in a named boolean helper-variable. (d) Adds/improves documentation. MozReview-Commit-ID: 7dEflfiERYB
ff6493183bee1f6a44469bbebca71d6ff616678b: Bug 1394995 - Fixed race in DDLogMessagesBufferQueue::Log_WasNewBufferAdded - r?jwwang draft
Gerald Squelart <gsquelart@mozilla.com> - Thu, 31 Aug 2017 11:22:24 +1200 - rev 656288
Push 77150 by gsquelart@mozilla.com at Wed, 30 Aug 2017 23:37:26 +0000
Bug 1394995 - Fixed race in DDLogMessagesBufferQueue::Log_WasNewBufferAdded - r?jwwang There could be a situation where thread 1 logs the last message in a buffer, but gets suspended even before looking at the head node. In the meantime thread 2 will log a new message, and therefore will create a new head node. When thread 1 resumes it will read the newly-created (but wrong) head node and just write at the end of it! This could completely block the processing from happening, as the last message of a node will never become valid. That special case was handled just above in a subset of situations, so the fix is just to move that code to a better location where it will catch all issues. *** Note to reviewer: This is a separate patch, not to disturb your review; I will roll this patch into the main one after the first review is completed. MozReview-Commit-ID: RSTPAgDB9S
c5a779f68eb7e6f6dec003cec2cf13a03a9cdac2: Bug 1394995 - Initial implementation of DecoderDoctorLogger - r?jwwang draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 28 Aug 2017 11:54:12 +1200 - rev 656287
Push 77150 by gsquelart@mozilla.com at Wed, 30 Aug 2017 23:37:26 +0000
Bug 1394995 - Initial implementation of DecoderDoctorLogger - r?jwwang DecoderDoctorLogger and its related classes offer a cheap way to gather log messages from media stack objects, and then process these messages to extract object lifetimes and messages related to separate HTMLMediaElement's. MozReview-Commit-ID: AIf2nAMjoDy
dd395b718b596bd6f9f6dd0087950de65fd7df49: Bug 1394995 - Moved DecoderDoctor files to dom/media/doctor/ - r?jwwang draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 28 Aug 2017 10:37:44 +1200 - rev 656286
Push 77150 by gsquelart@mozilla.com at Wed, 30 Aug 2017 23:37:26 +0000
Bug 1394995 - Moved DecoderDoctor files to dom/media/doctor/ - r?jwwang MozReview-Commit-ID: 9fEmeizzAAw
c22fb9355cc194654907098d770fda9f39fc285b: Bug 1395183 - Update size of web-ext note icon in about:debugging r?jdescottes draft
Mark Striemer <mstriemer@mozilla.com> - Wed, 30 Aug 2017 18:27:51 -0500 - rev 656285
Push 77149 by bmo:mstriemer@mozilla.com at Wed, 30 Aug 2017 23:28:21 +0000
Bug 1395183 - Update size of web-ext note icon in about:debugging r?jdescottes MozReview-Commit-ID: DYuU04hkhKt
d9b405d82cffb07343a5f2fd941e029298c7f6c4: Backed out changeset f3a4f4402577 (bug 1385249) for reftest failures in 966992-1.html a=backout CLOSED TREE
Wes Kocher <wkocher@mozilla.com> - Wed, 30 Aug 2017 15:48:29 -0700 - rev 656284
Push 77149 by bmo:mstriemer@mozilla.com at Wed, 30 Aug 2017 23:28:21 +0000
Backed out changeset f3a4f4402577 (bug 1385249) for reftest failures in 966992-1.html a=backout CLOSED TREE MozReview-Commit-ID: 7fX0Xd9C1VJ
c1c03b6102ed21321126ddf4e1bf376597bec03a: Bug 1376507 - Handle a list of contexts instead of a single context. r=billm draft
Blake Kaplan <mrbkap@gmail.com> - Mon, 28 Aug 2017 16:05:11 -0700 - rev 656283
Push 77148 by bmo:mrbkap@mozilla.com at Wed, 30 Aug 2017 23:27:42 +0000
Bug 1376507 - Handle a list of contexts instead of a single context. r=billm This might be prematurely optimized as it uses two lists (one list of active contexts and one list of inactive contexts) but I was really attracted by the idea of being able to answer questions like "is any context active" by only looking at a single context and not having to iterate the whole list every time we needed to do anything. It is really important that nobody touches any of the timestamps (or the mActive member) outside of the Watchdog lock. I thought about trying to encapsulate that data in its own class, but that felt like overkill. Let me know if you disagree. There are still a couple of uses of XPCJSContext::Get that probably need to be stamped out, but I think doing so will depend on the details of how we map JSContexts to XPCJSContext (and XPCJSRuntimes). I think that should wait for a separate bug. MozReview-Commit-ID: 9UZlh7Jutne
f351e5349d5b8f055936a6232d01b34916bd4b8e: Bug 1380605 - modifications to build openh264 v1.7.1 draft
Nick Thomas <nthomas@mozilla.com> - Wed, 30 Aug 2017 12:37:56 +1200 - rev 656282
Push 77147 by nthomas@mozilla.com at Wed, 30 Aug 2017 23:23:16 +0000
Bug 1380605 - modifications to build openh264 v1.7.1 Notable changes * ensure we run dump-symbols and upload actions on all platforms * On android: * add configuration and support for aarch64 * set min_sdk levels to match Fennec builds * use a full copy of the r11c ndk (our truncated one was missing toolchains we needed) and set NDKROOT when calling build * ensure the tooltool provided sdk is on the PATH * on linux copy tooltool.py into the mock environment, so we can get dump_syms from tt * remove macosx32 config as we've deprecated that in Firefox builds * update dump_syms to recent m-c, notably for aarch64 support on linux * on linux rev e365137fa61bfd729617ba1ebf9f1ed79facd1f2 (via try 0f72a5c28be1cdc2f3bdfaafdf3826254f6ba077) * on mac rev e365137fa61bfd729617ba1ebf9f1ed79facd1f2 (via compile on a bld-lin-r5) * on windows rev a4a448ba7f187069fce916ee234a06cbb0d06f80 (via try dc8b121e3c08e8022d62c0fa1951dd3dc4d6f7cc) * switch to Visual Studio 2015 Update 3 on win32/win64 to match Firefox * many updates to environement variables * painful to get win64 right to run win32 dump_syms.exe, but that's why the x86 redist is on teh PATH * unwind the changes to get_output_from_command() in v1.6 patch to avoid affecting other builds, and use query_env() which has this support already * add a scp_upload_directory since we don't have rsync on windows, use that to talk to the ffxbld upload host (not a long term solution but OK for now) Applies on top of https://reviewboard.mozilla.org/r/64022/diff/4#index_header MozReview-Commit-ID: B3NiWFvr2oR
0a107cbbe501ce1cae5fc84024ed70cbb09c8bec: Bug 1393098 part 1: Adjust nsTextFrame::CharacterDataChanged to skip redundant requests for reflow, via a new boolean member-var. r?jfkthame draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 30 Aug 2017 16:20:51 -0700 - rev 656281
Push 77146 by dholbert@mozilla.com at Wed, 30 Aug 2017 23:21:01 +0000
Bug 1393098 part 1: Adjust nsTextFrame::CharacterDataChanged to skip redundant requests for reflow, via a new boolean member-var. r?jfkthame Some benchmarks & use-cases cause nsTextFrame::CharacterDataChanged to be called multiple times for the same text between reflows. Each call triggers a slightly-expensive call to shell->FrameNeedsReflow(), for each affected nsTextFrame in the continuation chain. (OK, it's not quite that bad -- we skip the FrameNeedsReflow calls for siblings, since the ancestor notifications/tweaks would all be the same.) This patch makes us set a flag on the nsTextFrame to indicate that a reflow has *already* been requested by this chunk of code, and we'll now use that to skip the FrameNeedsReflow() call (and the dirty-bit-setting for siblings) on the next invocation. And we clear this new flag when the pending reflow actually happens. This shouldn't change behavior in a web-observable way, but it should speed things up by removing redundant work. MozReview-Commit-ID: 5nmbZHEFFDi
c494947d4007274be8b7bb3a0bc23bf3f0d9a25d: Bug 1380605 - Rebased patch from OpenH264 v1.6 (bug 1286533), p=Callek r?catlee draft
Justin Wood <Callek@gmail.com> - Wed, 13 Jul 2016 09:05:44 -0400 - rev 656280
Push 77145 by nthomas@mozilla.com at Wed, 30 Aug 2017 23:20:42 +0000
Bug 1380605 - Rebased patch from OpenH264 v1.6 (bug 1286533), p=Callek r?catlee Imported from https://reviewboard.mozilla.org/r/64022/diff/4#index_header MozReview-Commit-ID: B3NiWFvr2oR
442a182ee870b707443fddc10ed28c3edf5ec1dd: Bug 1393098 part 1: Adjust nsTextFrame::CharacterDataChanged to skip redundant requests for reflow, via a new boolean member-var. r?jfkthame draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 30 Aug 2017 16:17:04 -0700 - rev 656279
Push 77144 by dholbert@mozilla.com at Wed, 30 Aug 2017 23:17:19 +0000
Bug 1393098 part 1: Adjust nsTextFrame::CharacterDataChanged to skip redundant requests for reflow, via a new boolean member-var. r?jfkthame Some benchmarks & use-cases cause nsTextFrame::CharacterDataChanged to be called multiple times for the same text between reflows. Each call triggers a slightly-expensive call to shell->FrameNeedsReflow(), for each affected nsTextFrame in the continuation chain. (OK, it's not quite that bad -- we skip the FrameNeedsReflow calls for siblings, since the ancestor notifications/tweaks would all be the same.) This patch makes us set a flag on the nsTextFrame to indicate that a reflow has *already* been requested by this chunk of code, and we'll now use that to skip the FrameNeedsReflow() call (and the dirty-bit-setting for siblings) on the next invocation. And we clear this new flag when the pending reflow actually happens. This shouldn't change behavior in a web-observable way, but it should speed things up by removing redundant work. MozReview-Commit-ID: 5nmbZHEFFDi
b1c8eefe850f72a895338d46c20d49a55837b3a3: Bug 1393098 part 1: Adjust nsTextFrame::CharacterDataChanged to skip redundant requests for reflow, via a new boolean member-var. r?jfkthame draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 30 Aug 2017 16:09:30 -0700 - rev 656278
Push 77143 by dholbert@mozilla.com at Wed, 30 Aug 2017 23:10:17 +0000
Bug 1393098 part 1: Adjust nsTextFrame::CharacterDataChanged to skip redundant requests for reflow, via a new boolean member-var. r?jfkthame Some benchmarks & use-cases cause nsTextFrame::CharacterDataChanged to be called multiple times for the same text between reflows. Each call triggers a slightly-expensive call to shell->FrameNeedsReflow(), for each affected nsTextFrame in the continuation chain. (OK, it's not quite that bad -- we skip the FrameNeedsReflow calls for siblings, since the ancestor notifications/tweaks would all be the same.) This patch makes us set a flag on the nsTextFrame to indicate that a reflow has *already* been requested by this chunk of code, and we'll now use that to skip the FrameNeedsReflow() call (and the dirty-bit-setting for siblings) on the next invocation. And we clear this new flag when the pending reflow actually happens. This shouldn't change behavior in a web-observable way, but it should speed things up by removing redundant work. MozReview-Commit-ID: 5nmbZHEFFDi
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip