51e13cd4ec4a0ad9ec91e3bf2b52768aa6ba5e16: Bug 1426244 - 1. Fix some errors from javadoc generation; r=nalexander draft
Jim Chen <nchen@mozilla.com> - Sat, 13 Jan 2018 17:41:08 -0500 - rev 720171
Push 95466 by bmo:nchen@mozilla.com at Mon, 15 Jan 2018 00:55:47 +0000
Bug 1426244 - 1. Fix some errors from javadoc generation; r=nalexander Tweak the javadoc task arguments to not generate errors for a standard GeckoView javadoc run. MozReview-Commit-ID: 931xCtUcX6N
1817e2115368d8c3b8689c649915b549606b38bc: Bug 1429764 Do not call ReduceTimerPrecision twice for DOM Navigation timers r?timhuang,bkelly draft
Tom Ritter <tom@mozilla.com> - Fri, 12 Jan 2018 13:36:04 -0600 - rev 720170
Push 95465 by bmo:tom@mozilla.com at Sun, 14 Jan 2018 19:58:47 +0000
Bug 1429764 Do not call ReduceTimerPrecision twice for DOM Navigation timers r?timhuang,bkelly Bug 1429764 details a test failure that was asserting that the performance navigation timers were strictly increasing (or equal). fetchStart should have a timestamp before domainLookupStart. But it didn't. The problem is two-fold. This corrects the test and the issue by addressing one part of the problem, the second part of the problem needs to be written up in a new bug and addressed there. (That bug is not yet filed at writing, but see dependencies of 1429764 in the future to find it.) The second, and underlying, problem is that calling ReduceTimerPrecision with the same value multiple times may continually reduce it. Meaning that the first you call it with, say, .75, (and a precision of .20), it will be reduced to .6. The second time you call it (with .6), instead of staying at .6 it will be reduced to .4. This is because floats are fuzzy. Inside ReduceTimerPrecision we are multiplying a decimal by a decimal, so while floor(.6 / .20) should equal 3, sometimes it's actually 2.999... which gets floors to 2, gets multiplied again by .2, and which results in .4 If that's the underlying problem, the first, and surface, problem is - why are we calling ReduceTimerPrecision multiple times? We shouldn't be. That's what this patch fixes. TimeStampToDOMHighResOrFetchStart will return either TimeStampToDOMHighRes() or FetchStartHighRes(). FetchStartHighRes() internally calls TimeStampToDOMHighRes and then ReduceTimerPrecision - this is where (some of) the two reduction calls happen - because TimeStampToDOMHighRes itself calls ReduceTimerPrecision also. I remove the ReduceTimerPrecision from TimeStampToDOMHighRes. FetchStartHighRes will now only call ReduceTimerPrecision once, at the end of the return. But we have to fix places we call TimeStampToDOMHighResOrFetchStart, because the callers of that function also call ReduceTimerPrecision. So if TimeStampToDOMHighResOrFetchStart returned FetchStartHighRes, we'd be calling ReduceTimerPrecision twice for those callers. So inside first off, we remove the outer call to ReduceTimerPrecision. that surrounds the 5 or so callsites of TimeStampToDOMHighResOrFetchStart. Then inside of TimeStampToDOMHighResOrFetchStart we return either FetchStartHighRes (which is has already called ReduceTimerPrecision) or we call ReduceTimerPrecision with the value. Now. TimeStampToDOMHighRes was used in more places than just FetchStartHighRes - there were several other places where we were doing double rounding, and this fixed those as well. AsyncOpenHighRes, WorkerStartHighRes, DomainLookupEndHighRes, ConnectStartHighRes, SecureConnectionStartHighRes, ConnectEndHighRes, and ResponseEndHighRes. MozReview-Commit-ID: K5nHql135rb
d51a95a246666dfbbac37c296f61e3cd913056dd: Bug 1428852 - Crash reporter leaks file handle r?gsvelto draft
Jean-Luc Bonnafoux <jeanluc.bonnafoux@wanadoo.fr> - Sun, 14 Jan 2018 17:39:40 +0100 - rev 720169
Push 95464 by bmo:jeanluc.bonnafoux@wanadoo.fr at Sun, 14 Jan 2018 16:41:24 +0000
Bug 1428852 - Crash reporter leaks file handle r?gsvelto MozReview-Commit-ID: IXeI73FipZv
ba2281a150fcdafebe616f3ead2d5c5d3183f35d: Bug 1430425 - VideoStreamFactory constructor should pass codec name by reference r?dminor draft
Jean-Luc Bonnafoux <jeanluc.bonnafoux@wanadoo.fr> - Sun, 14 Jan 2018 17:26:26 +0100 - rev 720168
Push 95463 by bmo:jeanluc.bonnafoux@wanadoo.fr at Sun, 14 Jan 2018 16:31:50 +0000
Bug 1430425 - VideoStreamFactory constructor should pass codec name by reference r?dminor MozReview-Commit-ID: 8rUH1DfEUts
93d32aa98190ff6a4e5bb53a6c435bec7695bf3a: Bug 1283222 - add WPT tests for empty out-of-flow elements. draft
Jeremy Chen <jeremychen@mozilla.com> - Mon, 15 Jan 2018 00:20:09 +0800 - rev 720167
Push 95462 by bmo:jeremychen@mozilla.com at Sun, 14 Jan 2018 16:25:24 +0000
Bug 1283222 - add WPT tests for empty out-of-flow elements. According to CSS Text 3 Specification, out-of-flow elements do not introduce a forced line break or soft wrap opportunity in the flow. So, empty out-of-flow elements should be treated/rendered like empty in-flow elements. In this patch, we add tests to ensure this. MozReview-Commit-ID: 5WmVcTzBXMu
7f52be6eb8566e8590e9b3069b8f27498d5bf283: Bug 1283222 - add WPT tests for empty out-of-flow elements. draft
Jeremy Chen <jeremychen@mozilla.com> - Mon, 15 Jan 2018 00:20:09 +0800 - rev 720166
Push 95461 by bmo:jeremychen@mozilla.com at Sun, 14 Jan 2018 16:23:58 +0000
Bug 1283222 - add WPT tests for empty out-of-flow elements. According to CSS Text 3 Specification, out-of-flow non-empty elements do not introduce a forced line break or soft wrap opportunity in the flow. So, empty out-of-flow elements should be treated/rendered like empty in-flow elements. In this patch, we add tests to ensure this. MozReview-Commit-ID: 5WmVcTzBXMu
908a554bd59a08c914a20d0b15d1e017fff8f6ce: Bug 1430109 - Combine assert.window and assert.contentBrowser. r?maja_zf draft
Andreas Tolfsen <ato@sny.no> - Fri, 12 Jan 2018 14:25:30 +0000 - rev 720165
Push 95460 by bmo:ato@sny.no at Sun, 14 Jan 2018 15:14:24 +0000
Bug 1430109 - Combine assert.window and assert.contentBrowser. r?maja_zf The forthcoming window tracking refactoring introduces the new abstractions ContentContext and ChromeContext that to a large extent share the same interface. They make it possible to interact with both types of browsing context in a uniform manner. Marionette currently has a lot of convoluted if-conditions to paper over the differences between ChromeWindow, <xul:browser>, and browser.Context. Examples of this includes the assert.window and assert.contentBrowser assertions: they essentially perform the same job, but does not share the same API because the underlying APIs they call are different. In an effort to prepare Marionette for the window tracking refactoring, this patch adds a bit of glue to combine them both into one assertion called assert.open. This checks that the browsing context has not been discarded. MozReview-Commit-ID: K5e7Sr1mq0
e4ec6b49f9f5f60eb7a6dadfb33df3fb7b96f0e2: Bug 1389829 - Part 4 - Add simple Robocop test for View Page Source. r?nechen draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 13 Jan 2018 21:10:45 +0100 - rev 720164
Push 95459 by mozilla@buttercookie.de at Sun, 14 Jan 2018 13:29:51 +0000
Bug 1389829 - Part 4 - Add simple Robocop test for View Page Source. r?nechen MozReview-Commit-ID: DFC17YSSinx
62f5f4ec77d3e2c759e221941a2b170e8c42c505: Bug 1389829 - Part 3 - Handle "View Page Source" on the JS side. r?esawin draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 13 Aug 2017 18:28:50 +0200 - rev 720163
Push 95459 by mozilla@buttercookie.de at Sun, 14 Jan 2018 13:29:51 +0000
Bug 1389829 - Part 3 - Handle "View Page Source" on the JS side. r?esawin MozReview-Commit-ID: AOmTcNQ7qlj
736fb3f47d95f982a3c9d6327b33e2849b5fd39b: Bug 1389829 - Part 2 - Make files needed for View Source available for Fennec. r?esawin draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 13 Jan 2018 17:46:29 +0100 - rev 720162
Push 95459 by mozilla@buttercookie.de at Sun, 14 Jan 2018 13:29:51 +0000
Bug 1389829 - Part 2 - Make files needed for View Source available for Fennec. r?esawin viewPartialSource.js/xul and viewSource.css/js/xul are only required for opening the source in a new, special window. On Android we'll always use a new tab instead, so we don't have to include them there. MozReview-Commit-ID: LjX1WKELjqz
9d9dc827d68bd80002c7dba0ca9e5c98df6fab38: Bug 1389829 - Part 4 - Add simple Robocop test for View Page Source. r?nechen draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 13 Jan 2018 21:10:45 +0100 - rev 720161
Push 95458 by mozilla@buttercookie.de at Sun, 14 Jan 2018 13:25:40 +0000
Bug 1389829 - Part 4 - Add simple Robocop test for View Page Source. r?nechen MozReview-Commit-ID: DFC17YSSinx
5d86de800f5a62a2a9da6645844bdb72f22eaaad: Bug 1389829 - Part 3 - Handle "View Page Source" on the JS side. r?esawin draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 13 Aug 2017 18:28:50 +0200 - rev 720160
Push 95458 by mozilla@buttercookie.de at Sun, 14 Jan 2018 13:25:40 +0000
Bug 1389829 - Part 3 - Handle "View Page Source" on the JS side. r?esawin MozReview-Commit-ID: AOmTcNQ7qlj
ce90b637dfc66109036aac9144e599a99efd10d9: Bug 1389829 - Part 2 - Make files needed for View Source available for Fennec. r?esawin draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 13 Jan 2018 17:46:29 +0100 - rev 720159
Push 95458 by mozilla@buttercookie.de at Sun, 14 Jan 2018 13:25:40 +0000
Bug 1389829 - Part 2 - Make files needed for View Source available for Fennec. r?esawin viewPartialSource.js/xul and viewSource.css/js/xul are only required for opening the source in a new, special window, so we don't have to include them on Android, because there we'll always only open a new tab. MozReview-Commit-ID: LjX1WKELjqz
f3b3a132e718dbe0d07dd03e6df4ff9c5c2ad521: Bug 1389829 - Part 1 - Add "View Page Source" to the Page menu in the UI. r?nechen draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 13 Aug 2017 16:15:26 +0200 - rev 720158
Push 95458 by mozilla@buttercookie.de at Sun, 14 Jan 2018 13:25:40 +0000
Bug 1389829 - Part 1 - Add "View Page Source" to the Page menu in the UI. r?nechen The Page menu is disabled when no tab is open, so not doing a null-check on the currently selected tab in the menu click handler is safe. MozReview-Commit-ID: CYKHJ5N1q8I
b0acab0423a91c59bb1e0c32dd7348e4e0c3f44f: Bug 1430414 - Remove unused package-manifest.in references. r?nalexander draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 13 Jan 2018 18:48:39 +0100 - rev 720157
Push 95458 by mozilla@buttercookie.de at Sun, 14 Jan 2018 13:25:40 +0000
Bug 1430414 - Remove unused package-manifest.in references. r?nalexander Those are all remnants of APIs that are now gone for good. MozReview-Commit-ID: 266GvgbES3s
0042f4dd19901a183b0b073bb1c73baf796b0c2a: Bug 1430411 - Exclude viewZoomOverlay.js from Fennec builds. r?esawin draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 13 Jan 2018 18:09:20 +0100 - rev 720156
Push 95458 by mozilla@buttercookie.de at Sun, 14 Jan 2018 13:25:40 +0000
Bug 1430411 - Exclude viewZoomOverlay.js from Fennec builds. r?esawin That file is only needed for desktop Firefox and when displaying the page source in a separate window, which is a desktop-only feature as well. MozReview-Commit-ID: 5wgvoIW12Xn
87ff67bde212e25369904e740629ab169ebc9078: Bug 1429929 - Remove tabbrowser-close-tab-button binding. r?gijs draft
Dão Gottwald <dao@mozilla.com> - Sun, 14 Jan 2018 13:12:05 +0100 - rev 720155
Push 95457 by dgottwald@mozilla.com at Sun, 14 Jan 2018 12:12:42 +0000
Bug 1429929 - Remove tabbrowser-close-tab-button binding. r?gijs MozReview-Commit-ID: 3bIccSfVMuJ
92c108c86e6d737f17a788e3095daea117f58c9e: Bug 1430411 - Exclude viewZoomOverlay.js from Fennec builds. r?esawin draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 13 Jan 2018 18:09:20 +0100 - rev 720154
Push 95456 by mozilla@buttercookie.de at Sun, 14 Jan 2018 11:42:18 +0000
Bug 1430411 - Exclude viewZoomOverlay.js from Fennec builds. r?esawin That file is only needed for desktop Firefox and when displaying the page source in a separate window, which is a desktop-only feature as well. MozReview-Commit-ID: 5wgvoIW12Xn
c58a349ab84d4e8f195d2fc2b3a79bae10440273: Bug 1429929 - Remove tabbrowser-close-tab-button binding. r?gijs draft
Dão Gottwald <dao@mozilla.com> - Sun, 14 Jan 2018 12:28:17 +0100 - rev 720153
Push 95455 by dgottwald@mozilla.com at Sun, 14 Jan 2018 11:28:47 +0000
Bug 1429929 - Remove tabbrowser-close-tab-button binding. r?gijs MozReview-Commit-ID: AELxiBItQUR
39d35c6bd3513fd8cca0c56c825ccfe086ae4a61: Bug 1430457 - Stop using -moz-border-top-colors for the lwtheme faux window border on Windows 7. r?jaws draft
Dão Gottwald <dao@mozilla.com> - Sun, 14 Jan 2018 12:02:50 +0100 - rev 720152
Push 95454 by dgottwald@mozilla.com at Sun, 14 Jan 2018 11:03:36 +0000
Bug 1430457 - Stop using -moz-border-top-colors for the lwtheme faux window border on Windows 7. r?jaws MozReview-Commit-ID: 1qArevPwzcG
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip