51571f2cd52eb2694fee5868b772cb448bd020ab: Backed out changeset 49ef9e17682e (bug 1377974) for gl error during test_conformance__extensions__webgl-debug-shaders.html. r=backout on a CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 14 Jul 2017 10:11:11 +0200 - rev 608986
Push 68469 by bmo:tlin@mozilla.com at Fri, 14 Jul 2017 14:21:07 +0000
Backed out changeset 49ef9e17682e (bug 1377974) for gl error during test_conformance__extensions__webgl-debug-shaders.html. r=backout on a CLOSED TREE
2a4effa27df4c80076fac61fca0438af0a841097: Backed out changeset 7ec72cbf67b6 (bug 1380471) for Windows 2012 static bustage. r=backout on a CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 14 Jul 2017 10:00:52 +0200 - rev 608985
Push 68469 by bmo:tlin@mozilla.com at Fri, 14 Jul 2017 14:21:07 +0000
Backed out changeset 7ec72cbf67b6 (bug 1380471) for Windows 2012 static bustage. r=backout on a CLOSED TREE
85a383b0638256b457b42689c8580200ad52e669: Bug 1374828 - Properly initialize/shutdown telemetry in test_TelemetrySession.js. r=chutten
Alessio Placitelli <alessio.placitelli@gmail.com> - Thu, 13 Jul 2017 09:51:00 +0200 - rev 608984
Push 68469 by bmo:tlin@mozilla.com at Fri, 14 Jul 2017 14:21:07 +0000
Bug 1374828 - Properly initialize/shutdown telemetry in test_TelemetrySession.js. r=chutten This patch adds TelemetryController.testShutdown() calls to the tests that were not calling it, relying on TelemetryController.testReset() to do the full shutdown/restart cycle. Without the shutdown, the telemetry scheduler was generating rougue daily pings at undesired times.
bfd1975229fddbaf6994373e4a8e9180080677d9: Bug 1350958 - Finish labeling ProxyReleaseEvent, r=billm
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 14 Jul 2017 08:49:22 +0200 - rev 608983
Push 68469 by bmo:tlin@mozilla.com at Fri, 14 Jul 2017 14:21:07 +0000
Bug 1350958 - Finish labeling ProxyReleaseEvent, r=billm
034f4c1350153570c78dab9e47fd7daab3a6d4db: Bug 1381010 - After resizing the window, open the onboarding overlay but the tours would not appear. r=mossop draft
Fischer.json <fischer.json@gmail.com> - Fri, 14 Jul 2017 21:41:26 +0800 - rev 608982
Push 68468 by bmo:fliu@mozilla.com at Fri, 14 Jul 2017 13:42:31 +0000
Bug 1381010 - After resizing the window, open the onboarding overlay but the tours would not appear. r=mossop MozReview-Commit-ID: 3ZxuqTEJJu3
ac980676e8c7444f5511ef64e9a8ae8d99831dfe: Add the ability to check slots draft
Wouter Verhelst <wouter.verhelst@fedict.be> - Fri, 14 Jul 2017 15:36:45 +0200 - rev 608981
Push 68467 by bmo:w@uter.be at Fri, 14 Jul 2017 13:37:21 +0000
Add the ability to check slots When authentication does not succeed, a website which is set up to work with a specific PKCS#11 module might want to provide a diagnostic message to the user to tell her what to do to fix the failed authentication. Such a diagnostic could run with the following pseudocode: if user runs firefox: try to load content script from PKCS#11-specific addon if content script could not be loaded: tell user to install addon else: use content script to ask addon backend for token information if addon says PKCS#11 module could not be found: tell user to install PKCS#11 module if addon says no slots could be found: tell user to install card reader and try again if addon says no tokens could be found tell user to insert card into reader and try again PKCS#11 modules might export psuedo slots or tokens for various module-specific purposes; so don't just say "there is a token" or "there is a slot", instead tell the addon which tokens and slots are found, so they can figure out the rest for themselves. MozReview-Commit-ID: GtM5pB1F5b2
800795cface4c7a6105571b0db946c9b0bae69a7: Implement a PKCS#11 management API (bug 1357391). draft
Wouter Verhelst <wouter.verhelst@fedict.be> - Thu, 13 Jul 2017 17:07:24 +0200 - rev 608980
Push 68467 by bmo:w@uter.be at Fri, 14 Jul 2017 13:37:21 +0000
Implement a PKCS#11 management API (bug 1357391). Allows to find and remove installed PKCS#11 modules, and install new ones provided the addon knows the absolute path of the module (or a limited list of possibilities for that). r?zombie MozReview-Commit-ID: GVCrrOXQNvQ
3c211187843f39ceb3d175df47bffc7c60b71ec6: Bug 1347704 - Fix Intermittent test_ext_i18n.js, r?kmag draft
Bob Silverberg <bsilverberg@mozilla.com> - Fri, 14 Jul 2017 09:09:34 -0400 - rev 608979
Push 68466 by bmo:bob.silverberg@gmail.com at Fri, 14 Jul 2017 13:10:08 +0000
Bug 1347704 - Fix Intermittent test_ext_i18n.js, r?kmag Wait for content script to be loaded before sending a message to it. MozReview-Commit-ID: ENsMbdjLuVx
4475e919b9f723f8fd0b6b019d4ab8ce7f524cb2: Bug 1347351 - nsMenuBarListener::KeyPress() should wait reply event for handling F10 key r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 14 Jul 2017 21:44:57 +0900 - rev 608978
Push 68465 by masayuki@d-toybox.com at Fri, 14 Jul 2017 13:07:37 +0000
Bug 1347351 - nsMenuBarListener::KeyPress() should wait reply event for handling F10 key r?smaug Currently, nsMenuBarListener::KeyPress() handles F10 key before remote content handles it. However, if a remote process has focus, the keyboard event should be handled in the content first. Then, only when it's not consumed in the remote process, menubar should handle the F10 key press. MozReview-Commit-ID: GDf4POAPsTy
1d3c2c2cd66e3abd02d2e0d878f38bb99385ae9c: Bug 1347351 - nsMenuBarListener::KeyPress() should wait reply event for handling F10 key r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 14 Jul 2017 21:44:57 +0900 - rev 608977
Push 68464 by masayuki@d-toybox.com at Fri, 14 Jul 2017 13:02:34 +0000
Bug 1347351 - nsMenuBarListener::KeyPress() should wait reply event for handling F10 key r?smaug Currently, nsMenuBarListener::KeyPress() handles F10 key before remote content handles it. However, if a remote process has focus, the keyboard event should be handled in the content first. Then, only when it's not consumed in the remote process, menubar should handle the F10 key press. This patch adds a method |WidgetEvent::MaybePostedToRemoteProcessLater()| which checks if the event may be posted to a remote process later. If this returns true, nsMenuBarListener::KeyPress() should do nothing except marking it as "waiting reply from remote content". MozReview-Commit-ID: GDf4POAPsTy
52aebac251035b20c2c0fc920587d26827b565d6: Bug 1333459 - part3: Add automated tests into browser_accesskeys.js r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 07 Jul 2017 20:25:14 +0900 - rev 608976
Push 68463 by masayuki@d-toybox.com at Fri, 14 Jul 2017 13:01:50 +0000
Bug 1333459 - part3: Add automated tests into browser_accesskeys.js r?smaug MozReview-Commit-ID: 4zH3kgnX6bM
5b73c9e970d1681c5e940a3b167be3ed5bc75255: Bug 1333459 - part2-3: Make nsMenuBarListener::KeyPress() wait reply from remote process if the eKeyPress event will be sent to a remote process later r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 14 Jul 2017 20:12:28 +0900 - rev 608975
Push 68463 by masayuki@d-toybox.com at Fri, 14 Jul 2017 13:01:50 +0000
Bug 1333459 - part2-3: Make nsMenuBarListener::KeyPress() wait reply from remote process if the eKeyPress event will be sent to a remote process later r?smaug nsMenuBarListener::KeyPress() is eKeyEvent listener in the system event group. If the target is a remote process, it shouldn't handle accesskey immediately because preceding eKeyDown event may be consumed in the remote process or eKeyPress event itself may be consumed in the remote process. This patch makes nsMenuBarListener::KeyPress() mark eKeyPress event as "waiting reply from remote process" only when the event matches with a menu item's accesskey and it will be send to a remote process later. Then, reply event should be handled in this method if it's available. MozReview-Commit-ID: KOpCVgElnca
c4d292e37fe75007055834438fe888e014fff45a: Bug 1333459 - part2-2: EventStateManager should check if it needs to wait reply from remote content before handling access keys r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 14 Jul 2017 21:25:46 +0900 - rev 608974
Push 68463 by masayuki@d-toybox.com at Fri, 14 Jul 2017 13:01:50 +0000
Bug 1333459 - part2-2: EventStateManager should check if it needs to wait reply from remote content before handling access keys r?smaug Currently, access key is handled in EventStateManager::PreHandleEvent() with eKeyPress event, i.e., before dispatching it into the DOM tree, if the access key is registered in EventStateManager. So, the main process does not check if the preceding eKeyDown event is consumed in focused remote process. When preceding eKeyDown event is consumed in the main process, eKeyPress event won't be dispatched by widget. However, if remote process has focus, it's impossible. Therefore, main process needs to post eKeyPress event to check if preceding eKeyDown event was consumed. When eKeyPress event is marked as "waiting reply from remote process", TabChild sends it back to the main process only when preceding eKeyDown event wasn't consumed. So, only when eKeyPress event is back to the main process, main process should handle accesskey with it. This patch makes EventStateManager::PreHandleEvent() check if a remote target has focus before handling accesskey. If a remote process has accesskey and there is an accesskey matching with eKeyPress event, it marks the event as "waiting reply from remote content" and stop propagation in the process. Finally, when eKeyPress event is sent back to TabParent, TabParent::RecvReplyKeyEvent() calls EventStateManager::HandleAccessKey() before dispatching the reply event into the DOM tree. MozReview-Commit-ID: KsOkakaIVzb
7ff1119d0c5df0782d6a1c8634364c2f793c563a: Bug 1333459 - part2-1: EventStateManager should have a way to check if there is accesskey which is executed by a specific keyboard event r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 14 Jul 2017 17:33:08 +0900 - rev 608973
Push 68463 by masayuki@d-toybox.com at Fri, 14 Jul 2017 13:01:50 +0000
Bug 1333459 - part2-1: EventStateManager should have a way to check if there is accesskey which is executed by a specific keyboard event r?smaug Protected EventStateManager::HandleAccessKey() walks ESMs to handle access key and EventStateManager::ExecuteAccessKey() looks for an accesskey which matches given char code values and execute an accesskey if it finds a target. These names are hard to understand what they do and we need an option not to execute accesskey but looks for a target. Therefore, this patch renames the former to WalkESMTreeToHandleAccessKey() and the latter to LookForAccessKeyAndExecute(). Then, they take a new bool argument, aExecute. When it's true, LookForAccessKeyAndExecute() executes found accesskey. Otherwise, i.e., it's false, they return true if they find an accesskey target for the given event in the process. MozReview-Commit-ID: ETYbNmtTMGj
3cdd3382e299091be71699ed899e727c3ad6d6fa: Bug 1333459 - part1: Move methods of EventStateManager which check modifiers of access key to WidgetKeyboardEvent r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 06 Jul 2017 17:36:19 +0900 - rev 608972
Push 68463 by masayuki@d-toybox.com at Fri, 14 Jul 2017 13:01:50 +0000
Bug 1333459 - part1: Move methods of EventStateManager which check modifiers of access key to WidgetKeyboardEvent r?smaug EventStateManager checks if every keypress event's modifiers match with access key modifiers which are in prefs. Moving related methods of this to WidgetKeyboardEvent makes EventStateManager simpler and we can hide the NS_MODIFIER_* constants (they may make developers confused between Modifiers of WidgetInputEvent) into WidgetEventImpl.cpp. MozReview-Commit-ID: 23NUQ51lJ1M
532136f169c807d82f78602b17c2d8773913eb06: Bug 1375778 - Convert old console filter preferences to new ones; r=bgrins draft
Jan Odvarko <odvarko@gmail.com> - Fri, 14 Jul 2017 14:30:32 +0200 - rev 608971
Push 68462 by jodvarko@mozilla.com at Fri, 14 Jul 2017 12:31:07 +0000
Bug 1375778 - Convert old console filter preferences to new ones; r=bgrins MozReview-Commit-ID: 39wIi93JrOM
37bd74c3e63ee250d8e666f2beb8428bb49fc649: Bug 1380639 - Add constraint layout solver JAR to build. draft
Sebastian Kaspari <s.kaspari@gmail.com> - Fri, 14 Jul 2017 13:58:48 +0200 - rev 608970
Push 68461 by s.kaspari@gmail.com at Fri, 14 Jul 2017 12:04:37 +0000
Bug 1380639 - Add constraint layout solver JAR to build. MozReview-Commit-ID: IyiW0Ugig9X
13dce0a9f3602e3a03418bc43a31d68391dfd4c7: Bug 1380639 - Add contraint layout AAR to build. draft
Sebastian Kaspari <s.kaspari@gmail.com> - Fri, 14 Jul 2017 11:58:25 +0200 - rev 608969
Push 68461 by s.kaspari@gmail.com at Fri, 14 Jul 2017 12:04:37 +0000
Bug 1380639 - Add contraint layout AAR to build. MozReview-Commit-ID: 8N86rCQetv9
439c141804b06b5440efa42dfc4553c2429e9543: Bug 1380644 - Update Android lint library dependency to 25.3.2. r?grisha draft
Sebastian Kaspari <s.kaspari@gmail.com> - Thu, 13 Jul 2017 15:57:47 +0200 - rev 608968
Push 68461 by s.kaspari@gmail.com at Fri, 14 Jul 2017 12:04:37 +0000
Bug 1380644 - Update Android lint library dependency to 25.3.2. r?grisha This is primarily for local builds that use the latest Android SDK. MozReview-Commit-ID: 5uIjC6EhCho
9f5d1494982e0485b7a8fcb33440c3c539180caf: WIP draft
Sebastian Kaspari <s.kaspari@gmail.com> - Fri, 14 Jul 2017 10:16:17 +0200 - rev 608967
Push 68461 by s.kaspari@gmail.com at Fri, 14 Jul 2017 12:04:37 +0000
WIP MozReview-Commit-ID: JdJbFQPNDHD
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip