5134c7015cd5259c72aa2937047ecd31477d574f: Bug 1388238 - Implement waitForMasterPasswordDialog helper which handles open dialogs. r=MattN draft
steveck-chung <schung@mozilla.com> - Tue, 08 Aug 2017 20:53:49 -0700 - rev 644699
Push 73526 by schung@mozilla.com at Fri, 11 Aug 2017 09:18:08 +0000
Bug 1388238 - Implement waitForMasterPasswordDialog helper which handles open dialogs. r=MattN MozReview-Commit-ID: A8jx8s37f1k
127fc762533e0d8896cf3d9b03e5435cb95590bc: Bug 1389002 - Update background color as #F9F9FA to match updated Photon visual spec and the background color of toolbar. draft
Evan Tseng <evan@tseng.io> - Thu, 10 Aug 2017 15:12:44 +0800 - rev 644698
Push 73525 by bmo:evan@tseng.io at Fri, 11 Aug 2017 09:17:11 +0000
Bug 1389002 - Update background color as #F9F9FA to match updated Photon visual spec and the background color of toolbar. MozReview-Commit-ID: HtPnAyD1bjf
8cb8fe7391b07b6bee96b951bcf0e63757280a5f: Bug 1382588 - Hide scroll buttons and overflow indicators using display:none rather than visibility:collapse to avoid loading their image resources when they're not needed. r?johannh draft
Dão Gottwald <dao@mozilla.com> - Fri, 11 Aug 2017 11:15:38 +0200 - rev 644697
Push 73524 by dgottwald@mozilla.com at Fri, 11 Aug 2017 09:15:59 +0000
Bug 1382588 - Hide scroll buttons and overflow indicators using display:none rather than visibility:collapse to avoid loading their image resources when they're not needed. r?johannh MozReview-Commit-ID: JKj8qPsW7my
4d13aec8530fa56bc14cced62839efcb68d7e501: Bug 1387969 - show scrollbar when onboarding tour description is longer;r=rexboy draft
gasolin <gasolin@gmail.com> - Fri, 11 Aug 2017 17:11:24 +0800 - rev 644696
Push 73523 by bmo:gasolin@mozilla.com at Fri, 11 Aug 2017 09:11:49 +0000
Bug 1387969 - show scrollbar when onboarding tour description is longer;r=rexboy MozReview-Commit-ID: 12uhcn9EWJZ
a037bcf9cef9755946d6843288bb57b3e69f9a00: Bug 1389422 - Avoid @GLIBCXX_3.4.22 symbols from the use of std::thread when building with GCC 6. r?froydnj draft
Mike Hommey <mh+mozilla@glandium.org> - Fri, 11 Aug 2017 17:20:47 +0900 - rev 644695
Push 73522 by bmo:mh+mozilla@glandium.org at Fri, 11 Aug 2017 09:01:15 +0000
Bug 1389422 - Avoid @GLIBCXX_3.4.22 symbols from the use of std::thread when building with GCC 6. r?froydnj That the wrapper implementation works has been verified by creating a dummy program such as: $ cat test.cc #include <thread> int main() { std::thread([]() { printf("foo\n"); }).join(); return 0; } And compiling it with and without the hack: $ g++ -fno-rtti -o test test.cc -lpthread $ objdump -TC test | grep UND.*GLIBCXX_3.4.22 0000000000000000 DF *UND* 0000000000000000 GLIBCXX_3.4.22 std::thread::_State::~_State() 0000000000000000 DF *UND* 0000000000000000 GLIBCXX_3.4.22 std::thread::_M_start_thread(std::unique_ptr<std::thread::_State, std::default_delete<std::thread::_State> >, void (*)()) $ ./test foo $ g++ -fno-rtti -o test test.cc $objdir/build/unix/stdc++compat/stdc++compat.o -lpthread $ objdump -TC test | grep UND.*GLIBCXX_3.4.22 $ ./test foo
fbdbc66b26fef527c895a5afd4dfd75de17ab5f8: Bug 1388444 - Make about:preferences category focus color noticeable r?jaws draft
Ricky Chien <ricky060709@gmail.com> - Fri, 11 Aug 2017 16:56:55 +0800 - rev 644694
Push 73521 by bmo:rchien@mozilla.com at Fri, 11 Aug 2017 08:57:21 +0000
Bug 1388444 - Make about:preferences category focus color noticeable r?jaws
4de3f77846c640ba5a7204465be3965ace736f0b: Bug 1384482 - Rename android-api-15 into android-api-16 draft
Johan Lorenzo <jlorenzo@mozilla.com> - Wed, 09 Aug 2017 16:18:15 +0200 - rev 644693
Push 73520 by bmo:jlorenzo@mozilla.com at Fri, 11 Aug 2017 08:53:45 +0000
Bug 1384482 - Rename android-api-15 into android-api-16 MozReview-Commit-ID: 4j66pTZEJzq
69f5bb94361baed1c75b4eb61082535002dc0a1c: Bug 483155 - Put content creator function pointers onto nsHtml5ElementName. r?smaug draft
Henri Sivonen <hsivonen@hsivonen.fi> - Tue, 04 Jul 2017 11:00:03 +0300 - rev 644692
Push 73519 by bmo:hsivonen@hsivonen.fi at Fri, 11 Aug 2017 08:51:52 +0000
Bug 483155 - Put content creator function pointers onto nsHtml5ElementName. r?smaug MozReview-Commit-ID: E2AAx7Zz2UF
7e7942fd680139926b28257fa2e53b4ef47a627d: bug 1320656 - When exists, add -Wno-noexcept-type to the js build flags until we have a proper fix r?glandium draft
Sylvestre Ledru <sledru@mozilla.com> - Fri, 11 Aug 2017 10:46:02 +0200 - rev 644691
Push 73518 by bmo:sledru@mozilla.com at Fri, 11 Aug 2017 08:50:41 +0000
bug 1320656 - When exists, add -Wno-noexcept-type to the js build flags until we have a proper fix r?glandium MozReview-Commit-ID: HeDMTxopx9V
e7950f1511e2f93f57cea1e3324e39fbc8fcbfc3: Bug 1388634 - Set correct sampling filter when pushing image. r=kats draft
Ethan Lin <ethlin@mozilla.com> - Wed, 09 Aug 2017 14:27:46 +0800 - rev 644690
Push 73517 by bmo:ethlin@mozilla.com at Fri, 11 Aug 2017 08:50:09 +0000
Bug 1388634 - Set correct sampling filter when pushing image. r=kats MozReview-Commit-ID: BkKbL2l0AYb
1ea5ca21ac24d3275f3bf777ce20ff9daedb99c3: Bug 1387956 - Overhaul ComputedValues measurement, and add style structs measurement. r?bholley. draft
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 11 Aug 2017 16:37:33 +1000 - rev 644689
Push 73516 by nnethercote@mozilla.com at Fri, 11 Aug 2017 08:42:14 +0000
Bug 1387956 - Overhaul ComputedValues measurement, and add style structs measurement. r?bholley. This patch moves measurement of ComputedValues objects from Rust to C++. Measurement now happens (a) via DOM elements and (b) remaining elements via the frame tree. Likewise for the style structs hanging off ComputedValues objects. Here is an example of the output. > ├──27,600,448 B (26.49%) -- active/window(https://en.wikipedia.org/wiki/Barack_Obama) > │ ├──12,772,544 B (12.26%) -- layout > │ │ ├───4,483,744 B (04.30%) -- frames > │ │ │ ├──1,653,552 B (01.59%) ── nsInlineFrame > │ │ │ ├──1,415,760 B (01.36%) ── nsTextFrame > │ │ │ ├────431,376 B (00.41%) ── nsBlockFrame > │ │ │ ├────340,560 B (00.33%) ── nsHTMLScrollFrame > │ │ │ ├────302,544 B (00.29%) ── nsContinuingTextFrame > │ │ │ ├────156,408 B (00.15%) ── nsBulletFrame > │ │ │ ├─────73,024 B (00.07%) ── nsPlaceholderFrame > │ │ │ ├─────27,656 B (00.03%) ── sundries > │ │ │ ├─────23,520 B (00.02%) ── nsTableCellFrame > │ │ │ ├─────16,704 B (00.02%) ── nsImageFrame > │ │ │ ├─────15,488 B (00.01%) ── nsTableRowFrame > │ │ │ ├─────13,776 B (00.01%) ── nsTableColFrame > │ │ │ └─────13,376 B (00.01%) ── nsTableFrame > │ │ ├───3,412,192 B (03.28%) -- servo-style-structs > │ │ │ ├──1,288,224 B (01.24%) ── Display > │ │ │ ├────742,400 B (00.71%) ── Position > │ │ │ ├────308,736 B (00.30%) ── Font > │ │ │ ├────226,512 B (00.22%) ── Background > │ │ │ ├────218,304 B (00.21%) ── TextReset > │ │ │ ├────214,896 B (00.21%) ── Text > │ │ │ ├────130,560 B (00.13%) ── Border > │ │ │ ├─────81,408 B (00.08%) ── UIReset > │ │ │ ├─────61,440 B (00.06%) ── Padding > │ │ │ ├─────38,176 B (00.04%) ── UserInterface > │ │ │ ├─────29,232 B (00.03%) ── Margin > │ │ │ ├─────21,824 B (00.02%) ── sundries > │ │ │ ├─────20,080 B (00.02%) ── Color > │ │ │ ├─────20,080 B (00.02%) ── Column > │ │ │ └─────10,320 B (00.01%) ── Effects > │ │ ├───2,227,680 B (02.14%) -- computed-values > │ │ │ ├──1,182,928 B (01.14%) ── non-dom > │ │ │ └──1,044,752 B (01.00%) ── dom > │ │ ├───1,500,016 B (01.44%) ── text-runs > │ │ ├─────492,640 B (00.47%) ── line-boxes > │ │ ├─────326,688 B (00.31%) ── frame-properties > │ │ ├─────301,760 B (00.29%) ── pres-shell > │ │ ├──────27,648 B (00.03%) ── pres-contexts > │ │ └─────────176 B (00.00%) ── style-sets The 'servo-style-structs' and 'computed-values' sub-trees are new. (Prior to this patch, ComputedValues under DOM elements were tallied under the the 'dom/element-nodes' sub-tree, and ComputedValues not under DOM element were ignored.) 'servo-style-structs/sundries' aggregates all the style structs that are smaller than 8 KiB. Other notable things done by the patch are as follows. - It significantly changes the signatures of the methods measuring nsINode and its subclasses, in order to handle the tallying of style structs separately from element-nodes. Likewise for nsIFrame. - It renames the 'layout/style-structs' sub-tree as 'layout/gecko-style-structs', to clearly distinguish it from the new 'layout/servo-style-structs' sub-tree. - It adds some FFI functions to access various Rust-side data structures from C++ code. - There is a nasty hack used twice to measure Arcs, by stepping backwards from an interior pointer to a base pointer. It works, but I want to replace it with something better eventually. The "XXX WARNING" comments have details. - It makes DMD print a line to the console if it sees a pointer it doesn't recognise. This is useful for detecting when we are measuring an interior pointer instead of a base pointer, which is bad but easy to do when Arcs are involved. - It removes the Rust code for measuring CVs, because it's now all done on the C++ side. MozReview-Commit-ID: Hb889wT5Uwl
f50b8a44bc048f4693a5269ddc7ba8185645f85c: Bug 1387956 (part 2) - Overhaul handling of nsWindowSizes. r=mccr8. draft
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 10 Aug 2017 14:14:09 +1000 - rev 644688
Push 73516 by nnethercote@mozilla.com at Fri, 11 Aug 2017 08:42:14 +0000
Bug 1387956 (part 2) - Overhaul handling of nsWindowSizes. r=mccr8. This patch does the following. - Moves nsWindowSizes from nsWindowMemoryReporter.h to its own file, nsWindowSizes.h, so it can be included more widely without exposing nsWindowMemoryReporter. - Merges nsArenaMemoryStats.h (which defines nsTabSizes and nsArenaMemoryStats) into nsWindowSizes.h. - Renames nsArenaMemoryStats as nsArenaSizes, and nsWindowSizes::mArenaStats as nsWindowSizes::mArenaSizes. This is the more usual naming scheme for such types. - Renames FRAME_ID_STAT_FIELD as NS_ARENA_SIZES_FIELD. - Passes nsWindowSizes to PresShell::AddSizeOfIncludingThis() and nsPresArena::AddSizeOfExcludingThis(), instead of a bunch of smaller things. One nice consequence is that the odd nsArenaMemoryStats::mOther field is no longer necessary, because we can update nsWindowSizes::mLayoutPresShellSize directly in nsPresArena::AddSizeOfExcludingThis(). - Adds |const| to a few methods.
c7ada64881f015c68eaee2fbfad901f806cab833: Bug 1387956 (part 1) - Change |nsWindowSizes*| arguments to |nsWindowSizes&|. r=mccr8. draft
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 10 Aug 2017 14:13:22 +1000 - rev 644687
Push 73516 by nnethercote@mozilla.com at Fri, 11 Aug 2017 08:42:14 +0000
Bug 1387956 (part 1) - Change |nsWindowSizes*| arguments to |nsWindowSizes&|. r=mccr8. This makes it clear they are never null.
c0536a4e7152e9c7b7d71ca1d27bdd8584f995c0: Bug 483155 follow-up - Initialize the SVG/MathML enablement cache. r?bz draft
Henri Sivonen <hsivonen@hsivonen.fi> - Fri, 11 Aug 2017 11:39:09 +0300 - rev 644686
Push 73515 by bmo:hsivonen@hsivonen.fi at Fri, 11 Aug 2017 08:39:23 +0000
Bug 483155 follow-up - Initialize the SVG/MathML enablement cache. r?bz MozReview-Commit-ID: DvmkECwUdQL
651a7803c562fbe2b55900df1637765f540f1b30: Bug 1387956 - Overhaul ComputedValues measurement, and add style structs measurement. r=bholley. draft
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 11 Aug 2017 16:37:33 +1000 - rev 644685
Push 73514 by nnethercote@mozilla.com at Fri, 11 Aug 2017 08:38:54 +0000
Bug 1387956 - Overhaul ComputedValues measurement, and add style structs measurement. r=bholley. This patch moves measurement of ComputedValues objects from Rust to C++. Measurement now happens (a) via DOM elements and (b) remaining elements via the frame tree. Likewise for the style structs hanging off ComputedValues objects. Here is an example of the output. > ├──27,600,448 B (26.49%) -- active/window(https://en.wikipedia.org/wiki/Barack_Obama) > │ ├──12,772,544 B (12.26%) -- layout > │ │ ├───4,483,744 B (04.30%) -- frames > │ │ │ ├──1,653,552 B (01.59%) ── nsInlineFrame > │ │ │ ├──1,415,760 B (01.36%) ── nsTextFrame > │ │ │ ├────431,376 B (00.41%) ── nsBlockFrame > │ │ │ ├────340,560 B (00.33%) ── nsHTMLScrollFrame > │ │ │ ├────302,544 B (00.29%) ── nsContinuingTextFrame > │ │ │ ├────156,408 B (00.15%) ── nsBulletFrame > │ │ │ ├─────73,024 B (00.07%) ── nsPlaceholderFrame > │ │ │ ├─────27,656 B (00.03%) ── sundries > │ │ │ ├─────23,520 B (00.02%) ── nsTableCellFrame > │ │ │ ├─────16,704 B (00.02%) ── nsImageFrame > │ │ │ ├─────15,488 B (00.01%) ── nsTableRowFrame > │ │ │ ├─────13,776 B (00.01%) ── nsTableColFrame > │ │ │ └─────13,376 B (00.01%) ── nsTableFrame > │ │ ├───3,412,192 B (03.28%) -- servo-style-structs > │ │ │ ├──1,288,224 B (01.24%) ── Display > │ │ │ ├────742,400 B (00.71%) ── Position > │ │ │ ├────308,736 B (00.30%) ── Font > │ │ │ ├────226,512 B (00.22%) ── Background > │ │ │ ├────218,304 B (00.21%) ── TextReset > │ │ │ ├────214,896 B (00.21%) ── Text > │ │ │ ├────130,560 B (00.13%) ── Border > │ │ │ ├─────81,408 B (00.08%) ── UIReset > │ │ │ ├─────61,440 B (00.06%) ── Padding > │ │ │ ├─────38,176 B (00.04%) ── UserInterface > │ │ │ ├─────29,232 B (00.03%) ── Margin > │ │ │ ├─────21,824 B (00.02%) ── sundries > │ │ │ ├─────20,080 B (00.02%) ── Color > │ │ │ ├─────20,080 B (00.02%) ── Column > │ │ │ └─────10,320 B (00.01%) ── Effects > │ │ ├───2,227,680 B (02.14%) -- computed-values > │ │ │ ├──1,182,928 B (01.14%) ── non-dom > │ │ │ └──1,044,752 B (01.00%) ── dom > │ │ ├───1,500,016 B (01.44%) ── text-runs > │ │ ├─────492,640 B (00.47%) ── line-boxes > │ │ ├─────326,688 B (00.31%) ── frame-properties > │ │ ├─────301,760 B (00.29%) ── pres-shell > │ │ ├──────27,648 B (00.03%) ── pres-contexts > │ │ └─────────176 B (00.00%) ── style-sets The 'servo-style-structs' and 'computed-values' sub-trees are new. (Prior to this patch, ComputedValues under DOM elements were tallied under the the 'dom/element-nodes' sub-tree, and ComputedValues not under DOM element were ignored.) 'servo-style-structs/sundries' aggregates all the style structs that are smaller than 8 KiB. Other notable things done by the patch are as follows. - It significantly changes the signatures of the methods measuring nsINode and its subclasses, in order to handle the tallying of style structs separately from element-nodes. Likewise for nsIFrame. - It renames the 'layout/style-structs' sub-tree as 'layout/gecko-style-structs', to clearly distinguish it from the new 'layout/servo-style-structs' sub-tree. - It adds some FFI functions to access various Rust-side data structures from C++ code. - There is a nasty hack used twice to measure Arcs, by stepping backwards from an interior pointer to a base pointer. It works, but I want to replace it with something better eventually. The "XXX WARNING" comments have details. - It makes DMD print a line to the console if it sees a pointer it doesn't recognise. This is useful for detecting when we are measuring an interior pointer instead of a base pointer, which is bad but easy to do when Arcs are involved. - It removes the Rust code for measuring CVs, because it's now all done on the C++ side. MozReview-Commit-ID: 66d1DpNBT2b
89e5de5b66eac7a8965f0f4102b5be868276dfc3: Bug 1388975 (part 2) - Overhaul handling of nsWindowSizes. r=mccr8. draft
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 10 Aug 2017 14:14:09 +1000 - rev 644684
Push 73514 by nnethercote@mozilla.com at Fri, 11 Aug 2017 08:38:54 +0000
Bug 1388975 (part 2) - Overhaul handling of nsWindowSizes. r=mccr8. This patch does the following. - Moves nsWindowSizes from nsWindowMemoryReporter.h to its own file, nsWindowSizes.h, so it can be included more widely without exposing nsWindowMemoryReporter. - Merges nsArenaMemoryStats.h (which defines nsTabSizes and nsArenaMemoryStats) into nsWindowSizes.h. - Renames nsArenaMemoryStats as nsArenaSizes, and nsWindowSizes::mArenaStats as nsWindowSizes::mArenaSizes. This is the more usual naming scheme for such types. - Renames FRAME_ID_STAT_FIELD as NS_ARENA_SIZES_FIELD. - Passes nsWindowSizes to PresShell::AddSizeOfIncludingThis() and nsPresArena::AddSizeOfExcludingThis(), instead of a bunch of smaller things. One nice consequence is that the odd nsArenaMemoryStats::mOther field is no longer necessary, because we can update nsWindowSizes::mLayoutPresShellSize directly in nsPresArena::AddSizeOfExcludingThis(). - Adds |const| to a few methods. MozReview-Commit-ID: FP59jhSz0Q9
8e89e9628a0905c9cd5844ec2999095088efcc98: Bug 1388975 (part 1) - Change |nsWindowSizes*| arguments to |nsWindowSizes&|. r=mccr8. draft
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 10 Aug 2017 14:13:22 +1000 - rev 644683
Push 73514 by nnethercote@mozilla.com at Fri, 11 Aug 2017 08:38:54 +0000
Bug 1388975 (part 1) - Change |nsWindowSizes*| arguments to |nsWindowSizes&|. r=mccr8. This makes it clear they are never null. MozReview-Commit-ID: GF6vb8hp1JN
8fa9361b19689f6107b028317c14bacd1a72c11f: Bug 1372602 Make child widgets not visible if the window around it isn't visible on OS X. r=mstange
Mason Chang <mchang@mozilla.com> - Thu, 10 Aug 2017 21:43:26 -0700 - rev 644682
Push 73514 by nnethercote@mozilla.com at Fri, 11 Aug 2017 08:38:54 +0000
Bug 1372602 Make child widgets not visible if the window around it isn't visible on OS X. r=mstange
0059106aaa203a57da28bfd063d3a4b0427c2d20: Bug 1351148 Part12: Disable input event queue until related bugs are fixed. r=smaug.
Stone Shih <sshih@mozilla.com> - Tue, 08 Aug 2017 10:48:49 +0800 - rev 644681
Push 73514 by nnethercote@mozilla.com at Fri, 11 Aug 2017 08:38:54 +0000
Bug 1351148 Part12: Disable input event queue until related bugs are fixed. r=smaug. MozReview-Commit-ID: 74cycVYPe20
4b52e1b335fbd2cc0998366ac1666679dfea9b34: Bug 1351148 Part11: Set remote to be ready to handle input events when pref'ed off. r=smaug.
Stone Shih <sshih@mozilla.com> - Thu, 10 Aug 2017 13:20:58 +0800 - rev 644680
Push 73514 by nnethercote@mozilla.com at Fri, 11 Aug 2017 08:38:54 +0000
Bug 1351148 Part11: Set remote to be ready to handle input events when pref'ed off. r=smaug. MozReview-Commit-ID: CO5BU9eOC84
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip