50038633cebab6e3f57c87b94f80b010b8f4d901: Bug 1467049 - Fix a couple comments about disabled tests. r=standard8
Marco Bonardo <mbonardo@mozilla.com> - Wed, 06 Jun 2018 10:02:22 +0200 - rev 804843
Push 112482 by bmo:ato@sny.no at Wed, 06 Jun 2018 17:38:07 +0000
Bug 1467049 - Fix a couple comments about disabled tests. r=standard8 MozReview-Commit-ID: 5CNMRnAj9XC
841300ddc8ec135573453aa95a31196d84bba872: Merge mozilla-central to autoland. a=merge CLOSED TREE
Narcis Beleuzu <nbeleuzu@mozilla.com> - Wed, 06 Jun 2018 12:50:03 +0300 - rev 804842
Push 112482 by bmo:ato@sny.no at Wed, 06 Jun 2018 17:38:07 +0000
Merge mozilla-central to autoland. a=merge CLOSED TREE
e0d8aa3344b85dce6a962b5dc2e48a0ee403b524: Bug 1465397 - Font Editor: read font properties from computed style and overwrite with ones explicitly declared. r=pbro.
Razvan Caliman <rcaliman@mozilla.com> - Mon, 04 Jun 2018 15:07:00 +0200 - rev 804841
Push 112482 by bmo:ato@sny.no at Wed, 06 Jun 2018 17:38:07 +0000
Bug 1465397 - Font Editor: read font properties from computed style and overwrite with ones explicitly declared. r=pbro. - Read all expected font properties from computed style. - Overwrite with properties explicitly declared in rules which apply. - Skip explicit keywords, CSS Custom Properties and calc() expressions. MozReview-Commit-ID: JAKHundvV5w
2c78b7574bc1d1b9f5797bf0016438f6121449ec: Bug 1449568 - Grow the arrow box if it's partly hidden, and move the text to be visible; r=gl
Patrick Brosset <pbrosset@mozilla.com> - Tue, 22 May 2018 14:23:11 +0200 - rev 804840
Push 112482 by bmo:ato@sny.no at Wed, 06 Jun 2018 17:38:07 +0000
Bug 1449568 - Grow the arrow box if it's partly hidden, and move the text to be visible; r=gl MozReview-Commit-ID: EakAejm0Lhw
10c4e77579ca299b36ff975d71fdc1fa2a3fee36: Bug 1466007 - Add test which checking that the all tab will go into overflow menu if devtool's toolbar width is minimum width.r=jdescottes
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 06 Jun 2018 09:42:15 +0900 - rev 804839
Push 112482 by bmo:ato@sny.no at Wed, 06 Jun 2018 17:38:07 +0000
Bug 1466007 - Add test which checking that the all tab will go into overflow menu if devtool's toolbar width is minimum width.r=jdescottes This patch add the test which confirm to display only chevron when width is narrow. MozReview-Commit-ID: CpF4bWMtu8R
4d39fdf74ae76b02509a190b7081eecf49e25efe: bug 1442776 make CycleCollectedJSContext accessible from JSContext private r=peterv
Karl Tomlinson <karlt+@karlt.net> - Thu, 10 May 2018 17:04:12 +1200 - rev 804838
Push 112482 by bmo:ato@sny.no at Wed, 06 Jun 2018 17:38:07 +0000
bug 1442776 make CycleCollectedJSContext accessible from JSContext private r=peterv Inheriting PerThreadAtomCache on CycleCollectedJSContext permits use of static_cast, avoiding one level of indirection compared to adding a CycleCollectedJSContext* to PerThreadAtomCache. PerThreadAtomCache is over 18kB, and so WorkerJSContext and WorkletJSContext are moved from the stack to the heap. MozReview-Commit-ID: 6jdJeZcviK4
077407e42b77e532de6e307307356673ecbda73e: bug 1442776 treat PinnedStringId as rooted GC pointer in hazard analysis r=sfink
Karl Tomlinson <karlt+@karlt.net> - Tue, 05 Jun 2018 16:51:10 +1200 - rev 804837
Push 112482 by bmo:ato@sny.no at Wed, 06 Jun 2018 17:38:07 +0000
bug 1442776 treat PinnedStringId as rooted GC pointer in hazard analysis r=sfink MozReview-Commit-ID: GFPSwczIZxV
a96cf6ff334617c3d51e325ece5f27eaa0fefac9: Bug 1450781 - Enable pseudolocalization in Fluent. r?mossop draft
Zibi Braniecki <zbraniecki@mozilla.com> - Fri, 01 Jun 2018 12:37:13 -0700 - rev 804836
Push 112481 by bmo:gandalf@aviary.pl at Wed, 06 Jun 2018 17:32:02 +0000
Bug 1450781 - Enable pseudolocalization in Fluent. r?mossop MozReview-Commit-ID: Cs8OubRRur4
2944d47d968d6309e5407209140054dff5e068c5: Bug 1460743 - Don't install testing/profiles on Google Chrome; r?ahal draft
Rob Wood <rwood@mozilla.com> - Wed, 06 Jun 2018 13:28:54 -0400 - rev 804835
Push 112480 by rwood@mozilla.com at Wed, 06 Jun 2018 17:30:02 +0000
Bug 1460743 - Don't install testing/profiles on Google Chrome; r?ahal MozReview-Commit-ID: HW8iqfTDcd0
9464c3db252c93b0ae4e9d2ce84e0e0cdcf0fafc: Bug 1418602 - Allow theming sidebars. r= draft
Tim Nguyen <ntim.bugs@gmail.com> - Fri, 23 Feb 2018 12:17:56 -0500 - rev 804834
Push 112479 by bmo:ntim.bugs@gmail.com at Wed, 06 Jun 2018 17:27:05 +0000
Bug 1418602 - Allow theming sidebars. r= MozReview-Commit-ID: D6Z24bzNO7p
4a2a3d21289186d74fbf31adde1794b4611d2b7b: Bug 1437942 - Remove search engines from langpacks. r=adw, ted.mielczarek draft
Michael Kaply <mozilla@kaply.com> - Mon, 04 Jun 2018 16:45:50 -0500 - rev 804833
Push 112478 by mozilla@kaply.com at Wed, 06 Jun 2018 17:16:28 +0000
Bug 1437942 - Remove search engines from langpacks. r=adw, ted.mielczarek MozReview-Commit-ID: GFCIbfmCc5B
4783ac13d3b94ee58bfa83a529d111ceb0ff3222: Bug 1418602 - Allow theming sidebars. r= draft
Tim Nguyen <ntim.bugs@gmail.com> - Fri, 23 Feb 2018 12:17:56 -0500 - rev 804832
Push 112477 by bmo:ntim.bugs@gmail.com at Wed, 06 Jun 2018 17:08:18 +0000
Bug 1418602 - Allow theming sidebars. r= MozReview-Commit-ID: D6Z24bzNO7p
798bf46c5356fd1a99f83c7174295d309887b5d3: Bug 1309735 - Allow usercontextid to be set on mozbrowser frames. r=baku draft
J. Ryan Stinnett <jryans@gmail.com> - Fri, 23 Feb 2018 17:32:18 -0600 - rev 804831
Push 112476 by bmo:jryans@gmail.com at Wed, 06 Jun 2018 16:51:54 +0000
Bug 1309735 - Allow usercontextid to be set on mozbrowser frames. r=baku This allows the `usercontextid` attribute to be set on mozbrowser frames. This will help Responsive Design Mode support display of pages in containers, since it uses such frames internally. MozReview-Commit-ID: HWEJni6z1sp
83671d1cde90200ba0ef4348f7641c129d479bce: Bug 1460743 - TC configs for raptor speedometer on google chrome; r?jmaher draft
Rob Wood <rwood@mozilla.com> - Wed, 06 Jun 2018 12:39:02 -0400 - rev 804830
Push 112475 by rwood@mozilla.com at Wed, 06 Jun 2018 16:42:50 +0000
Bug 1460743 - TC configs for raptor speedometer on google chrome; r?jmaher MozReview-Commit-ID: 8ZxZc1Cz4WQ
7a9388a59635d0b682801fe2cd97f661f71c5960: Bug 1460777 - Taskgraph tasks for retrieving remote content; r?dustin, glandium draft
Gregory Szorc <gps@mozilla.com> - Wed, 06 Jun 2018 09:37:38 -0700 - rev 804829
Push 112474 by bmo:gps@mozilla.com at Wed, 06 Jun 2018 16:40:42 +0000
Bug 1460777 - Taskgraph tasks for retrieving remote content; r?dustin, glandium Currently, many tasks fetch content from the Internets. A problem with that is fetching from the Internets is unreliable: servers may have outages or be slow; content may disappear or change out from under us. The unreliability of 3rd party services poses a risk to Firefox CI. If services aren't available, we could potentially not run some CI tasks. In the worst case, we might not be able to release Firefox. That would be bad. In fact, as I write this, gmplib.org has been unavailable for ~24 hours and Firefox CI is unable to retrieve the GMP source code. As a result, building GCC toolchains is failing. A solution to this is to make tasks more hermetic by depending on fewer network services (which by definition aren't reliable over time and therefore introduce instability). This commit attempts to mitigate some external service dependencies by introducing the *fetch* task kind. The primary goal of the *fetch* kind is to obtain remote content and re-expose it as a task artifact. By making external content available as a cached task artifact, we allow dependent tasks to consume this content without touching the service originally providing that content, thus eliminating a run-time dependency and making tasks more hermetic and reproducible over time. We introduce a single "fetch-url" "using" flavor to define tasks that fetch single URLs and then re-expose that URL as an artifact. Powering this is a new, minimal "fetch" Docker image that contains a "fetch-content" Python script that does the work for us. We have added tasks to fetch source archives used to build the GCC toolchains. Fetching remote content and re-exposing it as an artifact is not very useful by itself: the value is in having tasks use those artifacts. We introduce a taskgraph transform that allows tasks to define an array of "fetches." Each entry corresponds to the name of a "fetch" task kind. When present, the corresponding "fetch" task is added as a dependency. And the task ID and artifact path from that "fetch" task is added to the MOZ_FETCHES environment variable of the task depending on it. Our "fetch-content" script has a "task-artifacts" sub-command that tasks can execute to perform retrieval of all artifacts listed in MOZ_FETCHES. To prove all of this works, the code for fetching dependencies when building GCC toolchains has been updated to use `fetch-content`. The now-unused legacy code has been deleted. This commit improves the reliability and efficiency of GCC toolchain tasks. Dependencies now all come from task artifacts and should always be available in the common case. In addition, `fetch-content` downloads and extracts files concurrently. This makes it faster than the serial application which we were previously using. There are some things I don't like about this commit. First, a new Docker image and Python script for downloading URLs feels a bit heavyweight. The Docker image is definitely overkill as things stand. I can eventually justify it because I want to implement support for fetching and repackaging VCS repositories and for caching Debian packages. These will require more packages than what I'm comfortable installing on the base Debian image, therefore justifying a dedicated image. The `fetch-content static-url` sub-command could definitely be implemented as a shell script. But Python is readily available and is more pleasant to maintain than shell, so I wrote it in Python. `fetch-content task-artifacts` is more advanced and writing it in Python is more justified, IMO. FWIW, the script is Python 3 only, which conveniently gives us access to `concurrent.futures`, which facilitates concurrent download. `fetch-content` also duplicates functionality found elsewhere. generic-worker's task payload supports a "mounts" feature which facilitates downloading remote content, including from a task artifact. However, this feature doesn't exist on docker-worker. So we have to implement downloading inside the task rather than at the worker level. I concede that if all workers had generic-worker's "mounts" feature and supported concurrent download, `fetch-content` wouldn't need to exist. `fetch-content` also duplicates functionality of `mach artifact toolchain`. I probably could have used `mach artifact toolchain` instead of writing `fetch-content task-artifacts`. However, I didn't want to introduce the requirement of a VCS checkout. `mach artifact toolchain` has its origins in providing a feature to the build system. And "fetching artifacts from tasks" is a more generic feature than that. I think it should be implemented as a generic feature and not something that is "toolchain" specific. I think the best place for a generic "fetch content" feature is in the worker, where content can be defined in the task payload. But as explained above, that feature isn't universally available. The next best place is probably run-task. run-task already performs generic, very-early task preparation steps, such as performing a VCS checkout. I would like to fold `fetch-content` into run-task and make it all driven by environment variables. But run-task is currently Python 2 and achieving concurrency would involve a bit of programming (or adding package dependencies). I may very well port run-task to Python 3 and then fold fetch-content into it. Or maybe we leave `fetch-content` as a standalone script. MozReview-Commit-ID: AGuTcwNcNJR
5fce34a460b51e45ac280a9f0cb8bad896fbcff1: Bug 1460777 - Extract GPG keys to standalone files; r?glandium draft
Gregory Szorc <gps@mozilla.com> - Fri, 11 May 2018 10:38:35 -0700 - rev 804828
Push 112474 by bmo:gps@mozilla.com at Wed, 06 Jun 2018 16:40:42 +0000
Bug 1460777 - Extract GPG keys to standalone files; r?glandium After this change, we consistently import GPG keys from files in the GCC build scripts. MozReview-Commit-ID: BcyvCQoGbMS
085fde748869b4d2dd0b82704df8ab260f1855ac: Bug 1418602 - Allow theming sidebars. r= draft
Tim Nguyen <ntim.bugs@gmail.com> - Fri, 23 Feb 2018 12:17:56 -0500 - rev 804827
Push 112473 by bmo:ntim.bugs@gmail.com at Wed, 06 Jun 2018 16:35:20 +0000
Bug 1418602 - Allow theming sidebars. r= MozReview-Commit-ID: D6Z24bzNO7p
570bea8ba74bc82343a48e5293eff1525a346cf0: Bug 1460743 - Add 'speedometer' benchmark to raptor for google chrome; r?jmaher draft
Rob Wood <rwood@mozilla.com> - Mon, 04 Jun 2018 15:42:44 -0400 - rev 804826
Push 112472 by rwood@mozilla.com at Wed, 06 Jun 2018 16:34:03 +0000
Bug 1460743 - Add 'speedometer' benchmark to raptor for google chrome; r?jmaher Includes a temporary downloading/installing Chrome 'hack' just so we can get going on try, until 'official' chrome builds are available in CI. Also some small raptor fixes/changes to support speedometer on chrome. MozReview-Commit-ID: 8ZBlOg0BOE4
001f7a97f643c7fee28d4bf1f0047a242ece151f: Bug 1451289 - Part 12: Remove the intermediate macro and make CASE_RULE macro work with CSS*Rule instead r?emilio draft
Nazım Can Altınova <canaltinova@gmail.com> - Wed, 06 Jun 2018 16:26:28 +0200 - rev 804825
Push 112471 by bmo:canaltinova@gmail.com at Wed, 06 Jun 2018 16:33:35 +0000
Bug 1451289 - Part 12: Remove the intermediate macro and make CASE_RULE macro work with CSS*Rule instead r?emilio MozReview-Commit-ID: GblL8jA23g4
722bf188b5ae9fb561882427feccb3a04fb1a74a: Bug 1451289 - Part 11: Merge ServoFontFeatureValuesRule and CSSFontFeatureValuesRule r?emilio draft
Nazım Can Altınova <canaltinova@gmail.com> - Wed, 06 Jun 2018 16:10:47 +0200 - rev 804824
Push 112471 by bmo:canaltinova@gmail.com at Wed, 06 Jun 2018 16:33:35 +0000
Bug 1451289 - Part 11: Merge ServoFontFeatureValuesRule and CSSFontFeatureValuesRule r?emilio MozReview-Commit-ID: 9aXGCHdkZwp
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip