4fb6656f1d9d25a21284bd6ab2fcb70a0872aaae: ansible/hg-reviewboard: remove executability of pash files (bug 1192338); r=fubar
Gregory Szorc <gps@mozilla.com> - Mon, 10 Aug 2015 11:42:02 -0700 - rev 361279
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
ansible/hg-reviewboard: remove executability of pash files (bug 1192338); r=fubar These files are Python support modules, not scripts. Remove the shebang, any __main__ routines, and executable bit from files.
931e452672790ffc34a692581f4faddf29caa5f2: ansible/hg-reviewboard: fix many style nits (bug 1192338); r=fubar
Gregory Szorc <gps@mozilla.com> - Mon, 10 Aug 2015 11:41:47 -0700 - rev 361278
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
ansible/hg-reviewboard: fix many style nits (bug 1192338); r=fubar There should be no significant code changes in this commit. Just a lot of style refactoring to act on warnings issued by flake8.
657bb56cac549a8a9af03683f0c752cb168ee9db: ansible/hg-reviewboard: use standard environment variable fetching (bug 1192338); r=fubar
Gregory Szorc <gps@mozilla.com> - Mon, 10 Aug 2015 11:41:34 -0700 - rev 361277
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
ansible/hg-reviewboard: use standard environment variable fetching (bug 1192338); r=fubar os.environ is preferred over the low-level os.getenv() function.
305089a773754f891683c9f7e364a1c4646d8020: pash: remove unused variable; r=fubar
Gregory Szorc <gps@mozilla.com> - Mon, 10 Aug 2015 11:41:19 -0700 - rev 361276
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
pash: remove unused variable; r=fubar I found this as part of comparing the 2 versions of pash.py.
eff01ca68c17fc6ddc0e4834ee4a558849051520: ansible/hg-reviewboard: move non-root handling to own function (bug 1192338); r=fubar
Gregory Szorc <gps@mozilla.com> - Mon, 10 Aug 2015 11:41:07 -0700 - rev 361275
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
ansible/hg-reviewboard: move non-root handling to own function (bug 1192338); r=fubar We move the processing of non-root logins to its own function so we can delay import modules that may fail to import. This ensures that root logins have minimal dependencies and are more robust against failures. We also clean up some unused imports.
ae60916d30dc095c0ba4a3416c7656578dc0be97: ansible/hg-reviewboard: remove server port handling (bug 1192338); r=fubar
Gregory Szorc <gps@mozilla.com> - Mon, 10 Aug 2015 11:40:55 -0700 - rev 361274
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
ansible/hg-reviewboard: remove server port handling (bug 1192338); r=fubar We are only ever listening on port 22. This code is not needed.
de1d6f6647703398750f901cec96678bae376da9: ansible/hg-reviewboard: move QuoteForPOSIX into pash.py (bug 1192338); r=fubar
Gregory Szorc <gps@mozilla.com> - Mon, 10 Aug 2015 11:40:38 -0700 - rev 361273
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
ansible/hg-reviewboard: move QuoteForPOSIX into pash.py (bug 1192338); r=fubar We don't want pash.py importing non-system modules because failure to import could lead to inability to SSH into the machine! We move QuoteForPOSIX into pash.py to avoid a module import.
26f3a48c663ca5b2e1cbf0a4e7c1d8628a5e0413: ansible/hg-reviewboard: clean up pash.py (bug 1192338); r=fubar
Gregory Szorc <gps@mozilla.com> - Mon, 10 Aug 2015 11:40:25 -0700 - rev 361272
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
ansible/hg-reviewboard: clean up pash.py (bug 1192338); r=fubar I'm going to try to have this file match the one used by hg.mozilla.org as much as possible. Start by performing some basic whitespace cleanup and by consolidating use of the USER environment variable.
196fc327b33c7e9c9bc59a39e1115e9e447870ee: ansible/hg-reviewboard: remove unused pash features (bug 1192338); r=fubar
Gregory Szorc <gps@mozilla.com> - Mon, 10 Aug 2015 11:40:12 -0700 - rev 361271
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
ansible/hg-reviewboard: remove unused pash features (bug 1192338); r=fubar We have 2 versions of pash floating around. Over time, I'd like to consolidate them. But that's a large task. This commit starts small by removing unused features from reviewboard's copy of pash. Support for the "pushlog" and "repo-group" commands have been removed. These are or were used for replication and are not relevant to reviewboard's Mercurial server. Since we removed the "repo-group" command, repo_group.py no longer serves a purpose and has been removed as well.
be13a2a84e69770bd8937fca372c04f0d348563c: ansible/hg-reviewboard: drop maximum requests in WSGI processes (bug 1192388); r=fubar
Gregory Szorc <gps@mozilla.com> - Mon, 10 Aug 2015 11:40:00 -0700 - rev 361270
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
ansible/hg-reviewboard: drop maximum requests in WSGI processes (bug 1192388); r=fubar This was recently changed in production as a way to try to keep memory leaks in check.
5240becf3191df26b2e53f79d2661e441f2cee30: ansible/hg-reviewboard: install v-c-t from public server (bug 1192338); r=fubar
Gregory Szorc <gps@mozilla.com> - Mon, 10 Aug 2015 11:39:45 -0700 - rev 361269
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
ansible/hg-reviewboard: install v-c-t from public server (bug 1192338); r=fubar Previously, we assumed v-c-t existed in a staging directory on the local filesystem (from Docker). This assumption does not hold true on servers. Install v-c-t from a public server when not running in Docker.
50ed4a74bfb5a112df4a7fd43d8b36e990000ac3: ansible/hg-reviewboard: configure IUS repo (bug 1192338); r=fubar
Gregory Szorc <gps@mozilla.com> - Mon, 10 Aug 2015 11:39:31 -0700 - rev 361268
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
ansible/hg-reviewboard: configure IUS repo (bug 1192338); r=fubar We'll eventually want to install Python 2.7. Configure the IUS repo to enable this.
4b8550503d1801b540ffa8567535626aa0bb99c5: rbbz: sort comments by file and line number (bug 1183935); r=smacleod
Gregory Szorc <gps@mozilla.com> - Tue, 11 Aug 2015 10:37:50 -0700 - rev 361267
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
rbbz: sort comments by file and line number (bug 1183935); r=smacleod This is how Review Board itself does it (see reviewboard.reviews.views.preview_reply_email). I didn't write a test because it is a Monday.
07bfdf492c6e62b9eeefc3b88e0e139cd7e75d8e: pushlog: backout 3912cb415898 (bug 1114843) for breaking TaskCluster
Gregory Szorc <gps@mozilla.com> - Mon, 10 Aug 2015 18:46:41 -0700 - rev 361266
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
pushlog: backout 3912cb415898 (bug 1114843) for breaking TaskCluster I suspect this is due to type coercion between ints and strings.
25c1a9a295ac9a457db60109f2ec2931235b5515: pash: support enabling obsolescence on repositories (bug 925383); r=bkero
Gregory Szorc <gps@mozilla.com> - Mon, 10 Aug 2015 15:31:40 -0700 - rev 361265
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
pash: support enabling obsolescence on repositories (bug 925383); r=bkero Reasons are discussed in the bug. The test was not explicitly reviewed.
e25916b7b24adfbfd024c297a1d9c2388bec2c08: pash: adjust test output to reflect push_urls hook
Gregory Szorc <gps@mozilla.com> - Mon, 10 Aug 2015 15:05:50 -0700 - rev 361264
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
pash: adjust test output to reflect push_urls hook This is fallout from a502fb4b12f7.
3912cb415898ee50999630f2b8f2231573abb40b: pushlog: return an error if startID is too large (bug 1114843); r=edmorley
Gregory Szorc <gps@mozilla.com> - Mon, 10 Aug 2015 14:00:36 -0700 - rev 361263
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
pushlog: return an error if startID is too large (bug 1114843); r=edmorley Clients need a mechanism to identify when a push ID value is out of bounds. This patch gives them that. This patch also introduces an error reporting mechanism for version 2 payloads. The new error mechanism may not be used everywhere yet. But it should be. Failure to utilize the new error mechanism should be considered a bug.
eb03ee6cd5c2c055983674742d62f19747f2ffba: docker: adjust permissions of file inside LDAP container
Gregory Szorc <gps@mozilla.com> - Fri, 07 Aug 2015 14:28:10 -0700 - rev 361262
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
docker: adjust permissions of file inside LDAP container Secure umasks were giving file permissions errors accessing this file.
6535b540863821926f26ec12701ba18efedb735f: docker: adjust permissions of RabbitMQ config file
Gregory Szorc <gps@mozilla.com> - Fri, 07 Aug 2015 14:11:03 -0700 - rev 361261
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
docker: adjust permissions of RabbitMQ config file Without this, the umask from the host may prevent the rabbit user from reading the file.
b208d030ecdaddbb215e0c9973378ac1ef7948c9: docker: make added files owned by root:root
Gregory Szorc <gps@mozilla.com> - Fri, 07 Aug 2015 13:56:35 -0700 - rev 361260
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
docker: make added files owned by root:root Read the inline comment. Basically secure umask settings meant added files could often not be read.
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip