4ef712436203e98a614179941e195f4b07f4e590: Bug 900750 - part 6: Rename |name| in test_keycodes.xul to |currentTestName| r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 04 Jun 2018 20:41:43 +0900 - rev 808645
Push 113450 by masayuki@d-toybox.com at Wed, 20 Jun 2018 08:29:32 +0000
Bug 900750 - part 6: Rename |name| in test_keycodes.xul to |currentTestName| r?smaug |name| is too generic but the scope is too wide in test_keycodes.xul. So, let's rename it to |currentTestName|. MozReview-Commit-ID: JvEDhRhKYCU
6bee0f0688c9189da838cf1c956b873c01f277f9: Bug 900750 - part 5: Make NativeKey set KeyboardEvent.key value of AltRight key to "AltGraph" when active keyboard layout has AltGr key r?m_kato, smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 31 May 2018 18:36:33 +0900 - rev 808644
Push 113450 by masayuki@d-toybox.com at Wed, 20 Jun 2018 08:29:32 +0000
Bug 900750 - part 5: Make NativeKey set KeyboardEvent.key value of AltRight key to "AltGraph" when active keyboard layout has AltGr key r?m_kato, smaug When AltGr key is pressed, following messages come: 1. WM_KEYDOWN for ControlLeft 2. WM_KEYDOWN for AltLeft 3. WM_SYSKEYUP for ControlLeft 4. WM_KEYUP for AltLeft In these key sequence, KeyboardEvent.key value of keydown event at #2 and keyup event at #4 should be "AltGraph". This patch fixes the key value and adding new test into test_keycodes.xul to check the behavior with SynthesizeNativeKey(). MozReview-Commit-ID: JZ6WednB8la
863ab80d7a002083dcb959ec43e26991e5ba09b9: Bug 900750 - part 4: Make NativeKey replaces MODIFIER_CONTROL and MODIFIER_ALT of mModKeyState with MODIFIER_ALTGRAPH if user emulates AltGr key press with pressing both Ctrl and Alt keys and current keydown produces character(s) r?m_kato, smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 04 Jun 2018 14:45:28 +0900 - rev 808643
Push 113450 by masayuki@d-toybox.com at Wed, 20 Jun 2018 08:29:32 +0000
Bug 900750 - part 4: Make NativeKey replaces MODIFIER_CONTROL and MODIFIER_ALT of mModKeyState with MODIFIER_ALTGRAPH if user emulates AltGr key press with pressing both Ctrl and Alt keys and current keydown produces character(s) r?m_kato, smaug Users can emulate AltGr key with pressing both Ctrl key and Alt key on Windows since AltGr is represented as so in Windows and physical keyboard may not have AltRight key. If user emulates AltGr key, we should set MODIFIER_ALTGRAPH to a set of keyboard events for printable keys only when the key press produces character(s) or a dead key. For example: 1. ControlLeft keydown event should make ctrlKey true. 2. AltLeft keydown event should make altKey true (not AltGraph state). 3. ctrlKey and altKey of printable keydown, keypress and keyup events should be set to false, but getModifierState("AltGraph") should return true. 4. AltLeft keyup event should make altKey false. 5. ControlLeft keyup event should make ctrlKey false. (If AltLeft key is pressed first, altKey of AltLeft keydown is true and both altKey and ctrlKey of the following ControlLeft keydown are true as usual.) MozReview-Commit-ID: 8Km8GXPDQw1
d8290c76d7294d741fcce7992a5a79f5e3f3197c: Bug 900750 - part 3: Remove unnecessary ModifierKeyState argument from some methods of NativeKey and KeyboardLayout r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 01 Jun 2018 15:22:41 +0900 - rev 808642
Push 113450 by masayuki@d-toybox.com at Wed, 20 Jun 2018 08:29:32 +0000
Bug 900750 - part 3: Remove unnecessary ModifierKeyState argument from some methods of NativeKey and KeyboardLayout r?m_kato KeyboardLayout::InitNativeKey() takes |const ModifierKeyState&| as its argument with NativeKey reference and it calls some internal methods with the given ModifierKeyState without any changes. Additionally, its caller is only NativeKey::InitWithKeyChar() and its called with given NativeKey instance's mModKeyState. So, removing the redundant arguments from some methods makes them clearer what they compute with. So, this patch does not change any behavior. MozReview-Commit-ID: 3w9Ee7PMU05
ed2c80339d1ab786e3a233f2ac75f84f1eacadc9: Bug 900750 - part 2: Make ModifierKeyState and VirtualKey treat AltGraph as new modifier and won't set Control and Alt state while AltGraph is active r?m_kato, smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 30 May 2018 17:27:31 +0900 - rev 808641
Push 113450 by masayuki@d-toybox.com at Wed, 20 Jun 2018 08:29:32 +0000
Bug 900750 - part 2: Make ModifierKeyState and VirtualKey treat AltGraph as new modifier and won't set Control and Alt state while AltGraph is active r?m_kato, smaug By the proposal from Google, <https://github.com/w3c/uievents/issues/147>, Chromium treat AltRight key as "AltGraph" modifier if the keyboard layout has AltGr key. When AltRight key is pressed with a keyboard layout which has AltGr key, modifiers should as following: 1. "keydown" for ControlLeft: ctrlKey: true, altKey: false, getModifierState("AltGraph"): false 2. "keydown" for AltRight: ctrlKey: false, altKey: false, getModifierState("AltGraph"): true 3. Some "keydown", "keypress" and "keyup" events: ctrlKey: false, altKey: false, getModifierState("AltGraph"): true 4. "keyup" for ControlLeft: ctrlKey: false, altKey: false, getModifierState("AltGraph"): true 5. "keyup" for AltRight: ctrlKey: false, altKey: false, getModifierState("AltGraph"): false So, only when the preceding "keydown" event for ControlLeft, ctrlKey should be set to true as usual. However, after AltRight key is pressed actually, we should treat "AltGraph" modifier is true and both ctrlKey and altKey should be set to false for web apps can handle text input normally. So, MODIFIER_ALTGRAPH and MODIFIER_CONTROL/MODIFIER_ALT should not be set at the same time. This patch makes ModifierKeyState have only MODIFIER_ALTGRAPH or MODIFIER_CONTROL/MODIFIER_ALT. Additionally, this patch makes VirtualKey::ShiftState treat "AltGraph" as a modifier. So, now, VirtualKey needs to convert ShiftState to index value when it accesses its mShiftStates array. Therefore, this patch adds VirtualKey::ToIndex() and make each VirtualKey method use it before accessing mShiftStates. Note that this patch also fixes bug of WinUtils::SetupKeyModifiersSequence(). The constructor of KeyPair takes 2 keycode values, but the second virtual keycode can have scancode to distinguish if the key is left or right. However, WinUtils::SetupKeyModifiersSequence() never sets scancode to KeyPair. Therefore, it fails to dispatch AltRight key event. MozReview-Commit-ID: 7ealxJH9KlZ
678133d451cf2bd9a5b5cd483dc9c1ae25f4d891: Bug 900750 - part 1: Make KeyboardLayout store the information if current keyboard layout has AltGr key r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 29 May 2018 20:36:38 +0900 - rev 808640
Push 113450 by masayuki@d-toybox.com at Wed, 20 Jun 2018 08:29:32 +0000
Bug 900750 - part 1: Make KeyboardLayout store the information if current keyboard layout has AltGr key r?m_kato For setting AltRight key's key value to "AltGraph" if it should work as so, we need to know if current keyboard layout has AltGr key. Unfortunately, Windows doesn't provide such information but we retrieve all input characters from each key when a keyboard layout is loaded. So, when we load a keyboard layout, we can mark if current keyboard layout has AltGr key with checking at least one key inputs different character(s) when AltGr key is pressed. MozReview-Commit-ID: 8GI3phSVTUS
dbcf06cfd39570bc018592f38e34b3b1c20c26f6: Bug 1452645 - Remove now unused PlacesTransactions.Annotate. r?mak draft
Mark Banner <standard8@mozilla.com> - Fri, 08 Jun 2018 14:24:36 +0100 - rev 808639
Push 113449 by bmo:standard8@mozilla.com at Wed, 20 Jun 2018 07:53:58 +0000
Bug 1452645 - Remove now unused PlacesTransactions.Annotate. r?mak MozReview-Commit-ID: JYnSX4DeibY
78fcb699cfc170f8c48b5bfc62335b423a28787f: Bug 1452645 - Remove load in sidebar functionality. r?mak,r?lina draft
Mark Banner <standard8@mozilla.com> - Wed, 06 Jun 2018 21:00:45 +0100 - rev 808638
Push 113449 by bmo:standard8@mozilla.com at Wed, 20 Jun 2018 07:53:58 +0000
Bug 1452645 - Remove load in sidebar functionality. r?mak,r?lina Based on patch by mixedpuppy. MozReview-Commit-ID: BZwOtr4VbCH
4a7a2a4e55314035dad120040fd7e172662a63c7: Bug 1454973 - Part 2.Add the animation inspector test of RTL environment. r?daisuke draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 20 Jun 2018 16:42:07 +0900 - rev 808637
Push 113448 by bmo:mantaroh@gmail.com at Wed, 20 Jun 2018 07:53:27 +0000
Bug 1454973 - Part 2.Add the animation inspector test of RTL environment. r?daisuke The patch of part 1 changed the logic of scrubber and tick label / line. So this patch will add the related tests of this MozReview-Commit-ID: 4XcEBq80yk2
71017f2d9e0f4f9301def57636611cff2e6dbe21: Bug 1454973 - Part 1. Support RTL in animation inspector. r?daisuke draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 20 Jun 2018 16:41:58 +0900 - rev 808636
Push 113448 by bmo:mantaroh@gmail.com at Wed, 20 Jun 2018 07:53:27 +0000
Bug 1454973 - Part 1. Support RTL in animation inspector. r?daisuke This patch will make animation inspector to support RTL environment. In order to support RTL in animation inspector, this patch introduce direction propertiy in each component. Toolbox get the direction once[1], so this patch will not change this direction property when changing the uidirection preference. [1] https://searchfox.org/mozilla-central/rev/42930ab9634ebf3f62aed60f7d1c1bf25c0bf00c/devtools/client/framework/toolbox.js#194-206 MozReview-Commit-ID: KA3eTuKaKPN
22593ab96742e5e6a91ef193adda4b555b3ecc7e: pick draft
trisha <tgupta@mozilla.com> - Mon, 18 Jun 2018 23:04:56 +0530 - rev 808635
Push 113447 by bmo:guptatrisha97@gmail.com at Wed, 20 Jun 2018 07:41:50 +0000
pick MozReview-Commit-ID: 97SkPGyrMSc
adf01e07aa88026519a6b337f317efb66834a50d: Bug 1458446 - Add AudioWorkletNode interface definitions. r=karlt draft
Arnaud Bienner <arnaud.bienner@gmail.com> - Fri, 01 Jun 2018 19:10:02 +0200 - rev 808634
Push 113446 by bmo:arnaud.bienner@gmail.com at Wed, 20 Jun 2018 07:35:28 +0000
Bug 1458446 - Add AudioWorkletNode interface definitions. r=karlt MozReview-Commit-ID: 3mMa4qnP29n
d311b8e3c28c61982d14487f876182181c325d66: Bug 1468670 - Enablel Alt modifier key on Wayland r?stransky draft
Takuro Ashie <ashie@clear-code.com> - Wed, 20 Jun 2018 16:24:27 +0900 - rev 808633
Push 113445 by bmo:ashie@clear-code.com at Wed, 20 Jun 2018 07:25:39 +0000
Bug 1468670 - Enablel Alt modifier key on Wayland r?stransky MozReview-Commit-ID: 3nxxJabsTkx
c4ee4ad88cdfa10f07b00581a3aa313f9d9a1b11: Bug 1469769 - Part 7: Remove NS_NOTREACHED definition. r?froydnj draft
Chris Peterson <cpeterson@mozilla.com> - Sun, 17 Jun 2018 22:34:23 -0700 - rev 808632
Push 113444 by cpeterson@mozilla.com at Wed, 20 Jun 2018 07:17:30 +0000
Bug 1469769 - Part 7: Remove NS_NOTREACHED definition. r?froydnj MozReview-Commit-ID: IwzSGKF3Osk
b0b946b29ef097ba39a2e988aab8e8bd547d367e: Bug 1469769 - Part 6b: Word-wrap and reindent long lines with MOZ_ASSERT_UNREACHABLE. r?froydnj draft
Chris Peterson <cpeterson@mozilla.com> - Sat, 09 Dec 2017 00:01:08 -0800 - rev 808631
Push 113444 by cpeterson@mozilla.com at Wed, 20 Jun 2018 07:17:30 +0000
Bug 1469769 - Part 6b: Word-wrap and reindent long lines with MOZ_ASSERT_UNREACHABLE. r?froydnj This patch is mostly whitespace changes to fix lines longer than 80 characters after replacing s/NS_NOTREACHED/MOZ_ASSERT_UNREACHABLE/. There are a couple other formatting cleanups, too. MozReview-Commit-ID: 6EutmlsDlNK
5708724e2874f57b00d85f067ccb00b9bb4aa6b6: Bug 1469769 - Part 6a: Replace non-failing NS_NOTREACHED with MOZ_ASSERT_UNREACHABLE. r?froydnj draft
Chris Peterson <cpeterson@mozilla.com> - Sun, 17 Jun 2018 22:43:11 -0700 - rev 808630
Push 113444 by cpeterson@mozilla.com at Wed, 20 Jun 2018 07:17:30 +0000
Bug 1469769 - Part 6a: Replace non-failing NS_NOTREACHED with MOZ_ASSERT_UNREACHABLE. r?froydnj This patch is an automatic replacement of s/NS_NOTREACHED/MOZ_ASSERT_UNREACHABLE/. Reindenting long lines and whitespace fixups follow in patch 6b. MozReview-Commit-ID: 5UQVHElSpCr
a215c8f1adcc79328bf0970181bfcace3097a9a2: Bug 1469769 - Part 5: widget/gtk: Replace failing NS_NOTREACHED with NS_ERROR. r?karlt draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 04 Jun 2018 01:43:02 -0700 - rev 808629
Push 113444 by cpeterson@mozilla.com at Wed, 20 Jun 2018 07:17:30 +0000
Bug 1469769 - Part 5: widget/gtk: Replace failing NS_NOTREACHED with NS_ERROR. r?karlt I'm replacing non-failing calls to NS_NOTREACHED with MOZ_ASSERT_UNREACHABLE, but this NS_NOTREACHED fails when running the browser/base/content/test/general/browser_tab_dragdrop2.js test because mContainer is unexpectedly *not* null. This is bug 1469183. This patch DOES NOT fix the cause of the assertion failure. It just replaces this failing NS_NOTREACHED with NS_ERROR because I can't replace with a fatal MOZ_ASSERT_UNREACHABLE. MozReview-Commit-ID: KeVjvKGihxZ
b6ea29cce2595d68757589c37a7922b70cfaaf74: Bug 1469769 - Part 4: svg: Replace failing NS_NOTREACHED with NS_ERROR. r?heycam draft
Chris Peterson <cpeterson@mozilla.com> - Sat, 26 May 2018 17:11:02 -0700 - rev 808628
Push 113444 by cpeterson@mozilla.com at Wed, 20 Jun 2018 07:17:30 +0000
Bug 1469769 - Part 4: svg: Replace failing NS_NOTREACHED with NS_ERROR. r?heycam I'm replacing non-failing calls to NS_NOTREACHED with MOZ_ASSERT_UNREACHABLE, but this NS_NOTREACHED fails when running the dom/svg/crashtests/412104-1.svg test. This assertion failure is bug 903785. This patch DOES NOT fix the cause of the assertion failure (a missing TextNodeCorrespondenceProperty). It just replaces this failing NS_NOTREACHED with NS_ERROR because I can't replace with a fatal MOZ_ASSERT_UNREACHABLE. MozReview-Commit-ID: 8ffEdO5W1zU
11504ad179370fe453f60e38e9874e29852a8818: Bug 1469769 - Part 3: css: Replace failing NS_NOTREACHED with NS_ERROR. r?heycam draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 04 Jun 2018 01:41:20 -0700 - rev 808627
Push 113444 by cpeterson@mozilla.com at Wed, 20 Jun 2018 07:17:30 +0000
Bug 1469769 - Part 3: css: Replace failing NS_NOTREACHED with NS_ERROR. r?heycam I'm replacing non-failing calls to NS_NOTREACHED with MOZ_ASSERT_UNREACHABLE, but this SelectionManager assertion fails when running the Linux debug Web platform tests with e10s test-linux32/debug-web-platform-tests-reftests-e10s-6 W-e10s(Wr6). This assertion failure is bug 1221888. Marionette INFO Testing http://web-platform.test:8000/css/CSS2/ui/outline-applies-to-005.xht == http://web-platform.test:8000/css/CSS2/reference/no-red-on-blank-page-ref.xht ###!!! ASSERTION: we should have saved a frame property: 'Error', file /builds/worker/workspace/build/src/layout/painting/nsCSSRendering.cpp, line 1038 This patch DOES NOT fix the cause of the assertion failure (a missing HyperTextAccessible). It just replaces this failing NS_NOTREACHED with NS_ERROR because I can't replace with a fatal MOZ_ASSERT_UNREACHABLE. MozReview-Commit-ID: L26bu4agM6y
599868b974c9e5a6321feaa6b05af12c994bef02: Bug 1469769 - Part 2: animation: Replace failing NS_NOTREACHED with NS_ERROR. r?heycam draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 04 Jun 2018 01:44:39 -0700 - rev 808626
Push 113444 by cpeterson@mozilla.com at Wed, 20 Jun 2018 07:17:30 +0000
Bug 1469769 - Part 2: animation: Replace failing NS_NOTREACHED with NS_ERROR. r?heycam I'm replacing non-failing calls to NS_NOTREACHED with MOZ_ASSERT_UNREACHABLE, but this NS_NOTREACHED fails when running the devtools/client/animationinspector/test/browser_animation_refresh_on_removed_animation.js test. This assertion failure is bug 1189015. This patch DOES NOT fix the cause of the assertion failure (a missing TextNodeCorrespondenceProperty). It just replaces this failing NS_NOTREACHED with NS_ERROR because I can't replace with a fatal MOZ_ASSERT_UNREACHABLE. MozReview-Commit-ID: H5rfyr71N1M
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip