4e0a8a128c13c260ac1c421584b81c5a664dedb6: Bug 1407830 - Verify that RDM swaps take place. r=ochameau draft
J. Ryan Stinnett <jryans@gmail.com> - Fri, 13 Oct 2017 20:19:49 -0500 - rev 680417
Push 84507 by bmo:jryans@gmail.com at Sat, 14 Oct 2017 04:45:44 +0000
Bug 1407830 - Verify that RDM swaps take place. r=ochameau It is possible for the frame loader swap within `gBrowser._swapBrowserDocShells` to fail when various frame state is either not ready yet or doesn't match between the two browsers you're trying to swap. However, such errors are currently caught and silenced in the browser, because they are apparently expected in certain cases. So, here we do our own check to verify that the swap actually did in fact take place, making it much easier to track such errors when they happen. MozReview-Commit-ID: LwuCXJQRRVW
146858c8c768e66dd056cc9d28f75d567115e584: Bug 1407830 - Add diagnostics to RDM swap. r=ochameau draft
J. Ryan Stinnett <jryans@gmail.com> - Fri, 13 Oct 2017 20:07:24 -0500 - rev 680416
Push 84507 by bmo:jryans@gmail.com at Sat, 14 Oct 2017 04:45:44 +0000
Bug 1407830 - Add diagnostics to RDM swap. r=ochameau Add some (disabled by default) logging to the RDM swap process to speed up future investigations. MozReview-Commit-ID: ICuH7i5Nsq5
f1abc0c0dcf5789b0dad06c7fd30645c33192e7b: Bug 1408365 - Enable flake8/py2/py3 linters on python/mozboot. r?ahal draft
Steve Armand <stevea1@mac.com> - Fri, 13 Oct 2017 23:33:00 -0400 - rev 680415
Push 84506 by bmo:stevea1@mac.com at Sat, 14 Oct 2017 03:36:03 +0000
Bug 1408365 - Enable flake8/py2/py3 linters on python/mozboot. r?ahal MozReview-Commit-ID: 3koZq509bjP
098e1b5ef5f7ee1702e19300204055ec6246a9ce: Bug 1407789 - Prohibit iframes for Credential Management r?qdot r?ttaubert draft
J.C. Jones <jjones@mozilla.com> - Thu, 12 Oct 2017 18:18:39 -0700 - rev 680414
Push 84505 by bmo:jjones@mozilla.com at Sat, 14 Oct 2017 03:34:08 +0000
Bug 1407789 - Prohibit iframes for Credential Management r?qdot r?ttaubert Credential Management defines that if the responsible document is not the active document in a top-level browsing context, then operations should return NotSupportedError [1][2]. However, we have to also allow iframes from the same origin for Mochitests, and it's just a reasonable expansion that's been discussed in-person a number of times. This ensures that https://webauthn.bin.coffee/iframe.html works, but the cross-origin https://u2f.bin.coffee/iframe-webauthn.html does not. qdot: Please check my logic for IsNotInAFrameOrIsSameOrigin - it appears to work, but I'm no DOM expert! [1] https://w3c.github.io/webappsec-credential-management/#algorithm-request [2] https://w3c.github.io/webappsec-credential-management/#algorithm-create MozReview-Commit-ID: KIyakgl0kGv
f474cb4e9f8be2515ae83bdfbdfa172f1ea3c096: Bug 1393672 - Show PWA onboarding and confrim prompt r?jwu draft
Nevin Chen(:nechen) <cnevinchen@gmail.com> - Tue, 26 Sep 2017 15:52:36 +0800 - rev 680413
Push 84504 by bmo:cnevinchen@gmail.com at Sat, 14 Oct 2017 03:20:28 +0000
Bug 1393672 - Show PWA onboarding and confrim prompt r?jwu MozReview-Commit-ID: Kzih56Om7NO
4cac676e46179855a86084048f60f66e75be89ba: Bug 1405655 - Only hide Flash Activation overlay UI if the entire plugin is covered. r=dothayer draft
Felipe Gomes <felipc@gmail.com> - Fri, 13 Oct 2017 22:17:17 -0300 - rev 680412
Push 84503 by felipc@gmail.com at Sat, 14 Oct 2017 01:17:44 +0000
Bug 1405655 - Only hide Flash Activation overlay UI if the entire plugin is covered. r=dothayer As opposed to right now where we hide if any of the corners or the center of the plugin is covered. MozReview-Commit-ID: BftGp9oLVQz
44c00191a4ce5b98f6f906a280ec70c21eae7fd9: Bug 1405655 - Only hide Flash Activation overlay UI if the entire plugin is covered. r=dothayer draft
Felipe Gomes <felipc@gmail.com> - Fri, 13 Oct 2017 22:12:24 -0300 - rev 680411
Push 84502 by felipc@gmail.com at Sat, 14 Oct 2017 01:13:08 +0000
Bug 1405655 - Only hide Flash Activation overlay UI if the entire plugin is covered. r=dothayer As opposed to right now where we hide if any of the corners or the center of the plugin is covered. MozReview-Commit-ID: 8Nkt55ncBS4
99a0e73bc99c502af9bf6cacbb5203055eaa40b9: Bug 1407789 - Prohibit iframes for Credential Management r?qdot r?ttaubert draft
J.C. Jones <jjones@mozilla.com> - Thu, 12 Oct 2017 18:18:39 -0700 - rev 680410
Push 84501 by bmo:jjones@mozilla.com at Sat, 14 Oct 2017 01:06:38 +0000
Bug 1407789 - Prohibit iframes for Credential Management r?qdot r?ttaubert Credential Management defines that if the responsible document is not the active document in a top-level browsing context, then operations should return NotSupportedError [1][2]. However, we have to also allow iframes from the same origin for Mochitests, and it's just a reasonable expansion that's been discussed in-person a number of times. This ensures that https://webauthn.bin.coffee/iframe.html works, but the cross-origin https://u2f.bin.coffee/iframe-webauthn.html does not. qdot: Please check my logic for IsNotInAFrameOrIsSameOrigin - it appears to work, but I'm no DOM expert! [1] https://w3c.github.io/webappsec-credential-management/#algorithm-request [2] https://w3c.github.io/webappsec-credential-management/#algorithm-create MozReview-Commit-ID: KIyakgl0kGv
069a788ea56aebd02072341d40d6ad53c43812cc: Bug 616436 - (For feedback only) Column-span implementation. draft
Neerja Pancholi <npancholi@mozilla.com> - Fri, 13 Oct 2017 17:56:23 -0700 - rev 680409
Push 84500 by bmo:npancholi@mozilla.com at Sat, 14 Oct 2017 01:04:37 +0000
Bug 616436 - (For feedback only) Column-span implementation. This is an implementation of the column-span property based on an approach similar to IB-Splitting. The high level algorithm is to break up content under a multicol into ColumnSetFrames and column-span wrappers such that the column-span wrappers are always direct children of the multicol wrapper itself and so take up all available inline space just like any other block level element. This new multicol wrapper that wraps both ColumnSetFrames and column-span wrapper frames is called the 'ColumnSetWrapper'. Some known problems with this implementation are: 1. [FIXED]Crash when using the inspector with any of the test cases. This is currently preventing the debugging of other issues so is highest priority. 2. [Most fixed, in process] Some margin related bugs. 3. [Most fixed, in process] Test failures on try need to be cleaned up. Because of these problems, this patch is not yet ready for review. MozReview-Commit-ID: 7SxGHwE9csv
74680f284b289b7699489de25a9de08509b59cf4: Bug 616436 - (For feedback only) Column-span implementation. draft
Neerja Pancholi <npancholi@mozilla.com> - Fri, 13 Oct 2017 17:56:23 -0700 - rev 680408
Push 84499 by bmo:npancholi@mozilla.com at Sat, 14 Oct 2017 01:03:07 +0000
Bug 616436 - (For feedback only) Column-span implementation. This is an implementation of the column-span property based on an approach similar to IB-Splitting. The high level algorithm is to break up content under a multicol into ColumnSetFrames and column-span wrappers such that the column-span wrappers are always direct children of the multicol wrapper itself and so take up all available inline space just like any other block level element. This new multicol wrapper that wraps both ColumnSetFrames and column-span wrapper frames is called the 'ColumnSetWrapper'. Some known problems with this implementation are: 1. [FIXED]Crash when using the inspector with any of the test cases. This is currently preventing the debugging of other issues so is highest priority. 2. [Most fixed, in process] Some margin related bugs. 3. [Most fixed, in process] Test failures on try need to be cleaned up. Because of these problems, this patch is not yet ready for review. MozReview-Commit-ID: 7SxGHwE9csv *** AvailableSize, placeholder and continuing frames related crashes fixed MozReview-Commit-ID: DsSDqhazk8M
64d2d7c30d00fd9394c1cfaf77f095b3b8358fd0: Bug 1407789 - Prohibit iframes for Credential Management r?qdot r?ttaubert draft
J.C. Jones <jjones@mozilla.com> - Thu, 12 Oct 2017 18:18:39 -0700 - rev 680407
Push 84498 by bmo:jjones@mozilla.com at Sat, 14 Oct 2017 01:01:42 +0000
Bug 1407789 - Prohibit iframes for Credential Management r?qdot r?ttaubert Credential Management defines that if the responsible document is not the active document in a top-level browsing context, then operations should return NotSupportedError [1][2]. However, we have to also allow iframes from the same origin for Mochitests, and it's just a reasonable expansion that's been discussed in-person a number of times. This ensures that https://webauthn.bin.coffee/iframe.html works, but the cross-origin https://u2f.bin.coffee/iframe-webauthn.html does not. [1] https://w3c.github.io/webappsec-credential-management/#algorithm-request [2] https://w3c.github.io/webappsec-credential-management/#algorithm-create MozReview-Commit-ID: KIyakgl0kGv
3b0f07fe0e8120e1cf81c558e7bb9bd87733be4c: Bug 1407789 - Prohibit iframes for Credential Management r?qdot r?ttaubert draft
J.C. Jones <jjones@mozilla.com> - Thu, 12 Oct 2017 18:18:39 -0700 - rev 680406
Push 84497 by bmo:jjones@mozilla.com at Sat, 14 Oct 2017 00:52:15 +0000
Bug 1407789 - Prohibit iframes for Credential Management r?qdot r?ttaubert Credential Management defines that if the responsible document is not the active document in a top-level browsing context, then operations should return NotSupportedError [1][2]. However, we have to also allow iframes from the same origin for Mochitests, and it's just a reasonable expansion that's been discussed in-person a number of times. This ensures that https://webauthn.bin.coffee/iframe.html works, but the cross-origin https://u2f.bin.coffee/iframe-webauthn.html does not. [1] https://w3c.github.io/webappsec-credential-management/#algorithm-request [2] https://w3c.github.io/webappsec-credential-management/#algorithm-create MozReview-Commit-ID: KIyakgl0kGv
2221246c7136f4f367b5c23c902587c4588dab8e: Bug 1408585 - Remove RepositorySession begin delegates r=rnewman draft
Grigory Kruglov <gkruglov@mozilla.com> - Fri, 13 Oct 2017 20:20:09 -0400 - rev 680405
Push 84496 by bmo:gkruglov@mozilla.com at Sat, 14 Oct 2017 00:20:51 +0000
Bug 1408585 - Remove RepositorySession begin delegates r=rnewman 'begin' now throws in case things go wrong. MozReview-Commit-ID: 8jcxYiPcsii
705663020160d5cfc52c226f6aeca55794f5e7d7: Bug 1408585 - Remove RepositorySession begin delegates r=rnewman draft
Grigory Kruglov <gkruglov@mozilla.com> - Fri, 13 Oct 2017 20:12:11 -0400 - rev 680404
Push 84495 by bmo:gkruglov@mozilla.com at Sat, 14 Oct 2017 00:12:43 +0000
Bug 1408585 - Remove RepositorySession begin delegates r=rnewman 'begin' now throws in case things go wrong. MozReview-Commit-ID: 8jcxYiPcsii
c550ad6ceb9dddfe236a6a41bec86a468c13f9a5: Bug 1408585 - Remove RepositorySession begin delegates r=rnewman draft
Grigory Kruglov <gkruglov@mozilla.com> - Fri, 13 Oct 2017 20:03:04 -0400 - rev 680403
Push 84494 by bmo:gkruglov@mozilla.com at Sat, 14 Oct 2017 00:08:00 +0000
Bug 1408585 - Remove RepositorySession begin delegates r=rnewman 'begin' now throws in case things go wrong. MozReview-Commit-ID: 8jcxYiPcsii
0ae38eb1cc1d249c6a9fcd6425209a18cf5db625: Bug 1385461 - Document the reason for wire_format.cc in SOURCES. draft
Francois Marier <francois@mozilla.com> - Thu, 12 Oct 2017 17:27:56 -0700 - rev 680402
Push 84493 by fmarier@mozilla.com at Fri, 13 Oct 2017 23:58:48 +0000
Bug 1385461 - Document the reason for wire_format.cc in SOURCES. wire_format.cc needs to be out of UNIFIED_SOURCES because it won't get the GetMessage undef from common.h: https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/stubs/common.h#L76-L91 which works around windows.h containing a define for GetMessage() that turns it into GetMessageA(). This removes the need for the customization added in bug 1024774: https://hg.mozilla.org/mozilla-central/diff/8f5b5bbc27af/toolkit/components/protobuf/m-c-changes.patch#l1.25 MozReview-Commit-ID: CrpgEQCBWhf
c7a48608b3eaa09997e8d6908bea20cbdbb0c7a2: Bug 1385461 - Document the reason for the json_escaping.h-including cc files in SOURCES. draft
Francois Marier <francois@mozilla.com> - Thu, 12 Oct 2017 17:27:49 -0700 - rev 680401
Push 84493 by fmarier@mozilla.com at Fri, 13 Oct 2017 23:58:48 +0000
Bug 1385461 - Document the reason for the json_escaping.h-including cc files in SOURCES. Because a namespace is improperly closed outside of the header guard in json_escaping.h: https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/util/internal/json_escaping.h#L91 we can't put any of the files that include json_escaping.h in UNIFIED_SOURCES without fixing this in the upstream source. This should be fixed in the next upstream release: https://github.com/google/protobuf/pull/3744 MozReview-Commit-ID: sc98xgrUfx
afc9bfa03fb0f0fa2a66f59ffe0e3855a3c14203: Bug 1385461 - Document the reason for the time.h-including cc files in SOURCES. draft
Francois Marier <francois@mozilla.com> - Thu, 12 Oct 2017 17:27:45 -0700 - rev 680400
Push 84493 by fmarier@mozilla.com at Fri, 13 Oct 2017 23:58:48 +0000
Bug 1385461 - Document the reason for the time.h-including cc files in SOURCES. On Windows, GetCurrentTime() is an alias for GetTickCount(): DWORD WINAPI GetTickCount(void); which comes from winbase.h: https://msdn.microsoft.com/en-us/library/windows/desktop/ms724408(v=vs.85).aspx In order to add the files that use time.h to UNIFIED_SOURCES, we'd have to add a hack similar to the one that's in util/time_util.h: https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/util/time_util.h#L94-L96 In the interest of patching upstream source as little as possible, we leave these files in SOURCES instead. MozReview-Commit-ID: BHCtTCQw9EU
ff9a5fb232080c93ef5dc6806625981ebaa62e53: Bug 1385461 - Update to the latest version of the protobuf library. r?mossop,mattwoodrow,fitzgen,dimi draft
Francois Marier <francois@mozilla.com> - Fri, 13 Oct 2017 16:04:22 -0700 - rev 680399
Push 84493 by fmarier@mozilla.com at Fri, 13 Oct 2017 23:58:48 +0000
Bug 1385461 - Update to the latest version of the protobuf library. r?mossop,mattwoodrow,fitzgen,dimi The tarball that was imported is the 3.4.1 release: https://github.com/google/protobuf/releases/tag/v3.4.1 https://github.com/google/protobuf/releases/download/v3.4.1/protobuf-cpp-3.4.1.tar.gz This drops all of the customizations that are no longer needed, which includes a few issues that were fixed upstream: - r512.patch from bug 892856: https://searchfox.org/mozilla-central/rev/bab9dbe9c4ef71f71fb07e53b701fb2dfde277d9/toolkit/components/protobuf/r512.patch https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/io/zero_copy_stream_impl.cc#L43 - vs2013.patch, also from bug 892856: https://searchfox.org/mozilla-central/rev/bab9dbe9c4ef71f71fb07e53b701fb2dfde277d9/toolkit/components/protobuf/vs2013.patch https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/wire_format_lite_inl.h#L39 - sparc64 fixes in m-c-changes.patch from bug 1275204: https://hg.mozilla.org/integration/mozilla-inbound/rev/21d692e82582 https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/stubs/platform_macros.h#L68 The other customizations that were dropped came from bug 1024774. The patch for OpenBSD/32-bit will likely be fixed upstream in a future release: https://github.com/google/protobuf/pull/3747#issuecomment-336581244 Upgrading the protobuf library also required re-generating all of the existing .pb.h and pb.cc files (they are neither forward nor backward-compatible) and making adjustments to the build config to make it compile (and silence warnings). text_format.cc can now be compiled as part of UNIFIED_SOURCES. MozReview-Commit-ID: 7F2IqFmwQnN
b793e27d6abff13848404162bb6eb59b9357f8f4: Bug 1385461 - Add script to regenerate all .pb.cc and .pb.h files. draft
Francois Marier <francois@mozilla.com> - Thu, 12 Oct 2017 16:25:33 -0700 - rev 680398
Push 84493 by fmarier@mozilla.com at Fri, 13 Oct 2017 23:58:48 +0000
Bug 1385461 - Add script to regenerate all .pb.cc and .pb.h files. MozReview-Commit-ID: LR0knKFfL7
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip