4dc8368d2b3f281a6209d369a137d2b41217c55f: Bug 1411480 (attempt 2) - Inline and remove PREF_GetPrefType(). r=glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 26 Oct 2017 16:14:00 +1100 - rev 686891
Push 86341 by bmo:rail@mozilla.com at Thu, 26 Oct 2017 15:26:49 +0000
Bug 1411480 (attempt 2) - Inline and remove PREF_GetPrefType(). r=glandium. It has a single call site. MozReview-Commit-ID: o5CwR8Od7o
f886999fd817b37fd9a1e4d2520407fcb451b6f8: Bug 1411480 (attempt 2) - Inline and remove pref_[SG]etInitPhase(). r=glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 26 Oct 2017 16:14:00 +1100 - rev 686890
Push 86341 by bmo:rail@mozilla.com at Thu, 26 Oct 2017 15:26:49 +0000
Bug 1411480 (attempt 2) - Inline and remove pref_[SG]etInitPhase(). r=glandium. They both have a single use. MozReview-Commit-ID: 4Jj64B6NV0o
c86d508a5e22c0d7869f71b3a5d2e76d144693ca: Bug 1411480 (attempt 2) - Inline and remove pref_SetWatchingPref(). r=glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 26 Oct 2017 16:14:00 +1100 - rev 686889
Push 86341 by bmo:rail@mozilla.com at Thu, 26 Oct 2017 15:26:49 +0000
Bug 1411480 (attempt 2) - Inline and remove pref_SetWatchingPref(). r=glandium. It's simple enough that having a separate function isn't helpful. MozReview-Commit-ID: Ke9BIfp9yHU
c086e6cc2f371172f1672a65701a23ed4cee7184: Bug 1411480 (attempt 2) - Inline and remove the parser's pref_DoCallback() function. r=glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 26 Oct 2017 15:32:15 +1100 - rev 686888
Push 86341 by bmo:rail@mozilla.com at Thu, 26 Oct 2017 15:26:49 +0000
Bug 1411480 (attempt 2) - Inline and remove the parser's pref_DoCallback() function. r=glandium. Preferences.cpp has two functions named pref_DoCallback(). One of them has a single use in the parser. This patch inlines that single use to remove the name duplication. MozReview-Commit-ID: HnyteQ0N5M1
c1fb8f188a56be2dece0ef23c62869c924b0f017: Bug 1411138. Be consistent (and follow the spec) in terms of how we determine the element that propagates styles to the viewport. r=dholbert
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 26 Oct 2017 00:35:22 -0400 - rev 686887
Push 86341 by bmo:rail@mozilla.com at Thu, 26 Oct 2017 15:26:49 +0000
Bug 1411138. Be consistent (and follow the spec) in terms of how we determine the element that propagates styles to the viewport. r=dholbert MozReview-Commit-ID: 8tH3nCDQJID
fda6993fe732f2b0551cc22ae42a3ae53b824b22: Bug 1410790 - Add more assertion in CustomElementData::SetCustomElementDefinition and GetCustomElementDefinition; r=smaug
Edgar Chen <echen@mozilla.com> - Fri, 13 Oct 2017 11:54:46 +0800 - rev 686886
Push 86341 by bmo:rail@mozilla.com at Thu, 26 Oct 2017 15:26:49 +0000
Bug 1410790 - Add more assertion in CustomElementData::SetCustomElementDefinition and GetCustomElementDefinition; r=smaug This is a follow-up patch for bug 1392970. Since we only set CustomElementDefinition on a custom element which is "custom", we could add more assertion to ensure that. MozReview-Commit-ID: 2sLP53bAYVV
86cb23533a6f02536152d18781dcd40996276c15: Bug 1409249: Follow-up: Fix Android build bustage. r=bustage
Kris Maglione <maglione.k@gmail.com> - Wed, 25 Oct 2017 20:56:41 -0700 - rev 686885
Push 86341 by bmo:rail@mozilla.com at Thu, 26 Oct 2017 15:26:49 +0000
Bug 1409249: Follow-up: Fix Android build bustage. r=bustage MozReview-Commit-ID: 1I3z8Oqz9Qm
3feb5338f65c83d2af52fb8a53f866155e88dc15: Bug 1409249: Require singleton constructors to return explicit already_AddRefed. r=froydnj
Kris Maglione <maglione.k@gmail.com> - Mon, 16 Oct 2017 21:08:42 -0700 - rev 686884
Push 86341 by bmo:rail@mozilla.com at Thu, 26 Oct 2017 15:26:49 +0000
Bug 1409249: Require singleton constructors to return explicit already_AddRefed. r=froydnj Right now, NS_GENERIC_FACTORY_SINGLETON_CONSTRUCTOR expects singleton constructors to return already-addrefed raw pointers, and while it accepts constructors that return already_AddRefed, most existing don't do so. Meanwhile, the convention elsewhere is that a raw pointer return value is owned by the callee, and that the caller needs to addref it if it wants to keep its own reference to it. The difference in convention makes it easy to leak (I've definitely caused more than one shutdown leak this way), so it would be better if we required the singleton getters to return an explicit already_AddRefed, which would behave the same for all callers. This also cleans up several singleton constructors that left a dangling pointer to their singletons when their initialization methods failed, when they released their references without clearing their global raw pointers. MozReview-Commit-ID: 9peyG4pRYcr
3c6a28afa74bb374733b637667160dfaa9467e77: Backed out 11 changesets (bug 1411480) for libpref xpcshell test failures
Phil Ringnalda <philringnalda@gmail.com> - Wed, 25 Oct 2017 20:03:25 -0700 - rev 686883
Push 86341 by bmo:rail@mozilla.com at Thu, 26 Oct 2017 15:26:49 +0000
Backed out 11 changesets (bug 1411480) for libpref xpcshell test failures Backed out changeset 0f266ffacf0d (bug 1411480) Backed out changeset 75212b4a8c0a (bug 1411480) Backed out changeset 0c807a8e8b29 (bug 1411480) Backed out changeset 21324f73db0c (bug 1411480) Backed out changeset f7de6fa0ef2c (bug 1411480) Backed out changeset b7cdbe5153fa (bug 1411480) Backed out changeset 8a66ec3e8338 (bug 1411480) Backed out changeset 3fdf2ac7762d (bug 1411480) Backed out changeset eaa177ef5f60 (bug 1411480) Backed out changeset e87ba9542cf8 (bug 1411480) Backed out changeset f1cf84a50ebc (bug 1411480) MozReview-Commit-ID: GEVRPZp5eSH
44543806172479e2d22563e7960d6b92969d25c8: Bug 1410459 - [mozharness] Upgrade from optparse to argparse in config.py, r?jlund draft
Andrew Halberstadt <ahalberstadt@mozilla.com> - Fri, 20 Oct 2017 11:53:44 -0400 - rev 686882
Push 86340 by ahalberstadt@mozilla.com at Thu, 26 Oct 2017 15:24:34 +0000
Bug 1410459 - [mozharness] Upgrade from optparse to argparse in config.py, r?jlund Upgrade from optparse to argparse: 1. 'type' field now needs to be callable (deleted if type was 'string' as that is the default) 2. 'extend' action re-implemented for argparse 3. 'callback' action no longer exists, re-implemented as a custom argparse action (only used in buildbase.py) 4. minor api changes, e.g 'add_option' -> 'add_argument' MozReview-Commit-ID: HcKowF13Da3
ce4e0213bdad9195eda2cbfa279820200a53cdb5: Bug 1385788 - Move the ownership of preview value from PresState to HTMLSelectElement. r=bz draft
Ray Lin <ralin@mozilla.com> - Wed, 25 Oct 2017 11:57:57 +0800 - rev 686881
Push 86339 by bmo:ralin@mozilla.com at Thu, 26 Oct 2017 15:19:50 +0000
Bug 1385788 - Move the ownership of preview value from PresState to HTMLSelectElement. r=bz MozReview-Commit-ID: 9NC8h6SyWdh
56abaa27233349c9c2231af25a366a2899f4696f: Bug 1411615 - make nsScannerIterator a trivial type in order to use memset. r?hsivonen draft
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Thu, 26 Oct 2017 17:50:26 +0300 - rev 686880
Push 86338 by bmo:bpostelnicu@mozilla.com at Thu, 26 Oct 2017 15:19:25 +0000
Bug 1411615 - make nsScannerIterator a trivial type in order to use memset. r?hsivonen MozReview-Commit-ID: 2YpZE8Rryyl
aebcf09227c5da8bfba417f8fa7e09b5cb4add0e: Bug 1334411 - Remove the UI for indexedDB in Permissions section of PageInfo and the identity block. r?johannh draft
Prathiksha <prathikshaprasadsuman@gmail.com> - Wed, 04 Oct 2017 19:59:19 +0530 - rev 686879
Push 86337 by bmo:prathikshaprasadsuman@gmail.com at Thu, 26 Oct 2017 15:18:51 +0000
Bug 1334411 - Remove the UI for indexedDB in Permissions section of PageInfo and the identity block. r?johannh MozReview-Commit-ID: 4Q9H1Aq4O2B
b212d4d6f8a2cf4df2260d3106d0d68cc629d360: Bug 1406610 - Implementing test; r=nchevobbe draft
Jan Odvarko <odvarko@gmail.com> - Thu, 26 Oct 2017 17:17:44 +0200 - rev 686878
Push 86336 by jodvarko@mozilla.com at Thu, 26 Oct 2017 15:18:18 +0000
Bug 1406610 - Implementing test; r=nchevobbe MozReview-Commit-ID: BHmjNR4udTK
1e1219683a37f28fe5a2afa3830b24af3b26118b: Bug 1406610 - No HTTP details for requests executed before the Console is activated; r=nchevobbe draft
Jan Odvarko <odvarko@gmail.com> - Thu, 26 Oct 2017 15:56:00 +0200 - rev 686877
Push 86336 by jodvarko@mozilla.com at Thu, 26 Oct 2017 15:18:18 +0000
Bug 1406610 - No HTTP details for requests executed before the Console is activated; r=nchevobbe MozReview-Commit-ID: 5gteEsxfw7j
015ac6e23476065a553e0f754cce156b75d1b0bd: Bug 1282721 - Add unit tests for shapes highlighter translate/scale for all shapes. r=pbro draft
Mike Park <mikeparkms@gmail.com> - Thu, 12 Oct 2017 15:54:45 -0400 - rev 686876
Push 86335 by bmo:mpark@mozilla.com at Thu, 26 Oct 2017 15:18:07 +0000
Bug 1282721 - Add unit tests for shapes highlighter translate/scale for all shapes. r=pbro MozReview-Commit-ID: JJg0zFtvi9s
9322df6670536f4fae80ca25599d7b0aebd18873: Bug 1282721 - Add transform mode to shapes highlighter with translation/scaling for all shapes. r=pbro draft
Mike Park <mikeparkms@gmail.com> - Tue, 10 Oct 2017 14:05:50 -0400 - rev 686875
Push 86335 by bmo:mpark@mozilla.com at Thu, 26 Oct 2017 15:18:07 +0000
Bug 1282721 - Add transform mode to shapes highlighter with translation/scaling for all shapes. r=pbro MozReview-Commit-ID: HhWY1pT7Mqu
3e51b7fe886ab82c1653fb92527f143118a10844: Bug 1411419 - Update Tiles new tab page to match Photon Design System draft
Ursula Sarracini - Thu, 26 Oct 2017 11:16:38 -0400 - rev 686874
Push 86334 by usarracini@mozilla.com at Thu, 26 Oct 2017 15:17:15 +0000
Bug 1411419 - Update Tiles new tab page to match Photon Design System MozReview-Commit-ID: LqHhkkfiUGE
4d76868991f0703f742b84ea3ca125d891f08fa0: Bug 1385788 - Move the ownership of preview value from PressState to HTMLSelectElement. r=bz draft
Ray Lin <ralin@mozilla.com> - Wed, 25 Oct 2017 11:57:57 +0800 - rev 686873
Push 86333 by bmo:ralin@mozilla.com at Thu, 26 Oct 2017 14:59:40 +0000
Bug 1385788 - Move the ownership of preview value from PressState to HTMLSelectElement. r=bz MozReview-Commit-ID: 9NC8h6SyWdh
0ac3ce12c53d235470dea4eadccead165a0aff48: bug 1406391 - Lock toolkit.telemetry.enabled based on channel r?froydnj draft
Chris H-C <chutten@mozilla.com> - Fri, 13 Oct 2017 16:17:18 -0400 - rev 686872
Push 86332 by bmo:chutten@mozilla.com at Thu, 26 Oct 2017 14:54:37 +0000
bug 1406391 - Lock toolkit.telemetry.enabled based on channel r?froydnj In Unified Telemetry toolkit.telemetry.enabled controls whether we send base collection data or extended collection. The difference is mostly in volume, not in kind (though extended collection has a little stricter testing and monitoring requirements). Since the Preferences UI change in Firefox 56, users no longer have the ability to change toolkit.telemetry.enabled. This is a good thing as for pre-release users very few disabled extended collection, and even fewer release users enabled it. This provides uniform collection based on channel which should eventually net us some efficiencies. Until then we need to align our use of the toolkit.telemetry.enabled pref with the UI change that has already shipped. This is accomplished by locking t.t.e to 'true' on pre-release channels and locking it to 'false' on everything else. This doesn't apply to Android as it doesn't (yet) use Unified Telemetry. t.t.e means something rather different there. MozReview-Commit-ID: EOpWm8b0jWA
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip