4d9d24459024680a7d7aef64cdb2a63920fe3d8e: Bug 1467536: Add CssPropFlags::SerializedByServo and use it on some simple properties. r?xidorn draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 07 Jun 2018 21:07:28 +0200 - rev 805650
Push 112729 by bmo:emilio@crisal.io at Fri, 08 Jun 2018 08:12:40 +0000
Bug 1467536: Add CssPropFlags::SerializedByServo and use it on some simple properties. r?xidorn The idea is to turn the simple properties into a blacklist instead really soon, and fix the offending ones soon after, so that only shorthands and properties with layout dependence (and maybe the scrollbar properties, because the poke at LookAndFeel) are not serialized by Servo. MozReview-Commit-ID: JTLNnmXzny8
d9971ef9917cfc67d64b7f0cfc15cb17af4c22e9: Bug 1467536: Add a Servo API to get the serialized style of a property. r?xidorn draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 07 Jun 2018 20:27:57 +0200 - rev 805649
Push 112729 by bmo:emilio@crisal.io at Fri, 08 Jun 2018 08:12:40 +0000
Bug 1467536: Add a Servo API to get the serialized style of a property. r?xidorn This is intended to be used by GetComputedStyle when there's no layout dependency. MozReview-Commit-ID: 3GAbjo1uQ34
9eddfbefa187c8087966ef2e97b52000244e90b7: Bug 1467461 - Migrate CrashReportingService to JobIntentService; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 08 Jun 2018 10:52:46 +0300 - rev 805648
Push 112728 by plingurar@mozilla.com at Fri, 08 Jun 2018 07:57:04 +0000
Bug 1467461 - Migrate CrashReportingService to JobIntentService; r?sdaswani Use a stub service to actually start our crash reporter. MozReview-Commit-ID: GATl6Waa9St
8c525e856612c0f4e5577b308eeef098cd71086f: Bug 1467692 - Create EditorBase::SelectAllInternal() for internal use r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 07 Jun 2018 22:30:14 +0900 - rev 805647
Push 112727 by masayuki@d-toybox.com at Fri, 08 Jun 2018 07:35:45 +0000
Bug 1467692 - Create EditorBase::SelectAllInternal() for internal use r?m_kato For preparing to fix bug 1465702, we need to split public methods of editor which are used by both outside and itself or friends. SelectAll() is used by both outside and TextEditor. So, we need to create SelectAllInternal() and make TextEditor use it instead. MozReview-Commit-ID: JtIlrfBYBSD
7dacf00f85e00833a470bafc29669fd53c285b2e: Bug 1467691 - Make some methods of EditorBase non-public r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 06 Jun 2018 13:30:44 +0900 - rev 805646
Push 112727 by masayuki@d-toybox.com at Fri, 08 Jun 2018 07:35:45 +0000
Bug 1467691 - Make some methods of EditorBase non-public r?m_kato This moves NotifyEditorObservers() and GetInputEventTargetContent() into protected member which should not be used by friends. And also this moves IsModifiableNode() into protected member which can be used by friends. MozReview-Commit-ID: AxDBgTVED3V
76ee8bf81bbb5543d85c891451a67846dcf17864: Bug 1465455 - extract middleware and enhancer functions from store.js; r=nchevobbe draft
Jan Odvarko <odvarko@gmail.com> - Fri, 08 Jun 2018 08:21:32 +0200 - rev 805645
Push 112726 by jodvarko@mozilla.com at Fri, 08 Jun 2018 07:31:30 +0000
Bug 1465455 - extract middleware and enhancer functions from store.js; r=nchevobbe MozReview-Commit-ID: L9bhjZD028G
f207610632f72d850ee0c66b440e7b6940ea51b2: Bug 1467690 - Make HTMLEditor use MaybeCollapseSelectionAtFirstEditableNode(false) instead of BeginningOfDocument() r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 05 Jun 2018 21:18:05 +0900 - rev 805644
Push 112725 by masayuki@d-toybox.com at Fri, 08 Jun 2018 07:27:10 +0000
Bug 1467690 - Make HTMLEditor use MaybeCollapseSelectionAtFirstEditableNode(false) instead of BeginningOfDocument() r?m_kato HTMLEditor::BeginningOfDocument() is an XPCOM method and it just calls MaybeCollapseSelectionAtFirstEditableNode(false). So, HTMLEditor can call MaybeCollapseSelectionAtFirstEditableNode(false) directly. MozReview-Commit-ID: 8x4j0AwzISl
96ba8e87cee72a7d01d901ef030ffe7724b6217c: Bug 1467691 - Make some methods of EditorBase non-public r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 06 Jun 2018 13:30:44 +0900 - rev 805643
Push 112724 by masayuki@d-toybox.com at Fri, 08 Jun 2018 07:25:52 +0000
Bug 1467691 - Make some methods of EditorBase non-public r?m_kato This moves NotifyEditorObservers() and GetInputEventTargetContent() into protected member which should not be used by friends. And also this moves IsModifiableNode() into protected member which can be used by friends. MozReview-Commit-ID: AxDBgTVED3V
d387662706750000bcd658dee27d470266182ec5: Bug 1467690 - Make HTMLEditor use MaybeCollapseSelectionAtFirstEditableNode(false) instead of BeginningOfDocument() r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 05 Jun 2018 21:18:05 +0900 - rev 805642
Push 112724 by masayuki@d-toybox.com at Fri, 08 Jun 2018 07:25:52 +0000
Bug 1467690 - Make HTMLEditor use MaybeCollapseSelectionAtFirstEditableNode(false) instead of BeginningOfDocument() r?m_kato HTMLEditor::BeginningOfDocument() is an XPCOM method and it just calls MaybeCollapseSelectionAtFirstEditableNode(false). So, HTMLEditor can call MaybeCollapseSelectionAtFirstEditableNode(false) directly.
5f54f0fe59ea8f6182c0b07dea3c7d8d1e09f7a0: Bug 1464011: nsComputedDOMStyle: Don't throw exceptions when querying styles in detached NAC subtrees except for pseudo-elements. r?emilio draft
James Teh <jteh@mozilla.com> - Fri, 08 Jun 2018 17:14:48 +1000 - rev 805641
Push 112723 by bmo:jteh@mozilla.com at Fri, 08 Jun 2018 07:19:41 +0000
Bug 1464011: nsComputedDOMStyle: Don't throw exceptions when querying styles in detached NAC subtrees except for pseudo-elements. r?emilio Bug 1454572 prevents a crash when computed styles are queried on a detached pseudo-element. However, the check was more restrictive than it needed to be and caused exceptions in video controls, which run in NAC and calculate computed styles. This check is now restricted to pseudo-elements (or pseudo-element ancestors). MozReview-Commit-ID: L5zD9CYJbCd
759f528b879703b2ffcfd7140781d1a9562c5569: Bug 1407046 - Migrate UpdateService to JobIntentService; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 06 Jun 2018 16:32:41 +0300 - rev 805640
Push 112722 by plingurar@mozilla.com at Fri, 08 Jun 2018 06:33:31 +0000
Bug 1407046 - Migrate UpdateService to JobIntentService; r?sdaswani Broke the big IntentService into four small JobIntentServices because the same JobIntentService class cannot be used with multiple JobIds (https://github.com/aosp-mirror/platform_frameworks_support/blob/b6838fd2d2e834fdd38aab34511d385cb7108f63/compat/src/main/java/android/support/v4/app/JobIntentService.java#L121) Also: - will make the code easier to be migrated to WorkManager in the future - more in line with SRP. It was initially doing too much. All the functionality of the big UpdateService class has been incorporated in Updater.java, UpdatesPrefs.java and UpdatesServiceHelper.java with the main logic to drive the important actions inside the new Services. UpdaterService is used as parent of the newly created service to help avoid duplicated code. Created an inner BroadcastReceiver to act upon notification actions while the service which posted it is running as it's state needed to be modified. Created a BroadcastReceiver to act on actions from notifications which remained posted after the service that posted them finished. This receiver will just start another UpdaterService. Otherwise the services are to be started from the UpdateServiceHelper class. MozReview-Commit-ID: 2OyBZ4YYvgh
187af0021ceaf9341fa715f9be5ac9433dd4fd78: Bug 1407046 - Migrate FileCleanupService to JobIntentService; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 06 Jun 2018 14:59:23 +0300 - rev 805639
Push 112722 by plingurar@mozilla.com at Fri, 08 Jun 2018 06:33:31 +0000
Bug 1407046 - Migrate FileCleanupService to JobIntentService; r?sdaswani Also cleaned the code a little. MozReview-Commit-ID: Bs3bUdxxz8k
cd93587ac11019ab90acfe3de14c521ae14a5d3a: Bug 1407046 - Migrate TelemetryUploadService to JobIntentService; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 06 Jun 2018 14:55:42 +0300 - rev 805638
Push 112722 by plingurar@mozilla.com at Fri, 08 Jun 2018 06:33:31 +0000
Bug 1407046 - Migrate TelemetryUploadService to JobIntentService; r?sdaswani MozReview-Commit-ID: 8UGDzgmY81y
35936f0475133d64fe7e590a3737da75e0ec540c: Bug 1407046 - Migrate FxAccountDeletedService to JobIntentService; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 06 Jun 2018 14:33:56 +0300 - rev 805637
Push 112722 by plingurar@mozilla.com at Fri, 08 Jun 2018 06:33:31 +0000
Bug 1407046 - Migrate FxAccountDeletedService to JobIntentService; r?sdaswani MozReview-Commit-ID: 5ksrTc1Stre
e8af28bda4fe038bd6f1e3581c199a17bdbac3d2: Bug 1407046 - Migrate FxAccountProfileService to JobIntentService; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 06 Jun 2018 14:27:47 +0300 - rev 805636
Push 112722 by plingurar@mozilla.com at Fri, 08 Jun 2018 06:33:31 +0000
Bug 1407046 - Migrate FxAccountProfileService to JobIntentService; r?sdaswani Also cleaned the code a little. MozReview-Commit-ID: 1Zm3oLVVZ8s
cb5c9b7d74d9d818233ade7123bf5652dca30a54: Bug 1407046 - Migrate TabReceivedService to JobIntentService; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 06 Jun 2018 14:19:18 +0300 - rev 805635
Push 112722 by plingurar@mozilla.com at Fri, 08 Jun 2018 06:33:31 +0000
Bug 1407046 - Migrate TabReceivedService to JobIntentService; r?sdaswani MozReview-Commit-ID: 5CEfJtUfmHq
5ca0188e753129face1c89ce296d19495e26acbd: Bug 1407046 - Migrate DownloadContentService to JobIntentService; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 06 Jun 2018 17:59:09 +0300 - rev 805634
Push 112722 by plingurar@mozilla.com at Fri, 08 Jun 2018 06:33:31 +0000
Bug 1407046 - Migrate DownloadContentService to JobIntentService; r?sdaswani Broke the big IntentService into four small JobIntentServices because the same JobIntentService class cannot be used with multiple JobIds (https://github.com/aosp-mirror/platform_frameworks_support/blob/b6838fd2d2e834fdd38aab34511d385cb7108f63/compat/src/main/java/android/support/v4/app/JobIntentService.java#L121) Also: - will make the code easier to be migrated to WorkManager in the future - more in line with SRP. It was initially doing too much. Cleaned the code a little, removed the unneededly creation of new Threads for DownloadContentCatalog().persistChanges() / .startLoadFromDisk() as those methods are always called from the background threads of the new JobIntentServices. The new DlcHelper helps reducing duplicated code. MozReview-Commit-ID: G3fsWYOGEbR ***
29768a32e5c2e59288e0f065b4f1bc219e8ac750: Bug 1385464 - Resolve obscure leaks and crashes after the upgrade; r?Grisha draft
Petru Lingurar <petru.lingurar@softvision.ro> - Sun, 27 May 2018 12:00:22 +0300 - rev 805633
Push 112722 by plingurar@mozilla.com at Fri, 08 Jun 2018 06:33:31 +0000
Bug 1385464 - Resolve obscure leaks and crashes after the upgrade; r?Grisha - LoaderManager.destroyLoader(..) was added before the existing call to LoaderManager.restartLoader(..) to prevent potential Cursor leaks - Disable website suggestions depending on the address bar inputs when running in automation to avoid Robocop tests failing (they were entering serially maybe 100 characters in <5 ms which created around that many new Threads, operation that could cause the Executor to throw a RejectedExecutionException) At the moment this functionality is not covered by tests anyway and it was the only fix I could find that would not involve changing the whole implemenation for address bar suggestions, implementation which in the real world works ok. MozReview-Commit-ID: Krl9TCjAyzr
4913d12f446164d28cd51a31156bdab448b4d83b: Bug 1385464 - Resolve missing resources and api changes; r?JanH draft
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 07 Jun 2018 13:44:36 +0300 - rev 805632
Push 112722 by plingurar@mozilla.com at Fri, 08 Jun 2018 06:33:31 +0000
Bug 1385464 - Resolve missing resources and api changes; r?JanH - LeanplumActionBarActivity was removed because Support Library 26 deprecated ActionBarActivity. Class was already not in use. - CustomTabsService added two new methods which we need to override. Tested to make sure that previous functionality was maintained but with the addition of the two new methods maybe that feature could be improved. - For checking layout direction we'll use our own new method from ViewUtil which mimics what the now restricted method from the support library would do. - Upgraded to use AppCompatResources#getDrawable(..) in place of the now restricted AppCompatDrawableManager.get().getDrawable(..). MozReview-Commit-ID: 6UpPPVYyPPP
fea67411479e13ee4a0f784f509e5de499722cf6: Bug 1385464 - Start using support library v. 26; r?JanH draft
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 25 May 2018 16:13:42 +0300 - rev 805631
Push 112722 by plingurar@mozilla.com at Fri, 08 Jun 2018 06:33:31 +0000
Bug 1385464 - Start using support library v. 26; r?JanH MozReview-Commit-ID: 2fX1SBHiSh0
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip