4d081c3f615dd44cf3587408c6e4f1a28ca36f3f: Bug 366192 - Fixed http/https regex checks. draft
Moritz Brunner <moritzbrunner@freenet.de> - Mon, 30 Oct 2017 18:46:09 +0100 - rev 688805
Push 86854 by bmo:moritzbrunner@freenet.de at Mon, 30 Oct 2017 17:51:12 +0000
Bug 366192 - Fixed http/https regex checks. MozReview-Commit-ID: 8oFM3US4lvT
e9913278b9d5c57481727de00bc9b8e4517b0d95: Bug 1381684 - Fix intermittent browser/components/extensions/test/browser/browser_ext_tabs_lastAccessed.js, r?mixedpuppy draft
Bob Silverberg <bsilverberg@mozilla.com> - Mon, 30 Oct 2017 13:39:53 -0400 - rev 688804
Push 86853 by bmo:bob.silverberg@gmail.com at Mon, 30 Oct 2017 17:44:13 +0000
Bug 1381684 - Fix intermittent browser/components/extensions/test/browser/browser_ext_tabs_lastAccessed.js, r?mixedpuppy This patch introduces two changes to the test: 1. It breaks apart the assertion that was combining three tests into individual assertions, so if this does fail again in the future it will be easier to spot the actual problem. 2. It waits for the load of each tab to complete before trying to check the lastAccessed times of each tab. When I was able to reproduce the failure, after separating the assertions, I found the one that was failing was the check that tab2.lastAccessed was less than the current time. I believe that the current time was being recorded too soon, which is why I changed the test to not record the current time until after both tabs have completed loading. This seems to fix the intermittent locally for me. MozReview-Commit-ID: I3VoYODwjgz
3c0e359ec68c02454b1ea8f29436db75d5d935ee: Bug 1408121 - Dark theme should apply dark colors to Firefox menus. r?ntim,k88hudson draft
Jared Wein <jwein@mozilla.com> - Thu, 12 Oct 2017 17:51:28 -0400 - rev 688803
Push 86852 by bmo:jaws@mozilla.com at Mon, 30 Oct 2017 17:42:37 +0000
Bug 1408121 - Dark theme should apply dark colors to Firefox menus. r?ntim,k88hudson MozReview-Commit-ID: D3gzLxIUXc
64b7efb97eb85c05406acf784d3326a3c46ea42f: Bug 1381684 - Fix intermittent browser/components/extensions/test/browser/browser_ext_tabs_lastAccessed.js, r?mixedpuppy draft
Bob Silverberg <bsilverberg@mozilla.com> - Mon, 30 Oct 2017 13:39:53 -0400 - rev 688802
Push 86851 by bmo:bob.silverberg@gmail.com at Mon, 30 Oct 2017 17:41:00 +0000
Bug 1381684 - Fix intermittent browser/components/extensions/test/browser/browser_ext_tabs_lastAccessed.js, r?mixedpuppy This patch introduces two changes to the test: 1. It breaks apart the assertion that was combining three tests into individual assertions, so if this does fail again in the future it will be easier to spot the actual problem. 2. It waits for the load of each tab to complete before trying to check the lastAccessed times of each tab. When I was able to reproduce the failure, after separating the assertions, I found the one that was failing was the check that tab2.lastAccessed was less than the current time. I believe that the current time was being recorded too soon, which is why I changed the test to not record the current time until after both tabs have completed loading. This seems to fix the intermittent locally for me. MozReview-Commit-ID: I3VoYODwjgz
bc33fcddaec41c72663b0e38d76a8aad1e49d53f: Bug 1411004 - ./mach clang-format: Better handling of relative paths r?=mystor draft
Sylvestre Ledru <sledru@mozilla.com> - Mon, 30 Oct 2017 18:36:28 +0100 - rev 688801
Push 86850 by bmo:sledru@mozilla.com at Mon, 30 Oct 2017 17:37:26 +0000
Bug 1411004 - ./mach clang-format: Better handling of relative paths r?=mystor For example, this is addressing the issue: ./mach clang-format -p ./mfbt/ MozReview-Commit-ID: Le8mPTOEfA7
73d851b3be50131832db5db3f14fb66ed7d55a9f: Bug 1408326 - Add a parent/children relationship in the ObjectActor; r= draft
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 19 Oct 2017 18:45:39 +0200 - rev 688800
Push 86849 by bmo:nchevobbe@mozilla.com at Mon, 30 Oct 2017 16:59:50 +0000
Bug 1408326 - Add a parent/children relationship in the ObjectActor; r= When creating an object actor, if the creation was initiated by an other object actor, we consider the new object actor a child of the initiator. When releasing an actor, we can then go through all of its children and release them as well. This allow us to only release the "root" ObjectActor in the frontend, and thus can prevent memory leaks. MozReview-Commit-ID: 34Jk0oeswVt
00ace7451869b4161a1f8fbe1bb7a9e9ca870ba7: Bug 1410652 - Let WebDriver:SwitchToFrame take a web element. r?whimboo draft
Andreas Tolfsen <ato@sny.no> - Sat, 21 Oct 2017 19:30:27 +0100 - rev 688799
Push 86848 by bmo:ato@sny.no at Mon, 30 Oct 2017 16:59:49 +0000
Bug 1410652 - Let WebDriver:SwitchToFrame take a web element. r?whimboo The "element" field on the WebDriver:SwitchToFrame command request's body takes a string web element reference UUID as input. This patch changes it so that it can also take a web element JSON Object. The old behaviour can be removed with Firefox 60. MozReview-Commit-ID: JcTD3MRxjOe
3de1051c435f89733878929b0663f7411cd5d096: Bug 1410652 - Use invalid argument error for web element deserialisation. r?whimboo draft
Andreas Tolfsen <ato@sny.no> - Tue, 24 Oct 2017 17:42:32 +0100 - rev 688798
Push 86848 by bmo:ato@sny.no at Mon, 30 Oct 2017 16:59:49 +0000
Bug 1410652 - Use invalid argument error for web element deserialisation. r?whimboo For user input we will want to return the appropriate invalid argument error. For internal input using TypeError is fine. MozReview-Commit-ID: AlOnZuhaczN
ece61cb83f7fc5d153f8f117f7764bc69174d367: Bug 1410652 - Fix various API documentation in element module. r?whimboo draft
Andreas Tolfsen <ato@sny.no> - Tue, 24 Oct 2017 17:38:55 +0100 - rev 688797
Push 86848 by bmo:ato@sny.no at Mon, 30 Oct 2017 16:59:49 +0000
Bug 1410652 - Fix various API documentation in element module. r?whimboo MozReview-Commit-ID: AaGnolglX5n
a086f2347e42889363c8bd5a62c3b5eba23a1d0d: Bug 1410652 - Fix API docs of assert functions. r?whimboo draft
Andreas Tolfsen <ato@sny.no> - Tue, 24 Oct 2017 17:32:26 +0100 - rev 688796
Push 86848 by bmo:ato@sny.no at Mon, 30 Oct 2017 16:59:49 +0000
Bug 1410652 - Fix API docs of assert functions. r?whimboo MozReview-Commit-ID: HktgnHoCGZV
cebe1e7ff0f37fe49a504e8babb7167a99351af3: Bug 1412751 - Add building multilocale.json to the libs step. draft
Zibi Braniecki <zbraniecki@mozilla.com> - Mon, 30 Oct 2017 09:50:16 -0700 - rev 688795
Push 86847 by bmo:gandalf@aviary.pl at Mon, 30 Oct 2017 16:56:05 +0000
Bug 1412751 - Add building multilocale.json to the libs step. MozReview-Commit-ID: 2MalHxkcFxn
1b30f3dfc740e75378a6fb4786affc24db26520e: Bug 1386018 - Tell users that the default search engine was set by an extension r?jaws r?aswan draft
Mark Striemer <mstriemer@mozilla.com> - Wed, 18 Oct 2017 14:54:54 -0500 - rev 688794
Push 86846 by bmo:mstriemer@mozilla.com at Mon, 30 Oct 2017 16:56:01 +0000
Bug 1386018 - Tell users that the default search engine was set by an extension r?jaws r?aswan MozReview-Commit-ID: A7uJ2lN0cLF
889894e70f00a1ef978c2f94f9f1afae2c1c978b: Bug 1412431 - Remove support for MOZ_BUILD_PROJECTS; r?build draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 15:20:34 -0700 - rev 688793
Push 86845 by bmo:gps@mozilla.com at Mon, 30 Oct 2017 16:54:04 +0000
Bug 1412431 - Remove support for MOZ_BUILD_PROJECTS; r?build This was mainly used to support Universal MacOS builds, which were removed several months ago. In theory, someone could be using this feature to build multiple applications with one build system invocation. But given that client.mk is no longer the preferred interface to the build system and multiple applications can be built by running `mach build` with different mozconfigs, I don't think support for this feature is worth keeping. This commit removes support for MOZ_BUILD_PROJECTS and related functionality from client.mk. Support for recognizing MOZ_CURRENT_PROJECT in configure and mozconfig evaluation has also been removed. This includes support for the ac_add_app_options mozconfig function. Good riddance. MozReview-Commit-ID: 7xI2jYxDFFr
ecfa12a477af6c0c29b2cc9873a0ba30d7cfc0a7: Bug 1412431 - Remove support for MOZ_PREFLIGHT and MOZ_POSTFLIGHT; r?build draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 14:55:31 -0700 - rev 688792
Push 86845 by bmo:gps@mozilla.com at Mon, 30 Oct 2017 16:54:04 +0000
Bug 1412431 - Remove support for MOZ_PREFLIGHT and MOZ_POSTFLIGHT; r?build These variables are unused in the repo. The %_ALL variation is used for sccache, however. The last use of these variables was removed when support for MacOS universal builds was removed. Someone somewhere may be relying on this functionality. But I don't think it is worth continuing to support in client.mk. If someone really needs it, we can reintroduce support for the feature elsewhere, like in mach or via mozconfig support somehow. MozReview-Commit-ID: 4KznCmK3JTN
2f47e17ca47b8980b2151365591beca0a66d13d5: Bug 1412431 - Remove MOZ_UNIFY_BDATE; r?build draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 14:49:25 -0700 - rev 688791
Push 86845 by bmo:gps@mozilla.com at Mon, 30 Oct 2017 16:54:04 +0000
Bug 1412431 - Remove MOZ_UNIFY_BDATE; r?build There are no references to this variable outside client.mk. AFAICT it is unused. The only reasonable justification for retaining this support IMO was Universal MacOS builds. And those are no longer supported. MozReview-Commit-ID: 9MnC18Bd1ge
3abb1c22d8b95cd363fae03764f6b180ebf330d5: Bug 1412431 - Remove unused BASE_DIR variable; r?build draft
Gregory Szorc <gps@mozilla.com> - Fri, 27 Oct 2017 14:47:06 -0700 - rev 688790
Push 86845 by bmo:gps@mozilla.com at Mon, 30 Oct 2017 16:54:04 +0000
Bug 1412431 - Remove unused BASE_DIR variable; r?build This variable has been unused since 683e59dc3094 (bug 1286934). MozReview-Commit-ID: FZ7D9mSIeME
5c93ee7593e4bf777507ccb83604acf700f9ab63: Bug 1386018 - Tell users that the default search engine was set by an extension r?jaws r?aswan draft
Mark Striemer <mstriemer@mozilla.com> - Wed, 18 Oct 2017 14:54:54 -0500 - rev 688789
Push 86844 by bmo:mstriemer@mozilla.com at Mon, 30 Oct 2017 16:53:12 +0000
Bug 1386018 - Tell users that the default search engine was set by an extension r?jaws r?aswan MozReview-Commit-ID: A7uJ2lN0cLF
8c8844a2e3ca181107a13ff4ab3984cc35b5d509: Bug 1406247 - 2. Fix testInputConnection to have correct check; r=esawin
Jim Chen <nchen@mozilla.com> - Mon, 30 Oct 2017 12:42:30 -0400 - rev 688788
Push 86844 by bmo:mstriemer@mozilla.com at Mon, 30 Oct 2017 16:53:12 +0000
Bug 1406247 - 2. Fix testInputConnection to have correct check; r=esawin testInputConnection had a wrong check for selection offset, which would otherwise have caught this bug. MozReview-Commit-ID: LdkmkRxK52s
76f9a0835dd7ae66515dd4ee5bd93a034b409794: Bug 1406247 - 1. Don't ignore selection change when Gecko text change is more than expected; r=esawin
Jim Chen <nchen@mozilla.com> - Mon, 30 Oct 2017 12:42:30 -0400 - rev 688787
Push 86844 by bmo:mstriemer@mozilla.com at Mon, 30 Oct 2017 16:53:12 +0000
Bug 1406247 - 1. Don't ignore selection change when Gecko text change is more than expected; r=esawin When a Gecko text change covers more than just our expected change on the Java side, don't ignore the subsequent selection change notification because the Gecko selection could have moved anywhere. MozReview-Commit-ID: 8kvz7Ws9DMM
ef22d58e750f8b24ceac4c93065d137aa939c6d0: Bug 1410236 - Deny permission by default if doorhanger is dismissed; r=sebastian
Jim Chen <nchen@mozilla.com> - Mon, 30 Oct 2017 12:42:30 -0400 - rev 688786
Push 86844 by bmo:mstriemer@mozilla.com at Mon, 30 Oct 2017 16:53:12 +0000
Bug 1410236 - Deny permission by default if doorhanger is dismissed; r=sebastian Add a "defaultCallback" option to the doorhanger API that specifies a callback to call when the doorhanger is dismissed without a button being clicked. Use that to deny a permission in ContentPermissionPrompt.js when the doorhanger is dismissed without explicit action. MozReview-Commit-ID: 9kOAWirI4Ux
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip