4be21a87e4c469820e46b25aa54524cd5fa30c02: Bug 1444301 - Add spacing around separator at end of toolbox; r?jryans draft
Brian Birtles <birtles@gmail.com> - Thu, 05 Apr 2018 10:14:02 +0900 - rev 777701
Push 105266 by bmo:bbirtles@mozilla.com at Thu, 05 Apr 2018 07:52:20 +0000
Bug 1444301 - Add spacing around separator at end of toolbox; r?jryans MozReview-Commit-ID: 2Dkiu1MHGBj
7e8982469703e4193c5377cdf5d85c9e253cb23a: Bug 1444301 - Fix badly rounded corner on frames graphic; r?jryans draft
Brian Birtles <birtles@gmail.com> - Thu, 05 Apr 2018 10:14:02 +0900 - rev 777700
Push 105266 by bmo:bbirtles@mozilla.com at Thu, 05 Apr 2018 07:52:20 +0000
Bug 1444301 - Fix badly rounded corner on frames graphic; r?jryans There seems to be a bug in the way the top-right corner of the frames graphic is rounded. This patch fixes it to make it consistent with the other corners. MozReview-Commit-ID: I7z5IVcEZHL
35538eeca58e7cc2ecc6ccec45ce568a951275ca: Bug 1444301 - Make the meatball button a little less meaty; r?jryans draft
Brian Birtles <birtles@gmail.com> - Thu, 05 Apr 2018 10:14:02 +0900 - rev 777699
Push 105266 by bmo:bbirtles@mozilla.com at Thu, 05 Apr 2018 07:52:20 +0000
Bug 1444301 - Make the meatball button a little less meaty; r?jryans This patch also reworks the SVG to make it a little easier to adjust in future. MozReview-Commit-ID: 7R3hDL3qaVD
080a1128854bb9e8e8f347ff118e45e5e033422a: Bug 1444301 - Tweak RDM button; r?jryans draft
Brian Birtles <birtles@gmail.com> - Thu, 05 Apr 2018 10:14:01 +0900 - rev 777698
Push 105266 by bmo:bbirtles@mozilla.com at Thu, 05 Apr 2018 07:52:20 +0000
Bug 1444301 - Tweak RDM button; r?jryans In the mockup the RDM button is slightly fatter than the current button. This patch adjusts the width of the button, tidying up the file at the same time as follows: * Move the contents to the center (it was off to the right by 0.5px) * Use relative paths for the SVG to make it easier to adjust in future * Fix some precision issues with paths not quite lining up * Simplify the SVG path data MozReview-Commit-ID: KAyx9Ki4y47
ec6adc7b9c6547230f4555c1ebc139b9a3046130: Bug 1444301 - Adjust spacing of iframe button; r?jryans draft
Brian Birtles <birtles@gmail.com> - Thu, 05 Apr 2018 10:13:22 +0900 - rev 777697
Push 105266 by bmo:bbirtles@mozilla.com at Thu, 05 Apr 2018 07:52:20 +0000
Bug 1444301 - Adjust spacing of iframe button; r?jryans This button is a little unbalanced: the icon is in the middle of the button but the drop-down arrow is flush up against the side. Now that it appears right before the separator it looks quite odd since the arrow is touching the separator. This patch adjusts the margins so that the contents sit more neatly inside the button. This patch also fixes the vertical position of the arrow so that it is a little lower, to match the mockup. MozReview-Commit-ID: 3P50X69paFb
5407dab6ac71034d66c11b8a11257f75e1b42c1f: Bug 1447544 - Remove the event listeners and timers when the videocontrols binding is destroyed draft
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 28 Mar 2018 15:35:33 +0800 - rev 777696
Push 105265 by timdream@gmail.com at Thu, 05 Apr 2018 06:41:36 +0000
Bug 1447544 - Remove the event listeners and timers when the videocontrols binding is destroyed Additionally, - Remove `self = this` usage - Access to the `Utils` object from the scope chain MozReview-Commit-ID: 5kbLgD951CM
9bec5291be35070c838fb9802f9cb816963e34bc: Bug 1447544 - Set firstShow to false before the control fades out draft
Timothy Guan-tin Chien <timdream@gmail.com> - Thu, 05 Apr 2018 13:07:27 +0800 - rev 777695
Push 105265 by timdream@gmail.com at Thu, 05 Apr 2018 06:41:36 +0000
Bug 1447544 - Set firstShow to false before the control fades out The flag is used to trigger play() when the control first hides. There is no reason to set only after transition ends. We can set it to false as soon as we trigger play(). This is likely to fix a regression from bug 1449532 given that we have switched to Web Animation API there. MozReview-Commit-ID: F4n3rKdzYKr
cf9b6929b8106c453b00236e692956fd4d6ca186: Bug 1449564 - part 3: Make absolute position editor listen to mouse events at the system event group r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 05 Apr 2018 00:32:32 +0900 - rev 777694
Push 105264 by masayuki@d-toybox.com at Thu, 05 Apr 2018 05:23:22 +0000
Bug 1449564 - part 3: Make absolute position editor listen to mouse events at the system event group r?m_kato Currently, absolute position editor listens to mouse events at the default event group to handle dragging of positioner. However, this is blocked by a call of Event.stopPropagation() in web apps unexpectedly. Therefore, we should make it listen to the events at the system event group instead. MozReview-Commit-ID: Hoa8c9QvMuG
094d1ed044e170d9dd8d24582c76018c63f67e5c: Bug 1449564 - part 2: Make absolute positioned element editor disabled in default and make it possible to enable it with new command r?m_kato, smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 04 Apr 2018 22:27:49 +0900 - rev 777693
Push 105264 by masayuki@d-toybox.com at Thu, 05 Apr 2018 05:23:22 +0000
Bug 1449564 - part 2: Make absolute positioned element editor disabled in default and make it possible to enable it with new command r?m_kato, smaug We have another built-in UI of editor which is not implemented by any other browsers. That is a draggable handler to move absolute positioned elements. So, we should disable it in default for compatibility with the other browsers. However, different from resizers and inline table editor, we don't have command to enable/disable this feature but for backward compatibility, we should have it. Therefore, this patch adds new command "enableAbsolutePositionEditor". Note that whether resizing UI is available only with enableObjectResizing state is different from enableInlineTableEditing command. Resizers for absolute positioned elements are NOT available both enableObjectResizing and enableAbsolutePositionEditor are enabled. Additionally, this adds automated tests to check basic functions of absolute positioned editor. MozReview-Commit-ID: 9ZSGB8tLpFw
c224c4ec6ecb394eddd1a68791e5fffd8c117256: Bug 1449564 - part 1: Disable object resizer and inline table editor in default r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 02 Apr 2018 17:26:46 +0900 - rev 777692
Push 105264 by masayuki@d-toybox.com at Thu, 05 Apr 2018 05:23:22 +0000
Bug 1449564 - part 1: Disable object resizer and inline table editor in default r?m_kato Gecko supports resizers of <img> elements and <table>, <td>, <th> elements and has UI to remove existing table row or column in default. However, the other browsers don't have such UI and web apps need to disable this feature with calling both: document.execCommand("enableObjectResizing", false, false); document.execCommand("enableInlineTableEditing", false, false); for avoiding conflicting with their own features to edit such elements. Therefore, it doesn't make sense to keep enabling them in default only on Gecko. If web apps want to keep using these features, they should call: document.execCommand("enableObjectResizing", false, true); document.execCommand("enableInlineTableEditing", false, true); at initializing the editor. And also this patch fixes bugs of document.queryCommandState("enableObjectResizing") and document.queryCommandState("enableInlineTableEditing"). They always return false even after calling document.execCommand(..., false, true) since nsSetDocumentStateCommand::GetCommandStateParams() sets bool value as STATE_ATTRIBUTE. However, nsHTMLDocument::QueryCommandValue() which is the caller referring STATE_ATTRIBUTE doesn't treat it as bool value. And also those commands are related to state of document. Therefore, they should be return as bool value of STATE_ALL instead. Then, nsHTMLDocument::QueryCommandState() returns the state as expected. Note that those commands are supported only by Gecko. So, we don't need to worry about the compatibility. Finally, this patch rewrites 2 existing tests to check basic behavior of resizers and appearance of resizers. Note that this patch does not add new tests to test inline table editor since it's difficult to test the behavior with current API. Perhaps, we should add an API to nsIHTMLEditor to retrieve each anonymous elements in another bug since it requires to add wrapping API of SpecialPowers. MozReview-Commit-ID: 1FhYo5vcV60
cd6c768886cfcb8846cbb59a18c59444ffe9d48e: Bug 1440189 - Stop dispatching keypress event to the default event group in web content (only Nightly and early Beta) r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 23 Mar 2018 12:06:55 +0900 - rev 777691
Push 105264 by masayuki@d-toybox.com at Thu, 05 Apr 2018 05:23:22 +0000
Bug 1440189 - Stop dispatching keypress event to the default event group in web content (only Nightly and early Beta) r?smaug UI Events declares that keypress event should be fired only when the keydown sequence produces some characters. For conforming to UI Events and compatibility with the other browsers, we should stop dispatching keypress events for non-printable keys. For getting regression reports, we should enable this new behavior only on Nightly and early Beta.
81edc14eeb3dc932c668db44c3662b599ab200ca: Bug 1448763 part 9 - Remove nsCSSRect. r?emilio draft
Xidorn Quan <me@upsuper.org> - Thu, 05 Apr 2018 14:37:17 +1000 - rev 777690
Push 105263 by xquan@mozilla.com at Thu, 05 Apr 2018 05:22:06 +0000
Bug 1448763 part 9 - Remove nsCSSRect. r?emilio MozReview-Commit-ID: BOsjszpdKwt
fc6a807430dbe634ee9b8ef8feddb52ead16bffe: Bug 1448763 part 8 - Remove CSSCalc.h. r?emilio draft
Xidorn Quan <me@upsuper.org> - Thu, 05 Apr 2018 14:24:05 +1000 - rev 777689
Push 105263 by xquan@mozilla.com at Thu, 05 Apr 2018 05:22:06 +0000
Bug 1448763 part 8 - Remove CSSCalc.h. r?emilio MozReview-Commit-ID: eecZRhdxH8
d712c6ffa78cd213098fd2d11929f5fe9e118cad: Bug 1448763 part 7 - Remove nsCSSCornerSizes. r?emilio draft
Xidorn Quan <me@upsuper.org> - Thu, 05 Apr 2018 14:21:01 +1000 - rev 777688
Push 105263 by xquan@mozilla.com at Thu, 05 Apr 2018 05:22:06 +0000
Bug 1448763 part 7 - Remove nsCSSCornerSizes. r?emilio MozReview-Commit-ID: jjSjoskIB8
7448adaa3ca81a4644b92cf4f0f4d7e6dd973aed: Bug 1448763 part 6 - Remove nsCSSValueTriplet. r?emilio draft
Xidorn Quan <me@upsuper.org> - Thu, 05 Apr 2018 14:13:59 +1000 - rev 777687
Push 105263 by xquan@mozilla.com at Thu, 05 Apr 2018 05:22:06 +0000
Bug 1448763 part 6 - Remove nsCSSValueTriplet. r?emilio MozReview-Commit-ID: 29GtK1gtreU
5dc71ab2cdb639617b6e9b4160e922bd42d1f6ad: Bug 1448763 part 5 - Remove all color stuff from nsCSSValue. r?emilio draft
Xidorn Quan <me@upsuper.org> - Thu, 05 Apr 2018 14:12:40 +1000 - rev 777686
Push 105263 by xquan@mozilla.com at Thu, 05 Apr 2018 05:22:06 +0000
Bug 1448763 part 5 - Remove all color stuff from nsCSSValue. r?emilio MozReview-Commit-ID: DQX0HOr8R8
3828ab2228036b67dee6460f2d897afd2f188451: Bug 1448763 part 4 - Remove nsCSSValueGradient and its friends. r?emilio draft
Xidorn Quan <me@upsuper.org> - Thu, 05 Apr 2018 14:06:03 +1000 - rev 777685
Push 105263 by xquan@mozilla.com at Thu, 05 Apr 2018 05:22:06 +0000
Bug 1448763 part 4 - Remove nsCSSValueGradient and its friends. r?emilio MozReview-Commit-ID: JoYZyud2Wtu
485f40d2e8245ddafcececc08f0fc1a6eed0de79: Bug 1448763 part 3 - Remove nsCSSValueTokenStream. r?emilio draft
Xidorn Quan <me@upsuper.org> - Thu, 05 Apr 2018 13:44:28 +1000 - rev 777684
Push 105263 by xquan@mozilla.com at Thu, 05 Apr 2018 05:22:06 +0000
Bug 1448763 part 3 - Remove nsCSSValueTokenStream. r?emilio MozReview-Commit-ID: 79CPOfWbo7t
f36ec0a41b2c67834f87292eea0b9a05022c10c8: Bug 1448763 part 2 - Remove serialization code for specified value. r?emilio draft
Xidorn Quan <me@upsuper.org> - Thu, 05 Apr 2018 13:36:31 +1000 - rev 777683
Push 105263 by xquan@mozilla.com at Thu, 05 Apr 2018 05:22:06 +0000
Bug 1448763 part 2 - Remove serialization code for specified value. r?emilio MozReview-Commit-ID: 2DTGHb7GH4T
19ac679c06e453e22c7bd124a72768ba28ac6b94: Bug 1448763 part 1 - Make DOMIntersectionObserver use nsStyleSides for mRootMargin, and use Servo code to serialize it. r?emilio draft
Xidorn Quan <me@upsuper.org> - Thu, 05 Apr 2018 13:23:27 +1000 - rev 777682
Push 105263 by xquan@mozilla.com at Thu, 05 Apr 2018 05:22:06 +0000
Bug 1448763 part 1 - Make DOMIntersectionObserver use nsStyleSides for mRootMargin, and use Servo code to serialize it. r?emilio MozReview-Commit-ID: 8RsoLflRtzE
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip