49c0e922c3ffa997338aea278517b2806fcd7caa: Bug 1262937 - part 4 - publically inherit from MessageListener in IProtocol; r=jld
Nathan Froyd <froydnj@gmail.com> - Sat, 21 May 2016 04:07:56 -0400 - rev 369388
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1262937 - part 4 - publically inherit from MessageListener in IProtocol; r=jld IProtocolManager is templated over some listener type. In our IPDL code, that type is always IProtocol, which is a subclass of MessageListener. It's also important to note that IProtocol uses protected inheritance from MessageListener; the generated code takes advantage of this inheritance structure when it reads actors: // ChannelListener is typedef'd to MessageListener // Lookup here is IProtocolManager::Lookup ChannelListener* listener = Lookup(id); Lookup returns a pointer to the type over which IProtocolManager is templated. As mentioned above, that type is always IProtocol. But thanks to the containing class inheriting from *both* IProtocolManager and IProtocol, the returned pointer can be silently upcasted to MessageListener thanks to C++ visibility rules. It's not clear that this restricted inheritance structure is actually benefitting anybody, or that the inheritance hierarchy of protocol classes is the best way to do things. This particular implementation detail is getting in the way for the next improvement, so let's make the protected inheritance public instead.
89b98926c2fdd4fad17285c0cfc8029277c6b0b0: Bug 1262937 - part 3 - move quoting out of checkedRead; r=jld
Nathan Froyd <froydnj@gmail.com> - Sat, 21 May 2016 04:07:56 -0400 - rev 369387
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1262937 - part 3 - move quoting out of checkedRead; r=jld checkedRead is set up to single-quote whatever message is passed in. This scheme works great for all existing messages, but it makes some callsites a little surprising ("where's the matching quote?") and doesn't work well with message changes to be made in future patches. Let's move the quoting out to client code.
63a20cf3a66d8b845df443b1bfe1d1ce41b5821c: Bug 1262937 - part 2 - don't include the message name when complaining about handler failure; r=jld
Nathan Froyd <froydnj@gmail.com> - Sat, 21 May 2016 04:07:56 -0400 - rev 369386
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1262937 - part 2 - don't include the message name when complaining about handler failure; r=jld Similar to part 1, this change enables the strings passed to ProtocolErrorBreakpoint to be collapsed into a single string, saving ~60K of read-only data (!). This change does affect debuggability slightly, but given that ProtocolErrorBreakpoint only tries to throw the passed-in string to stderr, I don't think it's a huge deal.
7ad129583196b1f1b7b060f7a8caee3909ea18a1: Bug 1262937 - part 1 - don't include the protocol name in Clone error messages; r=jld
Nathan Froyd <froydnj@gmail.com> - Sat, 21 May 2016 04:07:56 -0400 - rev 369385
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1262937 - part 1 - don't include the protocol name in Clone error messages; r=jld We have better ways of getting the protocol name at the point of the error (e.g. backtraces). Removing it means the error message can be condensed to a single string by the compiler/linking, saving ~8k of read-only data.
4174c9e21a403c08491127884ab0bc0d8db819cd: Bug 1273405. Part 4 - add assertions. r=jya.
JW Wang <jwwang@mozilla.com> - Tue, 17 May 2016 17:32:55 +0800 - rev 369384
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1273405. Part 4 - add assertions. r=jya. MozReview-Commit-ID: 6tbA0aj5Rto
c123be7651413615bb9886d074c783f4227de06a: Bug 1273405. Part 3 - remove use of FlushableTaskQueue. r=jya.
JW Wang <jwwang@mozilla.com> - Tue, 17 May 2016 17:30:53 +0800 - rev 369383
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1273405. Part 3 - remove use of FlushableTaskQueue. r=jya. MozReview-Commit-ID: Do9REbjltEW
7be21b2402d1240667468d33f0dae4e226eda497: Bug 1273405. Part 2 - remove use of FlushableTaskQueue::Flush(). r=jya.
JW Wang <jwwang@mozilla.com> - Tue, 17 May 2016 17:22:45 +0800 - rev 369382
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1273405. Part 2 - remove use of FlushableTaskQueue::Flush(). r=jya. MozReview-Commit-ID: bchmGXw1fw
64e64f5a50357d60ed34f16f57ae8dcf90a75aa2: Bug 1273405. Part 1 - rename some functions to be consistent with other MediaDataDecoder sub-classes. r=jya.
JW Wang <jwwang@mozilla.com> - Tue, 17 May 2016 16:05:30 +0800 - rev 369381
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1273405. Part 1 - rename some functions to be consistent with other MediaDataDecoder sub-classes. r=jya. MozReview-Commit-ID: 1CpEZktGNia
53e791a65fa2be8a94fedb0a70d47cfa152ce2c8: bug 1272194 explicitly invalidate after change style contexts belonging to widgets r=stransky+263117
Karl Tomlinson <karlt+@karlt.net> - Tue, 17 May 2016 18:15:12 +1200 - rev 369380
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
bug 1272194 explicitly invalidate after change style contexts belonging to widgets r=stransky+263117 This fixes menu item rendering during hover. MozReview-Commit-ID: CEa6aorqBZM
764650604afd8277b6bd58cb2100c7aa52e5ccba: bug 1272194 use WidgetStyleCache for menus r=stransky+263117
Karl Tomlinson <karlt+@karlt.net> - Tue, 17 May 2016 18:24:55 +1200 - rev 369379
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
bug 1272194 use WidgetStyleCache for menus r=stransky+263117 Unnecessary widget realization is also removed. MozReview-Commit-ID: A5HuE5bqf4x
3909bcf5501b7ee54ba3252a6a32044d22ea4207: bug 1272194 only add menubar class to menu items with GTK 3.4 r=stransky+263117
Karl Tomlinson <karlt+@karlt.net> - Tue, 17 May 2016 18:02:00 +1200 - rev 369378
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
bug 1272194 only add menubar class to menu items with GTK 3.4 r=stransky+263117 and save/restore context consistent with GTK 3.4. MozReview-Commit-ID: GdMoAmzOJlf
5299d183263bcc5465ab76fa9de2c0c8ea7a1d49: bug 1272194 don't create a label for menu items r=stransky+263117
Karl Tomlinson <karlt+@karlt.net> - Tue, 17 May 2016 11:02:25 +1200 - rev 369377
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
bug 1272194 don't create a label for menu items r=stransky+263117 The label dates back to GTK2 code and is not currently used. Removing will allow sharing code with menubar item creation. MozReview-Commit-ID: LI5t4agot1z
169369e8ef8a9fb5eab92a9f94161f3d9d0ac128: bug 1272194 replace MOZ_TOPLEVEL_MENU_ITEM flag with MOZ_GTK_MENUBARITEM node r=stransky+263117
Karl Tomlinson <karlt+@karlt.net> - Thu, 19 May 2016 16:55:04 +1200 - rev 369376
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
bug 1272194 replace MOZ_TOPLEVEL_MENU_ITEM flag with MOZ_GTK_MENUBARITEM node r=stransky+263117 This provides a better mapping between WidgetNodeType and GtkWidgets. MozReview-Commit-ID: 3YYzK4aZCbP
ca3135fa04fc4df03bf91b1a88216729d16c9944: Bug 1002857 - stop disabling GL layers for 10.6.2 and below. r=mstange
Benoit Girard <b56girard@gmail.com> - Wed, 18 May 2016 18:10:04 -0400 - rev 369375
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1002857 - stop disabling GL layers for 10.6.2 and below. r=mstange MozReview-Commit-ID: ITqcQNdolQ
6471cf751c2dc966c1c6fa171f78fcd1fed6d711: Bug 1272490 nsHTMLEditRules::ReapplyCachedStyles() should do nothing if nsIEditor::GetSelection() returns nullptr r=Ehsan
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 17 May 2016 11:47:39 +0900 - rev 369374
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1272490 nsHTMLEditRules::ReapplyCachedStyles() should do nothing if nsIEditor::GetSelection() returns nullptr r=Ehsan nsHTMLEditRules::ReapplyCachedStyles() may be called after the document is removed from the DOM tree. For example, the document can be removed from the tree even during handling an edit operation if the web contents uses DOMMutationEvent. In such case, nsIEditor::GetSelection() returns nullptr and it should do nothing. MozReview-Commit-ID: Jk3eGalAPhB
13753a81970ad0e15d8bd921338219c975c02064: Bug 1274385: don't retry decision tasks; r=garndt
Dustin J. Mitchell <dustin@mozilla.com> - Thu, 19 May 2016 20:09:29 +0000 - rev 369373
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1274385: don't retry decision tasks; r=garndt MozReview-Commit-ID: IjnhKWgoxAG
87219f2b44e5617029b6ba0f1d59a6b9ec2843a7: Bug 1273673 followup follwup - fix string concatenation that broke precedence, r=dustin
Steve Fink <sfink@mozilla.com> - Thu, 19 May 2016 11:08:16 -0700 - rev 369372
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1273673 followup follwup - fix string concatenation that broke precedence, r=dustin
f0c0e9e19a08a2ca0fe51290d0a2b48db89e13da: Bug 1273639 - Fix nonunified spidermonkey builds, r=terrence
Steve Fink <sfink@mozilla.com> - Thu, 19 May 2016 11:27:57 -0700 - rev 369371
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1273639 - Fix nonunified spidermonkey builds, r=terrence
eb9f5c426a83a667d1d9a179b307ccaf4f553136: Bug 1273504 - Disable D3D11 for some nvwgf2um DLLs - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Fri, 20 May 2016 11:06:13 +1000 - rev 369370
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
Bug 1273504 - Disable D3D11 for some nvwgf2um DLLs - r=cpearce MozReview-Commit-ID: RqUOn8YZo
1b8f35a4774e8080d105bb22783648ad7544a5ec: bug 1273677 - ensure session cache is properly configured and torn down for TLSServerSocket r=mcmanus
David Keeler <dkeeler@mozilla.com> - Tue, 17 May 2016 15:17:33 -0700 - rev 369369
Push 18842 by cykesiopka.bmo@gmail.com at Mon, 23 May 2016 01:13:51 +0000
bug 1273677 - ensure session cache is properly configured and torn down for TLSServerSocket r=mcmanus MozReview-Commit-ID: 6i7HxTdLcID
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip