4994954bf6bb56ed164ebe873864edeb4572156a: Bug 1273706 - Part 11: Have StyleAnimationValue::UncomputeValue(..., nsCSSValue) uncompute UnparsedStrings to token stream nsCSSValues. draft
Jonathan Chan <jyc@eqv.io> - Mon, 15 Aug 2016 00:48:18 -0700 - rev 400599
Push 26211 by jchan@mozilla.com at Mon, 15 Aug 2016 08:07:32 +0000
Bug 1273706 - Part 11: Have StyleAnimationValue::UncomputeValue(..., nsCSSValue) uncompute UnparsedStrings to token stream nsCSSValues. UncomputeValue(..., nsAString) already uncomputes these to strings. A later patch in this series uses unparsed strings to represent non-interpolable but animatable custom properties that don't require additional context (URL values require a principal, and StyleAnimationValue provides a URL type). MozReview-Commit-ID: ERHLMPCfFVF
9e47e0dc1245e1062fbf1a834ed3173a662f4133: Bug 1273706 - Part 10: Expose StyleAnimationValue::StyleCoordToValue and StyleCoordToCSSValue. draft
Jonathan Chan <jyc@eqv.io> - Mon, 15 Aug 2016 00:48:18 -0700 - rev 400598
Push 26211 by jchan@mozilla.com at Mon, 15 Aug 2016 08:07:32 +0000
Bug 1273706 - Part 10: Expose StyleAnimationValue::StyleCoordToValue and StyleCoordToCSSValue. Currently these are used by StyleAnimationValue internally in ExtractComputedValue only. A later patch in this series will use them for converting nsStyleCoords to StyleAnimationValues and for converting nsStyleCoords to strings (by way of nsCSSValue::AppendToString). Also add support for eStyleUnit_Integer to StyleCoordToCSSValue, because we use nsStyleCoords to store <integer>s too. MozReview-Commit-ID: L1zTPOxq88Z
21b2cd5b5e0f05a77762e8545c5a7b4d3634ee2f: Bug 1273706 - Part 9: Expose nsComputedDOMStyle::SetValueToStyleImage as a static method so that we can compute serialized computed values for gradients. draft
Jonathan Chan <jyc@eqv.io> - Mon, 15 Aug 2016 00:48:18 -0700 - rev 400597
Push 26211 by jchan@mozilla.com at Mon, 15 Aug 2016 08:07:32 +0000
Bug 1273706 - Part 9: Expose nsComputedDOMStyle::SetValueToStyleImage as a static method so that we can compute serialized computed values for gradients. SetValueToStyleImage doesn't use any member variables in itself or in the methods it calls, but it used various functions that were also non-static. The reason they were non-static is because in the call chain is a function that takes a member function pointer, which requires an object pointer, SetValueToCoord. The member function pointer argument is nullptr by default and not used by any of the functions used by SetValueToStyleImage. SetValueToCoord is modified to take a class object pointer argument and calls are updated appropriately to pass either nullptr or this. This is a little unpleasant, but its a useful method that a later patch needs to use (CSSComputedValue::AppendToString). MozReview-Commit-ID: Kc6KrZK2Dn5
419101843f71c2ec152ef8d7df5693265f219aa1: Bug 1273706 - Part 8: Separate nsStyleImage from nsStyleStruct. r?heycam draft
Jonathan Chan <jyc@eqv.io> - Mon, 15 Aug 2016 00:48:18 -0700 - rev 400596
Push 26211 by jchan@mozilla.com at Mon, 15 Aug 2016 08:07:32 +0000
Bug 1273706 - Part 8: Separate nsStyleImage from nsStyleStruct. r?heycam Also expose EqualURIs as mozilla::EqualURIs, which is necessary to separate nsStyleImage, and which also allows us to remove nsCSSFrameConstructor's own copy of EqualURIs. This is so that CSSComputedValue, implemented by a future patch in this series, can contain nsStyleImages without causing a circular dependency (because CSSComputedValues are stored in a nsStyleStruct added by a different future patch). MozReview-Commit-ID: 5roQChonIs0
b0ee16a654296ca4b0aefb162ec8682ab2a8cf1f: Bug 1273706 - Part 7: Add support to StyleAnimationValues for storing lists of values. r?heycam draft
Jonathan Chan <jyc@eqv.io> - Mon, 15 Aug 2016 00:48:17 -0700 - rev 400595
Push 26211 by jchan@mozilla.com at Mon, 15 Aug 2016 08:07:32 +0000
Bug 1273706 - Part 7: Add support to StyleAnimationValues for storing lists of values. r?heycam The lists are homogeneous lists of style animation values. We also implement computing distances & interpolating between them. The lists are simple lists, not repeatable lists. [1] This is for support of custom properties with syntax like <number>+, which indicates a list of <number>s with length at least one. Currently the syntax only supports homogeneous non-empty list. [1]: https://github.com/w3c/css-houdini-drafts/issues/273 MozReview-Commit-ID: 6DHgXxwpgVl
6b4db8145ce8573168043360ed8454f9e19fdbfc: Bug 1273706 - Part 6: Add CSSProperty type for custom properties. r?heycam draft
Jonathan Chan <jyc@eqv.io> - Mon, 15 Aug 2016 00:48:17 -0700 - rev 400594
Push 26211 by jchan@mozilla.com at Mon, 15 Aug 2016 08:07:32 +0000
Bug 1273706 - Part 6: Add CSSProperty type for custom properties. r?heycam Add CSSProperty type to replace nsCSSPropertyID in places where we might want to represent custom properties. In particular, a later patch in this series will modify the animation code to use these where appropriate. A CSSProperty is a tagged union containing a nsCSSPropertyID or holding a reference to an nsIAtom corresponding to the custom property name, sans the leading --. MozReview-Commit-ID: 3bEXG3qCxHt
c6087ed10b3749457d64518489f7515289baea35: Bug 1273706 - Part 5: Factor out code for parsing resolutions in nsCSSParser. r?heycam draft
Jonathan Chan <jyc@eqv.io> - Mon, 15 Aug 2016 00:48:17 -0700 - rev 400593
Push 26211 by jchan@mozilla.com at Mon, 15 Aug 2016 08:07:32 +0000
Bug 1273706 - Part 5: Factor out code for parsing resolutions in nsCSSParser. r?heycam Move it into a new ParseResolution method on CSSParserImpl. This is used by a later patch in this series which parses custom property values. MozReview-Commit-ID: 9SCyuepbXJR
a691ff7008f73d99849a9234c1ac76d5e84b767a: Bug 1273706 - Part 4: Add new nsCSSValue units for resolutions. r?heycam draft
Jonathan Chan <jyc@eqv.io> - Mon, 15 Aug 2016 00:48:17 -0700 - rev 400592
Push 26211 by jchan@mozilla.com at Mon, 15 Aug 2016 08:07:32 +0000
Bug 1273706 - Part 4: Add new nsCSSValue units for resolutions. r?heycam Before, eCSSUnit_Inch, eCSSUnit_Pixel, and eCSSUnit_Centimeter were used for DotsPerInch, DotsPerpixel, and DotsPerCentimeter, respectively. Now custom properties can have type <resolution>, and it'd be nice to associate proper units with the resulting nsCSSValues. The next patch in this series edits nsCSSParser to parse resolutions using the new units. MozReview-Commit-ID: HRUh6gfqZCT
efb28e07f1e2a885260a70c4d3dbaabccfc1d8d5: Bug 1273706 - Part 3: Add new pref to enable the Properties & Values API. r?dholbert draft
Jonathan Chan <jyc@eqv.io> - Mon, 15 Aug 2016 00:48:17 -0700 - rev 400591
Push 26211 by jchan@mozilla.com at Mon, 15 Aug 2016 08:07:32 +0000
Bug 1273706 - Part 3: Add new pref to enable the Properties & Values API. r?dholbert This will control whether or not CSS.registerProperty and CSS.unregisterProperty are available. Behavior with existing CSS variables should be the same. MozReview-Commit-ID: DMGMQAX1Xd3
75bf9cb8af5f32c063ce41149a2ffed5c9d194a1: Bug 1273706 - Part 2: Add missing namespace names that the Windows build complained about. r?dholbert draft
Jonathan Chan <jyc@eqv.io> - Mon, 15 Aug 2016 00:48:17 -0700 - rev 400590
Push 26211 by jchan@mozilla.com at Mon, 15 Aug 2016 08:07:32 +0000
Bug 1273706 - Part 2: Add missing namespace names that the Windows build complained about. r?dholbert MozReview-Commit-ID: 4aaM9fUWTeT
4b66d8ee2132a655affc69f934113a0e3131ae53: Bug 1273706 - Part 1: Add missing includes exposed by unification. r?dholbert draft
Jonathan Chan <jyc@eqv.io> - Mon, 15 Aug 2016 00:48:17 -0700 - rev 400589
Push 26211 by jchan@mozilla.com at Mon, 15 Aug 2016 08:07:32 +0000
Bug 1273706 - Part 1: Add missing includes exposed by unification. r?dholbert MozReview-Commit-ID: FmvULy8Z4XB
294994839720c51cab47ae303b65ab4e05d256bd: Bug 1293743: Add support to ParseVariant for parsing integer calc()s. r?dholbert draft
Jonathan Chan <jyc@eqv.io> - Mon, 15 Aug 2016 00:48:17 -0700 - rev 400588
Push 26211 by jchan@mozilla.com at Mon, 15 Aug 2016 08:07:32 +0000
Bug 1293743: Add support to ParseVariant for parsing integer calc()s. r?dholbert ParseVariant now parses integer calc()s when given VARIANT_INTEGER | VARIANT_CALC. Integer calcs cannot contain any division and must contain only integers. We also move ReduceNumberCalcOps from nsCSSParser to CSSCalc. [1]: https://drafts.csswg.org/css-values-3/#funcdef-calc MozReview-Commit-ID: YYX3k7ONUi
43b8da9db6f560b2a631c99fab8c39b3d6dfde35: Bug 1293739 - Part 2: Rename nsCSSPropertySet to nsCSSPropertyIDSet. r?dholbert draft
Jonathan Chan <jyc@eqv.io> - Mon, 15 Aug 2016 00:48:16 -0700 - rev 400587
Push 26211 by jchan@mozilla.com at Mon, 15 Aug 2016 08:07:32 +0000
Bug 1293739 - Part 2: Rename nsCSSPropertySet to nsCSSPropertyIDSet. r?dholbert The previous patch in this series renamed nsCSSProperty to nsCSSPropertyID. This patch renames nsCSSPropertySet to nsCSSPropertyIDSet accordingly. This patch is generated by the following commands (note: if you're running using OS X's sed, which accepts slightly different flags, you'll have to specify an actual backup suffix in -i, or use gsed from Homebrew): hg stat -c \ | cut -c 3- \ | tr '\n' '\0' \ | xargs -0 -P 8 gsed 's/\bnsCSSPropertySet\b/nsCSSPropertyIDSet/g' -i'' Then: hg mv layout/style/nsCSSPropertySet.h layout/style/nsCSSPropertyIDSet.h ... and finally, manually renaming nsCSSPropertySet in the include guard in nsCSSPropertyIDSet.h. (Note: on my computer, this somehow mishandles two symlinked files, testing/mozharness/configs/single_locale/linux32.py and media/libav/README -- I removed the changes from the changeset manually as well). MozReview-Commit-ID: 6lnaFFzRSb2
16a98279db0a125b55dc3ca8fc51b8140a8d7324: Bug 1293739 - Part 1: Rename nsCSSProperty to nsCSSPropertyID. r?dholbert draft
Jonathan Chan <jyc@eqv.io> - Mon, 15 Aug 2016 00:48:16 -0700 - rev 400586
Push 26211 by jchan@mozilla.com at Mon, 15 Aug 2016 08:07:32 +0000
Bug 1293739 - Part 1: Rename nsCSSProperty to nsCSSPropertyID. r?dholbert This patch is generated by the following commands (note: if you're running using OS X's sed, which accepts slightly different flags, you'll have to specify an actual backup suffix in -i, or use gsed from Homebrew): hg stat -c \ | cut -c 3- \ | tr '\n' '\0' \ | xargs -0 -P 8 gsed 's/\bnsCSSProperty\b/nsCSSPropertyID/g' -i'' Then: hg mv layout/style/nsCSSProperty.h layout/style/nsCSSPropertyID.h ... and finally, manually renaming nsCSSProperty in the include guard in nsCSSProperty.h. (Note: on my computer, this somehow mishandles two symlinked files, testing/mozharness/configs/single_locale/linux32.py and media/libav/README -- I removed the changes from the changeset manually as well). MozReview-Commit-ID: ZV6jyvmLfA
cce74e52a01e00ef2d191bbaed5a8bedcf47e282: Bug 1269102 - Part 5: Cleanup browser_net_copy_as_curl.js, reenable for e10s r?ochameau draft
Jarda Snajdr <jsnajdr@gmail.com> - Wed, 10 Aug 2016 13:46:02 +0200 - rev 400585
Push 26210 by bmo:jsnajdr@gmail.com at Mon, 15 Aug 2016 08:03:56 +0000
Bug 1269102 - Part 5: Cleanup browser_net_copy_as_curl.js, reenable for e10s r?ochameau MozReview-Commit-ID: Ce9f8wr7CKQ
9967b94f9ba10592532346f44eea19e076e59f11: Bug 1269102 - Part 4: browser_net_pane-toggle.js: wait for async update after opening the details pane r?ochameau draft
Jarda Snajdr <jsnajdr@gmail.com> - Wed, 10 Aug 2016 14:17:16 +0200 - rev 400584
Push 26210 by bmo:jsnajdr@gmail.com at Mon, 15 Aug 2016 08:03:56 +0000
Bug 1269102 - Part 4: browser_net_pane-toggle.js: wait for async update after opening the details pane r?ochameau MozReview-Commit-ID: Hm9S2nzWMLl
affdd3f3c5014ffe3b9318ed6a021f4976a45376: Bug 1269102 - Part 3: Cleanup browser_net_pane-toggle.js test (task.js, eslint) r?ochameau draft
Jarda Snajdr <jsnajdr@gmail.com> - Wed, 10 Aug 2016 13:43:08 +0200 - rev 400583
Push 26210 by bmo:jsnajdr@gmail.com at Mon, 15 Aug 2016 08:03:56 +0000
Bug 1269102 - Part 3: Cleanup browser_net_pane-toggle.js test (task.js, eslint) r?ochameau MozReview-Commit-ID: JhrDwO312RJ
193f772e1fa81795dffd23de171cc8750ec27ced: Bug 1269102 - Part 2: Include shared-head.js in netmonitor/test/head.js, remove duplicate definitions r?ochameau draft
Jarda Snajdr <jsnajdr@gmail.com> - Wed, 10 Aug 2016 13:39:11 +0200 - rev 400582
Push 26210 by bmo:jsnajdr@gmail.com at Mon, 15 Aug 2016 08:03:56 +0000
Bug 1269102 - Part 2: Include shared-head.js in netmonitor/test/head.js, remove duplicate definitions r?ochameau MozReview-Commit-ID: E75cKigju9P
5e8d0655deccedc5c45b103c968f93b950135343: Bug 1269102 - Part 1: Move waitForClipboardPromise to shared-head.js r?ochameau draft
Jarda Snajdr <jsnajdr@gmail.com> - Wed, 10 Aug 2016 13:34:30 +0200 - rev 400581
Push 26210 by bmo:jsnajdr@gmail.com at Mon, 15 Aug 2016 08:03:56 +0000
Bug 1269102 - Part 1: Move waitForClipboardPromise to shared-head.js r?ochameau MozReview-Commit-ID: 3PmdEBNLaJq
514c7ed58609cfb3f6810fb5b80ef0c119ac4323: Bug 1294628 - Replace block reflow input flags with a bit fields struct. r?dholbert draft
Ting-Yu Lin <tlin@mozilla.com> - Fri, 12 Aug 2016 15:28:45 +0800 - rev 400580
Push 26209 by bmo:tlin@mozilla.com at Mon, 15 Aug 2016 07:59:05 +0000
Bug 1294628 - Replace block reflow input flags with a bit fields struct. r?dholbert MozReview-Commit-ID: 2ZSm9hTrsuh
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip