47874267eb4421c5da4284a603ae67fa9e5e54f3: Bug 1297082 - Part 2: Use curl.js utility functions in HAR builder r=Honza
Jarda Snajdr <jsnajdr@gmail.com> - Mon, 22 Aug 2016 16:22:14 +0200 - rev 406131
Push 27648 by bmo:manishearth@gmail.com at Fri, 26 Aug 2016 14:13:20 +0000
Bug 1297082 - Part 2: Use curl.js utility functions in HAR builder r=Honza MozReview-Commit-ID: HffHwyLhoO6
bf02a86c242d53ace80040d33d2876ba92a02f95: Bug 1297082 - Part 1: Convert Curl.jsm to a CommonJS module r=Honza
Jarda Snajdr <jsnajdr@gmail.com> - Thu, 18 Aug 2016 17:05:15 +0200 - rev 406130
Push 27648 by bmo:manishearth@gmail.com at Fri, 26 Aug 2016 14:13:20 +0000
Bug 1297082 - Part 1: Convert Curl.jsm to a CommonJS module r=Honza MozReview-Commit-ID: LI7Ra1w3RBj
a89334d982bdfa4a444830375f4f6591891c41d8: Bug 1290437 - Fix and land the console netlogging tests r=jsnajdr
Ricky Chien <ricky060709@gmail.com> - Wed, 17 Aug 2016 16:24:56 +0800 - rev 406129
Push 27648 by bmo:manishearth@gmail.com at Fri, 26 Aug 2016 14:13:20 +0000
Bug 1290437 - Fix and land the console netlogging tests r=jsnajdr MozReview-Commit-ID: 9HRfcfn8g6b
62b153717ab082dac1268a8da15b8a87a4c88843: Bug 1295639 - TwoLinePageRow: Use stripAboutReaderUrl() instead of getUrlFromAboutReader(). r=ahunt
Sebastian Kaspari <s.kaspari@gmail.com> - Wed, 24 Aug 2016 12:14:35 +0200 - rev 406128
Push 27648 by bmo:manishearth@gmail.com at Fri, 26 Aug 2016 14:13:20 +0000
Bug 1295639 - TwoLinePageRow: Use stripAboutReaderUrl() instead of getUrlFromAboutReader(). r=ahunt ReaderModeUtils.getUrlFromAboutReader() will return null if this is not a 100% valid reader mode URL. However ReaderMoteUtils.stripAboutReaderUrl() will return the original URL if the reader mode URL could not be "decoded". MozReview-Commit-ID: J07Gkyq07JK
179f3c125af2d0e4e32e76ae73be41bae2a2da1c: Bug 1296750 - Don't crash if multiple files have same timestamp in TelemetryJSONFilePingStore.deleteSmallestFiles r=Grisha
Andrzej Hunt <ahunt@mozilla.com> - Fri, 19 Aug 2016 14:18:43 -0700 - rev 406127
Push 27648 by bmo:manishearth@gmail.com at Fri, 26 Aug 2016 14:13:20 +0000
Bug 1296750 - Don't crash if multiple files have same timestamp in TelemetryJSONFilePingStore.deleteSmallestFiles r=Grisha Using a set is bad since it will silently ignore multiple files with the same timestamp, resulting in crashes when the set has fewer items than we expected. A list is probably the best choice in this instance. (Note: I am not familiar enough with this code to know whether or not this is an expected situation, i.e. whether or not timestamps should be unique.) MozReview-Commit-ID: 5TRNLgTsSHO
6c9ce18c54e727baaae3a140e919394f0c0ba78e: Bug 1292602 - Set notification client before launching Gecko to avoid crash on notification r=sebastian
Andrzej Hunt <ahunt@mozilla.com> - Fri, 19 Aug 2016 09:51:37 -0700 - rev 406126
Push 27648 by bmo:manishearth@gmail.com at Fri, 26 Aug 2016 14:13:20 +0000
Bug 1292602 - Set notification client before launching Gecko to avoid crash on notification r=sebastian Gecko could potentially send notifications via ShowAlertNotification (or any related method). It's possible for this to happen very soon after launching Gecko, so we need to set the GeckoAppShell's notificationClient before launching Gecko to ensure that it can handle notifications (this also avoids the associated crash - we could try to do null-checks instead, but that would result in dropped notifications, which doesn't seem useful). MozReview-Commit-ID: 5MG8bBnt12M
04efdec5c0cf8548e2382b48537fa6b37bcf7197: Bug 1292566 - The "open" button in the subview for uncommon and potentially unwanted downloads should not ask for confirmation. r=Paolo
Drew Willcoxon <adw@mozilla.com> - Wed, 24 Aug 2016 17:56:44 -0700 - rev 406125
Push 27648 by bmo:manishearth@gmail.com at Fri, 26 Aug 2016 14:13:20 +0000
Bug 1292566 - The "open" button in the subview for uncommon and potentially unwanted downloads should not ask for confirmation. r=Paolo MozReview-Commit-ID: AVDyaQSbriX
18ae102fbf67c2be43b3b2b15b56e90821ef11fd: Bug 1258960 - use getters in marionette accessibility states structure to avoid Ci.nsIAccessibleStates undefined errors in builds with accessibility disabled. r=whimboo
Yura Zenevich <yzenevich@mozilla.com> - Wed, 24 Aug 2016 15:52:20 -0400 - rev 406124
Push 27648 by bmo:manishearth@gmail.com at Fri, 26 Aug 2016 14:13:20 +0000
Bug 1258960 - use getters in marionette accessibility states structure to avoid Ci.nsIAccessibleStates undefined errors in builds with accessibility disabled. r=whimboo MozReview-Commit-ID: 2SMM5AS0cVr
d931c9b5ab72bc69dfc76ce04d3b0974ac155ba7: Bug 1295630 - Allow a/v syncing to be ruined when running talos r=jmaher
William Lachance <wlachance@mozilla.com> - Wed, 24 Aug 2016 15:59:50 -0400 - rev 406123
Push 27648 by bmo:manishearth@gmail.com at Fri, 26 Aug 2016 14:13:20 +0000
Bug 1295630 - Allow a/v syncing to be ruined when running talos r=jmaher This prevents talos from measuring "infinite" values. MozReview-Commit-ID: 8rO476SCGyR
91b6e270107a96d5c5c6045b76c59c3aafe18a90: Bug 1295695 - Add maybe_pod_* methods to InfallibleAllocPolicy. r=glandium
Andrew McCreight <continuation@gmail.com> - Tue, 16 Aug 2016 11:09:05 -0700 - rev 406122
Push 27648 by bmo:manishearth@gmail.com at Fri, 26 Aug 2016 14:13:20 +0000
Bug 1295695 - Add maybe_pod_* methods to InfallibleAllocPolicy. r=glandium Bug 1207519 added maybe_pod_* methods to the allocation policy classes, but did not add them to InfallibleAllocPolicy. I think the idea of these methods is that the callers are explicitly opting into fallible behavior, so they will deal with any errors that occur. For instance, in js::HashTable, this is used to try to shrink the hash table when there are a lot of unused entries. If the shrink fails, it just continues to use the existing block of memory. However, having fallible methods in a supposedly infallible class is weird, so for now, just use the infallible version. MozReview-Commit-ID: 97D66Z4oLfl
79769d046c43ce0e1a3e30e4df2daff215e388c9: Bug 1290614, part 7 - Further refactor XPCNativeSetKey::Hash. r=mrbkap
Andrew McCreight <continuation@gmail.com> - Sun, 31 Jul 2016 14:19:31 -0700 - rev 406121
Push 27648 by bmo:manishearth@gmail.com at Fri, 26 Aug 2016 14:13:20 +0000
Bug 1290614, part 7 - Further refactor XPCNativeSetKey::Hash. r=mrbkap Now we can see what is really happening in Hash: first hash the interfaces from the base set, if any, then hash the additional interface, if any. Note that this function is wrong when mBaseSet is null. This will be fixed in bug 1290239. MozReview-Commit-ID: KaxQ57ofO1D
7433a7c06701aa157a47b38ca560715b25746d82: Bug 1290614, part 6 - Hoist out the common loop over all interfaces in XPCNativeSetKey::Hash(). r=mrbkap
Andrew McCreight <continuation@gmail.com> - Sun, 31 Jul 2016 14:16:52 -0700 - rev 406120
Push 27648 by bmo:manishearth@gmail.com at Fri, 26 Aug 2016 14:13:20 +0000
Bug 1290614, part 6 - Hoist out the common loop over all interfaces in XPCNativeSetKey::Hash(). r=mrbkap Both cases first hash together all of the existing interfaces. MozReview-Commit-ID: AnUF5uPSPpN
12e085578d94790bd6c1847e37ba7e659be2a59f: Bug 1290614, part 5 - Split out the last iteration of the XPCNativeSetKey loops. r=mrbkap
Andrew McCreight <continuation@gmail.com> - Sun, 31 Jul 2016 14:11:01 -0700 - rev 406119
Push 27648 by bmo:manishearth@gmail.com at Fri, 26 Aug 2016 14:13:20 +0000
Bug 1290614, part 5 - Split out the last iteration of the XPCNativeSetKey loops. r=mrbkap Now I take advantage of knowing that any new interface is always being added to the end of the set. Further cleanup of Hash() will happen in the next patch. MozReview-Commit-ID: EoESTOfIOr
3c8bce6d54b73c01c5204a32fc1f84afe00215c8: Bug 1290614, part 4 - Stop storing mPosition in XPCNativeSetKey. r=mrbkap
Andrew McCreight <continuation@gmail.com> - Sun, 31 Jul 2016 13:50:11 -0700 - rev 406118
Push 27648 by bmo:manishearth@gmail.com at Fri, 26 Aug 2016 14:13:20 +0000
Bug 1290614, part 4 - Stop storing mPosition in XPCNativeSetKey. r=mrbkap There are three cases for a key, represented by the three ctors: 1. mBaseSet is non-null, mAddition is null. 2. mBaseSet is null, mAddition is non-null. 3. Both mBaseSet and mAddition are non-null. In the three places that use the value of mPosition, condition 3 holds, so the key must have been constructed using the third ctor. For this ctor, mPosition is equal to mBaseSet->GetInterfaceCount(), so I substitute the value and eliminate the field. This makes a check in NewInstanceMutate() trivially false, so I eliminated that, too. MozReview-Commit-ID: 1SOF6GyccU7
ff0feedf164c1dfa004bddde890521570de94bc8: Bug 1290614, part 3 - The last argument to the third XPCNativeSetKey ctor is always the interface count. r=mrbkap
Andrew McCreight <continuation@gmail.com> - Sun, 31 Jul 2016 13:36:39 -0700 - rev 406117
Push 27648 by bmo:manishearth@gmail.com at Fri, 26 Aug 2016 14:13:20 +0000
Bug 1290614, part 3 - The last argument to the third XPCNativeSetKey ctor is always the interface count. r=mrbkap The mPosition field will be eliminated in a later patch. MozReview-Commit-ID: EyVYZGgUWrH
40e671c1ac3b763ae2785837f72fac2ea0d2e3dc: Bug 1290614, part 2 - Split XPCNativeSetKey into three constructors. r=mrbkap
Andrew McCreight <continuation@gmail.com> - Sun, 31 Jul 2016 13:25:05 -0700 - rev 406116
Push 27648 by bmo:manishearth@gmail.com at Fri, 26 Aug 2016 14:13:20 +0000
Bug 1290614, part 2 - Split XPCNativeSetKey into three constructors. r=mrbkap This explicitly represents the three types of keys that are used: 1. A key for an existing set. 2. A key for a new set with one interface added. 3. A key for an existing set with one new interface added at a specified position. MozReview-Commit-ID: Ctw41EymHbd
36fb54f13084730229c21e103883e4c0ee3fe8f9: Bug 1290614, part 1 - Pass around XPCNativeSetKeys to better encapsulate argument invariants. r=mrbkap
Andrew McCreight <continuation@gmail.com> - Sun, 31 Jul 2016 13:00:02 -0700 - rev 406115
Push 27648 by bmo:manishearth@gmail.com at Fri, 26 Aug 2016 14:13:20 +0000
Bug 1290614, part 1 - Pass around XPCNativeSetKeys to better encapsulate argument invariants. r=mrbkap XPCNativeSet::GetNewOrUsed() and ::NewInstanceMutate() essentially take XPCNativeSetKeys as arguments, but pass them around unboxed. Passing around the keys explicitly will allow later changes to enforce stronger invariants on keys. MozReview-Commit-ID: CyQU3bUGinq
59d5faa2dec5f3ef7eddc06e1b2f7c07e0e14ec4: Bug 1296354 - Use actual content hash to compare fiels if ETags are different. r=nthomas a=release DONTBUILD draft
Rail Aliiev <rail@mozilla.com> - Fri, 26 Aug 2016 10:06:21 -0400 - rev 406114
Push 27647 by bmo:rail@mozilla.com at Fri, 26 Aug 2016 14:06:49 +0000
Bug 1296354 - Use actual content hash to compare fiels if ETags are different. r=nthomas a=release DONTBUILD MozReview-Commit-ID: vovlfndXrK
ac16b2ccd7a11e81b8d2fcb84146c6460a188256: Bug 1294351 - Move restoring the canvas clip stack to its own method and early return form EnsureTarget. r=Bas
Nicolas Silva <nsilva@mozilla.com> - Fri, 26 Aug 2016 14:31:58 +0200 - rev 406113
Push 27647 by bmo:rail@mozilla.com at Fri, 26 Aug 2016 14:06:49 +0000
Bug 1294351 - Move restoring the canvas clip stack to its own method and early return form EnsureTarget. r=Bas
bc5a4525f6c291dc0482c750a8addeabdb543ca6: Bug 1297659 - Indentation fix in nsHTMLEntities.cpp. r=hsivonen
Nicolas Silva <nsilva@mozilla.com> - Fri, 26 Aug 2016 14:31:34 +0200 - rev 406112
Push 27647 by bmo:rail@mozilla.com at Fri, 26 Aug 2016 14:06:49 +0000
Bug 1297659 - Indentation fix in nsHTMLEntities.cpp. r=hsivonen
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip