44694696c309a4c7c92e9609d46c66995224fbb2: Bug 1402170 - Consistently use KeyframeEffect constructor for testing in processing-a-keyframes-argument.html; r?hiro draft
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 11:03:35 +0900 - rev 673218
Push 82504 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:09:17 +0000
Bug 1402170 - Consistently use KeyframeEffect constructor for testing in processing-a-keyframes-argument.html; r?hiro KeyframeEffectReadOnly may disappear (see [1]) and is only needed for CSS Animations and CSS Transitions so in that sense KeyframeEffect is more basic (despite being a subclass of KeyframeEffectReadOnly) so we should prefer it to KeyframeEffectReadOnly. Furthermore, as the comment at the start of the file suggests, we should consistently use the same method for testing these procedures. We currently use the KeyframeEffect constructor because it is more direct and basic. [1] https://github.com/w3c/web-animations/issues/185 MozReview-Commit-ID: LBrlfzyn2Ch
60d44017026e80d58bcccd3d6843dcaa03bed7ae: Bug 1402170 - Fix title in processing-a-keyframes-argument.html test; r?hiro draft
Brian Birtles <birtles@gmail.com> - Fri, 22 Sep 2017 10:18:25 +0900 - rev 673217
Push 82504 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:09:17 +0000
Bug 1402170 - Fix title in processing-a-keyframes-argument.html test; r?hiro And also drop the slightly misleading and redundant comment about the procedure that this test covers (it covers *both* the "process a keyframes argument" procedure and the "process a keyframe-like object" subprocedure). MozReview-Commit-ID: 9lzx4rCj20o
6c87ba016d1685ab32abec2dc993b279ad56f997: Bug 1402547 - Add crashtest for multiple empty SMIL values; r?hiro draft
Brian Birtles <birtles@gmail.com> - Mon, 02 Oct 2017 14:04:24 +0900 - rev 673216
Push 82503 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:05:15 +0000
Bug 1402547 - Add crashtest for multiple empty SMIL values; r?hiro I have verified that this fails without the code changes from the previous patch in this series, and passes with them. MozReview-Commit-ID: 1respvNVQaC
718a5bd90452b7b5df7567aecfa305c3f90286b9: Bug 1402547 - Handle addition/interpolate of nsSMILCSSValueType objects when both objects are empty; r?hiro draft
Brian Birtles <birtles@gmail.com> - Mon, 02 Oct 2017 14:03:53 +0900 - rev 673215
Push 82503 by bmo:bbirtles@mozilla.com at Mon, 02 Oct 2017 05:05:15 +0000
Bug 1402547 - Handle addition/interpolate of nsSMILCSSValueType objects when both objects are empty; r?hiro In some rare cases we can end up with both arguments passed to nsSMILCSSValueType::SandwichAdd being "empty", that is, having the type nsSMILCSSValueType but a null pointer. This can happen, for example, when we have a two by-animations and linear interpolation causing us to pass the "empty" from-value up as the underlying value from the first by-animation to the second by-animation (which it will try to add with its empty from-value). In this case the result of adding "empty" to "empty" should just be "empty" which we achieve by just doing an early return (since the fallback behavior for failed addition is to just use the second argument as the result; note that if we return true though the result would also be the same). We don't currently have a test case that produces this for interpolate but it makes sense that trying to interpolate "empty" to "empty" should likewise fail and just produce "empty". In this case failing will make us fall back to discrete animation and just use the "empty" values as-is. Indicating failure, however, has the additional effect of making us use the special keyTimes behavior defined for discrete animation. MozReview-Commit-ID: IZ5qg0Mk5Uy
a57f562476480caf0167d6d14c5f1a59ad698682: Bug 1400796 - Add 'ia' to the Firefox Nightly builds r?delphine draft
Francesco Lodolo (:flod) <flod@lodolo.net> - Mon, 02 Oct 2017 06:54:43 +0200 - rev 673214
Push 82502 by bmo:francesco.lodolo@gmail.com at Mon, 02 Oct 2017 04:55:44 +0000
Bug 1400796 - Add 'ia' to the Firefox Nightly builds r?delphine MozReview-Commit-ID: F1h78ESHchf
78a6563dc999794d919c4d28fdfce502ee40eb01: Bug 1400115 - Part 3: Add test. r?gl,pbro draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Mon, 02 Oct 2017 13:54:51 +0900 - rev 673213
Push 82501 by bmo:dakatsuka@mozilla.com at Mon, 02 Oct 2017 04:55:19 +0000
Bug 1400115 - Part 3: Add test. r?gl,pbro MozReview-Commit-ID: LIpkVybR8GA
44c200d1208cffe21808b9ddd3300e8965202887: Bug 1400115 - Part 3: Add test. r?gl,pbro draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Mon, 02 Oct 2017 13:32:53 +0900 - rev 673212
Push 82500 by bmo:dakatsuka@mozilla.com at Mon, 02 Oct 2017 04:49:29 +0000
Bug 1400115 - Part 3: Add test. r?gl,pbro MozReview-Commit-ID: LIpkVybR8GA
b65a8b8309318a8880004f0f279f3d7476a0b4c7: Bug 1400115 - Part 2: Introduce a pref to implement the new Animation panel behind. r?pbro,gl draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Mon, 02 Oct 2017 13:22:53 +0900 - rev 673211
Push 82500 by bmo:dakatsuka@mozilla.com at Mon, 02 Oct 2017 04:49:29 +0000
Bug 1400115 - Part 2: Introduce a pref to implement the new Animation panel behind. r?pbro,gl MozReview-Commit-ID: LgEW8w1CyhU
f3ecac0d10a55b351f5713045fd5a602683d78f3: Bug 1400115 - Part 1: Create a base pane. r?gl draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Mon, 02 Oct 2017 11:09:03 +0900 - rev 673210
Push 82500 by bmo:dakatsuka@mozilla.com at Mon, 02 Oct 2017 04:49:29 +0000
Bug 1400115 - Part 1: Create a base pane. r?gl MozReview-Commit-ID: Af3lI8gO3sl
6d8d99dc748ac44e3b73ce5db4d628f2af249ead: Bug 1400798 - [ia] Search engine setup for Firefox for Interlingua r?delphine draft
Francesco Lodolo (:flod) <flod@lodolo.net> - Mon, 02 Oct 2017 06:38:54 +0200 - rev 673209
Push 82499 by bmo:francesco.lodolo@gmail.com at Mon, 02 Oct 2017 04:43:33 +0000
Bug 1400798 - [ia] Search engine setup for Firefox for Interlingua r?delphine MozReview-Commit-ID: 4Stpr12otgs
e10f6cc3d996195a60cdbf6909915e54e7c92a01: Bug 1400798 - [ia] Search engine setup for Firefox for Interlingua r?delphine draft
Francesco Lodolo (:flod) <flod@lodolo.net> - Mon, 02 Oct 2017 06:38:54 +0200 - rev 673208
Push 82498 by bmo:francesco.lodolo@gmail.com at Mon, 02 Oct 2017 04:39:51 +0000
Bug 1400798 - [ia] Search engine setup for Firefox for Interlingua r?delphine MozReview-Commit-ID: 4Stpr12otgs
aee2cd20aa447bf9650f3c4a44e3ebeea214a8fc: Bug 1401474 - [Form Autofill] Don't store computed fields on tombstones coming from sync. r=steveck draft
Luke Chang <lchang@mozilla.com> - Mon, 02 Oct 2017 12:18:04 +0800 - rev 673207
Push 82497 by bmo:lchang@mozilla.com at Mon, 02 Oct 2017 04:19:04 +0000
Bug 1401474 - [Form Autofill] Don't store computed fields on tombstones coming from sync. r=steveck MozReview-Commit-ID: 6KIgFnV8QFv
c5997215a7c2bb6d4753127177dd5eb7605f6378: style: Use a SharedFontlist object to store font-family values for Gecko. r?Manishearth draft
Cameron McCormack <cam@mcc.id.au> - Fri, 29 Sep 2017 17:43:22 +0800 - rev 673206
Push 82496 by bmo:cam@mcc.id.au at Mon, 02 Oct 2017 03:59:43 +0000
style: Use a SharedFontlist object to store font-family values for Gecko. r?Manishearth MozReview-Commit-ID: 8JZndKwMJHW
6f23811a4cd192ffd14659cfe71139f1c26ee85a: Bug 1397626 - Part 3: Use SharedFontlist to store font-family specified and computed values. r?xidorn draft
Cameron McCormack <cam@mcc.id.au> - Mon, 02 Oct 2017 11:23:01 +0800 - rev 673205
Push 82496 by bmo:cam@mcc.id.au at Mon, 02 Oct 2017 03:59:43 +0000
Bug 1397626 - Part 3: Use SharedFontlist to store font-family specified and computed values. r?xidorn MozReview-Commit-ID: J3MNO2un2ov
dc1ce7c9faa34306e78eb81f4971428144a87247: Bug 1397626 - Part 2: Replace uses of FontFamilyListRefCnt with SharedFontlist. r?xidorn draft
Cameron McCormack <cam@mcc.id.au> - Mon, 02 Oct 2017 10:24:25 +0800 - rev 673204
Push 82496 by bmo:cam@mcc.id.au at Mon, 02 Oct 2017 03:59:43 +0000
Bug 1397626 - Part 2: Replace uses of FontFamilyListRefCnt with SharedFontlist. r?xidorn MozReview-Commit-ID: 7HoBae9UOks
3e2363f1120dcd9af422b87265327006cb471583: Bug 1397626 - Part 1: Add a SharedFontFamilyList class. r?xidorn draft
Cameron McCormack <cam@mcc.id.au> - Mon, 02 Oct 2017 10:21:20 +0800 - rev 673203
Push 82496 by bmo:cam@mcc.id.au at Mon, 02 Oct 2017 03:59:43 +0000
Bug 1397626 - Part 1: Add a SharedFontFamilyList class. r?xidorn MozReview-Commit-ID: 9mx8HTc2CCO
1d9f89de86dded0a53791e7dea7e4d1ffdff1c6f: Bug 1404243 Part 4 - Change StyleShapeSource's URL value storage by using nsStyleImage. draft
Ting-Yu Lin <tlin@mozilla.com> - Fri, 29 Sep 2017 16:24:23 +0800 - rev 673202
Push 82495 by bmo:tlin@mozilla.com at Mon, 02 Oct 2017 03:57:39 +0000
Bug 1404243 Part 4 - Change StyleShapeSource's URL value storage by using nsStyleImage. This is for implementing shape-outside: <image> later. MozReview-Commit-ID: 93TmLecRjRx
070e993fd42511de5a3ca7b72bc3b07177382a66: Bug 1404243 Part 3 - Remove refcount for StyleBasicShape, and use UniquePtr to hold it. draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 25 Sep 2017 18:50:24 +0800 - rev 673201
Push 82495 by bmo:tlin@mozilla.com at Mon, 02 Oct 2017 03:57:39 +0000
Bug 1404243 Part 3 - Remove refcount for StyleBasicShape, and use UniquePtr to hold it. After StyleBasicShape is set to StyleShapeSource, it's life cycle never go beyond StyleShapeSource, so I make StyleBasicShape hold by a UniquePtr in StyleShapeSource. Also, replace all raw pointers to StyleBasicShape by UniquePtr in all APIs. MozReview-Commit-ID: 1MfIFjP8TsQ
ef39ecaf85dbc849f8c338b335f3cd43b2e842e2: Bug 1404243 Part 2 - Change StyleShapeSource::operator==() to use logic in DefinitelyEquals(). draft
Ting-Yu Lin <tlin@mozilla.com> - Fri, 29 Sep 2017 14:36:35 +0800 - rev 673200
Push 82495 by bmo:tlin@mozilla.com at Mon, 02 Oct 2017 03:57:39 +0000
Bug 1404243 Part 2 - Change StyleShapeSource::operator==() to use logic in DefinitelyEquals(). The original operator==() (implemented by EqualsInternal<true>) is not been used. Therefore, I expand EqualsInternal<false> into it, and move it to nsStyleStruct.cpp. Also, use DefinitelyEqualURIs() in nsStyleStruct.cpp in operator==(). MozReview-Commit-ID: HccwKvzQHR
9f49ba69e091c97ce64502032fd7c3960c22df9e: Bug 1404243 Part 1 - Move StyleShapeSource's large methods to nsStyleStruct.cpp. draft
Ting-Yu Lin <tlin@mozilla.com> - Wed, 27 Sep 2017 11:32:38 +0800 - rev 673199
Push 82495 by bmo:tlin@mozilla.com at Mon, 02 Oct 2017 03:57:39 +0000
Bug 1404243 Part 1 - Move StyleShapeSource's large methods to nsStyleStruct.cpp. MozReview-Commit-ID: 5X5LGCSzSwX
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip