423c7b57355d659e1a5bd96dac35060cae38801c: Bug 1286464 part.12 ContentEventHandler::GetFirstFrameHavingFlatTextInRange() should return only frames whose content causes text r=smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 21 Jul 2016 17:45:17 +0900 - rev 400168
Push 26081 by masayuki@d-toybox.com at Fri, 12 Aug 2016 17:11:29 +0000
Bug 1286464 part.12 ContentEventHandler::GetFirstFrameHavingFlatTextInRange() should return only frames whose content causes text r=smaug If it returns frames which don't cause text, the caller needs complicated loop. So, it should return only frames which causes some text. MozReview-Commit-ID: 9gny0w1PUMa
97653f1ed04a6a03373cd53613d92aba45fbe38b: Bug 1286464 part.11 nsTextFrame::GetCharacterRectsInRange() shouldn't compute character rect at the first character in next nsTextFrame r=jfkthame draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 21 Jul 2016 16:24:37 +0900 - rev 400167
Push 26081 by masayuki@d-toybox.com at Fri, 12 Aug 2016 17:11:29 +0000
Bug 1286464 part.11 nsTextFrame::GetCharacterRectsInRange() shouldn't compute character rect at the first character in next nsTextFrame r=jfkthame nsTextFrame::GetCharacterRectsInRange() handles a character at the end offset of its content as in it. However, it causes odd result when the caller wants first text rect in the next nsTextFrame. E.g., if end of query range is at the next nsTextFrame's first character, currently, it returns the last character as in same line. So, it should stop handling next frame's first character as in it. MozReview-Commit-ID: 7WteerisrZp
dca28a6e4661eef3c8a102916c451e0f021bf6d5: Bug 1286464 part.10 ContentEventHandler::OnQueryTextRectArray() should append same rects for following characters of a line breaker in nsTextFrame r=smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 05 Aug 2016 14:06:30 +0900 - rev 400166
Push 26081 by masayuki@d-toybox.com at Fri, 12 Aug 2016 17:11:29 +0000
Bug 1286464 part.10 ContentEventHandler::OnQueryTextRectArray() should append same rects for following characters of a line breaker in nsTextFrame r=smaug If line breakers in a text node works as is, e.g., |white-space: pre;| is specified, we need to handle line breakers in text frames too. This patch handles "\n" in text nodes same as line breakers caused by some elements. MozReview-Commit-ID: JmXesusFxzR
3afaca4d6e9f09e2054c4a6bd876635cfef6c58c: Bug 1286464 part.9 ContentEventHandler::OnQueryTextRectArray() shouldn't append same rect for following character of a lien breaker when the query range starts from middle of the line breaker r=smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 05 Aug 2016 13:53:08 +0900 - rev 400165
Push 26081 by masayuki@d-toybox.com at Fri, 12 Aug 2016 17:11:29 +0000
Bug 1286464 part.9 ContentEventHandler::OnQueryTextRectArray() shouldn't append same rect for following character of a lien breaker when the query range starts from middle of the line breaker r=smaug If the query range starts middle of a line breaker, i.e., "\r[\n", ContentEventHandler::OnQueryTextRectArray() does not need to (in other words, should not) append same rect anymore. This patch checks if the range starts middle of a line breaker and in such case, skip to append same rect. MozReview-Commit-ID: H5gdtAakGcP
3117d68f056dc69550a16f52adade82049ba8277: Bug 1286464 part.8 ContentEventHandler::OnQueryTextRectArray() should handle line break before a node r=smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 05 Aug 2016 13:36:22 +0900 - rev 400164
Push 26081 by masayuki@d-toybox.com at Fri, 12 Aug 2016 17:11:29 +0000
Bug 1286464 part.8 ContentEventHandler::OnQueryTextRectArray() should handle line break before a node r=smaug Some elements causes a line break before itself. In such case, OnQueryTextRectArray() should append one or two rects for such line breakers. This patch also implements GetLineBreakerRectBefore(). It computes line breaker rect for the given frame. Even if it's a <br> frame, we cannot use its rect because <br> frame height is computed with line height but we need text's height (i.e., font height) and both height and width are 0 if it's in quirks mode and in non-empty line. Therefore, this patch computes it with frame's baseline, font's max-ascent and max-descent. Although, this patch computes a line breaker rect caused by a open tag of a block level element with block frame's rect. However, it shouldn't be used actually as far as possible. Following patches will kill the path to the hack. MozReview-Commit-ID: 9cym04j9NH9
aef43e028fdf19b1e4977ce0d73e3fd700793ba9: Bug 1286464 part.7 ContentEventHandler::OnQueryTextRect() should redirect the query event to OnQueryCaretRect() if its query range is empty r=smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 25 Jul 2016 23:19:53 +0900 - rev 400163
Push 26081 by masayuki@d-toybox.com at Fri, 12 Aug 2016 17:11:29 +0000
Bug 1286464 part.7 ContentEventHandler::OnQueryTextRect() should redirect the query event to OnQueryCaretRect() if its query range is empty r=smaug When eQueryTextRect's query range length is 0 (this may be caused by native IME's bug), it should return caret rect. Therefore, it should redirect such query events to OnQueryCaretRect(). Such IME must want caret rect in such case. MozReview-Commit-ID: JaUwhw1Cn5G
31f2ec578eeb2af82b8af2d938448eb42afd50ea: Bug 1286464 part.6 ContentEventHandler::OnQueryCaretRect() should use eQueryTextRect event when it needs to guess the caret rect r=smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 29 Jul 2016 00:37:09 +0900 - rev 400162
Push 26081 by masayuki@d-toybox.com at Fri, 12 Aug 2016 17:11:29 +0000
Bug 1286464 part.6 ContentEventHandler::OnQueryCaretRect() should use eQueryTextRect event when it needs to guess the caret rect r=smaug ContentEventHandler::OnQueryTextRect() is now too complicated. So, we shouldn't duplicate similar code in OnQueryCaretRect(). When it needs to guess a caret rect from a character rect, we shouldn't compute character rect by itself. MozReview-Commit-ID: 5G4MzQJzmoV
98021e68cd0150149e6417c5a8f91979f5baad76: Bug 1286464 part.5 Create ContentEventHandler::EnsureNonEmptyRect() for query various rect event handlers r=smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 05 Aug 2016 13:01:17 +0900 - rev 400161
Push 26081 by masayuki@d-toybox.com at Fri, 12 Aug 2016 17:11:29 +0000
Bug 1286464 part.5 Create ContentEventHandler::EnsureNonEmptyRect() for query various rect event handlers r=smaug This can kill the duplicated code in a lot of places in ContentEventHandler. MozReview-Commit-ID: BRpBkbXyeBs
b7933554c2a5bf51b8faabe3a96d006971510e0a: Bug 1286464 part.4 ContentEventHandler::SetRangeFromFlatTextOffset() should set end of the range to after a line break when the range is end between a set of native line breakers r=smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 28 Jul 2016 17:23:47 +0900 - rev 400160
Push 26081 by masayuki@d-toybox.com at Fri, 12 Aug 2016 17:11:29 +0000
Bug 1286464 part.4 ContentEventHandler::SetRangeFromFlatTextOffset() should set end of the range to after a line break when the range is end between a set of native line breakers r=smaug Currently, ContentEventHandler::SetRangeFromFlatTextOffset() sets end point to before a line breaker when the end of queried range is between a set of native line breakers (i.e., "\r]\n" on Windows). This causes unexpected empty range (e.g., "[]\n") when it queries a text rect at [\r]\n. Therefore, it should select an XP line breaker in such case (i.e., the range should be "[\n]" when it queries "[\r]\n" or "\r[\n]"). Note that we don't need to do anything at setting selection start because it's always aligned to before the line breaker. MozReview-Commit-ID: 6ht8QNAhibY
635cec95ee9f3d73f619186925464ae17010e929: Bug 1286464 part.3 Make static methods, AdjustTextRectNode() and GetFirstFrameInRange(), members of ContentEventHandler r=smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 05 Aug 2016 12:43:40 +0900 - rev 400159
Push 26081 by masayuki@d-toybox.com at Fri, 12 Aug 2016 17:11:29 +0000
Bug 1286464 part.3 Make static methods, AdjustTextRectNode() and GetFirstFrameInRange(), members of ContentEventHandler r=smaug This patch makes the static methods members of ContentEventHandler because ContentEventHandler::NodePosition is useful for them. * nsINode* AdjustTextRectNode(nsINode*, int32_t&) -> NodePosition GetNodeHavingFlatText(nsINode* int32_t) * nsIFrame* GetFirstFrameInRange(nsRange*, int32_t&) -> FrameAndNodeOffset GetFirstFrameHavingFlatTextInRange(nsRange*) So, this patch avoids unclear in/out arguments of them. MozReview-Commit-ID: 7yWeIkRdGj
c753d34dc2691da2ec25c9f5a6fe17d67af24a70: Bug 1286464 part.2 GetFirstFrameInRange() should return node offset since it may return different node's frame r=m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 14 Jul 2016 22:57:00 +0900 - rev 400158
Push 26081 by masayuki@d-toybox.com at Fri, 12 Aug 2016 17:11:29 +0000
Bug 1286464 part.2 GetFirstFrameInRange() should return node offset since it may return different node's frame r=m_kato GetFirstFrameInRange() uses AdjustTextRectNode() which may return different node before retrieving the result frame. Therefore, the caller may need offset in the new node. MozReview-Commit-ID: 2AQU5WfahT9
c1b0074bde0580be466259f82d0756ff18e29f53: Bug 1286464 part.1 Cleaning up ContentEventHandler::OnQueryTextRectArray() r=m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 14 Jul 2016 22:46:37 +0900 - rev 400157
Push 26081 by masayuki@d-toybox.com at Fri, 12 Aug 2016 17:11:29 +0000
Bug 1286464 part.1 Cleaning up ContentEventHandler::OnQueryTextRectArray() r=m_kato MozReview-Commit-ID: BDLkQLrzoUI
19003eb0f337c6a0bcea1014db0117ba00d344bb: Bug 1286464 part.0 Add eQueryTextRect tests for line breakers r=smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Sat, 30 Jul 2016 22:00:30 +0900 - rev 400156
Push 26081 by masayuki@d-toybox.com at Fri, 12 Aug 2016 17:11:29 +0000
Bug 1286464 part.0 Add eQueryTextRect tests for line breakers r=smaug MozReview-Commit-ID: 2SxNlyjc4KM
9a2b35fed90a1d518f76810fd65f4589fbe13048: Bug 1275913 - Add Borrowed types for sharing arcs with Rust; r?bholley draft
Manish Goregaokar <manishearth@gmail.com> - Fri, 12 Aug 2016 19:54:43 +0530 - rev 400155
Push 26080 by manishearth@gmail.com at Fri, 12 Aug 2016 17:07:22 +0000
Bug 1275913 - Add Borrowed types for sharing arcs with Rust; r?bholley MozReview-Commit-ID: JMl4DdBVQPS
963a15b0f19e5b7e6573c382b9d6971760a59bfa: Bug 1275913 - Use already_addrefed properly when dealing with arcs sent from servo to gecko; r?bholley draft
Manish Goregaokar <manishearth@gmail.com> - Fri, 12 Aug 2016 19:52:28 +0530 - rev 400154
Push 26080 by manishearth@gmail.com at Fri, 12 Aug 2016 17:07:22 +0000
Bug 1275913 - Use already_addrefed properly when dealing with arcs sent from servo to gecko; r?bholley MozReview-Commit-ID: JRNs66ytjAy
cd563d8433c2025566b18b94dd2034d101361e25: Bug 1275913 - Add Borrowed types for sharing arcs with Rust; r?bholley draft
Manish Goregaokar <manishearth@gmail.com> - Fri, 12 Aug 2016 19:54:43 +0530 - rev 400153
Push 26079 by manishearth@gmail.com at Fri, 12 Aug 2016 17:03:28 +0000
Bug 1275913 - Add Borrowed types for sharing arcs with Rust; r?bholley MozReview-Commit-ID: JMl4DdBVQPS
f6d1ed06e47abe9e454ae7aa9b142126a7f3e9f4: Bug 1275913 - Use already_addrefed properly when dealing with arcs sent from servo to gecko; r?bholley draft
Manish Goregaokar <manishearth@gmail.com> - Fri, 12 Aug 2016 19:52:28 +0530 - rev 400152
Push 26079 by manishearth@gmail.com at Fri, 12 Aug 2016 17:03:28 +0000
Bug 1275913 - Use already_addrefed properly when dealing with arcs sent from servo to gecko; r?bholley MozReview-Commit-ID: JRNs66ytjAy
55964621d1e9bdbe6eb8263d80057ae3b45681ed: Bug 1283915: preserve input selection properties after type change; r?smaug draft
Decky Coss <coss@cosstropolis.com> - Wed, 27 Jul 2016 11:04:53 -0400 - rev 400151
Push 26078 by coss@cosstropolis.com at Fri, 12 Aug 2016 16:56:51 +0000
Bug 1283915: preserve input selection properties after type change; r?smaug MozReview-Commit-ID: 7xJKc3vIpTY
1c706a6b1875ed8cf647b333aba484c858fa4c81: Bug 1290518 - Part 3: add tests for filters in store. r=bgrins draft
Lin Clark <lclark@mozilla.com> - Mon, 01 Aug 2016 15:39:03 -0400 - rev 400150
Push 26077 by bmo:lclark@mozilla.com at Fri, 12 Aug 2016 16:50:32 +0000
Bug 1290518 - Part 3: add tests for filters in store. r=bgrins
d838f317c91f39ee5e2777c48569a964ac621172: Bug 1290518 - Part 2: Test filter components. r=bgrins draft
Lin Clark <lclark@mozilla.com> - Mon, 01 Aug 2016 11:54:09 -0400 - rev 400149
Push 26077 by bmo:lclark@mozilla.com at Fri, 12 Aug 2016 16:50:32 +0000
Bug 1290518 - Part 2: Test filter components. r=bgrins
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip