41f5c21bcda06ebd8a334669e3107091354e2363: Bug 1461980 - [taskgraph] Use run-task's 'use-artifacts' key to setup artifacts in mochitest and reftest selftests, r?dustin draft
Andrew Halberstadt <ahalberstadt@mozilla.com> - Fri, 18 May 2018 08:22:36 -0400 - rev 798093
Push 110677 by ahalberstadt@mozilla.com at Tue, 22 May 2018 12:56:55 +0000
Bug 1461980 - [taskgraph] Use run-task's 'use-artifacts' key to setup artifacts in mochitest and reftest selftests, r?dustin Instead of downloading the build artifacts (rather hackily) in moztest.fixtures, this now happens directly in the taskgraph module via the run-task script. For now extraction and setup happens in the task's command key. It might be a good idea to figure out a syntax to tell run-task to do this extraction, e.g something like: run: using-artifacts: build: target.tar.bz2: extract: true path: /home/worker/build name: firefox But for now I wanted to avoid this extra complexity, so maybe it could be done in a follow-up. MozReview-Commit-ID: KOhFFpFdP7Y
8eca338eefc8db5fcc7c031b1da3a23135d6cd15: Bug 1461980 - [taskgraph] Add ability to download artifacts from dependencies in run-task script, r?dustin draft
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 17 May 2018 10:04:23 -0400 - rev 798092
Push 110677 by ahalberstadt@mozilla.com at Tue, 22 May 2018 12:56:55 +0000
Bug 1461980 - [taskgraph] Add ability to download artifacts from dependencies in run-task script, r?dustin This adds a 'use-artifacts' key to the run_task schema. Tasks can specify artifacts to download like this: run: using: run-task use_artifacts: build: - target.tar.bz2 - target.common.tests.zip - target.mochitest.tests.zip This will cause the run-task script to download those three artifacts from the task's 'build' dependency. If the task doesn't have a 'build' dependency, taskgraph generation will error. The artifacts will be downloaded into $USE_ARTIFACT_PATH. It is up to the task to do whatever extracting/setup may be required. E.g this setup could go in the task's command. At this time, only 'run-task' tasks using docker-worker are supported. MozReview-Commit-ID: 3f02oCys62i
2ba578b308933e16bbdd0e9cbcf4425e81a5f965: Bug 1463399 - Remove unused local variable in TextEditor::OutputToString. r?masayuki draft
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 22 May 2018 21:07:09 +0900 - rev 798091
Push 110676 by bmo:m_kato@ga2.so-net.ne.jp at Tue, 22 May 2018 12:51:39 +0000
Bug 1463399 - Remove unused local variable in TextEditor::OutputToString. r?masayuki Now RulesInfo uses nsAString, but old comment is "XXX Struct should store a nsAReadable*". We can remove unnecessary local variable of nsString. MozReview-Commit-ID: C7gnTG7xTjU
bb1b5151bacbeb2ed8c86bdd0933854593847527: Bug 1463103 - Highlight text-runs even in the FontEditor; r=rcaliman draft
Patrick Brosset <pbrosset@mozilla.com> - Mon, 21 May 2018 15:40:28 +0200 - rev 798090
Push 110675 by bmo:pbrosset@mozilla.com at Tue, 22 May 2018 12:49:25 +0000
Bug 1463103 - Highlight text-runs even in the FontEditor; r=rcaliman MozReview-Commit-ID: BocTmIRmkY0
0cfd9d1651e248cc0c3d4792a04213d0a17bee4a: Bug 1441465 - Measure window dimensions on grid/flex highlighter updates when the canvas is hidden; r=gl draft
Patrick Brosset <pbrosset@mozilla.com> - Tue, 22 May 2018 14:28:37 +0200 - rev 798089
Push 110674 by bmo:pbrosset@mozilla.com at Tue, 22 May 2018 12:35:16 +0000
Bug 1441465 - Measure window dimensions on grid/flex highlighter updates when the canvas is hidden; r=gl MozReview-Commit-ID: GW35e9s3rLy
be63fb2764ed97864bfe4cccf03d336df46de4db: Bug 1463057 - Fix expanding object in console.error message; r=Honza. draft
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 21 May 2018 12:02:12 +0200 - rev 798088
Push 110673 by bmo:nchevobbe@mozilla.com at Tue, 22 May 2018 12:12:57 +0000
Bug 1463057 - Fix expanding object in console.error message; r=Honza. There was a race between the fetching of the object properties and the expansion of the stacktrace of the console.error message. In the end, the message was re-rendered, without the object being expanded. To prevent such thing, we stop the propagation of the click on the Tree node. Here the fix is done directly in the Reps bundle so it can be applied on beta, without unrelated code changes we'd have if doing a full bundle release. The fix will be backported to the Tree components so it's included in the bundle on the next reps release. A test is added to make sure we don't regress this. MozReview-Commit-ID: Di8YxJ7P1Wl
7b927a5af7d69e63ee902c53a85bbccb04646191: Bug 1463398 - Removal of deprecated newChannel() API on nsIIOService r?ckerschb draft
Jonathan Kingston <jkt@mozilla.com> - Tue, 22 May 2018 13:09:41 +0100 - rev 798087
Push 110672 by bmo:jkt@mozilla.com at Tue, 22 May 2018 12:10:29 +0000
Bug 1463398 - Removal of deprecated newChannel() API on nsIIOService r?ckerschb MozReview-Commit-ID: 5AwSnQhFtT2
7d6525927410e9d70873b5588adfd7f3f87f850f: Bug 1448484 - Intermittent devtools/client/storage/test/browser_storage_cookies_samesite.js | sameSite1 is Unset - Got undefined, expected Unset r?pbro draft
Michael Ratcliffe <mratcliffe@mozilla.com> - Tue, 22 May 2018 12:21:11 +0100 - rev 798086
Push 110671 by bmo:mratcliffe@mozilla.com at Tue, 22 May 2018 12:04:58 +0000
Bug 1448484 - Intermittent devtools/client/storage/test/browser_storage_cookies_samesite.js | sameSite1 is Unset - Got undefined, expected Unset r?pbro The problem is that we use this: this.front.on("stores-update", this.onEdit); But this.onEdit is async so we have race issues here. Luckily, only tests are fast enough to trigger race conditions in this type of instance. We also have similar issues caused by: - this.tree.on("select", this.onHostSelect); - this.table.on(TableWidget.EVENTS.SCROLL_END, this.handleScrollEnd); - this._refreshButton.addEventListener("command", this.onRefreshTable); Sadly this is a difficult issue to fix because adding async support to the event emitter would mean moving emit calls inside shared libraries into async method chains... the problem being that maybe we may not want the emitter to be asynchronous. The easy workaround for the moment is to add a small pause before reading the row values. This makes the most sense, especially considering that this tool needs converting to React / HTML at some point. MozReview-Commit-ID: 9fixDvkCAOX
401f964e6d07f60037847c506969dde01d377d92: Intermittent devtools/client/storage/test/browser_storage_cookies_samesite.js | sameSite1 is Unset - Got undefined, expected Unset r?pbro draft
Michael Ratcliffe <mratcliffe@mozilla.com> - Tue, 22 May 2018 12:21:11 +0100 - rev 798085
Push 110670 by bmo:mratcliffe@mozilla.com at Tue, 22 May 2018 12:02:17 +0000
Intermittent devtools/client/storage/test/browser_storage_cookies_samesite.js | sameSite1 is Unset - Got undefined, expected Unset r?pbro The problem is that we use this: this.front.on("stores-update", this.onEdit); But this.onEdit is async so we have race issues here. Luckily, only tests are fast enough to trigger race conditions in this type of instance. We also have similar issues caused by: - this.tree.on("select", this.onHostSelect); - this.table.on(TableWidget.EVENTS.SCROLL_END, this.handleScrollEnd); - this._refreshButton.addEventListener("command", this.onRefreshTable); Sadly this is a difficult issue to fix because adding async support to the event emitter would mean moving emit calls inside shared libraries into async method chains... the problem being that maybe we may not want the emitter to be asynchronous. The easy workaround for the moment is to add a small pause before reading the row values. This makes the most sense, especially considering that this tool needs converting to React / HTML at some point. MozReview-Commit-ID: 9fixDvkCAOX
b75acf9652937ce79a9bf02de843c100db0e5ec7: Bug 1461905 - Disable cookie test for instability on linux debug + non-e10s, a=testonly
James Graham <james@hoppipolla.co.uk> - Tue, 22 May 2018 10:47:42 +0100 - rev 798084
Push 110670 by bmo:mratcliffe@mozilla.com at Tue, 22 May 2018 12:02:17 +0000
Bug 1461905 - Disable cookie test for instability on linux debug + non-e10s, a=testonly MozReview-Commit-ID: 5cC0lQfrIbP
b1f04486772b837a72558a2cfa812923b525f04a: Bug 1463396: Remove unused nsStyleUtil::AppendSerializedFontSrc. r?dholbert draft
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 22 May 2018 13:58:24 +0200 - rev 798083
Push 110669 by bmo:emilio@crisal.io at Tue, 22 May 2018 12:01:17 +0000
Bug 1463396: Remove unused nsStyleUtil::AppendSerializedFontSrc. r?dholbert MozReview-Commit-ID: FG6SMUQAj89
5e0f36130c6d14339e57a59e928500ad745ec11d: Bug 1463386: Remove eCSSUnit_Image. r?heycam draft
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 22 May 2018 13:34:17 +0200 - rev 798082
Push 110668 by bmo:emilio@crisal.io at Tue, 22 May 2018 11:36:48 +0000
Bug 1463386: Remove eCSSUnit_Image. r?heycam MozReview-Commit-ID: 9OX6iW7Lr5Q
c9902fef3d633441d255655d620e1fe2f375d68b: Bug 1463386: Remove dead nsStyleImageRequest constructor. r?heycam draft
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 22 May 2018 13:02:55 +0200 - rev 798081
Push 110668 by bmo:emilio@crisal.io at Tue, 22 May 2018 11:36:48 +0000
Bug 1463386: Remove dead nsStyleImageRequest constructor. r?heycam MozReview-Commit-ID: 3mF3PPQbS5O
892e9033adb730dff590681ab4a711ae1ea4f944: Bug 1463372 - Part 2: Test for createdTime based keyframes progress bar. r?pbro draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Tue, 22 May 2018 20:10:21 +0900 - rev 798080
Push 110667 by bmo:dakatsuka@mozilla.com at Tue, 22 May 2018 11:14:08 +0000
Bug 1463372 - Part 2: Test for createdTime based keyframes progress bar. r?pbro MozReview-Commit-ID: IDMU37WdMM1
e79162a71f3eb33f0ae6a40b7eb4a19e58a2da97: Bug 1463372 - Part 1: Introduce createdTime to keyframes progress bar. r?pbro draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Tue, 22 May 2018 20:09:13 +0900 - rev 798079
Push 110667 by bmo:dakatsuka@mozilla.com at Tue, 22 May 2018 11:14:08 +0000
Bug 1463372 - Part 1: Introduce createdTime to keyframes progress bar. r?pbro MozReview-Commit-ID: Biy0AhZZxLQ
a3ce98f344bba1f7215bb25554c1b9b0fd0fbaa3: Bug 1463372 - Part 2: Test for createdTime based keyframes progress bar. r?pbro draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Tue, 22 May 2018 20:04:52 +0900 - rev 798078
Push 110666 by bmo:dakatsuka@mozilla.com at Tue, 22 May 2018 11:07:17 +0000
Bug 1463372 - Part 2: Test for createdTime based keyframes progress bar. r?pbro MozReview-Commit-ID: IDMU37WdMM1
bfd7cf0ffd6aed09410ff0c84cecf39cf736e8e4: Bug 1463372 - Part 1: Introduce createdTime to keyframes progress bar. r?pbro draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Tue, 22 May 2018 19:21:44 +0900 - rev 798077
Push 110666 by bmo:dakatsuka@mozilla.com at Tue, 22 May 2018 11:07:17 +0000
Bug 1463372 - Part 1: Introduce createdTime to keyframes progress bar. r?pbro MozReview-Commit-ID: Biy0AhZZxLQ
264b427abbd4c24e5431c2e5b0d3e44743f73abe: Bug 1454954 - Part 2: Test the animation state in case of the currentTime is over endTime. r?pbro draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Tue, 22 May 2018 19:00:25 +0900 - rev 798076
Push 110666 by bmo:dakatsuka@mozilla.com at Tue, 22 May 2018 11:07:17 +0000
Bug 1454954 - Part 2: Test the animation state in case of the currentTime is over endTime. r?pbro MozReview-Commit-ID: 39jPrDAuWHM
3c50b41158114952ab5eada50412648e49544179: Bug 1454954 - Part 1: Rewind animations if the currentTime is over endTime when click play button. r?pbro draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Tue, 22 May 2018 19:00:02 +0900 - rev 798075
Push 110666 by bmo:dakatsuka@mozilla.com at Tue, 22 May 2018 11:07:17 +0000
Bug 1454954 - Part 1: Rewind animations if the currentTime is over endTime when click play button. r?pbro MozReview-Commit-ID: 2jHTnP63xad
55ef055b0c894880ac9a9a3207887715bd84d6d9: Bug 1463330 - Move CanPasteTransferable and PreDestroy to out of nsIEditor. r?masayuki draft
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 22 May 2018 18:23:21 +0900 - rev 798074
Push 110665 by bmo:m_kato@ga2.so-net.ne.jp at Tue, 22 May 2018 10:54:16 +0000
Bug 1463330 - Move CanPasteTransferable and PreDestroy to out of nsIEditor. r?masayuki CanPasteTransferable and PreDestroy aren't used from script (inc. comm-central and bluegriffon), so we should move these to out of nsIEditor. MozReview-Commit-ID: GRfBobAm2qi
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip