Bug 1434206 - Make LookupCache objects const as much as possible. r?gcp MozReview-Commit-ID: AqC6NUh6ifm

Bug 1434206 - Keep LookupCache objects in smart pointers. r?gcp The existing mix of UniquePtr and raw pointers is confusing when trying to figure out the exact lifetime of these objects. MozReview-Commit-ID: Br4S7BXEFKs

Bug 1434206 - Add const to functions and members that can take it. r?gcp MozReview-Commit-ID: D8IQoLZkFaA

Bug 1434206 - Replace a pointer with a reference. r?gcp This will prevent our holding on to this pointer incorrectly in the future. MozReview-Commit-ID: H8ueIOK1qAK

Bug 1434206 - Make TableUpdate objects const as much as possible. r?gcp I tried to make TableUpdateArray point to const TableUpdate objects everywhere but there were two problems: - HashStore::ApplyUpdate() triggers a few Merge() calls which include sorting the underlying TableUpdate object first. - LookupCacheV4::ApplyUpdate() calls TableUpdateV4::NewChecksum() when the checksum is missing and that sets mChecksum. MozReview-Commit-ID: LIhJcoxo7e7

Bug 1434206 - Keep TableUpdate objects in smart pointers. r?gcp Manually keeping tabs on the lifetime of these objects is a pain and is the likely source of some of our crashes. I suspect we might also be leaking memory. This change creates an explicit copy of the main array into the update thread to avoid using a non-thread-safe shared data structure. This is a shallow copy. Only the pointers to the TableUpdates are copied, which means one pointer per list (e.g. 5 in total for google4 in a new profile). MozReview-Commit-ID: 221d6GkKt0M

Bug 1434206 - Assert that gethash processing happens on the right thread. r?gcp MozReview-Commit-ID: FbF8LzCZ3XO

Bug 1434206 - Don't cache gethash response if we failed to apply results. r?gcp MozReview-Commit-ID: APJ1qhofU3t

Bug 1434206 - Use a TableUpdateV2 param in ApplyUpdate(). r?gcp HashStore::ApplyUpdate() is a V2-only function and so we can be explicit about that and remove unnecessary casts. Add a new update error code for when we fail to cast a TableUpdate object to the expected protocol version. MozReview-Commit-ID: 65BBwiZJw6J

Bug 1434206 - Clear the current table when protocol parser is done. r?gcp Add assertions in the functions that don't already test for mTableUpdate just to be extra-safe. MozReview-Commit-ID: 8R67SLSgj23

Bug 1434206 - Add const to members and functions that can take it. r?gcp MozReview-Commit-ID: B2aaQTttPAV

Bug 1434206 - Remove unused and undefined functions. r?gcp mProtocolV2 is still used to skip the caching of misses on V4: https://searchfox.org/mozilla-central/rev/d4b9e50875ad7e5d20f2fee6a53418315f6dfcc0/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp#1353-1357 MozReview-Commit-ID: 2cHh9JiZuHh

Bug 1319228 - Build dependentlibs.list in the tup backend, create a group for shared libraries to be used as its input. MozReview-Commit-ID: 3nvHaS5ZcIg

Bug 1319228 - Link libxul in the Tup backend. MozReview-Commit-ID: AyhoaPIZJ6I

Bug 1319228 - Generate rules for rust in the Tup backend via cargo --build-plan. MozReview-Commit-ID: 9m0Prz3AvmC

Bug 1319228 - Use pass_thru=True when running config.status to expose error messages from sub-commands. MozReview-Commit-ID: K1DfauDn37r

Bug 1319228 - Disable the js shell in tup automation builds. The js shell is symlinked back to the js objdir by a one off rule. This fails in the current tup build because the symlink rule is written in the Tupfile before the rule to build the shell. MozReview-Commit-ID: 5yK1xqvrX6R

Bug 1319228 - Build tup with nightly rust in automation. MozReview-Commit-ID: 7PCQ9q5eVpK

Bug 1461046 Part 7: Mark existing WPT reftests that check empty float areas as failing. MozReview-Commit-ID: CttOvLg1TVK

Bug 1461046 Part 6: Remove submitted WPT reftests that checked for empty float areas (which are no longer empty), or relied on ignoring horizontal spurs in polygons. MozReview-Commit-ID: 4fADKtvcZVp