3fdd157bb6988ea8087c2ec25f4393b93021ed2a: Bug 1434206 - Make LookupCache objects const as much as possible. r?gcp draft
Francois Marier <francois@mozilla.com> - Mon, 21 May 2018 15:11:01 -0700 - rev 801247
Push 111610 by fmarier@mozilla.com at Tue, 29 May 2018 22:36:12 +0000
Bug 1434206 - Make LookupCache objects const as much as possible. r?gcp MozReview-Commit-ID: AqC6NUh6ifm
b1565f3aacdba314faea3df775ff436e190e1112: Bug 1434206 - Keep LookupCache objects in smart pointers. r?gcp draft
Francois Marier <francois@mozilla.com> - Wed, 16 May 2018 19:13:48 -0700 - rev 801246
Push 111610 by fmarier@mozilla.com at Tue, 29 May 2018 22:36:12 +0000
Bug 1434206 - Keep LookupCache objects in smart pointers. r?gcp The existing mix of UniquePtr and raw pointers is confusing when trying to figure out the exact lifetime of these objects. MozReview-Commit-ID: Br4S7BXEFKs
a1a382f2e7733d869db65be0644b53ec81a61738: Bug 1434206 - Add const to functions and members that can take it. r?gcp draft
Francois Marier <francois@mozilla.com> - Wed, 16 May 2018 15:39:33 -0700 - rev 801245
Push 111610 by fmarier@mozilla.com at Tue, 29 May 2018 22:36:12 +0000
Bug 1434206 - Add const to functions and members that can take it. r?gcp MozReview-Commit-ID: D8IQoLZkFaA
976e25b49758ca77ba2073262ca293a76322213d: Bug 1434206 - Replace a pointer with a reference. r?gcp draft
Francois Marier <francois@mozilla.com> - Tue, 15 May 2018 17:18:18 -0700 - rev 801244
Push 111610 by fmarier@mozilla.com at Tue, 29 May 2018 22:36:12 +0000
Bug 1434206 - Replace a pointer with a reference. r?gcp This will prevent our holding on to this pointer incorrectly in the future. MozReview-Commit-ID: H8ueIOK1qAK
0d7a4e1c00797e98ce419075a7548ac384145ad8: Bug 1434206 - Make TableUpdate objects const as much as possible. r?gcp draft
Francois Marier <francois@mozilla.com> - Fri, 11 May 2018 16:02:37 -0700 - rev 801243
Push 111610 by fmarier@mozilla.com at Tue, 29 May 2018 22:36:12 +0000
Bug 1434206 - Make TableUpdate objects const as much as possible. r?gcp I tried to make TableUpdateArray point to const TableUpdate objects everywhere but there were two problems: - HashStore::ApplyUpdate() triggers a few Merge() calls which include sorting the underlying TableUpdate object first. - LookupCacheV4::ApplyUpdate() calls TableUpdateV4::NewChecksum() when the checksum is missing and that sets mChecksum. MozReview-Commit-ID: LIhJcoxo7e7
f6a657bca64fc80ce221d3ab0a54d441e995ca1e: Bug 1434206 - Keep TableUpdate objects in smart pointers. r?gcp draft
Francois Marier <francois@mozilla.com> - Tue, 15 May 2018 16:18:41 -0700 - rev 801242
Push 111610 by fmarier@mozilla.com at Tue, 29 May 2018 22:36:12 +0000
Bug 1434206 - Keep TableUpdate objects in smart pointers. r?gcp Manually keeping tabs on the lifetime of these objects is a pain and is the likely source of some of our crashes. I suspect we might also be leaking memory. This change creates an explicit copy of the main array into the update thread to avoid using a non-thread-safe shared data structure. This is a shallow copy. Only the pointers to the TableUpdates are copied, which means one pointer per list (e.g. 5 in total for google4 in a new profile). MozReview-Commit-ID: 221d6GkKt0M
47906774d58d476f24d7c2a42d22c3d6b2df2607: Bug 1434206 - Assert that gethash processing happens on the right thread. r?gcp draft
Francois Marier <francois@mozilla.com> - Fri, 11 May 2018 11:47:26 -0700 - rev 801241
Push 111610 by fmarier@mozilla.com at Tue, 29 May 2018 22:36:12 +0000
Bug 1434206 - Assert that gethash processing happens on the right thread. r?gcp MozReview-Commit-ID: FbF8LzCZ3XO
e194843f5b7a3c7faa8d811b33410ac1ee596c2d: Bug 1434206 - Don't cache gethash response if we failed to apply results. r?gcp draft
Francois Marier <francois@mozilla.com> - Fri, 11 May 2018 10:57:11 -0700 - rev 801240
Push 111610 by fmarier@mozilla.com at Tue, 29 May 2018 22:36:12 +0000
Bug 1434206 - Don't cache gethash response if we failed to apply results. r?gcp MozReview-Commit-ID: APJ1qhofU3t
2d1bf04fd155fba7a749beab0b879eddb04c2108: Bug 1434206 - Use a TableUpdateV2 param in ApplyUpdate(). r?gcp draft
Francois Marier <francois@mozilla.com> - Thu, 10 May 2018 16:06:49 -0700 - rev 801239
Push 111610 by fmarier@mozilla.com at Tue, 29 May 2018 22:36:12 +0000
Bug 1434206 - Use a TableUpdateV2 param in ApplyUpdate(). r?gcp HashStore::ApplyUpdate() is a V2-only function and so we can be explicit about that and remove unnecessary casts. Add a new update error code for when we fail to cast a TableUpdate object to the expected protocol version. MozReview-Commit-ID: 65BBwiZJw6J
c04b620136c786ee49b5782fb62f434d38f95455: Bug 1434206 - Clear the current table when protocol parser is done. r?gcp draft
Francois Marier <francois@mozilla.com> - Thu, 10 May 2018 17:58:01 -0700 - rev 801238
Push 111610 by fmarier@mozilla.com at Tue, 29 May 2018 22:36:12 +0000
Bug 1434206 - Clear the current table when protocol parser is done. r?gcp Add assertions in the functions that don't already test for mTableUpdate just to be extra-safe. MozReview-Commit-ID: 8R67SLSgj23
7ddfe5ae2fa6ed0d811f6302a51bd13bdf14f410: Bug 1434206 - Add const to members and functions that can take it. r?gcp draft
Francois Marier <francois@mozilla.com> - Wed, 16 May 2018 15:26:14 -0700 - rev 801237
Push 111610 by fmarier@mozilla.com at Tue, 29 May 2018 22:36:12 +0000
Bug 1434206 - Add const to members and functions that can take it. r?gcp MozReview-Commit-ID: B2aaQTttPAV
3c31c543e736282c70cf6b74856cffedb3681b67: Bug 1434206 - Remove unused and undefined functions. r?gcp draft
Francois Marier <francois@mozilla.com> - Mon, 28 May 2018 14:39:32 -0700 - rev 801236
Push 111610 by fmarier@mozilla.com at Tue, 29 May 2018 22:36:12 +0000
Bug 1434206 - Remove unused and undefined functions. r?gcp mProtocolV2 is still used to skip the caching of misses on V4: https://searchfox.org/mozilla-central/rev/d4b9e50875ad7e5d20f2fee6a53418315f6dfcc0/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp#1353-1357 MozReview-Commit-ID: 2cHh9JiZuHh
6a26ec400cddbdd8188d71007693d7475d5f1814: Bug 1319228 - Build dependentlibs.list in the tup backend, create a group for shared libraries to be used as its input. draft
Chris Manchester <cmanchester@mozilla.com> - Tue, 29 May 2018 15:33:26 -0700 - rev 801235
Push 111609 by bmo:cmanchester@mozilla.com at Tue, 29 May 2018 22:33:43 +0000
Bug 1319228 - Build dependentlibs.list in the tup backend, create a group for shared libraries to be used as its input. MozReview-Commit-ID: 3nvHaS5ZcIg
6688939cd57a4dd10df0a512fc2c3c9d5b298eb8: Bug 1319228 - Link libxul in the Tup backend. draft
Chris Manchester <cmanchester@mozilla.com> - Tue, 29 May 2018 15:33:26 -0700 - rev 801234
Push 111609 by bmo:cmanchester@mozilla.com at Tue, 29 May 2018 22:33:43 +0000
Bug 1319228 - Link libxul in the Tup backend. MozReview-Commit-ID: AyhoaPIZJ6I
e6003254781e240b599501bc41ecc03490447989: Bug 1319228 - Generate rules for rust in the Tup backend via cargo --build-plan. draft
Chris Manchester <cmanchester@mozilla.com> - Tue, 29 May 2018 15:33:14 -0700 - rev 801233
Push 111609 by bmo:cmanchester@mozilla.com at Tue, 29 May 2018 22:33:43 +0000
Bug 1319228 - Generate rules for rust in the Tup backend via cargo --build-plan. MozReview-Commit-ID: 9m0Prz3AvmC
e217e3a551548a92b01f1fc879728c913889adc7: Bug 1319228 - Use pass_thru=True when running config.status to expose error messages from sub-commands. draft
Chris Manchester <cmanchester@mozilla.com> - Tue, 29 May 2018 15:31:48 -0700 - rev 801232
Push 111609 by bmo:cmanchester@mozilla.com at Tue, 29 May 2018 22:33:43 +0000
Bug 1319228 - Use pass_thru=True when running config.status to expose error messages from sub-commands. MozReview-Commit-ID: K1DfauDn37r
88f15d46da6c21a0d5f6db550c337bc2e1b1ff55: Bug 1319228 - Disable the js shell in tup automation builds. draft
Chris Manchester <cmanchester@mozilla.com> - Tue, 29 May 2018 15:31:48 -0700 - rev 801231
Push 111609 by bmo:cmanchester@mozilla.com at Tue, 29 May 2018 22:33:43 +0000
Bug 1319228 - Disable the js shell in tup automation builds. The js shell is symlinked back to the js objdir by a one off rule. This fails in the current tup build because the symlink rule is written in the Tupfile before the rule to build the shell. MozReview-Commit-ID: 5yK1xqvrX6R
3f5cc1f6ea97b3a36a5cff7decc2b1bc5c993a8f: Bug 1319228 - Build tup with nightly rust in automation. draft
Chris Manchester <cmanchester@mozilla.com> - Tue, 29 May 2018 15:31:47 -0700 - rev 801230
Push 111609 by bmo:cmanchester@mozilla.com at Tue, 29 May 2018 22:33:43 +0000
Bug 1319228 - Build tup with nightly rust in automation. MozReview-Commit-ID: 7PCQ9q5eVpK
8f94a2c6b844d577ca6fb654f8cc391a21efa5bd: Bug 1461046 Part 7: Mark existing WPT reftests that check empty float areas as failing. draft
Brad Werth <bwerth@mozilla.com> - Fri, 25 May 2018 11:35:54 -0700 - rev 801229
Push 111608 by bwerth@mozilla.com at Tue, 29 May 2018 22:29:47 +0000
Bug 1461046 Part 7: Mark existing WPT reftests that check empty float areas as failing. MozReview-Commit-ID: CttOvLg1TVK
79afd437f5a227b1d6ce1c3bf03b65a3f7b41527: Bug 1461046 Part 6: Remove submitted WPT reftests that checked for empty float areas (which are no longer empty), or relied on ignoring horizontal spurs in polygons. draft
Brad Werth <bwerth@mozilla.com> - Fri, 25 May 2018 10:44:40 -0700 - rev 801228
Push 111608 by bwerth@mozilla.com at Tue, 29 May 2018 22:29:47 +0000
Bug 1461046 Part 6: Remove submitted WPT reftests that checked for empty float areas (which are no longer empty), or relied on ignoring horizontal spurs in polygons. MozReview-Commit-ID: 4fADKtvcZVp
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip