3f9350bf23ff9af20cf8369e92dfce2eca75d42e: Bug 1390748 - Remove unnecessary includes in *Decoders. r=jwwang
Chris Pearce <cpearce@mozilla.com> - Wed, 16 Aug 2017 17:19:39 +1200 - rev 648233
Push 74672 by nhnt11@gmail.com at Thu, 17 Aug 2017 12:31:35 +0000
Bug 1390748 - Remove unnecessary includes in *Decoders. r=jwwang MozReview-Commit-ID: 3bfAdpopOfp
9172b8d6ce3e1d96457191979432e77d131d9280: Bug 1390748 - Remove some unnecessary includes. r=jwwang
Chris Pearce <cpearce@mozilla.com> - Wed, 16 Aug 2017 17:18:39 +1200 - rev 648232
Push 74672 by nhnt11@gmail.com at Thu, 17 Aug 2017 12:31:35 +0000
Bug 1390748 - Remove some unnecessary includes. r=jwwang MozReview-Commit-ID: J3viRI4Q6LF
d3c000525403411a57a465e076507efa984b84dc: Bug 1390748 - Remove ChannelMediaDecoder::CloneImpl() and remove subclasses of ChannelMediaDecoder. r=jwwang
Chris Pearce <cpearce@mozilla.com> - Tue, 15 Aug 2017 17:52:17 +1200 - rev 648231
Push 74672 by nhnt11@gmail.com at Thu, 17 Aug 2017 12:31:35 +0000
Bug 1390748 - Remove ChannelMediaDecoder::CloneImpl() and remove subclasses of ChannelMediaDecoder. r=jwwang MozReview-Commit-ID: 6nlBArYgwEJ
94c0ec4bf19ea64f4a241441b21d4da93606d4e5: Bug 1390748 - Create DecoderTraits::IsSupportedType(const MediaContainerType&). r=jwwang
Chris Pearce <cpearce@mozilla.com> - Tue, 15 Aug 2017 17:38:16 +1200 - rev 648230
Push 74672 by nhnt11@gmail.com at Thu, 17 Aug 2017 12:31:35 +0000
Bug 1390748 - Create DecoderTraits::IsSupportedType(const MediaContainerType&). r=jwwang Most ChannelMediaDecoder::CloneImpl() functions just check to see whether their "is enabled" pref is still true, and then clone their true type. If we had a function to check whether the decoder for an arbitrary type was still enabled, we'd not need the "is enabled" checks in the CloneImpl() implementations. We'd then have removed the last custom behaviour in the ChannelMediaDecoder subclasses. MozReview-Commit-ID: D7kW6kb6ztW
4a31e4302e03b5a741f9357347badc9293491188: Bug 1390748 - Pre-declare MediaDecoder in HTMLMediaElement. r=jwwang
Chris Pearce <cpearce@mozilla.com> - Tue, 15 Aug 2017 17:09:06 +1200 - rev 648229
Push 74672 by nhnt11@gmail.com at Thu, 17 Aug 2017 12:31:35 +0000
Bug 1390748 - Pre-declare MediaDecoder in HTMLMediaElement. r=jwwang I noticed that touching MediaDecoder rebuilds a lot of seemingly unrelated code. This is because HTMLMediaElement includes MediaDecoder.h, and HTMLMediaElement is included in a number of places. Having HTMLMediaElement.h predeclare rather than include fixes it. MozReview-Commit-ID: I0vrPgqvvge
2964dba33ef8aca0abe52c48e6beff2cd2a79046: Bug 1390748 - Create default MediaDecoder::GetMozDebugReaderData() implementation. r=jwwang
Chris Pearce <cpearce@mozilla.com> - Tue, 15 Aug 2017 17:07:13 +1200 - rev 648228
Push 74672 by nhnt11@gmail.com at Thu, 17 Aug 2017 12:31:35 +0000
Bug 1390748 - Create default MediaDecoder::GetMozDebugReaderData() implementation. r=jwwang We have three implementations, in the MP4, WebM and MediaSource decoders. The WebM and MP4 are the same. Ogg and other decoders don't have an implementation, but if we create a default implementation in MediaDecoder, they'll get it for free. MediaSourceDecoder needs a custom override still. MozReview-Commit-ID: AXxn2Xhn0Jn
ad5c7eb1bfe1ebdece8b7646dd0896f2bb05f082: Bug 1390748 - Remove unnececssary 'public:' in MediaDecoder.h. r=jwwang
Chris Pearce <cpearce@mozilla.com> - Tue, 15 Aug 2017 16:38:05 +1200 - rev 648227
Push 74672 by nhnt11@gmail.com at Thu, 17 Aug 2017 12:31:35 +0000
Bug 1390748 - Remove unnececssary 'public:' in MediaDecoder.h. r=jwwang There's an existing 'public:' further up. MozReview-Commit-ID: 7CMmpVkZ7oz
b86afd45a710e16577c7313227cf6d1f3f4b5397: Bug 1390748 - Make MediaDecoder::CreateStateMachine() non-virtual. r=jwwang
Chris Pearce <cpearce@mozilla.com> - Tue, 15 Aug 2017 16:37:00 +1200 - rev 648226
Push 74672 by nhnt11@gmail.com at Thu, 17 Aug 2017 12:31:35 +0000
Bug 1390748 - Make MediaDecoder::CreateStateMachine() non-virtual. r=jwwang MediaDecoder::CreateStateMachine is only virtual so that Ogg can attach the reader's metadata/seekable produces to its chaining event. The MediaSourceDecoder also overrides CreateStateMachine(), but it's not called by anything external, so its implementation doesn't actually need to be virtual. MozReview-Commit-ID: 2x6bpK6Fdzd
57be2e971ae2af2aeb752860a20767caa5835b67: Bug 1390748 - Remove OggDecoder::CreateStateMachine(). r=jwwang
Chris Pearce <cpearce@mozilla.com> - Tue, 15 Aug 2017 16:21:35 +1200 - rev 648225
Push 74672 by nhnt11@gmail.com at Thu, 17 Aug 2017 12:31:35 +0000
Bug 1390748 - Remove OggDecoder::CreateStateMachine(). r=jwwang MozReview-Commit-ID: 2JgZ2Ppv6as
08b9253036bec9a0067b1c83eced2668468eaa0e: Bug 1384001 - Reenable test_intersectionobservers.html. r=xidorn
Xidorn Quan <me@upsuper.org> - Thu, 17 Aug 2017 13:35:37 +1000 - rev 648224
Push 74672 by nhnt11@gmail.com at Thu, 17 Aug 2017 12:31:35 +0000
Bug 1384001 - Reenable test_intersectionobservers.html. r=xidorn MozReview-Commit-ID: 1duaKfd8ADd
2451b21968df85dfb53a29fd5f05fe32b92710e6: servo: Merge #18121 - style: Move functions related to anonymous element to GeckoElement (Bug 1390773) (from aethanyc:move-anonymous-flag-functions); r=emilio
Ting-Yu Lin <tlin@mozilla.com> - Wed, 16 Aug 2017 23:09:35 -0500 - rev 648223
Push 74672 by nhnt11@gmail.com at Thu, 17 Aug 2017 12:31:35 +0000
servo: Merge #18121 - style: Move functions related to anonymous element to GeckoElement (Bug 1390773) (from aethanyc:move-anonymous-flag-functions); r=emilio This change was reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1390773 Source-Repo: https://github.com/servo/servo Source-Revision: 5964be77217ee42af0558b04af2388080245b72c
9fbd55be05b2e19ffa33cb5964ded8bb7e71841e: Bug 1366056 - showing v57 tourset for new user tour and update user tour;r=Fischer,mossop,rexboy
gasolin <gasolin@gmail.com> - Mon, 14 Aug 2017 14:30:46 +0800 - rev 648222
Push 74672 by nhnt11@gmail.com at Thu, 17 Aug 2017 12:31:35 +0000
Bug 1366056 - showing v57 tourset for new user tour and update user tour;r=Fischer,mossop,rexboy MozReview-Commit-ID: JUmPyJiNKFx
e61998d0ccbae3a1921c943619f8f2cb932c0a3d: Backed out 10 changesets (bug 1390748) for build bustage
Phil Ringnalda <philringnalda@gmail.com> - Wed, 16 Aug 2017 21:33:10 -0700 - rev 648221
Push 74672 by nhnt11@gmail.com at Thu, 17 Aug 2017 12:31:35 +0000
Backed out 10 changesets (bug 1390748) for build bustage Backed out changeset 02b36ee5fb17 (bug 1390748) Backed out changeset 84e8bf01c856 (bug 1390748) Backed out changeset fc8989be30f3 (bug 1390748) Backed out changeset 14d421ace6cc (bug 1390748) Backed out changeset 7dadac869038 (bug 1390748) Backed out changeset 0e77809e7bc2 (bug 1390748) Backed out changeset bf78a8dce9c5 (bug 1390748) Backed out changeset 5fa77990472e (bug 1390748) Backed out changeset 5d3b637d2485 (bug 1390748) Backed out changeset 634fe076d134 (bug 1390748) MozReview-Commit-ID: Dxio8vXDCHg
02b36ee5fb17ec5de04121dc04015dfa097214fc: Bug 1390748 - Remove usage of mozilla::Vector from mp4_demuxer::ByteReader. r=jwwang
Chris Pearce <cpearce@mozilla.com> - Wed, 16 Aug 2017 17:19:58 +1200 - rev 648220
Push 74672 by nhnt11@gmail.com at Thu, 17 Aug 2017 12:31:35 +0000
Bug 1390748 - Remove usage of mozilla::Vector from mp4_demuxer::ByteReader. r=jwwang It appears to be unused. MozReview-Commit-ID: 7vVK4PRzaPt
84e8bf01c856e9b98427340c45a8aa71dda7adca: Bug 1390748 - Remove unnecessary includes in *Decoders. r=jwwang
Chris Pearce <cpearce@mozilla.com> - Wed, 16 Aug 2017 17:19:39 +1200 - rev 648219
Push 74672 by nhnt11@gmail.com at Thu, 17 Aug 2017 12:31:35 +0000
Bug 1390748 - Remove unnecessary includes in *Decoders. r=jwwang MozReview-Commit-ID: 3bfAdpopOfp
fc8989be30f39d965522e3badcd60ffba2b239e9: Bug 1390748 - Remove some unnecessary includes. r=jwwang
Chris Pearce <cpearce@mozilla.com> - Wed, 16 Aug 2017 17:18:39 +1200 - rev 648218
Push 74672 by nhnt11@gmail.com at Thu, 17 Aug 2017 12:31:35 +0000
Bug 1390748 - Remove some unnecessary includes. r=jwwang MozReview-Commit-ID: J3viRI4Q6LF
14d421ace6ccffb8f0c05f58726b6871a9f9e5e7: Bug 1390748 - Remove ChannelMediaDecoder::CloneImpl() and remove subclasses of ChannelMediaDecoder. r=jwwang
Chris Pearce <cpearce@mozilla.com> - Tue, 15 Aug 2017 17:52:17 +1200 - rev 648217
Push 74672 by nhnt11@gmail.com at Thu, 17 Aug 2017 12:31:35 +0000
Bug 1390748 - Remove ChannelMediaDecoder::CloneImpl() and remove subclasses of ChannelMediaDecoder. r=jwwang MozReview-Commit-ID: 6nlBArYgwEJ
7dadac86903887b83d5e94c744f53db67d92ddb0: Bug 1390748 - Create DecoderTraits::IsSupportedType(const MediaContainerType&). r=jwwang
Chris Pearce <cpearce@mozilla.com> - Tue, 15 Aug 2017 17:38:16 +1200 - rev 648216
Push 74672 by nhnt11@gmail.com at Thu, 17 Aug 2017 12:31:35 +0000
Bug 1390748 - Create DecoderTraits::IsSupportedType(const MediaContainerType&). r=jwwang Most ChannelMediaDecoder::CloneImpl() functions just check to see whether their "is enabled" pref is still true, and then clone their true type. If we had a function to check whether the decoder for an arbitrary type was still enabled, we'd not need the "is enabled" checks in the CloneImpl() implementations. We'd then have removed the last custom behaviour in the ChannelMediaDecoder subclasses. MozReview-Commit-ID: D7kW6kb6ztW
0e77809e7bc21fcd922700ccb7148395205091e4: Bug 1390748 - Pre-declare MediaDecoder in HTMLMediaElement. r=jwwang
Chris Pearce <cpearce@mozilla.com> - Tue, 15 Aug 2017 17:09:06 +1200 - rev 648215
Push 74672 by nhnt11@gmail.com at Thu, 17 Aug 2017 12:31:35 +0000
Bug 1390748 - Pre-declare MediaDecoder in HTMLMediaElement. r=jwwang I noticed that touching MediaDecoder rebuilds a lot of seemingly unrelated code. This is because HTMLMediaElement includes MediaDecoder.h, and HTMLMediaElement is included in a number of places. Having HTMLMediaElement.h predeclare rather than include fixes it. MozReview-Commit-ID: I0vrPgqvvge
bf78a8dce9c5bfe3cf6e0e4cdfbd7cbf317aa6dd: Bug 1390748 - Create default MediaDecoder::GetMozDebugReaderData() implementation. r=jwwang
Chris Pearce <cpearce@mozilla.com> - Tue, 15 Aug 2017 17:07:13 +1200 - rev 648214
Push 74672 by nhnt11@gmail.com at Thu, 17 Aug 2017 12:31:35 +0000
Bug 1390748 - Create default MediaDecoder::GetMozDebugReaderData() implementation. r=jwwang We have three implementations, in the MP4, WebM and MediaSource decoders. The WebM and MP4 are the same. Ogg and other decoders don't have an implementation, but if we create a default implementation in MediaDecoder, they'll get it for free. MediaSourceDecoder needs a custom override still. MozReview-Commit-ID: AXxn2Xhn0Jn
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip